Re: [Nouveau] 3.12rc1-pre Nouveau? oops

2013-09-08 Thread Tobias Klausmann
Looks like you have Optimus (intel + nvidia), and the backtrace has runtime pm in it, which is something new Dave added for 3.12, adding him in explicitly. The simplest explanation is that disp-init is NULL. And it seems like there are no outputs from the earlier nouveau init prints. I guess

Re: [Nouveau] 3.12rc1-pre Nouveau? oops

2013-09-08 Thread Tobias Klausmann
On 08.09.2013 23:33, Dave Airlie wrote: Looks like you have Optimus (intel + nvidia), and the backtrace has runtime pm in it, which is something new Dave added for 3.12, adding him in explicitly. The simplest explanation is that disp-init is NULL. And it seems like there are no outputs from the

[Nouveau] Implement buffer_clear for nvc0

2014-05-26 Thread Tobias Klausmann
Hi, please review the following patch! Thanks, Tobias Klausmann ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [PATCH] nvc0: Implement buffer_clear for this type of hardware

2014-05-26 Thread Tobias Klausmann
--- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 171 1 file changed, 171 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c index 6b7c30c..987b6c4 100644 ---

[Nouveau] [PATCH V2] nvc0: implement clear_buffer

2014-05-26 Thread Tobias Klausmann
v2: change patch according to Ilia Mirkins review --- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 151 1 file changed, 151 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c index

[Nouveau] [PATCH V3] nvc0: implement clear_buffer

2014-05-26 Thread Tobias Klausmann
the framebuffer dirty for if we don't touch the GPU Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 151 1 file changed, 151 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0

[Nouveau] Add constant folding for new opcodes

2014-05-29 Thread Tobias Klausmann
when folding constant expressions src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) Thanks, Tobias Klausmann ___ Nouveau mailing list Nouveau

[Nouveau] [PATCH 1/4] nvc0/ir: clear subop when folding constant expressions

2014-05-29 Thread Tobias Klausmann
Some operations (e.g. OP_MUL/OP_MAD/OP_EXTBF might have a subop set. After folding, make sure that it is cleared Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + 1 file changed, 1 insertion(+) diff --git

[Nouveau] [PATCH 2/4] nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions

2014-05-29 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers

[Nouveau] [PATCH 4/4] nvc0/ir: Handle OP_BFIND when folding constant expressions

2014-05-29 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen

[Nouveau] [PATCH 3/4] nvc0/ir: Handle OP_POPCNT when folding constant expressions

2014-05-29 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen

Re: [Nouveau] [PATCH 2/4] nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions

2014-05-29 Thread Tobias Klausmann
that you tested how the HW handles this, as well as exactly how you did it (i.e. how did you modify the code + piglit test, what the results were, etc) On Thu, May 29, 2014 at 3:43 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: Signed-off-by: Tobias Klausmann tobias.johannes.klausm

[Nouveau] [PATCH v2 1/4] nvc0/ir: clear subop when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Some operations (e.g. OP_MUL/OP_MAD/OP_EXTBF might have a subop set. After folding, make sure that it is cleared Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + 1 file changed, 1 insertion(+) diff --git

[Nouveau] [PATCH v2 2/4] nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions

2014-06-03 Thread Tobias Klausmann
V2: Handle the instruction right (shift after reverse) Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers

[Nouveau] [PATCH v2 3/4] nvc0/ir: Handle OP_BFIND when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen

[Nouveau] [PATCH v2 4/4] nvc0/ir: Handle OP_POPCNT when folding constant expressions

2014-06-03 Thread Tobias Klausmann
V2: Add support for a single-argument version of POPCNT for Maxwell (SM5) Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/gallium/drivers

[Nouveau] [PATCH v2 0/4] Constant folding of new Instructions

2014-06-03 Thread Tobias Klausmann
And another try for constant folding of Instructions for nvc0. Please Review this! Thanks, Tobias Klausmann Tobias Klausmann (4): nvc0/ir: clear subop when folding constant expressions nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions nvc0/ir: Handle

[Nouveau] [PATCH v3 2/4] nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2: Handle the instruction right (shift after reverse) V3: Reverse once, not independently for every TYPE src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 12 ++-- 1 file changed, 10 insertions(+), 2

[Nouveau] [PATCH v3 0/4] Constant folding of new Instructions

2014-06-03 Thread Tobias Klausmann
Yet another try for constant folding of Instructions for nvc0. Please Review this again! (Hopefully the last time ;-) ) Tobias Klausmann (4): nvc0/ir: clear subop when folding constant expressions nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions nvc0/ir

[Nouveau] [PATCH v3 4/4] nvc0/ir: Handle OP_POPCNT when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2: Add support for a single-argument version of POPCNT for Maxwell (SM5) V3: Clean up a bit more src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src

[Nouveau] [PATCH v3 1/4] nvc0/ir: clear subop when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Some operations (e.g. OP_MUL/OP_MAD/OP_EXTBF might have a subop set. After folding, make sure that it is cleared Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de Reviewed-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1

[Nouveau] [PATCH v3 3/4] nvc0/ir: Handle OP_BFIND when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V3: Use BuildUtil for the Immediate instead of a type conversion .../drivers/nouveau/codegen/nv50_ir_peephole.cpp| 17 + 1 file changed, 17 insertions(+) diff --git a/src/gallium/drivers/nouveau

[Nouveau] [PATCH 1/3] nvc0: implement multiple viewports/scissors, enable ARB_viewport_array

2014-06-14 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 7 +- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 20 ++-- src/gallium/drivers/nouveau/nvc0

[Nouveau] [PATCH 3/3] nv50/ir: Remove NV50_SEMANTIC_VIEWPORTINDEX and its last consumer

2014-06-14 Thread Tobias Klausmann
We use TGSI_SEMANTIC_VIEWPORT_INDEX for nvc0 now as well. Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h| 1 - src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp | 1 - 2 files changed, 2 deletions

[Nouveau] [PATCH 0/3] ARB_viewport_array for nvc0

2014-06-14 Thread Tobias Klausmann
This patch-series implements the ARB_viewport_array for nvc0 and does a little house-cleanig afterwords. Tobias Klausmann (3): nvc0: implement multiple viewports/scissors, enable ARB_viewport_array nvc0: mark scissor in nvc0_clear_{} nv50/ir: Remove NV50_SEMANTIC_VIEWPORTINDEX and its last

[Nouveau] [PATCH 2/3] nvc0: mark scissor in nvc0_clear_{}

2014-06-14 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c index c28ec6d..72227b8

[Nouveau] [PATCH v2 0/3] ARB_viewport_array for nvc0

2014-06-15 Thread Tobias Klausmann
This patch-series implements the ARB_viewport_array for nvc0 and does a little house-cleanig afterwords. V2: Add Release-Notes, mark this in GL3 as done for nvc0 Don't mark the scissors dirty when we don't need to do that Tobias Klausmann (3): nvc0: implement multiple viewports/scissors

[Nouveau] [PATCH v2 2/3] docs: update GL3.txt, relnotes: mark GL_ARB_viewport_array as done for nvc0

2014-06-15 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- docs/GL3.txt| 2 +- docs/relnotes/10.3.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index f5f940c..a392b92 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt

[Nouveau] [PATCH v2 1/3] nvc0: implement multiple viewports/scissors, enable ARB_viewport_array

2014-06-15 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 7 +- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 20 ++-- src/gallium/drivers/nouveau/nvc0

[Nouveau] [PATCH v2 3/3] nv50/ir: Remove NV50_SEMANTIC_VIEWPORTINDEX

2014-06-15 Thread Tobias Klausmann
Use TGSI_SEMANTIC_VIEWPORT_INDEX for the last consumer. Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h| 1 - src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp | 2 +- 2 files changed, 1 insertion

[Nouveau] [PATCH] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- .../drivers/nouveau/codegen/nv50_ir_driver.h | 1 + .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 27 -- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers

[Nouveau] [PATCH v2] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Tobias Klausmann
on each emit. This fixes the remaining piglit tests in ARB_viewport_array for nvc0. Note: Not tested on nv50 Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2: provide description fix naming of vars .../drivers/nouveau/codegen/nv50_ir_driver.h | 1

[Nouveau] [PATCH v3] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Tobias Klausmann
on each emit. This fixes the remaining piglit tests in ARB_viewport_array for nvc0. Note: Not tested on nv50 Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2: provide description fix naming of vars V3: spare a function call, use the idx we already have second

Re: [Nouveau] nouveau xorg driver - compile error

2014-07-01 Thread Tobias klausmann
Hi Pali, maybe you are missing a package somewhere? Latest git is building fine for me on OBS/opensuse. Greetings, Tobias On 01.07.2014 21:47, Pali Rohár wrote: Hello, nouveau xorg driver from master git repository cannot be compiled on ubuntu precise. Here is build log:

[Nouveau] [PATCH] nv50/ir: Handle OP_CVT when folding constant expressions

2014-07-02 Thread Tobias Klausmann
Folding for conversions: F32/64-(U16/32, S16/32) and (U16/32, S16/32)-F32 No piglit regressions observed! Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 74 ++ 1 file changed, 74 insertions

[Nouveau] [PATCH v3 1/2] nv50/ir: Add support for the double Type to BuildUtil

2014-07-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- .../drivers/nouveau/codegen/nv50_ir_build_util.cpp | 17 + .../drivers/nouveau/codegen/nv50_ir_build_util.h| 2 ++ 2 files changed, 19 insertions(+) diff --git a/src/gallium/drivers/nouveau

[Nouveau] [PATCH v3 2/2] nv50/ir: Handle OP_CVT when folding constant expressions

2014-07-03 Thread Tobias Klausmann
Folding for conversions: F32/64-(U16/32, S16/32) and (U16/32, S16/32)-F32 No piglit regressions observed on nv50 and nvc0! Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 74 ++ 1 file changed, 74

[Nouveau] [PATCH v4] nv50/ir: Handle OP_CVT when folding constant expressions

2014-07-05 Thread Tobias Klausmann
Folding for conversions: F32/64-(U16/32, S16/32) and (U16/32, S16/32)-F32 No piglit regressions observed on nv50 and nvc0! Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2: fix usage of wrong variable V3: enable F64 support V4: - disable F64 support again - handle

[Nouveau] [PATCH v5] nv50/ir: Handle OP_CVT when folding constant expressions

2014-07-05 Thread Tobias Klausmann
Folding for conversions: F32/64-(U16/32, S16/32) and (U16/32, S16/32)-F32 No piglit regressions observed on nv50 and nvc0! Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2: fix usage of wrong variable V3: enable F64 support V4: - disable F64 support again - handle

[Nouveau] [PATCH] nv50/ir: use unordered_set instead of list to keep our instructions in uses

2014-07-07 Thread Tobias Klausmann
This shortens runtime of piglit test fp-long-alu to ~22s No piglit regressions observed on nvc0! Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir.cpp | 6 +++--- src/gallium/drivers/nouveau/codegen/nv50_ir.h

[Nouveau] [PATCH] nv50/ir: (trivial) initialize pointer to silence warning

2014-07-25 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen

[Nouveau] [PATCH] nv50/ir: use unordered_set instead of list to keep track of var defs

2014-09-01 Thread Tobias Klausmann
The set of variable defs does not need to be ordered in any way, and removing/adding elements is a fairly common operation in various optimization passes. This shortens runtime of piglit test fp-long-alu to ~11s from ~22s No piglit regressions observed on nvc0! Signed-off-by: Tobias Klausmann

[Nouveau] [PATCH v2] nv50: Handle ARB_conditional_render_inverted and enable it

2014-10-21 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- docs/GL3.txt| 2 +- docs/relnotes/10.4.html | 1 + src/gallium/drivers/nouveau/nv50/nv50_context.h | 3 +- src/gallium/drivers/nouveau/nv50/nv50_query.c | 56

[Nouveau] [PATCH] nv50: Fix allocation size for querys

2014-10-26 Thread Tobias Klausmann
This was missed by commit: nv50: handle inverted render conditions 1a170980a09d82201b88e3fe20684a0df2cfea80 Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions

[Nouveau] [PATCH RESEND] nv50/ir: use unordered_set instead of list to keep track of var defs

2014-12-02 Thread Tobias Klausmann
The set of variable defs does not need to be ordered in any way, and removing/adding elements is a fairly common operation in various optimization passes. This shortens runtime of piglit test fp-long-alu to ~11s from ~22s No piglit regressions observed on nvc0! Signed-off-by: Tobias Klausmann

[Nouveau] [PATCH v3] nv50: enable texture compression

2015-01-02 Thread Tobias Klausmann
We enable compression only for some supported formats Suggested-by: Ilia Mirkin imir...@alum.mit.edu Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- v2: add more formats for compression v3: only enable compression if supported by drm src/gallium/drivers/nouveau/nv50

[Nouveau] [PATCH v2] nv50: enable texture compression

2015-01-02 Thread Tobias Klausmann
We enable compression only for some supported formats Suggested-by: Ilia Mirkin imir...@alum.mit.edu Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/nv50/nv50_miptree.c | 23 +-- src/gallium/drivers/nouveau/nv50

Re: [Nouveau] [PATCH v2] nv50: enable texture compression

2015-01-02 Thread Tobias Klausmann
On 03.01.2015 00:20, Ilia Mirkin wrote: On Fri, Jan 2, 2015 at 6:09 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: We enable compression only for some supported formats Suggested-by: Ilia Mirkin imir...@alum.mit.edu Signed-off-by: Tobias Klausmann tobias.johannes.klausm

[Nouveau] [PATCH] nv50: enable texture compression

2015-01-01 Thread Tobias Klausmann
We enable compression only for some supported formats Suggested-by: Ilia Mirkin imir...@alum.mit.edu Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/nv50/nv50_miptree.c | 4 ++-- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 11

Re: [Nouveau] [PATCH] nv50/ir: Handle OP_CVT when folding constant expressions

2015-01-24 Thread Tobias Klausmann
On 11.01.2015 23:53, Ilia Mirkin wrote: On Sun, Jan 11, 2015 at 5:48 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 11.01.2015 23:12, Ilia Mirkin wrote: On Sun, Jan 11, 2015 at 5:08 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 11.01.2015 22:54

[Nouveau] [PATCH v4] nv50/ir: Handle OP_CVT when folding constant expressions

2015-01-24 Thread Tobias Klausmann
Folding for conversions: F32-(U{16/32}, S{16/32}) (U{16/32}, {S16/32})-F32 U32 - U16 Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2: Split out F64 parts V3: remove handling of saturate for (U/S)32 V4: handle U32-U16 for OP_TXF .../drivers/nouveau/codegen

Re: [Nouveau] Problem with GTX 970 under Fedora 21

2015-01-26 Thread Tobias Klausmann
On 25.01.2015 21:40, super_7b wrote: Hi, I took this issue to the Fedora forum initially, but no-one there has been able to offer any guidance, so I have decided to come to the nouveau community directly. I was running a KDE desktop under Fedora 21 successfully, including the ability to

Re: [Nouveau] [RESEND/PATCH] nv50/ir: Handle OP_CVT when folding constant expressions

2015-01-09 Thread Tobias Klausmann
On 10.01.2015 02:41, Ilia Mirkin wrote: On Fri, Jan 9, 2015 at 6:47 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: Folding for conversions: F32-(U{16/32}, S{16/32}) and (U{16/32}, {S16/32})-F32 Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de

[Nouveau] [RESEND/PATCH] nv50/ir: Handle OP_CVT when folding constant expressions

2015-01-09 Thread Tobias Klausmann
Folding for conversions: F32-(U{16/32}, S{16/32}) and (U{16/32}, {S16/32})-F32 Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 109 + 1 file changed, 109 insertions(+) diff --git a/src/gallium

[Nouveau] [PATCH v2] nv50/ir: Handle OP_CVT when folding constant expressions

2015-01-09 Thread Tobias Klausmann
Folding for conversions: F32-(U{16/32}, S{16/32}) and (U{16/32}, {S16/32})-F32 Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2: beat me, whip me, split out F64 .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 81 ++ 1 file changed, 81

Re: [Nouveau] [PATCH v2] nv50/ir: Handle OP_CVT when folding constant expressions

2015-01-11 Thread Tobias Klausmann
On 11.01.2015 20:19, Ilia Mirkin wrote: On Sun, Jan 11, 2015 at 12:27 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 11.01.2015 01:58, Ilia Mirkin wrote: On Fri, Jan 9, 2015 at 8:24 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: Folding

[Nouveau] Re: [RFC] mesa/st: Avoid passing a NULL buffer to the drivers

2015-01-11 Thread Tobias Klausmann
On 11.01.2015 06:05, Ilia Mirkin wrote: Can you elaborate a bit as to why that's the right thing to do? On Wed, Jan 7, 2015 at 1:52 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: If we capture transform feedback from n stream in (n-1) buffers we face a NULL buffer, use

Re: [Nouveau] [PATCH] nv50/ir: Handle OP_CVT when folding constant expressions

2015-01-11 Thread Tobias Klausmann
On 11.01.2015 22:54, Ilia Mirkin wrote: On Sun, Jan 11, 2015 at 4:40 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: Folding for conversions: F32-(U{16/32}, S{16/32}) and (U{16/32}, {S16/32})-F32 Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2

Re: [Nouveau] [PATCH] nv50/ir: Handle OP_CVT when folding constant expressions

2015-01-11 Thread Tobias Klausmann
On 11.01.2015 23:12, Ilia Mirkin wrote: On Sun, Jan 11, 2015 at 5:08 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 11.01.2015 22:54, Ilia Mirkin wrote: On Sun, Jan 11, 2015 at 4:40 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: Folding

[Nouveau] Re: [RFC] mesa/st: Avoid passing a NULL buffer to the drivers

2015-01-11 Thread Tobias Klausmann
On 12.01.2015 01:57, Ilia Mirkin wrote: On Sun, Jan 11, 2015 at 7:43 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 11.01.2015 06:05, Ilia Mirkin wrote: Can you elaborate a bit as to why that's the right thing to do? On Wed, Jan 7, 2015 at 1:52 PM, Tobias Klausmann

[Nouveau] [PATCH] nv50/ir: Handle OP_CVT when folding constant expressions

2015-01-11 Thread Tobias Klausmann
Folding for conversions: F32-(U{16/32}, S{16/32}) and (U{16/32}, {S16/32})-F32 Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2: Split out F64 parts V3: remove handling of saturate for (U/S)32, .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 73

[Nouveau] [RFC] mesa/st: Avoid passing a NULL buffer to the drivers

2015-01-07 Thread Tobias Klausmann
If we capture transform feedback from n stream in (n-1) buffers we face a NULL buffer, use the buffer (n-1) to capture the output of stream n. This fixes one piglit test with nvc0: arb_gpu_shader5-xfb-streams-without-invocations Signed-off-by: Tobias Klausmann tobias.johannes.klausm

Re: [Nouveau] [PATCH] fuse/gm107: simplify the return logic

2015-01-25 Thread Tobias Klausmann
nvkm_object *engine, ret = nvkm_fuse_create(parent, engine, oclass, priv); *pobject = nv_object(priv); - if (ret) - return ret; - return 0; + return ret; } struct nvkm_oclass Reviewed-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de If it is helping

Re: [Nouveau] [PATCH 4/4] nv50/ir: allow OP_SET to merge with OP_SET_AND/etc as well as a neg

2015-05-09 Thread Tobias Klausmann
On 09.05.2015 07:35, Ilia Mirkin wrote: This covers the pattern where a KILL_IF is used, which triggers a comparison of -x to 0. This can usually be folded into the comparison whose result is being compared to 0, however it may, itself, have already been combined with another comparison. That

Re: [Nouveau] [PATCH] nvc0: switch mechanism for shader eviction to be a while loop

2015-05-10 Thread Tobias Klausmann
On 10.05.2015 07:57, Ilia Mirkin wrote: This aligns it to work similarly to nv50. However there's no library code there, so the whole thing can be freed. Here we end up with an allocated node that's not attached to a specific program. Bugzilla:

Re: [Nouveau] [PATCH 3/4] nvc0/ir: optimize set 1.0 to produce boolean-float sets

2015-05-09 Thread Tobias Klausmann
On 09.05.2015 07:35, Ilia Mirkin wrote: This has started to happen more now that the backend is producing KILL_IF more often. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 29 ++

Re: [Nouveau] [PATCH] nv50/ir: only enable mul saturate on G200+

2015-05-09 Thread Tobias Klausmann
Reviewed-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de On 09.05.2015 09:31, Ilia Mirkin wrote: Commit 44673512a84 enabled support for saturating fmul. However experimentally this does not seem to work on the older chips. Restrict the feature to G200 (NVA0) and later. Reported

Re: [Nouveau] [PATCH 3/4] nvc0/ir: optimize set 1.0 to produce boolean-float sets

2015-05-09 Thread Tobias Klausmann
On 09.05.2015 19:53, Ilia Mirkin wrote: On Sat, May 9, 2015 at 11:27 AM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 09.05.2015 07:35, Ilia Mirkin wrote: This has started to happen more now that the backend is producing KILL_IF more often. Signed-off-by: Ilia Mirkin

Re: [Nouveau] [Mesa-dev] [PATCH 00/12] Tessellation support for nvc0

2015-05-17 Thread Tobias Klausmann
as far as i can evaluate this without deeper insight into tess, this patchseries looks good to me! Reviewed-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de On 17.05.2015 07:07, Ilia Mirkin wrote: This is enough to enable tessellation support on nvc0. It seems to work a lot better

[Nouveau] [PATCH] nvc0: fix context destruction for partly implemented tesselation

2015-05-17 Thread Tobias Klausmann
0x70a2cf63 in st_destroy_context (st=0x68a9f0) at state_tracker/st_context.c:382 ... Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers

Re: [Nouveau] [PATCH] fix a wrong use of a logical operator in drmmode_output_dpms()

2015-05-20 Thread Tobias Klausmann
looks good to me! :) Feel free to add my R-b. On 20.05.2015 17:08, Samuel Pitoiset wrote: This is probably a typo error which has been introduced in 2009... This fixes the following warning detected by Clang : drmmode_display.c:907:30: warning: use of logical '' with constant operand

Re: [Nouveau] [PATCH] ram/gf100-: error out if a ridiculous amount of vram is detected

2015-05-20 Thread Tobias Klausmann
Any idea on how to solve the problem. other than just reporting it? But for now this adds a helpful error message... you may add my R-b. On 20.05.2015 22:01, Ilia Mirkin wrote: Some newer chips have trouble coming up, and we get bad MMIO reads from them, like 0xbadf100. This ends up

Re: [Nouveau] [RFC PATCH 00/11] Implement ARB_cull_distance

2015-05-27 Thread Tobias Klausmann
? It doesn't seem to be possible. Marek On Mon, May 25, 2015 at 5:07 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, May 25, 2015 at 9:40 AM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 25.05.2015 07:17, Dave Airlie wrote: On 25 May 2015 at 08:11, Marek Olšák mar

Re: [Nouveau] [Mesa-dev] [PATCH 2/2] nv30: fix clip plane uploads and enable changes

2015-05-24 Thread Tobias Klausmann
On 24.05.2015 16:15, Pierre Moreau wrote: On 24 May 2015, at 16:03, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 24.05.2015 10:38, Samuel Pitoiset wrote: On 05/24/2015 06:58 AM, Ilia Mirkin wrote: nv30_validate_clip depends on the rasterizer state. Also we should

Re: [Nouveau] [Mesa-dev] [PATCH 2/2] nv30: fix clip plane uploads and enable changes

2015-05-24 Thread Tobias Klausmann
On 24.05.2015 10:38, Samuel Pitoiset wrote: On 05/24/2015 06:58 AM, Ilia Mirkin wrote: nv30_validate_clip depends on the rasterizer state. Also we should upload all the new clip planes on change since next time the plane data won't have changed, but the enables might. Signed-off-by: Ilia

[Nouveau] [PATCH 01/11] glapi: add GL_ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mapi/glapi/gen/gl_API.xml | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 3090b9f..a792056 100644 --- a/src/mapi/glapi/gen

[Nouveau] [RFC PATCH 00/11] Implement ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
This patch series adds the needed support for this extension to the various parts of mesa to finally enable it for nvc0. Dave Airlie (1): glsl: lower cull_distance into cull_distance_mesa Tobias Klausmann (10): glapi: add GL_ARB_cull_distance mesa/main: add support for GL_ARB_cull_distance

[Nouveau] [PATCH 02/11] mesa/main: add support for GL_ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mesa/main/extensions.c | 1 + src/mesa/main/get.c | 26 ++ src/mesa/main/get_hash_params.py | 4 src/mesa/main/mtypes.h | 22

[Nouveau] [PATCH 08/11] i965: rename UsesClipDistanceOut to UsesClipCullDistanceOut

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- src/mesa/drivers/dri/i965/brw_gs.c | 2 +- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 2 +- src

[Nouveau] [PATCH 05/11] glsl: Add a helper to see if an array was unsize in the shader

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/glsl/glsl_types.cpp | 8 src/glsl/glsl_types.h | 10 -- src/glsl/linker.cpp | 2 +- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl

[Nouveau] [PATCH 06/11] glsl: lower cull_distance into cull_distance_mesa

2015-05-24 Thread Tobias Klausmann
From: Dave Airlie airl...@redhat.com Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/glsl/Makefile.sources| 1 + src/glsl/ir_optimization.h | 1 + src/glsl/link_varyings.cpp | 15 +- src/glsl/link_varyings.h | 3 +- src/glsl

[Nouveau] [PATCH 07/11] glsl: Add arb_cull_distance support

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/glsl/ast_to_hir.cpp | 14 + src/glsl/builtin_variables.cpp | 13 +++- src/glsl/glcpp/glcpp-parse.y| 3 + src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h

[Nouveau] [PATCH 10/11] nouveau/codegen: sort in galliums cull_distance semantic into the drivers bitmask

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen

[Nouveau] [PATCH 04/11] mesa/st: add support for GL_ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mesa/state_tracker/st_extensions.c | 4 src/mesa/state_tracker/st_program.c| 34 ++ 2 files changed, 38 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src

[Nouveau] [PATCH 11/11] nouveau/nvc0: implement cull_distance as a special form of clip distance

2015-05-24 Thread Tobias Klausmann
This enables ARB_cull_distance. Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- docs/GL3.txt | 2 +- docs/relnotes/10.7.0.html | 4 +++- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 6

[Nouveau] [PATCH 09/11] gallium: add support for arb_cull_distance

2015-05-24 Thread Tobias Klausmann
Add another pipe cap so we can savely enable of disable this extension Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/auxiliary/cso_cache/cso_context.c| 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c

[Nouveau] [PATCH 03/11] mesa/prog: Add varyings for arb_cull_distance

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mesa/program/prog_print.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/program/prog_print.c b/src/mesa/program/prog_print.c index d588d07..e8855cd 100644 --- a/src/mesa/program/prog_print.c +++ b/src

Re: [Nouveau] [PATCH 02/11] mesa/main: add support for GL_ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
On 24.05.2015 20:11, Ilia Mirkin wrote: On Sun, May 24, 2015 at 1:58 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mesa/main/extensions.c | 1 + src/mesa/main/get.c

Re: [Nouveau] [Mesa-dev] [PATCH 04/11] mesa/st: add support for GL_ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
On 24.05.2015 20:12, Marek Olšák wrote: On Sun, May 24, 2015 at 7:58 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/mesa/state_tracker/st_extensions.c | 4 src/mesa/state_tracker

Re: [Nouveau] [Mesa-dev] [PATCH 2/2] nv30: fix clip plane uploads and enable changes

2015-05-24 Thread Tobias Klausmann
On 24.05.2015 17:42, Ilia Mirkin wrote: On Sun, May 24, 2015 at 10:56 AM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 24.05.2015 16:15, Pierre Moreau wrote: On 24 May 2015, at 16:03, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 24.05.2015 10:38

Re: [Nouveau] [RFC PATCH 00/11] Implement ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
nvc0 code (for the vertex shader)? (hack up a patch for this, run it without DRI_PRIME=1, see i pass and forget to check it again) yeah those are equal, sorry for wasting your time on this :/ On Sun, May 24, 2015 at 1:57 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote

Re: [Nouveau] [RFC PATCH 00/11] Implement ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
On 24.05.2015 21:36, Ilia Mirkin wrote: On Sun, May 24, 2015 at 3:30 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 24.05.2015 20:25, Ilia Mirkin wrote: I'm having a bit of trouble tracing through this. What happens if I have a shader that just does: gl_ClipDistance[0

Re: [Nouveau] [RFC PATCH 00/11] Implement ARB_cull_distance

2015-05-25 Thread Tobias Klausmann
On 25.05.2015 07:17, Dave Airlie wrote: On 25 May 2015 at 08:11, Marek Olšák mar...@gmail.com wrote: It's the same on Radeon. There are 2x ClipOrCullDistance output vectors and a mask saying it should clip or cull or do nothing. Marek My thinking was gallium should have a single semantic

[Nouveau] [PATCH] docs: Mark ARB_cull_distance as in progress

2015-05-25 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- I'm already getting emails wanting me to do this, so just mark it, wont change anything really docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 44a824b

Re: [Nouveau] [Mesa-dev] [PATCH 09/11] gallium: add support for arb_cull_distance

2015-05-25 Thread Tobias Klausmann
for llvmpipe, I'm not entirely sure for softpipe) if not there's some unaccounted difference somewhere how we'd thought of how this should work for dx10 vs. opengl). Hey nice to know llvmpipe already supports this, i'll test it! Tobias Roland Am 24.05.2015 um 19:58 schrieb Tobias Klausmann

Re: [Nouveau] [PATCH 1/2] nv30/draw: rework some of the output vertex buffer logic

2015-05-25 Thread Tobias Klausmann
for it. i'm not really happy moving things to gart and don't see why this resolves the issue but granted if it works out :-) Reviewed-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.5 10.6 mesa-sta...@lists.freedesktop.org

Re: [Nouveau] [PATCH 2/2] nv30/draw: switch varying hookup logic to know about texcoords

2015-05-25 Thread Tobias Klausmann
On 26.05.2015 02:49, Ilia Mirkin wrote: On Mon, May 25, 2015 at 8:37 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 25.05.2015 21:29, Ilia Mirkin wrote: Commit 8acaf862dfe switched things over to use TEXCOORD instead of GENERIC, but did not update the nv30 swtnl draw

Re: [Nouveau] Self introduction Hans de Goede

2015-05-26 Thread Tobias Klausmann
On 26.05.2015 09:43, Hans de Goede wrote: Hi, On 26-05-15 09:41, Martin Peres wrote: On 26/05/15 10:29, Hans de Goede wrote: Hi All, Since I will be working on nouveau pretty much starting today I thought it would be good to write a quick self introduction. I'm an FOSS enthusiast /

Re: [Nouveau] [PATCH 2/2] nv30/draw: switch varying hookup logic to know about texcoords

2015-05-26 Thread Tobias Klausmann
On 26.05.2015 02:59, Ilia Mirkin wrote: On Mon, May 25, 2015 at 8:55 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 26.05.2015 02:49, Ilia Mirkin wrote: On Mon, May 25, 2015 at 8:37 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: On 25.05.2015 21:29

Re: [Nouveau] [PATCH 4/9] nvkm/fb/ramnv50: Ressurect timing code, use proper timing/rammap handlers

2015-05-22 Thread Tobias Klausmann
On 23.05.2015 00:33, Roy Spliet wrote: Might need some generalisation to GT200. For those: use at your own risk! Signed-off-by: Roy Spliet rspl...@eclipso.eu --- .../drm/nouveau/include/nvkm/subdev/bios/ramcfg.h | 16 ++ .../drm/nouveau/include/nvkm/subdev/bios/rammap.h | 2 +

  1   2   >