Re: [Numpy-discussion] MAINT: Use of except-pass blocks

2021-04-06 Thread Michael Dubravski
Okay thank you for the input. Do you have any recommendations for the type of exception classes that they could be changed to? From: NumPy-Discussion on behalf of Benjamin Root Reply-To: Discussion of Numerical Python Date: Tuesday, April 6, 2021 at 2:58 PM To: Discussion of Numerical

Re: [Numpy-discussion] MAINT: Use of except-pass blocks

2021-04-06 Thread Benjamin Root
In both of those situations, the `pass` aspect makes sense, although they probably should specify a better exception class to catch. The first one, with the copyto() has a comment that explains what is goingon. The second one, dealing with adding to the docstring, is needed because one can run

Re: [Numpy-discussion] MAINT: Use of except-pass blocks

2021-04-06 Thread Eric Wieser
I think the add_docstring one is best left alone, since if it fails once it will probably fail for every docstring in the system, and the logging would be pure noise. The ma/core one is suspicious - I can't think of any examples where an error would occur, but if you're interested, I'd encourage

[Numpy-discussion] umPy Development Meeting Wednesday - Triage Focus

2021-04-06 Thread Sebastian Berg
Hi all, Our bi-weekly triage-focused NumPy development meeting is Wednesday, March 10th at 11 am Pacific Time (18:00 UTC). Everyone is invited to join in and edit the work-in-progress meeting topics and notes: https://hackmd.io/68i_JvOYQfy9ERiHgXMPvg I encourage everyone to notify us of issues

[Numpy-discussion] MAINT: Use of except-pass blocks

2021-04-06 Thread Michael Dubravski
Hello everyone, There are multiple instances of except-pass blocks within the codebase that to my knowledge are bad practices (Referencing This StackOverflow Article. For example in numpy/ma/core.py there is an except-pass block that catches all exceptions thrown. Another example of this