Re: ContentSession#createBlob ?

2012-10-23 Thread Angela Schreiber
hi michael i create an enhancement to track that issue at https://issues.apache.org/jira/browse/OAK-392 and i added a suggestion on how to improve that in rev. 1401331 (with TODOs for those parts that IMO need some extra care and clarification). tests passed but i didn't check if there are many

ContentSession#createBlob ?

2012-10-19 Thread Angela Schreiber
hi all recent the ContentSession interface got a new method Blob createBlob(InputStream inputStream) throws IOException; this there is no TODO comment associated with it i assume that is intended to stay... however, it feels a bit odd to me having that method on the content session interface

Re: ContentSession#createBlob ?

2012-10-19 Thread Michael Dürig
The purpose of that method is to allow the API consumer to create Blob instances which are immediately streamed down to the BlobStore in the Microkernel. This way the API consumer can control at what point streaming takes place when setting values of Type.BINARY on a Tree: blob instances

Re: ContentSession#createBlob ?

2012-10-19 Thread Angela Schreiber
hi michael thanks for the info Note that createBlobd() is very much the same as the getCoreValueFactory() method, which it replaced. yes, i am aware of this... the reason why i don't like the method on contentsession has nothing to do with the 'what-it-does' but rather the fact i IMO it

Re: ContentSession#createBlob ?

2012-10-19 Thread Michael Dürig
On 19.10.12 10:36, Angela Schreiber wrote: hi michael thanks for the info Note that createBlobd() is very much the same as the getCoreValueFactory() method, which it replaced. yes, i am aware of this... the reason why i don't like the method on contentsession has nothing to do with the