Re: commit hooks and indexing

2013-02-15 Thread Tommaso Teofili
On 15/feb/2013, at 08:11, Jukka Zitting wrote: Hi, On Thu, Feb 14, 2013 at 10:29 PM, Michael Dürig mdue...@apache.org wrote: However, there is a difference depending on whether the index is stored in content or external. For the former case using commit hooks is the right thing to do. In

Re: commit hooks and indexing

2013-02-15 Thread Jukka Zitting
Hi, On Fri, Feb 15, 2013 at 11:20 AM, Tommaso Teofili teof...@adobe.com wrote: maybe it would be nice to explicitly design the synchronous / asynchronous execution of an hook An Observer is essentially an asynchronous hook. BR, Jukka Zitting

Re: commit hooks and indexing

2013-02-15 Thread Thomas Mueller
Hi, To update the external index: the hooks could be used to remember what content may needs to be indexed. That is: (A) The index hook stores the path of the added/removed/changed nodes (only for those nodes that contain indexed data) in a separate 'toBeIndexed' node, in the form of a tree.

Re: commit hooks and indexing

2013-02-15 Thread Jukka Zitting
Hi, On Fri, Feb 15, 2013 at 12:05 PM, Thomas Mueller muel...@adobe.com wrote: (A) The index hook stores the path of the added/removed/changed nodes (only for those nodes that contain indexed data) in a separate 'toBeIndexed' node, in the form of a tree. This information is already available

script to compare maven test run times

2013-02-15 Thread Alex Parvulescu
hi, For OAK-624 I needed to compare the test run times between 2 different mk implementations so I came up with a script that computes the percentage difference between the 2 'mvn test' runs. This allows for output like the one in this comment [0]. The interesting part is it is generic enough to

Re: script to compare maven test run times

2013-02-15 Thread Stefan Guggisberg
On Fri, Feb 15, 2013 at 12:04 PM, Alex Parvulescu alex.parvule...@gmail.com wrote: hi, For OAK-624 I needed to compare the test run times between 2 different mk implementations so I came up with a script that computes the percentage difference between the 2 'mvn test' runs. This allows for

Re: Add the #setHook method to the NodeStore?

2013-02-15 Thread Jukka Zitting
Hi, On Thu, Feb 14, 2013 at 7:38 PM, Angela Schreiber anch...@adobe.com wrote: that would also simplify things for having separate commit hook instances depending on the 'nature' of the root... for example creating hooks that know about the modified workspace (see OAK-625, which currently

Re: Add the #setHook method to the NodeStore?

2013-02-15 Thread Angela Schreiber
hi jukka now that you have committed an initial patch for OAK-627 (thanks) i will check if there wasn't a smarter solution for OAK-625... update will follow in the issue. gruss angela On 2/15/13 1:48 PM, Jukka Zitting wrote: Hi, On Thu, Feb 14, 2013 at 7:38 PM, Angela

Re: script to compare maven test run times

2013-02-15 Thread Michael Dürig
Good stuff! Michael On 15.2.13 11:04, Alex Parvulescu wrote: hi, For OAK-624 I needed to compare the test run times between 2 different mk implementations so I came up with a script that computes the percentage difference between the 2 'mvn test' runs. This allows for output like the one in