Fwd: Looking for small task starting in OAK .. DS conversion?
Hi Julian, I finished the conversion for the oak-auth-external module and created a PR. The tests all run fine. I will look into the comparison tool but I am not sure if it is needed. Of course it is possible that I introduce a bug with my PR but the comparison tool will also not guarantee that the conversion is bug free. Christian 2017-10-30 13:40 GMT+01:00 Julian Sedding <jsedd...@gmail.com>: > Hi Christian > > I have worked on OAK-6741 before and there were some concerns > regarding my changes. > > To address these concerns, I started work on a tool that allows > diffing the OSGi DS and MetaType metadata of two bundles. It uses > Felix' SCR and MetaType implementations to parse the metadata and > should thus be able to compare on a semantic level rather than on a > purely syntactic level (i.e. diff all XML files, which comes with its > own challenges)[0]. > > Note, that the tool is yet unfinished, as I don't currently have time > to complete it. Basically, what's left to do is implementing some > comparisons and possibly more rendering (see TODOs in > MetaDataDiff[1]). Fell free to fork, or I'm also happy grant you write > access on my repository. > > I hope you find this helpful! > > Regards > Julian > > [0] https://github.com/jsedding/osgi-ds-metatype-diff > [1] https://github.com/jsedding/osgi-ds-metatype-diff/blob/ > master/src/main/java/net/distilledcode/tools/osgi/MetadataDiff.java > > > On Mon, Oct 30, 2017 at 10:28 AM, Alex Deparvu <stilla...@apache.org> > wrote: > > Hi Christian, > > > > Thanks for your interest in helping out in this area! > > You can look at OAK-6741 [0] to see what the status of this effort is, > > there's a few tasks created already waiting for some attention :) > > > > best, > > alex > > > > [0] https://issues.apache.org/jira/browse/OAK-6741 > > > > > > > > On Mon, Oct 30, 2017 at 9:57 AM, Christian Schneider < > > ch...@die-schneider.net> wrote: > > > >> Hi all, > >> > >> as I am just starting to work on OAK I am looking for a small task. > >> I found that there are still some components that use the old felix scr > >> annotations. > >> Does it make sense that I look into converting these to the DS ones so > we > >> can remove support for felix scr in the build? > >> > >> I have listed the classes below. > >> The main issue I see with the migration is that OAK uses the meta type > >> support of felix scr which is quite different to what DS 1.3 provides. > So I > >> would need to migrate from the property based meta type descriptions to > the > >> type safe ones of the DS 1.3 metatype support. > >> > >> Anyway I would provide one module per PR so the reviewer does not have > to > >> review one big commit at once. > >> > >> Best > >> Christian > >> > >> -- > >> -- > >> Christian Schneider > >> http://www.liquid-reality.de > >> <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e > >> 46=http%3a%2f%2fwww.liquid-reality.de> > >> > >> Computer Scientist > >> http://www.adobe.com > >> > >> > >> --- > >> > >> oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/ > >> authentication/external/impl/DefaultSyncConfigImpl.java:import > >> org.apache.felix.scr.annotations.Component; > >> > >> oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/ > >> authentication/external/impl/DefaultSyncHandler.java:import > >> org.apache.felix.scr.annotations.Component; > >> > >> oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/ > >> authentication/external/impl/ExternalIDPManagerImpl.java:import > >> org.apache.felix.scr.annotations.Component; > >> > >> oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/ > >> authentication/external/impl/ExternalLoginModuleFactory.java:import > >> org.apache.felix.scr.annotations.Component; > >> > >> oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/ > >> authentication/external/impl/principal/ExternalPrincipalConfiguration > >> .java:import > >> org.apache.felix.scr.annotations.Component; > >> > >> oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/ > >> authentication/external/impl/SyncManagerImpl.java:import > >> org.apache.felix.scr.annotations.Component; > >> > >> oak-auth-ldap/
Looking for small task starting in OAK .. DS conversion?
Hi all, as I am just starting to work on OAK I am looking for a small task. I found that there are still some components that use the old felix scr annotations. Does it make sense that I look into converting these to the DS ones so we can remove support for felix scr in the build? I have listed the classes below. The main issue I see with the migration is that OAK uses the meta type support of felix scr which is quite different to what DS 1.3 provides. So I would need to migrate from the property based meta type descriptions to the type safe ones of the DS 1.3 metatype support. Anyway I would provide one module per PR so the reviewer does not have to review one big commit at once. Best Christian -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Computer Scientist http://www.adobe.com --- oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncConfigImpl.java:import org.apache.felix.scr.annotations.Component; oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncHandler.java:import org.apache.felix.scr.annotations.Component; oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalIDPManagerImpl.java:import org.apache.felix.scr.annotations.Component; oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModuleFactory.java:import org.apache.felix.scr.annotations.Component; oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalPrincipalConfiguration.java:import org.apache.felix.scr.annotations.Component; oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/SyncManagerImpl.java:import org.apache.felix.scr.annotations.Component; oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/LdapIdentityProvider.java:import org.apache.felix.scr.annotations.Component; oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/LdapProviderConfig.java:import org.apache.felix.scr.annotations.Component; oak-authorization-cug/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/cug/impl/CugConfiguration.java:import org.apache.felix.scr.annotations.Component; oak-authorization-cug/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/cug/impl/CugExcludeImpl.java:import org.apache.felix.scr.annotations.Component; oak-blob/src/main/java/org/apache/jackrabbit/oak/spi/blob/osgi/FileBlobStoreService.java:import org.apache.felix.scr.annotations.Component; oak-blob/src/main/java/org/apache/jackrabbit/oak/spi/blob/osgi/SplitBlobStoreService.java:import org.apache.felix.scr.annotations.Component; oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/AbstractS3DataStoreService.java:import org.apache.felix.scr.annotations.Component; oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3DataStoreService.java:import org.apache.felix.scr.annotations.Component; oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/SharedS3DataStoreService.java:import org.apache.felix.scr.annotations.Component; oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureDataStoreService.java:import org.apache.felix.scr.annotations.Component; oak-blob-plugins/src/main/java/org/apache/jackrabbit/oak/plugins/blob/ConsolidatedDataStoreCacheStats.java:import org.apache.felix.scr.annotations.Component; oak-blob-plugins/src/main/java/org/apache/jackrabbit/oak/plugins/blob/datastore/AbstractDataStoreService.java:import org.apache.felix.scr.annotations.Component; oak-blob-plugins/src/main/java/org/apache/jackrabbit/oak/plugins/blob/datastore/DbDataStoreService.java:import org.apache.felix.scr.annotations.Component; oak-blob-plugins/src/main/java/org/apache/jackrabbit/oak/plugins/blob/datastore/FileDataStoreService.java:import org.apache.felix.scr.annotations.Component; oak-blob-plugins/src/main/java/org/apache/jackrabbit/oak/plugins/blob/migration/BlobMigration.java:import org.apache.felix.scr.annotations.Component; oak-exercise/src/main/java/org/apache/jackrabbit/oak/exercise/security/authentication/CustomLoginModuleFactory.java:import org.apache.felix.scr.annotations.Component; oak-exercise/src/main/java/org/apache/jackrabbit/oak/exercise/security/authentication/external/CustomExternalIdentityProvider.java:import org.apache.felix.scr.annotations.Component; oak-exercise/src/main/java/org/apache/jackrabbit/oak/exercise/security/authorization/restriction/CustomRestrictionProvider.java:import org.apache.felix.scr.annotations.Component; oak-exercise/src/main/java/org/apache/jackrabbit/oak/exercise/security/pri
Re: Build fails at oak-lucene
Yes .. I think this is what I experienced. I guess I got the 5.1.2 from some internal Adobe build. So upgrading to 5.1.3 makes a lot of sense. Christian 2017-10-30 8:34 GMT+01:00 Davide Giannella <dav...@apache.org>: > On 27/10/2017 15:08, Julian Reschke wrote: > > Yes. There are indeed two different versions of this artifact. I have > > no idea why. > > I think the main reason is that before 5.1.2 xmpcore were a closed > source project within Adobe. the 5.1.2 version has been release both > internally in adobe and later on publicly with the same version. > > Therefore, if you happen to download the first time xmpcore on your > system from within the Adobe network it will download the one that > references internal artifacts that are not available publicly. > Eventually when building from outside the VPN if one of those artifacts > are not in the local repo it fails. > > I see that xmpcore is not up to version 6.1.10. Maybe by simply updating > tikka to 5.1.3 could solve this issue for good. > > D. > > > > > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Computer Scientist http://www.adobe.com
Re: BUILD FAILURE: Jackrabbit Oak - Build # 919 - Failure
Hi Chetan, there are more similar failures. The build then breaks for me at oak-upgrade. .e.g: [*INFO*] Running org.apache.jackrabbit.oak.upgrade.cli.*Jcr2ToSegmentTest* [*ERROR*] *Tests **run: 2*, Failures: 0, *Errors: 2*, Skipped: 0, Time elapsed: 1.657 s* <<< FAILURE!* - in org.apache.jackrabbit.oak.upgrade.cli. *Jcr2ToSegmentTest* [*ERROR*] validateMigration(org.apache.jackrabbit.oak.upgrade.cli.Jcr2ToSegmentTest) Time elapsed: 1.657 s <<< ERROR! java.lang.RuntimeException: javax.jcr.RepositoryException: Failed to copy content at org.apache.jackrabbit.oak.upgrade.cli.Jcr2ToSegmentTest.prepare(Jcr2ToSegmentTest.java:56) Caused by: javax.jcr.RepositoryException: Failed to copy content at org.apache.jackrabbit.oak.upgrade.cli.Jcr2ToSegmentTest.prepare(Jcr2ToSegmentTest.java:56) Caused by: java.lang.NullPointerException: QueryIndexProvider yet not initialized at org.apache.jackrabbit.oak.upgrade.cli.Jcr2ToSegmentTest.prepare(Jcr2ToSegmentTest.java:56) Christian 2017-10-27 15:42 GMT+02:00 Chetan Mehrotra <chetan.mehro...@gmail.com>: > Fixed the test now with 1813536 > Chetan Mehrotra > > > On Fri, Oct 27, 2017 at 6:37 PM, Apache Jenkins Server > <jenk...@builds.apache.org> wrote: > > The Apache Jenkins build system has built Jackrabbit Oak (build #919) > > > > Status: Failure > > > > Check console output at https://builds.apache.org/job/ > Jackrabbit%20Oak/919/ to view the results. > > > > Changes: > > [frm] OAK-6829 - Make the configuration of NetworkErrorProxy immutable > > > > [frm] OAK-6829 - Let the primary and the standby close the connection if > an exception is caught > > > > [chetanm] OAK-6873 - UserInitializer should not use hard coded > QueryIndexProvider > > > > > > > > Test results: > > 1 tests failed. > > FAILED: org.apache.jackrabbit.oak.segment.InitializerTest. > testInitializerSegment > > > > Error Message: > > QueryIndexProvider yet not initialized > > > > Stack Trace: > > java.lang.NullPointerException: QueryIndexProvider yet not initialized > > at org.apache.jackrabbit.oak.segment.InitializerTest. > testInitializerSegment(InitializerTest.java:51) > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Computer Scientist http://www.adobe.com
Build fails at oak-lucene
Hi all, I am currently trying to build oak from master. When doing mvn clean install I get an error in the oak-lucene module. It looks like the referenced adobe granite parent pom is missing. I guess this error does not occur when someone builds using the Adobe vpn. So I think we need to publish the parent pom to maven central. I will try to find someone with the rights to do this. Christian - [*ERROR*] Failed to execute goal on project oak-lucene: *Could not resolve dependencies for project org.apache.jackrabbit:oak-lucene:bundle:1.8-SNAPSHOT: Failed to collect dependencies at org.apache.tika:tika-parsers:jar:1.15 -> com.drewnoakes:metadata-extractor:jar:2.9.1 -> com.adobe.xmp:xmpcore:jar:5.1.2*: Failed to read artifact descriptor for com.adobe.xmp:xmpcore:jar:5.1.2: Failure to find com.adobe.granite:parent:pom:60 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> *[Help 1]* -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Computer Scientist http://www.adobe.com
