[jira] [Commented] (OAK-3606) Improvements for IndexStatsMBean usage

2016-11-16 Thread Manfred Baedke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671377#comment-15671377 ] Manfred Baedke commented on OAK-3606: - Thanks [~chetanm], that actually seems to work! > Improvements

[jira] [Commented] (OAK-5113) Avoid dispatching changes for checkpoint related changes

2016-11-16 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669827#comment-15669827 ] Alex Parvulescu commented on OAK-5113: -- looks good! > Avoid dispatching changes for checkpoint related

[jira] [Resolved] (OAK-5113) Avoid dispatching changes for checkpoint related changes

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved OAK-5113. -- Resolution: Fixed Fix Version/s: 1.5.14 Done changes with 1769947,1769948, 1769949 >

[jira] [Commented] (OAK-3606) Improvements for IndexStatsMBean usage

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670451#comment-15670451 ] Chetan Mehrotra commented on OAK-3606: -- This would need some change. The IndexUpdate constructor used

[jira] [Updated] (OAK-4179) Difference in splitdn and User DN paths options in Oak

2016-11-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-4179: Issue Type: Improvement (was: Bug) > Difference in splitdn and User DN paths options in Oak >

[jira] [Resolved] (OAK-3626) Provide bind credentials callback

2016-11-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-3626. - Resolution: Resolved > Provide bind credentials callback > - > >

[jira] [Commented] (OAK-4898) Allow for external changes to have a CommitInfo attached

2016-11-16 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669952#comment-15669952 ] Marcel Reutegger commented on OAK-4898: --- bq. Making CommitInfo non null would require change in

[jira] [Updated] (OAK-4898) Allow for external changes to have a CommitInfo attached

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-4898: - Attachment: OAK-4898-v2.patch [updated patch|^OAK-4898-v2.patch] which adds a static method

[jira] [Commented] (OAK-4898) Allow for external changes to have a CommitInfo attached

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669965#comment-15669965 ] Chetan Mehrotra commented on OAK-4898: -- bq. what about existing code outside of Oak that currently

[jira] [Commented] (OAK-2108) Killing a cluster node may stop async index update to to 30 minutes

2016-11-16 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669841#comment-15669841 ] Alex Parvulescu commented on OAK-2108: -- bq. For setups involving SegmentNodeStore we can optimize this

[jira] [Created] (OAK-5115) IndexCopier#cowCopyDoneOnCloseExceptionHandling test hangs intermittently

2016-11-16 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created OAK-5115: Summary: IndexCopier#cowCopyDoneOnCloseExceptionHandling test hangs intermittently Key: OAK-5115 URL: https://issues.apache.org/jira/browse/OAK-5115 Project:

[jira] [Updated] (OAK-5113) Avoid dispatching changes for checkpoint related changes

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-5113: - Component/s: segmentmk > Avoid dispatching changes for checkpoint related changes >

[jira] [Updated] (OAK-4114) Cached lucene index gets corrupted in case of unclean shutdown and journal rollback in SegmentNodeStore

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-4114: - Labels: candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4 resilience (was: resilience) >

[jira] [Commented] (OAK-3985) MongoDocumentStore: implement new conditional remove method

2016-11-16 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669976#comment-15669976 ] Marcel Reutegger commented on OAK-3985: --- The finally block surrounding {{dbCollection.remove()}}

[jira] [Resolved] (OAK-5115) IndexCopier#cowCopyDoneOnCloseExceptionHandling test hangs intermittently

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved OAK-5115. -- Resolution: Fixed Fix Version/s: 1.5.14 Fixed with r1769941 >

[jira] [Commented] (OAK-4898) Allow for external changes to have a CommitInfo attached

2016-11-16 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669880#comment-15669880 ] Stefan Egli commented on OAK-4898: -- bq. But would we want to merge the ChangeSet also when collapsing we

[jira] [Commented] (OAK-3001) Simplify JournalGarbageCollector using a dedicated timestamp property

2016-11-16 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669885#comment-15669885 ] Marcel Reutegger commented on OAK-3001: --- AFAICS you didn't change any checks, you added more. The

[jira] [Commented] (OAK-5101) Enable prefiltering for external changes

2016-11-16 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669884#comment-15669884 ] Stefan Egli commented on OAK-5101: -- Note that when collapsing we could merge the ChangeSets, see [this

[jira] [Comment Edited] (OAK-4114) Cached lucene index gets corrupted in case of unclean shutdown and journal rollback in SegmentNodeStore

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669866#comment-15669866 ] Chetan Mehrotra edited comment on OAK-4114 at 11/16/16 8:53 AM: Did a fix

[jira] [Resolved] (OAK-4114) Cached lucene index gets corrupted in case of unclean shutdown and journal rollback in SegmentNodeStore

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved OAK-4114. -- Resolution: Fixed Fix Version/s: 1.5.14 Did a fix with 1769940, 1769939 Now before and

[jira] [Commented] (OAK-3001) Simplify JournalGarbageCollector using a dedicated timestamp property

2016-11-16 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669900#comment-15669900 ] Marcel Reutegger commented on OAK-3001: --- bq. I didn't extend Condition class for this as afaics usage

[jira] [Commented] (OAK-4898) Allow for external changes to have a CommitInfo attached

2016-11-16 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669857#comment-15669857 ] Michael Dürig commented on OAK-4898: One minor comment re. the patch: the {{info == null ||

[jira] [Commented] (OAK-3001) Simplify JournalGarbageCollector using a dedicated timestamp property

2016-11-16 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670134#comment-15670134 ] Stefan Egli commented on OAK-3001: -- bq. can you please review if I wavered off from what we planned to do?

[jira] [Updated] (OAK-2108) Killing a cluster node may stop async index update to to 30 minutes

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-2108: - Attachment: OAK-2108-v1.patch [patch|^OAK-2108-v1.patch] for the same. [~alexparvulescu] Please

[jira] [Commented] (OAK-3001) Simplify JournalGarbageCollector using a dedicated timestamp property

2016-11-16 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670187#comment-15670187 ] Vikas Saurabh commented on OAK-3001: [~mreutegg], I should've clarified my statement better. What I

[jira] [Commented] (OAK-3001) Simplify JournalGarbageCollector using a dedicated timestamp property

2016-11-16 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670192#comment-15670192 ] Vikas Saurabh commented on OAK-3001: [~mreutegg], oh!, i meant if I need to update this code to utilize

[jira] [Commented] (OAK-3001) Simplify JournalGarbageCollector using a dedicated timestamp property

2016-11-16 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670200#comment-15670200 ] Marcel Reutegger commented on OAK-3001: --- That's better, yes. > Simplify JournalGarbageCollector using

[jira] [Created] (OAK-5116) GCJournal should persist size only when compaction is successful

2016-11-16 Thread Alex Parvulescu (JIRA)
Alex Parvulescu created OAK-5116: Summary: GCJournal should persist size only when compaction is successful Key: OAK-5116 URL: https://issues.apache.org/jira/browse/OAK-5116 Project: Jackrabbit Oak

[jira] [Updated] (OAK-5116) GCJournal should persist size only when compaction is successful

2016-11-16 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Parvulescu updated OAK-5116: - Fix Version/s: 1.5.14 1.6 > GCJournal should persist size only when compaction

[jira] [Commented] (OAK-3001) Simplify JournalGarbageCollector using a dedicated timestamp property

2016-11-16 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670100#comment-15670100 ] Stefan Egli commented on OAK-3001: -- bq. noticed OAK-3975 in related issues. I think we should revert that

[jira] [Assigned] (OAK-5117) Improve checkMemory for compaction

2016-11-16 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Parvulescu reassigned OAK-5117: Assignee: Alex Parvulescu > Improve checkMemory for compaction >

[jira] [Created] (OAK-5119) JourncalGarbageCollector: journalGcBatchSize configuration is irrelevant post implementation tasks of bulk remove support in DocumentStore

2016-11-16 Thread Vikas Saurabh (JIRA)
Vikas Saurabh created OAK-5119: -- Summary: JourncalGarbageCollector: journalGcBatchSize configuration is irrelevant post implementation tasks of bulk remove support in DocumentStore Key: OAK-5119 URL:

[jira] [Resolved] (OAK-4952) reject UpdateOp with set operation for _id, clarify API, add tests, fix implementations

2016-11-16 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved OAK-4952. --- Resolution: Fixed Fix Version/s: 1.5.14 Applied changes to trunk:

[jira] [Commented] (OAK-5117) Improve checkMemory for compaction

2016-11-16 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670549#comment-15670549 ] Alex Parvulescu commented on OAK-5117: -- bq. This means that, depending on the JVM, it will be checking

[jira] [Updated] (OAK-5119) JournalGarbageCollector: journalGcBatchSize configuration is irrelevant post implementation tasks of bulk remove support in DocumentStore

2016-11-16 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Saurabh updated OAK-5119: --- Summary: JournalGarbageCollector: journalGcBatchSize configuration is irrelevant post implementation

[jira] [Created] (OAK-5120) Automatically convert *all* "or" queries to "union" for SQL-2, take 2

2016-11-16 Thread Thomas Mueller (JIRA)
Thomas Mueller created OAK-5120: --- Summary: Automatically convert *all* "or" queries to "union" for SQL-2, take 2 Key: OAK-5120 URL: https://issues.apache.org/jira/browse/OAK-5120 Project: Jackrabbit

[jira] [Assigned] (OAK-4952) reject UpdateOp with set operation for _id, clarify API, add tests, fix implementations

2016-11-16 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger reassigned OAK-4952: - Assignee: Marcel Reutegger (was: Julian Reschke) > reject UpdateOp with set operation for

[jira] [Updated] (OAK-5117) Improve checkMemory for compaction

2016-11-16 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Parvulescu updated OAK-5117: - Fix Version/s: 1.5.14 1.6 > Improve checkMemory for compaction >

[jira] [Commented] (OAK-5117) Improve checkMemory for compaction

2016-11-16 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670594#comment-15670594 ] Alex Parvulescu commented on OAK-5117: -- clarified it with [~volteanu]. it seems all pools return

[jira] [Resolved] (OAK-4938) clarify contract for UpdateOp with missing operation on _id

2016-11-16 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved OAK-4938. --- Resolution: Fixed Fix Version/s: (was: 1.5.15) 1.5.14 All

[jira] [Commented] (OAK-3975) Change DELETE_BATCH_SIZE to 100 (from 450), and make it configurable

2016-11-16 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670766#comment-15670766 ] Vikas Saurabh commented on OAK-3975: Btw, OAK-5119 has undone this as OAK-3001 is committed now. >

[jira] [Commented] (OAK-5117) Improve checkMemory for compaction

2016-11-16 Thread Valentin Olteanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670839#comment-15670839 ] Valentin Olteanu commented on OAK-5117: --- I agree, it's simpler and cleaner. > Improve checkMemory

[jira] [Updated] (OAK-4898) Allow for external changes to have a CommitInfo attached

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-4898: - Attachment: OAK-4898-v3.patch [take 3|^OAK-4898-v3.patch] which makes CommitInfo non null. Due to

[jira] [Commented] (OAK-3001) Simplify JournalGarbageCollector using a dedicated timestamp property

2016-11-16 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670778#comment-15670778 ] Vikas Saurabh commented on OAK-3001: Done (OAK-5119). > Simplify JournalGarbageCollector using a

[jira] [Created] (OAK-5121) review CommitInfo==null in BackgroundObserver with isExternal change

2016-11-16 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-5121: Summary: review CommitInfo==null in BackgroundObserver with isExternal change Key: OAK-5121 URL: https://issues.apache.org/jira/browse/OAK-5121 Project: Jackrabbit Oak

[jira] [Resolved] (OAK-5119) JournalGarbageCollector: journalGcBatchSize configuration is irrelevant post implementation tasks of bulk remove support in DocumentStore

2016-11-16 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Saurabh resolved OAK-5119. Resolution: Fixed Fix Version/s: 1.6 Done on trunk at

[jira] [Resolved] (OAK-3985) MongoDocumentStore: implement new conditional remove method

2016-11-16 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Saurabh resolved OAK-3985. Resolution: Fixed > MongoDocumentStore: implement new conditional remove method >

[jira] [Commented] (OAK-3985) MongoDocumentStore: implement new conditional remove method

2016-11-16 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670772#comment-15670772 ] Vikas Saurabh commented on OAK-3985: Thanks [~mreutegg]. Fixed this in

[jira] [Updated] (OAK-5121) review CommitInfo==null in BackgroundObserver with isExternal change

2016-11-16 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-5121: - Fix Version/s: 1.5.14 > review CommitInfo==null in BackgroundObserver with isExternal change >

[jira] [Commented] (OAK-4898) Allow for external changes to have a CommitInfo attached

2016-11-16 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670884#comment-15670884 ] Stefan Egli commented on OAK-4898: -- [~chetanm], patch looks good. Some comments: * AsyncIndexUpdate

[jira] [Commented] (OAK-4898) Allow for external changes to have a CommitInfo attached

2016-11-16 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670983#comment-15670983 ] Stefan Egli commented on OAK-4898: -- +1, perfect, looks good to me. > Allow for external changes to have a

[jira] [Updated] (OAK-4898) Allow for external changes to have a CommitInfo attached

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-4898: - Attachment: OAK-4898-v4.patch [take 4|^OAK-4898-v4.patch] for including above change bq.

[jira] [Commented] (OAK-4943) Keep Lucene Commits so that if the Segments file gets corrupted recovery can be attempted.

2016-11-16 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671017#comment-15671017 ] Chetan Mehrotra commented on OAK-4943: -- [~ianeboston] Are there any more changes in your github branch?