[
https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670884#comment-15670884
]
Stefan Egli commented on OAK-4898:
----------------------------------
[~chetanm], patch looks good. Some comments:
* AsyncIndexUpdate introduces a typo in the change
* ChangeProcessor.contentChanged (still) has a check for info != null, but that
should probably now be 'CommitContext' != null
* NodeEventHandler (still) has a check for commitInfo == null, which it
translates into EMPTY. In theory that check is no longer necessary now? Or
should it be changed to EMPTY_EXTERNAL..
* And a question: I'm wondering if we should make the {{info}} map of EMPTY and
EMPTY_EXTERNAL immutable to avoid erroneously updating that (and then updating
the singleton). As by having non-empty CommitInfo all the time now we might
make use of this and add a CommitContext even to EMPTY and EMPTY_EXTERNAL
CommitInfos at some point - but to do that we first have to clone it to avoid
this mistake. Adding a safety check might help in any case. Wdyt?
bq. Can you look into changes required in BackgroundObserver
Created OAK-5121 to follow up on that.
> Allow for external changes to have a CommitInfo attached
> --------------------------------------------------------
>
> Key: OAK-4898
> URL: https://issues.apache.org/jira/browse/OAK-4898
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Fix For: 1.6
>
> Attachments: OAK-4898-v1.patch, OAK-4898-v2.patch, OAK-4898-v3.patch
>
>
> Currently the observation logic relies on fact that CommitInfo being null
> means that changes are from other cluster node i.e. external changes.
> We should change this semantic and provide a different way to indicate that
> changes are external. This would allow a NodeStore implementation to still
> pass in a CommitInfo which captures useful information about commit like
> brief summary on what got changed which can be used for pre filtering
> (OAK-4796)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
