[
https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669965#comment-15669965
]
Chetan Mehrotra commented on OAK-4898:
--------------------------------------
bq. what about existing code outside of Oak that currently implement Observer
(e.g. Apache Sling) and work according to the current contract?
At least for Sling code was changed to move to EventListener (See SLING-6138).
Also the api is currently not versioned
{noformat}
org.apache.jackrabbit.oak.security,version=0.0.0
org.apache.jackrabbit.oak.spi.commit,version=0.0.0
{noformat}
So for making CommitInfo NonNull should I come up with a static
CommitInfo.EMPTY_EXTERNAL which would be used by NodeStore where they are
passing null?
Would come up with a new patch then
> Allow for external changes to have a CommitInfo attached
> --------------------------------------------------------
>
> Key: OAK-4898
> URL: https://issues.apache.org/jira/browse/OAK-4898
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Fix For: 1.6
>
> Attachments: OAK-4898-v1.patch, OAK-4898-v2.patch
>
>
> Currently the observation logic relies on fact that CommitInfo being null
> means that changes are from other cluster node i.e. external changes.
> We should change this semantic and provide a different way to indicate that
> changes are external. This would allow a NodeStore implementation to still
> pass in a CommitInfo which captures useful information about commit like
> brief summary on what got changed which can be used for pre filtering
> (OAK-4796)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
