[jira] [Commented] (OAK-3235) Deadlock when closing a concurrently used FileStore

[ https://issues.apache.org/jira/browse/OAK-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14714206#comment-14714206 ] Michael Dürig commented on OAK-3235: The {{SNFE}} is caused by the offending segment not

[jira] [Assigned] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reassigned OAK-3288: --- Assignee: Julian Reschke clarify DocumentStore contract with respect to number formats

[jira] [Updated] (OAK-3263) Support including and excluding paths for PropertyIndex

[ https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated OAK-3263: Attachment: OAK-3263-v2.patch Support including and excluding paths for PropertyIndex

[jira] [Updated] (OAK-3263) Support including and excluding paths for PropertyIndex

[ https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated OAK-3263: Attachment: OAK-3263-v2.patch Attached OAK-3263-v2.patch. If an index has excludedPaths and there is

[jira] [Updated] (OAK-3263) Support including and excluding paths for PropertyIndex

[ https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated OAK-3263: Attachment: (was: OAK-3263-v2.patch) Support including and excluding paths for PropertyIndex

[jira] [Created] (OAK-3302) ExternalLoginModule:193 can never be reached

Thorsten Biegner created OAK-3302: - Summary: ExternalLoginModule:193 can never be reached Key: OAK-3302 URL: https://issues.apache.org/jira/browse/OAK-3302 Project: Jackrabbit Oak Issue

[jira] [Comment Edited] (OAK-3263) Support including and excluding paths for PropertyIndex

[ https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715211#comment-14715211 ] Manfred Baedke edited comment on OAK-3263 at 8/26/15 5:42 PM: --

[jira] [Commented] (OAK-3292) DocumentDiscoveryLiteServiceTest failures on travis and jenkins

[ https://issues.apache.org/jira/browse/OAK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14714234#comment-14714234 ] Stefan Egli commented on OAK-3292: -- fixed one issue found: http://svn.apache.org/r1697958

[jira] [Commented] (OAK-3250) Restart DocumentNodeStore on lease timeout instead of System.exit

[ https://issues.apache.org/jira/browse/OAK-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712636#comment-14712636 ] Marcel Reutegger commented on OAK-3250: --- bq. it would not know that a restart has

[jira] [Commented] (OAK-3250) Restart DocumentNodeStore on lease timeout instead of System.exit

[ https://issues.apache.org/jira/browse/OAK-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712662#comment-14712662 ] Marcel Reutegger commented on OAK-3250: --- I'm confused. I thought we would shut down

[jira] [Commented] (OAK-3230) Query engine should support virtual index rows

[ https://issues.apache.org/jira/browse/OAK-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712917#comment-14712917 ] Thomas Mueller commented on OAK-3230: - Ah oak-lucene fails with a NPE, so we do have

[jira] [Commented] (OAK-3250) Restart DocumentNodeStore on lease timeout instead of System.exit

[ https://issues.apache.org/jira/browse/OAK-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712650#comment-14712650 ] Stefan Egli commented on OAK-3250: -- the sequence number would change yes, but that does not

[jira] [Commented] (OAK-3250) Restart DocumentNodeStore on lease timeout instead of System.exit

[ https://issues.apache.org/jira/browse/OAK-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712667#comment-14712667 ] Stefan Egli commented on OAK-3250: -- bq. Doesn't this include the discovery mechanism?

[jira] [Updated] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-3288: Attachment: OAK-3288.diff Proposed patch (doc change still missing) clarify DocumentStore contract

[jira] [Commented] (OAK-3250) Restart DocumentNodeStore on lease timeout instead of System.exit

[ https://issues.apache.org/jira/browse/OAK-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712654#comment-14712654 ] Stefan Egli commented on OAK-3250: -- which - when reading this again - reminds me that not

[jira] [Commented] (OAK-3230) Query engine should support virtual index rows

[ https://issues.apache.org/jira/browse/OAK-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712871#comment-14712871 ] Thomas Mueller commented on OAK-3230: - The change in AggregationCursor looks wrong to

[jira] [Commented] (OAK-3230) Query engine should support virtual index rows

[ https://issues.apache.org/jira/browse/OAK-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712908#comment-14712908 ] Thomas Mueller commented on OAK-3230: - Even without the above change, oak-core tests

[jira] [Updated] (OAK-2679) Query engine: cache execution plans

[ https://issues.apache.org/jira/browse/OAK-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Richard updated OAK-2679: -- Attachment: 0001-OAK-2679-Reduce-execution-plan-overhead_0.2.patch I have attached an updated version of

[jira] [Created] (OAK-3298) Allow to specify LogDumper's log buffer size

Stefan Egli created OAK-3298: Summary: Allow to specify LogDumper's log buffer size Key: OAK-3298 URL: https://issues.apache.org/jira/browse/OAK-3298 Project: Jackrabbit Oak Issue Type:

[jira] [Resolved] (OAK-3298) Allow to specify LogDumper's log buffer size

[ https://issues.apache.org/jira/browse/OAK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-3298. -- Resolution: Fixed done. Allow to specify LogDumper's log buffer size

[jira] [Commented] (OAK-3281) Test failures on trunk: SolrIndexQueryTestIT.sql2

[ https://issues.apache.org/jira/browse/OAK-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712792#comment-14712792 ] Thomas Mueller commented on OAK-3281: - We would need to have the target/...sql2.txt

[jira] [Commented] (OAK-3230) Query engine should support virtual index rows

[ https://issues.apache.org/jira/browse/OAK-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712880#comment-14712880 ] Vikas Saurabh commented on OAK-3230: Good catch [~tmueller].. Yes, virtual row check

[jira] [Commented] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712915#comment-14712915 ] Julian Reschke commented on OAK-3288: - If we wanted to change the signature for set()

[jira] [Comment Edited] (OAK-3230) Query engine should support virtual index rows

[ https://issues.apache.org/jira/browse/OAK-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712926#comment-14712926 ] Vikas Saurabh edited comment on OAK-3230 at 8/26/15 10:44 AM: --

[jira] [Assigned] (OAK-3153) Make it possible to disable recording of stack trace in SessionStats

[ https://issues.apache.org/jira/browse/OAK-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-3153: --- Assignee: Thomas Mueller Make it possible to disable recording of stack trace in SessionStats

[jira] [Updated] (OAK-3153) Make it possible to disable recording of stack trace in SessionStats

[ https://issues.apache.org/jira/browse/OAK-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-3153: Fix Version/s: 1.3.5 Make it possible to disable recording of stack trace in SessionStats

[jira] [Comment Edited] (OAK-3238) fine tune clock-sync check vs lease-check settings

[ https://issues.apache.org/jira/browse/OAK-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713054#comment-14713054 ] Stefan Egli edited comment on OAK-3238 at 8/26/15 12:48 PM:

[jira] [Commented] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712969#comment-14712969 ] Marcel Reutegger commented on OAK-3288: --- bq. I also see a case where a Map is set

[jira] [Commented] (OAK-2849) Improve revision gc on SegmentMK

[ https://issues.apache.org/jira/browse/OAK-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713041#comment-14713041 ] Alex Parvulescu commented on OAK-2849: -- fyi I tweaked the nodestore init bits with

[jira] [Commented] (OAK-3230) Query engine should support virtual index rows

[ https://issues.apache.org/jira/browse/OAK-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712926#comment-14712926 ] Vikas Saurabh commented on OAK-3230: I'm not sure of the version change part. Would that

[jira] [Updated] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-3288: Attachment: (was: OAK-3288.diff) clarify DocumentStore contract with respect to number formats

[jira] [Updated] (OAK-3079) LastRevRecoveryAgent can update _lastRev of children but not the root

[ https://issues.apache.org/jira/browse/OAK-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-3079: -- Affects Version/s: 1.2 LastRevRecoveryAgent can update _lastRev of children but not the root

[jira] [Commented] (OAK-3294) Read-only live FileStore implementation

[ https://issues.apache.org/jira/browse/OAK-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713045#comment-14713045 ] Francesco Mari commented on OAK-3294: - [~alex.parvulescu], the patch looks good to me. I

[jira] [Resolved] (OAK-3238) fine tune clock-sync check vs lease-check settings

[ https://issues.apache.org/jira/browse/OAK-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-3238. -- Resolution: Fixed Changed the lease behavior as follows (http://svn.apache.org/r1697913): * update is

[jira] [Resolved] (OAK-3153) Make it possible to disable recording of stack trace in SessionStats

[ https://issues.apache.org/jira/browse/OAK-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-3153. - Resolution: Fixed Make it possible to disable recording of stack trace in SessionStats

[jira] [Resolved] (OAK-3230) Query engine should support virtual index rows

[ https://issues.apache.org/jira/browse/OAK-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-3230. - Resolution: Fixed Query engine should support virtual index rows

[jira] [Commented] (OAK-3230) Query engine should support virtual index rows

[ https://issues.apache.org/jira/browse/OAK-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713009#comment-14713009 ] Thomas Mueller commented on OAK-3230: - http://svn.apache.org/r1697896 Query engine

[jira] [Commented] (OAK-3153) Make it possible to disable recording of stack trace in SessionStats

[ https://issues.apache.org/jira/browse/OAK-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713063#comment-14713063 ] Thomas Mueller commented on OAK-3153: - http://svn.apache.org/r1697915 Thanks a lot for

[jira] [Updated] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-3288: Attachment: OAK-3288.diff Proposed change with API unchanged, but javadoc pointing out restrictions.

[jira] [Updated] (OAK-2714) Test failures on Jenkins

[ https://issues.apache.org/jira/browse/OAK-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig updated OAK-2714: --- Description: This issue is for tracking test failures seen at our Jenkins instance that might yet be

[jira] [Updated] (OAK-2714) Test failures on Jenkins

[ https://issues.apache.org/jira/browse/OAK-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig updated OAK-2714: --- Description: This issue is for tracking test failures seen at our Jenkins instance that might yet be

[jira] [Commented] (OAK-3230) Query engine should support virtual index rows

[ https://issues.apache.org/jira/browse/OAK-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712966#comment-14712966 ] Thomas Mueller commented on OAK-3230: - I'm not sure of the version change part. Would

[jira] [Created] (OAK-3299) SNFE in SegmentOverflowExceptionIT

Michael Dürig created OAK-3299: -- Summary: SNFE in SegmentOverflowExceptionIT Key: OAK-3299 URL: https://issues.apache.org/jira/browse/OAK-3299 Project: Jackrabbit Oak Issue Type: Improvement

[jira] [Resolved] (OAK-3299) SNFE in SegmentOverflowExceptionIT

[ https://issues.apache.org/jira/browse/OAK-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig resolved OAK-3299. Resolution: Fixed Fixed at http://svn.apache.org/r1697891 SNFE in SegmentOverflowExceptionIT

[jira] [Commented] (OAK-3294) Read-only live FileStore implementation

[ https://issues.apache.org/jira/browse/OAK-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713049#comment-14713049 ] Michael Dürig commented on OAK-3294: Looks good AFAICS. I don't like all the

[jira] [Updated] (OAK-2679) Query engine: cache execution plans

[ https://issues.apache.org/jira/browse/OAK-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Richard updated OAK-2679: -- Attachment: (was: 0001-OAK-2679-Reduce-execution-plan-overhead.patch) Query engine: cache execution

[jira] [Updated] (OAK-3300) Include parameter descriptions in test output when running parameterised tests

[ https://issues.apache.org/jira/browse/OAK-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated OAK-3300: - Attachment: OAK-3300.png Include parameter descriptions in test output when running parameterised

[jira] [Commented] (OAK-3156) Lucene suggestions index definition can't be restricted to a specific type of node

[ https://issues.apache.org/jira/browse/OAK-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713077#comment-14713077 ] Vikas Saurabh commented on OAK-3156: Now that OAK-3230 has been resolved,

[jira] [Commented] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713401#comment-14713401 ] Stefan Egli commented on OAK-3288: -- PS: until OAK-3288 is there I had to do an ugly

[jira] [Commented] (OAK-3300) Include parameter descriptions in test output when running parameterised tests

[ https://issues.apache.org/jira/browse/OAK-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713489#comment-14713489 ] Robert Munteanu commented on OAK-3300: -- Attached [trivial

[jira] [Updated] (OAK-2881) ConsistencyChecker#checkConsistency can't cope with inconsistent journal

[ https://issues.apache.org/jira/browse/OAK-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig updated OAK-2881: --- Fix Version/s: (was: 1.3.5) 1.3.6 ConsistencyChecker#checkConsistency can't

[jira] [Created] (OAK-3300) Include parameter descriptions in test output when running parameterised tests

Robert Munteanu created OAK-3300: Summary: Include parameter descriptions in test output when running parameterised tests Key: OAK-3300 URL: https://issues.apache.org/jira/browse/OAK-3300 Project:

[jira] [Updated] (OAK-3300) Include parameter descriptions in test output when running parameterised tests

[ https://issues.apache.org/jira/browse/OAK-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated OAK-3300: - Attachment: 0001-OAK-3300-Include-parameter-descriptions-in-test-outp.patch Include parameter

[jira] [Commented] (OAK-3235) Deadlock when closing a concurrently used FileStore

[ https://issues.apache.org/jira/browse/OAK-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713628#comment-14713628 ] Michael Dürig commented on OAK-3235: Unfortunately the fix for the deadlock seems to

[jira] [Commented] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713635#comment-14713635 ] Julian Reschke commented on OAK-3288: - [~egli]? clarify DocumentStore contract with

[jira] [Updated] (OAK-3235) Deadlock when closing a concurrently used FileStore

[ https://issues.apache.org/jira/browse/OAK-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig updated OAK-3235: --- Labels: resilience (was: ) Deadlock when closing a concurrently used FileStore

[jira] [Created] (OAK-3301) AbstractRepositoryUpgrade leaks Repository instances

Robert Munteanu created OAK-3301: Summary: AbstractRepositoryUpgrade leaks Repository instances Key: OAK-3301 URL: https://issues.apache.org/jira/browse/OAK-3301 Project: Jackrabbit Oak

[jira] [Updated] (OAK-3300) Include parameter descriptions in test output when running parameterised tests

[ https://issues.apache.org/jira/browse/OAK-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated OAK-3300: - Flags: Patch Include parameter descriptions in test output when running parameterised tests

[jira] [Commented] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713657#comment-14713657 ] Stefan Egli commented on OAK-3288: -- could do indeed yes - let's see what the outcome of

[jira] [Commented] (OAK-3292) DocumentDiscoveryLiteServiceTest failures on travis and jenkins

[ https://issues.apache.org/jira/browse/OAK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713619#comment-14713619 ] Stefan Egli commented on OAK-3292: -- note that commit http://svn.apache.org/r1697952 belongs

[jira] [Resolved] (OAK-3267) Add discovery-lite descriptor for segmentNodeStore

[ https://issues.apache.org/jira/browse/OAK-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-3267. -- Resolution: Fixed done * svn commit msg contains wrong ticket nr - commit is:

[jira] [Commented] (OAK-3235) Deadlock when closing a concurrently used FileStore

[ https://issues.apache.org/jira/browse/OAK-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713634#comment-14713634 ] Michael Dürig commented on OAK-3235: Reverted http://svn.apache.org/r1697368 at

[jira] [Commented] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713633#comment-14713633 ] Julian Reschke commented on OAK-3288: - You could treat them both as java.lang.Number

[jira] [Updated] (OAK-3235) Deadlock when closing a concurrently used FileStore

[ https://issues.apache.org/jira/browse/OAK-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig updated OAK-3235: --- Fix Version/s: (was: 1.3.5) 1.3.6 Deadlock when closing a concurrently used

[jira] [Commented] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713648#comment-14713648 ] Stefan Egli commented on OAK-3288: -- are you referring to

[jira] [Updated] (OAK-3301) AbstractRepositoryUpgrade leaks Repository instances

[ https://issues.apache.org/jira/browse/OAK-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated OAK-3301: - Attachment: 0001-OAK-3301-AbstractRepositoryUpgrade-leaks-Repository-.patch Attached patch

[jira] [Updated] (OAK-3301) AbstractRepositoryUpgrade leaks Repository instances

[ https://issues.apache.org/jira/browse/OAK-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated OAK-3301: - Flags: Patch AbstractRepositoryUpgrade leaks Repository instances

[jira] [Commented] (OAK-3288) clarify DocumentStore contract with respect to number formats

[ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14714179#comment-14714179 ] Julian Reschke commented on OAK-3288: - [~mreutegg] so if we want to restrict the types