[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744991#comment-14744991
]
Marcel Reutegger commented on OAK-3390:
---
This issue is specifically about the instanceof check in
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743614#comment-14743614
]
Julian Reschke commented on OAK-3390:
-
Hmmm.
1) This doesn't remove the "instanceof", it just moves it
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743049#comment-14743049
]
Stefan Egli commented on OAK-3390:
--
my take on doing a generic {{Adaptable}} is that that makes sense in a
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743062#comment-14743062
]
Julian Reschke commented on OAK-3390:
-
More breakage in a different place:
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743056#comment-14743056
]
Julian Reschke commented on OAK-3390:
-
If that was true, why do we have the current breakage then? :-)
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743057#comment-14743057
]
Marcel Reutegger commented on OAK-3390:
---
I agree with Stefan. We are talking about as single
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740701#comment-14740701
]
Julian Reschke commented on OAK-3390:
-
[~mreutegg] note that the changes for OAK-3313 now cause
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738798#comment-14738798
]
Stefan Egli commented on OAK-3390:
--
or .. we could also demand DocumentStore to provide an adapter for the
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738814#comment-14738814
]
Julian Reschke commented on OAK-3390:
-
I think we shouldn't conflate the two issues. 1) is making the DS
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738803#comment-14738803
]
Marcel Reutegger commented on OAK-3390:
---
I would rather move this kind of factory method into the
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738782#comment-14738782
]
Stefan Egli commented on OAK-3390:
--
What about introducing {{DocumentStore.unwrap()}} which would provide
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738787#comment-14738787
]
Julian Reschke commented on OAK-3390:
-
Recommendation: borrow from both
[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738974#comment-14738974
]
Julian Reschke commented on OAK-3390:
-
Proposed interface:
{code}
/*
* Licensed to the Apache Software
13 matches
Mail list logo
