[jira] [Updated] (OAK-4579) Improve FileStore.size calculation

2016-08-01 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4579: - Attachment: OAK-4579-01.patch There were some issues regarding step 2 with three test classes which

[jira] [Comment Edited] (OAK-4579) Improve FileStore.size calculation

2016-08-01 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401954#comment-15401954 ] Andrei Dulceanu edited comment on OAK-4579 at 8/1/16 1:28 PM: -- There were some

[jira] [Updated] (OAK-4579) Improve FileStore.size calculation

2016-08-01 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4579: - Description: A new approach for calculating {{FileStore::size}} is needed because this method is

[jira] [Updated] (OAK-4579) Improve FileStore.size calculation

2016-08-01 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4579: - Attachment: OAK-4579-01.patch > Improve FileStore.size calculation >

[jira] [Updated] (OAK-4579) Improve FileStore.size calculation

2016-08-01 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4579: - Attachment: (was: OAK-4579-01.patch) > Improve FileStore.size calculation >

[jira] [Updated] (OAK-4097) Add metric for FileStore journal writes

2016-08-02 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4097: - Attachment: OAK-4097-01.patch [~mduerig]/[~chetanm] Could you take a look at the patch submitted?

[jira] [Created] (OAK-4667) Create IT to validate that reclaimed size after cleanup is always positive

2016-08-11 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-4667: Summary: Create IT to validate that reclaimed size after cleanup is always positive Key: OAK-4667 URL: https://issues.apache.org/jira/browse/OAK-4667 Project:

[jira] [Comment Edited] (OAK-4657) Add metric for FileStore cleanup reclaimed size

2016-08-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416875#comment-15416875 ] Andrei Dulceanu edited comment on OAK-4657 at 8/11/16 12:15 PM: Another

[jira] [Updated] (OAK-4657) Add metric for FileStore cleanup reclaimed size

2016-08-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4657: - Attachment: OAK-4657-03.patch Per [~alexparvulescu]'s suggestion I decided to move the test in

[jira] [Updated] (OAK-4657) Add metric for FileStore cleanup reclaimed size

2016-08-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4657: - Attachment: OAK-4657-02.patch > Add metric for FileStore cleanup reclaimed size >

[jira] [Updated] (OAK-4657) Add metric for FileStore cleanup reclaimed size

2016-08-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4657: - Attachment: (was: OAK-4657.patch) > Add metric for FileStore cleanup reclaimed size >

[jira] [Commented] (OAK-4667) Create IT to validate that reclaimed size after cleanup is always positive

2016-08-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417408#comment-15417408 ] Andrei Dulceanu commented on OAK-4667: -- While taking a look at the patch above [~alexparvulescu]

[jira] [Updated] (OAK-4667) Create IT to validate that reclaimed size after cleanup is always positive

2016-08-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4667: - Description: As OAK-4106 reworked the way {{reclaimedSize}} is computed, it would be nice to have

[jira] [Updated] (OAK-4667) Create IT to validate that reclaimed size after cleanup is always positive

2016-08-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4667: - Attachment: OAK-4667-01.patch Attaching a first draft of the test which is currently incorrectly

[jira] [Comment Edited] (OAK-4667) Create IT to validate that reclaimed size after cleanup is always positive

2016-08-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417399#comment-15417399 ] Andrei Dulceanu edited comment on OAK-4667 at 8/11/16 3:17 PM: --- Attaching a

[jira] [Created] (OAK-4657) Add metric for FileStore cleanup reclaimed size

2016-08-10 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-4657: Summary: Add metric for FileStore cleanup reclaimed size Key: OAK-4657 URL: https://issues.apache.org/jira/browse/OAK-4657 Project: Jackrabbit Oak Issue

[jira] [Commented] (OAK-4106) Reclaimed size reported by FileStore.cleanup is off

2016-08-03 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406016#comment-15406016 ] Andrei Dulceanu commented on OAK-4106: -- [~mduerig] Sure! Just wanted to ask you how did you reproduce

[jira] [Created] (OAK-4648) Improve documentation about structure of TAR files

2016-08-04 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-4648: Summary: Improve documentation about structure of TAR files Key: OAK-4648 URL: https://issues.apache.org/jira/browse/OAK-4648 Project: Jackrabbit Oak Issue

[jira] [Updated] (OAK-4669) Cleanup creates new generation of tar file without removing any segments

2016-08-12 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4669: - Attachment: test case.patch Attached a simple test case to validate the hypothesis in the

[jira] [Commented] (OAK-4667) Create IT to validate that reclaimed size after cleanup is always positive

2016-08-12 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418791#comment-15418791 ] Andrei Dulceanu commented on OAK-4667: -- Created OAK-4669 to track this. > Create IT to validate that

[jira] [Updated] (OAK-4669) Cleanup creates new generation of tar file without removing any segments

2016-08-12 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4669: - Description: On some deployments I have seen tar files with a quite hight generation post-fix

[jira] [Created] (OAK-4669) Cleanup creates new generation of tar file without removing any segments

2016-08-12 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-4669: Summary: Cleanup creates new generation of tar file without removing any segments Key: OAK-4669 URL: https://issues.apache.org/jira/browse/OAK-4669 Project:

[jira] [Comment Edited] (OAK-4106) Reclaimed size reported by FileStore.cleanup is off

2016-08-10 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414858#comment-15414858 ] Andrei Dulceanu edited comment on OAK-4106 at 8/10/16 7:37 AM: --- I changed the

[jira] [Updated] (OAK-4106) Reclaimed size reported by FileStore.cleanup is off

2016-08-10 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4106: - Attachment: OAK-4106-01.patch I changed the way {{reclaimedSize}} is computed. Now it accounts only

[jira] [Updated] (OAK-4657) Add metric for FileStore cleanup reclaimed size

2016-08-10 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4657: - Attachment: OAK-4657-01.patch Exposed {{reclaimedSize}} from {{FileStore.cleanup()}} through

[jira] [Updated] (OAK-4657) Add metric for FileStore cleanup reclaimed size

2016-08-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4657: - Attachment: OAK-4657.patch I reworked the patch to use {{GCMonitorBean}} instead of

[jira] [Commented] (OAK-4657) Add metric for FileStore cleanup reclaimed size

2016-08-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416875#comment-15416875 ] Andrei Dulceanu commented on OAK-4657: -- Another important thing: the previous implementation of

[jira] [Comment Edited] (OAK-4657) Add metric for FileStore cleanup reclaimed size

2016-08-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416738#comment-15416738 ] Andrei Dulceanu edited comment on OAK-4657 at 8/11/16 8:36 AM: --- I reworked the

[jira] [Comment Edited] (OAK-4657) Add metric for FileStore cleanup reclaimed size

2016-08-10 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414890#comment-15414890 ] Andrei Dulceanu edited comment on OAK-4657 at 8/10/16 8:16 AM: --- Exposed

[jira] [Commented] (OAK-4122) Replace the commit semaphore in the segment node store with a scheduler

2016-08-10 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414950#comment-15414950 ] Andrei Dulceanu commented on OAK-4122: -- [~mduerig], [~frm] I would like to work on this issue. Can you

[jira] [Commented] (OAK-4106) Reclaimed size reported by FileStore.cleanup is off

2016-08-10 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415007#comment-15415007 ] Andrei Dulceanu commented on OAK-4106: -- [~mduerig] Everything ok from my side. One improvement which

[jira] [Updated] (OAK-4105) Implement FileStore.size through FileStore.approximateSize

2016-07-15 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4105: - Attachment: OAK-4105-01.patch I changed the {{FileStore.size()}} implementation to use

[jira] [Assigned] (OAK-4097) Add metric for FileStore journal writes

2016-07-15 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu reassigned OAK-4097: Assignee: Andrei Dulceanu (was: Chetan Mehrotra) > Add metric for FileStore journal writes

[jira] [Commented] (OAK-4105) Implement FileStore.size through FileStore.approximateSize

2016-07-18 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382379#comment-15382379 ] Andrei Dulceanu commented on OAK-4105: -- [~mduerig] I guess you are right regarding the incorrect

[jira] [Comment Edited] (OAK-4097) Add metric for FileStore journal writes

2016-07-19 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383749#comment-15383749 ] Andrei Dulceanu edited comment on OAK-4097 at 7/19/16 7:58 AM: --- I'd like some

[jira] [Updated] (OAK-4105) Implement FileStore.size through FileStore.approximateSize

2016-07-19 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4105: - Attachment: OAK-4105-02.patch [~mduerig] I reworked the patch so that during

[jira] [Commented] (OAK-4105) Implement FileStore.size through FileStore.approximateSize

2016-07-20 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385662#comment-15385662 ] Andrei Dulceanu commented on OAK-4105: -- As an alternate solution, we might think about why this line

[jira] [Created] (OAK-4579) Improve FileStore.size calculation

2016-07-20 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-4579: Summary: Improve FileStore.size calculation Key: OAK-4579 URL: https://issues.apache.org/jira/browse/OAK-4579 Project: Jackrabbit Oak Issue Type: Task

[jira] [Commented] (OAK-4105) Implement FileStore.size through FileStore.approximateSize

2016-07-20 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385947#comment-15385947 ] Andrei Dulceanu commented on OAK-4105: -- [~mduerig] I created

[jira] [Commented] (OAK-4103) Replace journal.log with an in place journal

2016-07-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370618#comment-15370618 ] Andrei Dulceanu commented on OAK-4103: -- [~frm] I'd like to work on this issue. Can you please assign it

[jira] [Commented] (OAK-4105) Implement FileStore.size through FileStore.approximateSize

2016-07-11 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370614#comment-15370614 ] Andrei Dulceanu commented on OAK-4105: -- [~frm] I'd like to work on this issue. Can you please assign it

[jira] [Commented] (OAK-4097) Add metric for FileStore journal writes

2016-08-05 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409349#comment-15409349 ] Andrei Dulceanu commented on OAK-4097: -- [~chetanm] Sure, I will think about/create a test and attach it

[jira] [Updated] (OAK-4097) Add metric for FileStore journal writes

2016-08-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4097: - Attachment: OAK-4097-02.patch Actually I found out a bug in my previous implementation which showed

[jira] [Comment Edited] (OAK-4097) Add metric for FileStore journal writes

2016-08-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411904#comment-15411904 ] Andrei Dulceanu edited comment on OAK-4097 at 8/8/16 2:45 PM: -- Actually I found

[jira] [Comment Edited] (OAK-4097) Add metric for FileStore journal writes

2016-08-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411904#comment-15411904 ] Andrei Dulceanu edited comment on OAK-4097 at 8/8/16 2:46 PM: -- Actually I found

[jira] [Commented] (OAK-4106) Reclaimed size reported by FileStore.cleanup is off

2016-08-09 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413125#comment-15413125 ] Andrei Dulceanu commented on OAK-4106: -- So in other words we are interested in the real reclaimedSize,

[jira] [Updated] (OAK-4097) Add metric for FileStore journal writes

2016-08-09 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4097: - Attachment: OAK-4097-03.patch [~mduerig] I followed your advice regarding manually calling

[jira] [Commented] (OAK-4106) Reclaimed size reported by FileStore.cleanup is off

2016-08-09 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413525#comment-15413525 ] Andrei Dulceanu commented on OAK-4106: -- I might have a working solution for this and I am now trying to

[jira] [Commented] (OAK-4106) Reclaimed size reported by FileStore.cleanup is off

2016-08-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411752#comment-15411752 ] Andrei Dulceanu commented on OAK-4106: -- [~mduerig] After reviewing FileStore.cleanup(), with the

[jira] [Updated] (OAK-4669) Cleanup creates new generation of tar file without removing any segments

2016-08-16 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4669: - Attachment: OAK-4669-01.patch [~mduerig], I followed your advice and changed the way the decision

[jira] [Updated] (OAK-4667) Create IT to validate that reclaimed size after cleanup is always positive

2016-08-17 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4667: - Attachment: OAK-4667-02.patch I've just attached a new version of the patch. Since working on this

[jira] [Comment Edited] (OAK-4667) Create IT to validate that reclaimed size after cleanup is always positive

2016-08-17 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424551#comment-15424551 ] Andrei Dulceanu edited comment on OAK-4667 at 8/17/16 1:54 PM: --- I've just

[jira] [Commented] (OAK-4138) Decouple revision cleanup from the flush thread

2016-08-18 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426519#comment-15426519 ] Andrei Dulceanu commented on OAK-4138: -- Not sure I understood the comment inside {{FileStore.flush}}:

[jira] [Assigned] (OAK-5556) Allow filter paths for Check command

2017-02-02 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu reassigned OAK-5556: Assignee: Andrei Dulceanu > Allow filter paths for Check command >

[jira] [Assigned] (OAK-5277) The check command defines a useless default value for the "bin" option

2017-02-02 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu reassigned OAK-5277: Assignee: Andrei Dulceanu (was: Francesco Mari) > The check command defines a useless

[jira] [Updated] (OAK-5275) The check command should accept the path to the store as a positional argument

2017-02-02 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5275: - Attachment: OAK-5275.patch [~frm], , could you take a look at the patch attached? > The check

[jira] [Commented] (OAK-5547) Document TarMK design

2017-02-01 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848222#comment-15848222 ] Andrei Dulceanu commented on OAK-5547: -- [~mduerig] Looks good to me. The only thing I could find was

[jira] [Commented] (OAK-5547) Document TarMK design

2017-02-01 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848385#comment-15848385 ] Andrei Dulceanu commented on OAK-5547: -- [~frm] I've just finished updating it :). Does it make sense to

[jira] [Updated] (OAK-5276) The check command overloads the meaning of the "deep" option

2017-02-01 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5276: - Attachment: OAK-5276.patch [~frm], could you take a look at the patch attached? > The check

[jira] [Commented] (OAK-5547) Document TarMK design

2017-02-01 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848408#comment-15848408 ] Andrei Dulceanu commented on OAK-5547: -- I committed the updated data segments header description at

[jira] [Assigned] (OAK-5275) The check command should accept the path to the store as a positional argument

2017-02-01 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu reassigned OAK-5275: Assignee: Andrei Dulceanu (was: Francesco Mari) > The check command should accept the path

[jira] [Commented] (OAK-4648) Improve documentation about structure of TAR files

2017-02-01 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848448#comment-15848448 ] Andrei Dulceanu commented on OAK-4648: -- I agree, let's close it. > Improve documentation about

[jira] [Created] (OAK-5590) The check command doesn't do any check when "deep" option is not provided

2017-02-06 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-5590: Summary: The check command doesn't do any check when "deep" option is not provided Key: OAK-5590 URL: https://issues.apache.org/jira/browse/OAK-5590 Project:

[jira] [Updated] (OAK-5590) The check command doesn't do any check when "deep" option is not provided

2017-02-06 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5590: - Attachment: OAK-5590.patch [~frm] I inverted a little bit your logic, in the sense that the

[jira] [Commented] (OAK-5595) The check command should do deep traversals by default

2017-02-07 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855800#comment-15855800 ] Andrei Dulceanu commented on OAK-5595: -- [~mduerig], should this change apply also to {{oak-segment}}?

[jira] [Updated] (OAK-5595) The check command should do deep traversals by default

2017-02-07 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5595: - Attachment: OAK-5595.patch Since deep traversals are enabled by default, there was some room for

[jira] [Updated] (OAK-5604) The check command should accept a non-argument "bin" option for checking binaries

2017-02-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5604: - Fix Version/s: 1.6.1 1.8 > The check command should accept a non-argument "bin"

[jira] [Created] (OAK-5604) The check command should accept a non-argument "bin" option for checking binaries

2017-02-08 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-5604: Summary: The check command should accept a non-argument "bin" option for checking binaries Key: OAK-5604 URL: https://issues.apache.org/jira/browse/OAK-5604 Project:

[jira] [Updated] (OAK-5604) The check command should accept a non-argument "bin" option for checking binaries

2017-02-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5604: - Attachment: OAK-5604.patch I decided that adding an additional warning when using {{--bin LENGTH}}

[jira] [Commented] (OAK-5604) The check command should accept a non-argument "bin" option for checking binaries

2017-02-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858191#comment-15858191 ] Andrei Dulceanu commented on OAK-5604: -- [~frm], thanks for reviewing! Regarding your comments, they

[jira] [Updated] (OAK-5604) The check command should accept a non-argument "bin" option for checking binaries

2017-02-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5604: - Description: Currently the {{--bin}} option expects a {{Long}} argument, as the {{LENGTH}} up to

[jira] [Resolved] (OAK-5276) The check command overloads the meaning of the "deep" option

2017-02-02 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu resolved OAK-5276. -- Resolution: Fixed Committed a slightly modified version of the initial patch at r1781379. Fixed

[jira] [Resolved] (OAK-5275) The check command should accept the path to the store as a positional argument

2017-02-02 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu resolved OAK-5275. -- Resolution: Fixed Fixed at r1781382. [~frm], thanks for reviewing! > The check command should

[jira] [Updated] (OAK-5277) The check command defines a useless default value for the "bin" option

2017-02-02 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5277: - Attachment: OAK-5277.patch [~frm], could you take a look at the patch attached? > The check

[jira] [Updated] (OAK-5277) The check command defines a useless default value for the "bin" option

2017-02-02 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5277: - Attachment: OAK-5277-02.patch [~frm], thanks for clarifying! I attached a new version of the

[jira] [Commented] (OAK-5590) The check command doesn't do any check when "deep" option is not provided

2017-02-06 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854203#comment-15854203 ] Andrei Dulceanu commented on OAK-5590: -- bq. AFAIKS this would trigger a full traversal Not necessarily,

[jira] [Commented] (OAK-5590) The check command doesn't do any check when "deep" option is not provided

2017-02-06 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854151#comment-15854151 ] Andrei Dulceanu commented on OAK-5590: -- [~mduerig] re. first bullet point, this change is tracked in

[jira] [Comment Edited] (OAK-5590) The check command doesn't do any check when "deep" option is not provided

2017-02-06 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854203#comment-15854203 ] Andrei Dulceanu edited comment on OAK-5590 at 2/6/17 3:23 PM: -- bq. AFAIKS this

[jira] [Updated] (OAK-5595) The check command should do deep traversals by default

2017-02-06 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5595: - Description: Only checking accessibility of the root nodes doesn't make much sense. Even more so

[jira] [Created] (OAK-5595) The check command should do deep traversals by default

2017-02-06 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-5595: Summary: The check command should do deep traversals by default Key: OAK-5595 URL: https://issues.apache.org/jira/browse/OAK-5595 Project: Jackrabbit Oak

[jira] [Commented] (OAK-5590) The check command doesn't do any check when "deep" option is not provided

2017-02-06 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854272#comment-15854272 ] Andrei Dulceanu commented on OAK-5590: -- Please disregard the comment above. After discussing about this

[jira] [Created] (OAK-5600) Test coverage for CheckCommand

2017-02-08 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-5600: Summary: Test coverage for CheckCommand Key: OAK-5600 URL: https://issues.apache.org/jira/browse/OAK-5600 Project: Jackrabbit Oak Issue Type: Task

[jira] [Updated] (OAK-5556) Allow filter paths for Check command

2017-02-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5556: - Description: It would be good if the {{check}} command would allow for filtering on content path.

[jira] [Updated] (OAK-5595) The check command should do deep traversals by default

2017-02-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5595: - Attachment: OAK-5595-02.patch Attaching a new patch with a simpler fix, without the refactoring

[jira] [Resolved] (OAK-5595) The check command should do deep traversals by default

2017-02-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu resolved OAK-5595. -- Resolution: Fixed Removed the orphaned variable and fixed at r1782137. > The check command

[jira] [Resolved] (OAK-5590) The check command doesn't do any check when "deep" option is not provided

2017-02-08 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu resolved OAK-5590. -- Resolution: Not A Problem No longer applies once OAK-5595 enabled deep traversals by default. >

[jira] [Resolved] (OAK-5277) The check command defines a useless default value for the "bin" option

2017-02-03 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu resolved OAK-5277. -- Resolution: Fixed Fixed at r1781520. > The check command defines a useless default value for the

[jira] [Created] (OAK-5514) Standby Automatic Cleanup should be on by default

2017-01-25 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-5514: Summary: Standby Automatic Cleanup should be on by default Key: OAK-5514 URL: https://issues.apache.org/jira/browse/OAK-5514 Project: Jackrabbit Oak Issue

[jira] [Updated] (OAK-5514) Standby Automatic Cleanup should be on by default

2017-01-25 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5514: - Description: The OSGi setting controlling standby automatic cleanup, {{standby.autoclean}}, should

[jira] [Updated] (OAK-5514) Standby Automatic Cleanup should be on by default

2017-01-25 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5514: - Fix Version/s: (was: 1.6) 1.8 > Standby Automatic Cleanup should be on by

[jira] [Created] (OAK-5497) Inverted logic for ignoring/reporting SNFE

2017-01-20 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-5497: Summary: Inverted logic for ignoring/reporting SNFE Key: OAK-5497 URL: https://issues.apache.org/jira/browse/OAK-5497 Project: Jackrabbit Oak Issue Type:

[jira] [Updated] (OAK-5497) Inverted logic for ignoring/reporting SNFE

2017-01-20 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-5497: - Attachment: OAK-5497.patch Attached patch fixing this behaviour. [~frm], can you please take a look

[jira] [Updated] (OAK-4648) Improve documentation about structure of TAR files

2017-01-27 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu updated OAK-4648: - Attachment: OAK-4648.patch [~frm], I attached a first draft. Among changes covered: * included a

[jira] [Comment Edited] (OAK-4648) Improve documentation about structure of TAR files

2017-01-27 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842625#comment-15842625 ] Andrei Dulceanu edited comment on OAK-4648 at 1/27/17 12:06 PM: [~frm], I

[jira] [Commented] (OAK-4648) Improve documentation about structure of TAR files

2017-01-27 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842710#comment-15842710 ] Andrei Dulceanu commented on OAK-4648: -- Committed at r1780547. I will wait for your feedback before

[jira] [Commented] (OAK-5600) Test coverage for CheckCommand

2017-02-22 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878033#comment-15878033 ] Andrei Dulceanu commented on OAK-5600: -- Committed the latest patch at r1784012. [~mduerig], thanks for

[jira] [Created] (OAK-5753) Consistency check incorrectly fails for broken partial paths

2017-02-22 Thread Andrei Dulceanu (JIRA)
Andrei Dulceanu created OAK-5753: Summary: Consistency check incorrectly fails for broken partial paths Key: OAK-5753 URL: https://issues.apache.org/jira/browse/OAK-5753 Project: Jackrabbit Oak

[jira] [Commented] (OAK-5753) Consistency check incorrectly fails for broken partial paths

2017-02-22 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877889#comment-15877889 ] Andrei Dulceanu commented on OAK-5753: -- One way to handle this is to adopt the same strategy as

[jira] [Commented] (OAK-5792) TarMK: Implement tooling to repair broken nodes

2017-02-24 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882298#comment-15882298 ] Andrei Dulceanu commented on OAK-5792: -- I was thinking about the same functionality while working on

[jira] [Comment Edited] (OAK-5753) Consistency check incorrectly fails for broken partial paths

2017-02-24 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882552#comment-15882552 ] Andrei Dulceanu edited comment on OAK-5753 at 2/24/17 12:25 PM: bq. Would it

  1   2   3   4   5   6   7   8   9   >