From: Coly Li co...@suse.de
Mainline commit 73ac36ea14fd18ea3dc057e41b16ff31a3c0bd5a
When I review ocfs2 code, find there are 2 typos to successfull. After
doing grep successfull in kernel tree, 22 typos found totally -- great
minds always think alike :)
This patch fixes all the similar
, the ocfs2 dlmglue layer serializes the dlm op for each
lockid.
Users encountering this bug will see flock() return EINVAL and dmesg have the
following error:
ERROR: Dlm error DLM_BADARGS while calling dlmlock on resource LOCKID: bad
api args
Reported-by: Coly Li co...@suse.de
Signed-off-by: Sunil Mushran
-by: Sunil Mushran sunil.mush...@oracle.com
Signed-off-by: Mark Fasheh mfas...@suse.com
---
fs/ocfs2/dlm/dlmthread.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c
index 4060bb3..d129520 100644
--- a/fs/ocfs2/dlm/dlmthread.c
that did not hold that lock. As the new lock only protects this list,
we can explicitly take it when removing the lockres from the tracking list.
This bug was exposed when testing multiple processes concurrently flock() the
same file.
Signed-off-by: Sunil Mushran sunil.mush...@oracle.com
Signed
From: Frederik Schwarzer schwarz...@gmail.com
Mainline commit 025dfdafe77f20b3890981a394774baab7b9c827
- (better, more, bigger ...) then - (...) than
Signed-off-by: Frederik Schwarzer schwarz...@gmail.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
---
fs/ocfs2/cluster/heartbeat.c |2 +-
1
Mainline commit 57dff2676eb68d805883a2204faaa5339ac44e03
Patch cleans printed errors in dlm_proxy_ast_handler(). The errors now includes
the node number that sent the (b)ast. Also it reduces the number of endian swaps
of the cookie.
Signed-off-by: Sunil Mushran sunil.mush...@oracle.com
Signed
From: Jan Kara j...@suse.cz
Mainline commit b99835c1684918b9975851d71455c5c007d1715b
We forgot to set i_nlink to 0 when returning due to error from
ocfs2_mknod_locked()
and thus inode was not properly released via ocfs2_delete_inode() (e.g. claimed
space was not released). Fix it.
Mark Fasheh wrote:
Sounds good. I left the last one '--no-backup-super' there and marked it
deprecated though. I figure it's best to keep it documented until we remove
it from mkfs.ocfs2 altogether.
ok.
Done, though I'm starting to wonder about us versioning the features like
that. A lot of
Why not one statistics debugfs file where we can keep adding all the
stats?
Joel Becker wrote:
It would be nice to know how often we get checksum failures. Even
better, how many of them we can fix with the single bit ecc. So, we add
a statistics structure. The structure can be installed
aah... sob.
Tao Ma wrote:
Signed-off-by: Tao Ma tao...@oracle.com
Mark Fasheh wrote:
On Fri, Dec 26, 2008 at 02:24:27PM -0800, Mark Fasheh wrote:
Kernels since 2.6.24 have supported this, I think it's time to make it a
default feature.
Signed-off-by: Mark Fasheh mfas...@suse.com
I thought Tao had sob-ed it.
On Dec 26, 2008, at 2:39 PM, Mark Fasheh mfas...@suse.com wrote:
Anyone get a chance to sob this? It's pretty much a copy of the fs
locks
patch...
--Mark
On Thu, Dec 04, 2008 at 10:14:50PM -0800, Mark Fasheh wrote:
This way we can review locking state
The inode arg comes by way of the struct file_operations' open() and
release()
function prototypes. On a typical file system, the inode points to the
entity
that that operation is for. In synthetic file systems, however, the
inode is at
times superfluous because the entity being worked could be
Mark Fasheh wrote:
A lot of the above seems a bit like overkill to me. Couldn't we just get
this stuff with 'mount' and 'debugfs.ocfs2'?
We could. However, this info is useful because it could be captured
automatically by oswatcher.
Also, I wonder if it's not a bad idea to split out the
Resending two debugfs patches that now make use of generic_file_llseek()
instead of the hand-rolled _llseek().
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
Patch creates a debugfs file, o2hb/livesnodes, which exposes the aggregate
list of heartbeating node across all heartbeat regions.
Signed-off-by: Sunil Mushran sunil.mush...@oracle.com
---
fs/ocfs2/cluster/heartbeat.c | 96 +++-
fs/ocfs2/cluster
Patches include o2hb and ocfs2 info exposure via debugfs and some
dlm fixes including the race in flock() discovered recently.
Sunil
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
Patch creates a per mount debugfs file, fs_state, which exposes information
like, cluster stack in use, states of the downconvert, recovery and commit
threads, number of journal txns, some allocation stats, list of all slots, etc.
Signed-off-by: Sunil Mushran sunil.mush...@oracle.com
---
fs
.
Signed-off-by: Sunil Mushran sunil.mush...@oracle.com
---
fs/ocfs2/dlm/dlmmaster.c | 23 +++
1 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
index 44f87ca..92fd1d7 100644
--- a/fs/ocfs2/dlm/dlmmaster.c
+++ b
During lockres purge, o2dlm sends a drop reference message to the lockres
master. This patch delays the message if the lockres is being migrated.
Fixes oss bugzilla#1012
http://oss.oracle.com/bugzilla/show_bug.cgi?id=1012
Signed-off-by: Sunil Mushran sunil.mush...@oracle.com
---
fs/ocfs2/dlm
Patch creates a debugfs file, o2hb/livesnodes, which exposes the aggregate
list of heartbeating node across all heartbeat regions.
Signed-off-by: Sunil Mushran sunil.mush...@oracle.com
---
fs/ocfs2/cluster/heartbeat.c | 140 +++-
fs/ocfs2/cluster
Mark Fasheh wrote:
On Tue, Dec 16, 2008 at 03:49:23PM -0800, Sunil Mushran wrote:
dlm_get_lock_resource() is supposed to return a lock resource with a proper
master. If multiple concurrent threads attempt to lookup the lockres for the
same lockid while the lock mastery in underway, one
Coly Li wrote:
Because I am not familiar with the code yet, I though this is an oops
triggered by my first
modification. Therefore, I choose to use a loop which did not trigger the
oops.
From your reply, it seems kernel BUG in __dlm_lockres_drop_inflight_ref at
dlmmaster.c:680 is
So these patches are against the ocfs2-1.4 tree. I am sending them as-is
as the bug has been filed against 1.4. Will email the patches for the
mainline kernel later.
Sunil
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/dlm/dlmmaster.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
index 4d493f4..6bda3ab 100644
--- a/fs/ocfs2/dlm/dlmmaster.c
+++ b/fs/ocfs2/dlm/dlmmaster.c
operations, dlmglue
should ensure that only one thread is performing dlm operations for a given
lockid at any one time.
Thank Sunil for his review and comments.
Signed-off-by: Coly Li [EMAIL PROTECTED]
Cc: Sunil Mushran [EMAIL PROTECTED]
Cc: Mark Fasheh [EMAIL PROTECTED]
Cc: Jeff Mahoney [EMAIL
So I have a new patch. It has debug code too. I am still testing this.
Don't upload it to bz.
--- a/fs/ocfs2/dlm/dlmmaster.c
+++ b/fs/ocfs2/dlm/dlmmaster.c
@@ -672,6 +672,12 @@ void __dlm_lockres_drop_inflight_ref(struct
dlm_ctxt *dlm,
{
assert_spin_locked(res-spinlock);
+ if
On second thoughts, I should elaborate further. I'll do so sometime
later today.
Sunil Mushran wrote:
Read the purge_lockres code, the only place where we set this flag.
Coly Li wrote:
Sunil Mushran Wrote:
No. dlm-spinlock prevents it racing the dlm_thread. Secondly, lookup
Coly Li wrote:
diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
index 44f87ca..c777844 100644
--- a/fs/ocfs2/dlm/dlmmaster.c
+++ b/fs/ocfs2/dlm/dlmmaster.c
@@ -742,6 +742,19 @@ lookup:
goto lookup;
}
+ /* tmpres might be
No. dlm-spinlock prevents it racing the dlm_thread. Secondly, lookup
also does a get.
What scenario are you envisioning?
Coly Li wrote:
Hi list,
When I read code of dlm_get_lock_resource(), there is something not clear to
me.
719 lookup:
720 spin_lock(dlm-spinlock);
721
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
Coly Li wrote:
In init_dlmfs_fs(), if calling kmem_cache_create() failed, the code will use
return value from
calling bdi_init(). The correct behavior should be set status as -ENOMEM
before going to bail:.
Signed-off-by: Coly Li [EMAIL
Yes, it is being integrated. It should be available for enterprise
users with sles11.
[EMAIL PROTECTED] wrote:
Dear All,
I have to introduce a cluster file system that is supported by Novell
SLES 10 and that supports ACLs. OCFS is a good candidate as it is
integrated in the standard Linux
Patch sets journal descriptor to NULL after the journal is shutdown.
This ensures that jbd2_journal_release_jbd_inode(), which removes the
jbd2 inode from txn lists, can be called safely from ocfs2_clear_inode()
even after the journal has been shutdown.
Signed-off-by: Sunil Mushran [EMAIL
Please review these patches. I want them in for 1.4.2.
http://oss.oracle.com/pipermail/ocfs2-tools-devel/2008-October/001318.html
http://oss.oracle.com/pipermail/ocfs2-tools-devel/2008-October/001319.html
http://oss.oracle.com/pipermail/ocfs2-tools-devel/2008-October/001320.html
Tao,
Please can you attach this to the bugzilla.
http://oss.oracle.com/bugzilla/show_bug.cgi?id=1019
Easier to track fixes.
Thanks
Sunil
Tao Ma wrote:
In ocfs2_page_mkwrite, we return -EINVAL when we found the page mapping
isn't updated, and it will cause the user space program get SIGBUS
Can you change configure such that it will fail to build unless user
explicitly specifies --disable-devmapper or something similar.
As in, I see no reason why we should not always build with it.
Sunil
Andrew Beekhof wrote:
Hi,
Jeff delegated the submission of this patch to me :-)
Andrew
NAK
There is no voting in ocfs2 1.4.
Secondly, i_nlink=0 does not mean inode is deleted. It simply
means it has no more links. So returning enoent for a valid
inode would be incorrect.
wangang wang wrote:
nlink should be also checked in ocfs2_inode_revalidate().
before setting flag
NAK.
I fail to understand your logic. The code you've added is pretty
much what d_prune_aliases() does (the call you have deleted).
wangang wang wrote:
In ocfs2_process_delete_request(), we should unhash all dentries on the inode.
--not only the ones with 0 referrence count. so that it's
NAK
Firstly ip_lock does not protect inode. Secondly, the field is
protected by inode_lock. Follow the code:
iput (inode_lock taken) = iput_final == ocfs2_drop_inode (inode_lock
still held).
void iput(struct inode *inode)
{
if (atomic_dec_and_lock(inode-i_count,
If so, won't that be a bug?
wengang wang wrote:
Sunil,
d_prune_aliases() unhashes dentries that has 0 reference count,
dentries with non-zero ref count won't be unhashed.
My code unhashes all no matter there reference counts are 0 or not.
regards,
wengang.
Sunil Mushran wrote:
NAK
The newline looks like a typo here.
@@ -1070,6 +1066,12 @@ journal_t * jbd2_journal_init_inode (struct inode
*inode)
+ sprintf(p, :%lu\n, journal-j_inode-i_ino);
Other than that, the test ran fine. Marcos successfully ran multiple
recoveries in a 6 node cluster.
Sunil Mushran wrote:
Thanks
OCFS2 1.2 and 1.4 are two different releases. If you want to
stay with 1.2., 1.2.9 would be the latest. With 1.4, 1.4.1 would be
the latest. We will continue to provide patch upgrades to both 1.2
and 1.4 in the short term. To learn more about 1.4, read the 1.4 user's
guide.
Sashi wrote:
All,
Moves the definition of struct ocfs2_slot_info from slot_map.c to ocfs2.h.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/ocfs2.h| 16 +++-
fs/ocfs2/slot_map.c | 17 -
2 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/fs/ocfs2/ocfs2
Patch creates a debugfs file, o2hb/livesnodes, which when read will expose
the aggregate list of heartbeating node across all heartbeat regions.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/cluster/heartbeat.c | 140 +++-
fs/ocfs2/cluster
Patch creates a per mount debugfs file, fs_state, which when read will expose
information like, cluster stack in use, states of the downconvert, recovery
and commit threads, number of journal txns, some allocation stats, list of
all slots, etc.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED
Added two debugfs entries... one to dump o2hb livenodes and the other
to dump osb.
$ cat /sys/kernel/debug/ocfs2/BC4F4550BEA74F92BDCC746AAD2EC0BF/fs_state
Device = Id: 8,65 Uuid: BC4F4550BEA74F92BDCC746AAD2EC0BF Gen: 0xA02024F2
Label: sunil-xattr
Volume = State: 1 Flags: 0x0
Sizes =
Patch adds check for [no]user_xattr in ocfs2_show_options() that compiles
the list of all mount options.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/super.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index
Any reason we don't want to support both jbd and jdb2. As in, using
incompat to specifically enable jbd2.
I am talking about short term only. Long term is jdb2 only.
Joel Becker wrote:
ocfs2 wants JBD2 for many reasons, not the least of which is that JBD is
limiting our maximum filesystem
-by: Mark Fasheh [EMAIL PROTECTED]
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
Maybe change symbolic link to nowhere to broken symbolic link.
Looks good otherwise.
Coly Li wrote:
Adds error messages to mount.ocfs2 when mount point is invalid in three
conditions:
1) mount point does not exist.
2) mount point is a symbolic link.
3) mount point is not a directory.
This patch fixes an oops that is reproduced when one races writes to a mmap-ed
region with another process truncating the file.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/aops.c | 29 +
1 files changed, 17 insertions(+), 12 deletions(-)
diff --git
Two changes.
One was implementing Joel suggestion of moving bump and get recogens
into journal.c.
Second was concerning the recogen refresh on nodes that did not replay
the journal. We now refresh at the end of the recovery process just
before we release the EX on the superblock lock. Earlier we
This patch renames the ij_pad to ij_recovery_generation in struct ocfs2_dinode.
This will be used to keep count of journal replays after an unclean shutdown.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/ocfs2_fs.h |5 -
1 files changed, 4 insertions(+), 1 deletions
, the messaging would indirectly indicate that the slot
was being recovered.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/journal.c | 173
fs/ocfs2/journal.h |3 +-
fs/ocfs2/ocfs2.h |2 +
fs/ocfs2/super.c | 12 +++-
4 files
Ok... same as the one I have been emailing for ocfs2 1.4. This was built
and tested with 2.6.26.
Sunil
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
This patch renames the ij_pad to ij_recovery_generation in struct ocfs2_dinode.
This will be used to keep count of journal replays after an unclean shutdown.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/ocfs2_fs.h |5 -
1 files changed, 4 insertions(+), 1 deletions
, the messaging would indirectly indicate that the slot
was being recovered.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/journal.c | 164
fs/ocfs2/journal.h |3 +-
fs/ocfs2/ocfs2.h |2 +
fs/ocfs2/super.c | 14 -
4 files
All suggestions incorporated. Please review.
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
All suggestions implemented.
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
, the messaging would indirectly indicate that the slot
was being recovered.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/journal.c | 162 +++-
fs/ocfs2/journal.h | 13 -
fs/ocfs2/ocfs2.h |2 +
fs/ocfs2/super.c | 12 -
4
This patch renames the ij_pad to ij_recovery_generation in struct ocfs2_dinode.
This will be used to keep count of journal replays after an unclean shutdown.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/ocfs2_fs.h |5 -
1 files changed, 4 insertions(+), 1 deletions
Please review the patches as discussed in the last concall.
In particular, please review the journal inode read code. I am not
sure whether that is the most efficient. As in, I may be reading the
blocks twice.
Sunil
___
Ocfs2-devel mailing list
, the messaging would indirectly indicate that the slot
was being recovered.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/journal.c | 156 +---
fs/ocfs2/journal.h |2 +-
fs/ocfs2/ocfs2.h |2 +
fs/ocfs2/super.c | 14 -
4
Joel is partial to generation. And you to recovery.
ij_recovery_generation?
Mouthful... but we use it only in a few places.
---BeginMessage---
On Thu, Jul 10, 2008 at 05:15:44PM -0700, Joel Becker wrote:
On Thu, Jul 10, 2008 at 04:17:50PM -0700, Sunil Mushran wrote:
This patch renames
Instead of using generation, we could use ij_pad. Renamed to
something appropriate.
Sunil Mushran wrote:
ok.. going back to the drawing board. I am putting in writing the
scheme the two of us thrashed out here. Please review.
Problem:
How does a recovery thread know that the slot
Patch fixes a race that can result in an oops while adding a
lockres to the dlm lockres tracking list.
Bug introduced by mainline commit 29576f8bb54045be944ba809d4fca1ad77c94165.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/dlm/dlmmaster.c |2 ++
1 files changed, 2 insertions
,
leave the buffer unmapped and return.
Fix is suggested by Mark Fasheh, and I code up the patch.
Signed-off-by: Coly Li [EMAIL PROTECTED]
Cc: Mark Fesheh [EMAIL PROTECTED]
Cc: Sunil Mushran [EMAIL PROTECTED]
---
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 17964c0..f59ebfd 100644
Wengang,
I needed some clarification. Is the fix proposed in kernel or in ocfs2,
or in kernel and in ocfs2?
Is the bug in 1.2/el4 only? Has 1.2/el5 or current mainline tested?
Just want to know what has been tested.
Also, please could you a file a bugzilla with the details. Especially
the
[EMAIL PROTECTED] wrote:
From: Wengang Wang [EMAIL PROTECTED]
This patch ensures the mount fails if the fs is unable to load the journal.
Signed-off-by: Wengang Wang [EMAIL PROTECTED]
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
___
Ocfs2
This patch silences an EINVAL error message in ocfs2_file_aio_read()
that is always due to a user error.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/file.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index 57e0d30
Wengang,
Thanks. The patch looks good.
However, please can you respin the patch for mainline. As we have now
have a 1.4 tree too, inorder to ensure that we don't miss any patches,
we want all patches to hit mainline before trickling down to 1.2/1.4.
And as this is a bugfix, we should be able to
Thanks.
Marc Grimme wrote:
Hello,
I just wanted to inform you that we have successfully ported the
Open-Sharedroot Cluster to be used with RHEL5.2/CentOS5.2 with OCFS2 1.3.9
and above.
More information can be found here:
Ivan,
Updating inode-i_size will require us to take the EX on the inode
cluster lock. (We take great pains to avoid taking that lock
in the directio path lest we serialize those ios across the
cluster.)
As far as treating unwritten extents as holes goes, we do that
simply to remember to
unsigned int', but
argument 29 has type 'suseconds_t'
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/cluster/netdebug.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/fs/ocfs2/cluster/netdebug.c b/fs/ocfs2/cluster/netdebug.c
index 7bf3c0e..d8bfa0e 100644
overhead that is involved in gathering such statistics.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/Kconfig |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/fs/Kconfig b/fs/Kconfig
index cf12c40..c264610 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -470,6 +470,14
This patch adds code to track the number of times the fs takes
various cluster locks as well as the times associated with it.
The information is made available to users via debugfs.
This patch was originally written by Jan Kara [EMAIL PROTECTED].
Signed-off-by: Sunil Mushran [EMAIL PROTECTED
This patch silences the build warnings concerning dlm_debug_init()
and friends when building without CONFIG_DEBUG_FS enabled.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/dlm/dlmdebug.h | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/ocfs2
This patch silences the build warnings concerning o2net_init_nst()
and friends when building without CONFIG_DEBUG_FS enabled.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/cluster/tcp.c | 28 +---
fs/ocfs2/cluster/tcp_internal.h | 32
This patch silences the build warnings concerning o2net_debugfs_init()
and friends when building without CONFIG_DEBUG_FS enabled.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/cluster/tcp.h | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/ocfs2
This patch adds code to track the number of times the fs takes
various cluster locks as well as the times associated with it.
Authored-by: Jan Kara [EMAIL PROTECTED]
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/dlmglue.c | 96
Thanks.
Can you work with Marcos to check this in ocfs2-test repo.
Tao Ma wrote:
One more thing, it has been tested with my script which has been sent to
ocfs2-tools-devel for review. Please see
http://oss.oracle.com/pipermail/ocfs2-tools-devel/2008-March/000621.html
Regards,
Tao
[EMAIL
Adrian Bunk wrote:
This patch makes the following needlessly global functions static:
- stringify_lockname()
- dlm_debug_put()
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Acked-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/dlm/dlmdebug.c |8 +---
1 file changed, 5
---BeginMessage---
d_move() is strangely implemented in that it swaps the position of
new_dentry and old_dentry in the namespace. This is admittedly weird (see
comments for d_move_locked()), but normally harmless: even though
new_dentry swaps places with old_dentry, it is unhashed, and won't
This patch adds the ability to change attributes of a symlink.
Fixes oss bugzilla#963
http://oss.oracle.com/bugzilla/show_bug.cgi?id=963
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/file.c|4
fs/ocfs2/symlink.c |2 ++
2 files changed, 6 insertions(+), 0 deletions
Mark Fasheh wrote:
Yeah, it breaks the protocol ;)
I meant, other than that. As in, we can always queue up this change
the next time we break the protocol for a better reason.
What do the tcp dumps look like? Is it raw binary data, is the binary
converted into hex, etc?
dentry lock from
Any reason the dentry lock has parent# in string and block# in binary?
The reverse will make it easier to grep for dentry locks in tcpdumps.
Sunil
___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
information via /proc.)
[Mark: checkpatch fixes]
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
Reviewed-by: Joel Becker [EMAIL PROTECTED]
Signed-off-by: Mark Fasheh [EMAIL PROTECTED]
---
fs/ocfs2/cluster/Makefile |2 +-
fs/ocfs2/cluster/netdebug.c | 441
struct ocfs2_alloc_stats alloc_stats;
Though this is off osb so has a smaller memory footprint.
Mark Fasheh wrote:
On Thu, Apr 10, 2008 at 03:56:31PM -0700, Sunil Mushran wrote:
How about I add another config OCFS2_ENABLE_STATS? OCFS2_DEBUG_FS
is truly debugging that has no place
information via /proc.)
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
---
fs/ocfs2/cluster/Makefile |2 +-
fs/ocfs2/cluster/netdebug.c | 437 +++
fs/ocfs2/cluster/nodemanager.c |5 +-
fs/ocfs2/cluster/tcp.c | 20 ++
fs/ocfs2/cluster/tcp.h
all use o2nm_single_cluster so there's no point
in passing an argument at all. This patch removes the arguments and kills
those bugs dead.
Signed-off-by: Jeff Mahoney [EMAIL PROTECTED]
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
- ---
fs/ocfs2/cluster/tcp.c | 45
A previous patch added KERN_NOTICE to printks printing the lockres that
cluttered the output. This patch removes the log level. For people concerned
with syslog clutter, please note we now use this facility to print lockres
only during an error.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED
Mainline commit c78bad11fbf1272ea021f56458025dc98486d6f4
Author: Joe Perches [EMAIL PROTECTED]
Date: Sun, 3 Feb 2008 17:33:42 +0200
This patch includes the ocfs2 relevant changes from the above
mainline commit.
Signed-off-by: Joe Perches [EMAIL PROTECTED]
Signed-off-by: Adrian Bunk [EMAIL
Mainline commit 52987e2ab456c1a828046494aac53819b1454341
Author: Sunil Mushran [EMAIL PROTECTED]
Date: Sat, 1 Mar 2008 14:04:21 -0800
During migration, the recovery master node may be asked to master a lockres
it may not know about. In that case, it would not only have to create a
lockres and add
Mainline commit 86c838b03daf35e2af6555842d04fe09a89f8d93
Author: Julia Lawall [EMAIL PROTECTED]
Date: Tue, 26 Feb 2008 21:45:56 +0100
In mainline commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337, a bug was fixed
that
involved converting !x y to !(x y). The code below shows the same
pattern,
Mainline commit 200bfae37a15e50e0f9aa5683958bdfc3fd55e05
Author: Adrian Bunk [EMAIL PROTECTED]
Date: Sun, 17 Feb 2008 10:20:38 +0200
This patch makes the needlessly global ocfs2_downconvert_thread()
static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Signed-off-by: Mark Fasheh [EMAIL PROTECTED]
Mainline commit 4338ab6a750303cbae4cc76cc7de5edba6598ebe
Author: Tao Ma [EMAIL PROTECTED]
Date: Mon, 3 Mar 2008 10:53:02 +0800
In ocfs2_group_add, 'cr' is a disk field of type 'ocfs2_chain_rec', and we
were putting cpu byteorder values into it. Swap things to the right endian
before storing.
Mainline commit b31cfc0237f89c3a8bc8f31b5da996e71b543214
Author: Sunil Mushran [EMAIL PROTECTED]
Date: Sat, 1 Mar 2008 14:04:22 -0800
dlm_master_request_handler() forgot to put a lockres when
dlm_assert_master_worker() failed or was skipped.
Signed-off-by: Sunil Mushran [EMAIL PROTECTED]
Signed
Mainline commit 535f7026fddafce6d0a0524db01a432c23a0a7b4
Author: Sunil Mushran [EMAIL PROTECTED]
Date: Sat, 1 Mar 2008 14:04:24 -0800
Knowing the dlm recovery master helps in debugging recovery
issues. This patch prints a message on the recovery master node.
Signed-off-by: Sunil Mushran [EMAIL
Mainline commit 0f71b7b40f55de909e40fa5ab217a5da3439c7d8
Author: Joel Becker [EMAIL PROTECTED]
Date: Tue, 12 Feb 2008 14:56:25 -0800
struct dlm_query_join_packet is made up of four one-byte fields. They
are effectively in big-endian order already. However, little-endian
machines swap them
Mainline commit d24fbcda0c4988322949df3d759f1cfb32b32953
Author: Joel Becker [EMAIL PROTECTED]
Date: Fri, 25 Jan 2008 17:02:21 -0800
Currently, when ocfs2 nodes connect via TCP, they advertise their
compatibility level. If the versions do not match, two nodes cannot speak
to each other and they
Mainline commit cdef59a94c2fc962ada379d4240d556db7b56d55
Author: Tao Ma [EMAIL PROTECTED]
Date: Wed, 5 Mar 2008 15:49:55 +0800
In some situations, ocfs2_set_nn_state might get called with sc = NULL and
valid = 0. If sc = NULL, we can't dereference it to get the o2nm_node
member. Instead, do what
701 - 800 of 958 matches
Mail list logo
