[PATCH] atmodem/sms: added missing return in at_cmt_notify before error processing

--- drivers/atmodem/sms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c index 7e78fcf..fb4d67a 100644 --- a/drivers/atmodem/sms.c +++ b/drivers/atmodem/sms.c @@ -455,6 +455,7 @@ static void at_cmt_notify(GAtResult *result, gpointer user_data)

[PATCH] mbim driver: fixed the initialization function

--- drivers/mbimmodem/mbimmodem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mbimmodem/mbimmodem.c b/drivers/mbimmodem/mbimmodem.c index a4c9daa..2a01dd6 100644 --- a/drivers/mbimmodem/mbimmodem.c +++ b/drivers/mbimmodem/mbimmodem.c @@ -33,7 +33,7 @@ static int

[PATCH] mbim driver: call the release function in case MBIM OPEN fails

--- drivers/mbimmodem/mbim.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mbimmodem/mbim.c b/drivers/mbimmodem/mbim.c index 9fcf44b..f4132d0 100644 --- a/drivers/mbimmodem/mbim.c +++ b/drivers/mbimmodem/mbim.c @@ -781,6 +781,9 @@ static bool open_read_handler(struct l_io *io,

[PATCH] src/gprs.c: make sure that the context is properly released

--- src/gprs.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gprs.c b/src/gprs.c index 8f5d195..40f43e3 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -1642,6 +1642,9 @@ static void release_active_contexts(struct ofono_gprs *gprs) if (gc->driver->detach_shutdown !=

[PATCH 2/2] tools/auto-enable.c and tools/huawei-audio.c: removed calls to g_thread_init

--- tools/auto-enable.c | 5 - tools/huawei-audio.c | 5 - 2 files changed, 10 deletions(-) diff --git a/tools/auto-enable.c b/tools/auto-enable.c index 87fb0a8..5195aaa 100644 --- a/tools/auto-enable.c +++ b/tools/auto-enable.c @@ -492,11 +492,6 @@ int main(int argc, char **argv)

[PATCH] bugfix: src/gprs.c used the right binary NOT operator in bitwise operation instead of the boolean NOT operator

--- src/gprs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gprs.c b/src/gprs.c index f17f31b..8f5d195 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -1015,7 +1015,7 @@ static void pri_read_settings_callback(const struct ofono_error *error, value =

[PATCH 2/4] added default values handling for gprs authentication in atmodem and mbimmodem

this is needed so that with the additional methods NONE and ANY the compilation is not broken --- drivers/atmodem/gprs-context.c | 2 ++ drivers/mbimmodem/gprs-context.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c index

[PATCH 4/4] src/gprs.c: added support for NONE and ANY authentication methods

--- src/gprs.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gprs.c b/src/gprs.c index 377eced..f17f31b 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -261,6 +261,10 @@ static const char *gprs_auth_method_to_string(enum ofono_gprs_auth_method auth) return "chap";

[PATCH 3/4] plugins/file-provisioning.c: take into account auth_methods NONE and ANY

added the support for the NONE and ANY authentication methods --- plugins/file-provision.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/plugins/file-provision.c b/plugins/file-provision.c index d4846a6..f7412e6 100644 --- a/plugins/file-provision.c +++ b/plugins/file-provision.c @@

[PATCH 1/4] gprs: added two authentication methods: NONE and ANY

OFONO_GPRS_AUTH_METHOD_NONE disables the authentication OFONO_GPRS_AUTH_METHOD_ANY tries first CHAP then PAP, but only applies to supporting drivers and modules --- include/gprs-context.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/gprs-context.h

[PATCH] ril driver: commented out pragma

gcc 4.8.4 rejects the line: and this breaks the default compilation. Since they may be needed for other compilers, I have just commented them out with '//', so that they stand out. --- drivers/rilmodem/call-forwarding.c | 2 +- drivers/rilmodem/network-registration.c | 2 +- 2 files changed,

Re: [PATCH] ril driver: commented out pragma\n\ngcc 4.8.4 rejects the line:\n#pragma GCC diagnostic ignored "-Wrestrict"\nand this breaks the default compilation.\nsince they may be needed for other c

please ignore this. the commit message was wrongly formatted for some reason. On Thu, Sep 20, 2018 at 6:00 AM Giacinto Cifelli wrote: > --- > drivers/rilmodem/call-forwarding.c | 2 +- > drivers/rilmodem/network-registration.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >

[PATCH] ril driver: commented out pragma\n\ngcc 4.8.4 rejects the line:\n#pragma GCC diagnostic ignored "-Wrestrict"\nand this breaks the default compilation.\nsince they may be needed for other compi

--- drivers/rilmodem/call-forwarding.c | 2 +- drivers/rilmodem/network-registration.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rilmodem/call-forwarding.c b/drivers/rilmodem/call-forwarding.c index 4aff4d3..0bdab3f 100644 ---

[PATCH 1/2] gemaltomodem: added Gemalto-specific gprs-context atom This atom name is not the same as the driver, because it might be necessary to add other grps-context atoms, according to the needs.

--- drivers/gemaltomodem/gemaltomodem.c | 2 + drivers/gemaltomodem/gemaltomodem.h | 3 + drivers/gemaltomodem/gprs-context-wwan.c | 446 +++ 3 files changed, 451 insertions(+) create mode 100644 drivers/gemaltomodem/gprs-context-wwan.c diff --git

[PATCH 2/2] gemaltomodem: added gprs-context-wwan.c in the makefile

--- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index e2363e2..fabda0a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -397,6 +397,7 @@ builtin_modules += gemaltomodem builtin_sources += drivers/atmodem/atutil.h \

[PATCH 1/2] gemaltomodem: added voicecall atom

--- drivers/gemaltomodem/gemaltomodem.c | 3 +- drivers/gemaltomodem/gemaltomodem.h | 3 + drivers/gemaltomodem/voicecall.c| 965 3 files changed, 970 insertions(+), 1 deletion(-) create mode 100644 drivers/gemaltomodem/voicecall.c diff --git

[PATCH 2/2] gemaltomodem: added voicecall.c in the makefile

--- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 6dee4ce..e2363e2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -397,6 +397,7 @@ builtin_modules += gemaltomodem builtin_sources += drivers/atmodem/atutil.h \

[PATCH] atmodem: added vendor Gemalto

--- drivers/atmodem/vendor.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/atmodem/vendor.h b/drivers/atmodem/vendor.h index 721796e..abe2d89 100644 --- a/drivers/atmodem/vendor.h +++ b/drivers/atmodem/vendor.h @@ -49,4 +49,5 @@ enum ofono_vendor {

[PATCH] atmodem: added inline function to parse AT+CESQ result for signal strenght It complements the function at_util_convert_signal_strength for AT+CSQ, which does not apply well to 3G and not at al

--- drivers/atmodem/atutil.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/atmodem/atutil.h b/drivers/atmodem/atutil.h index 7113a4c..57573cb 100644 --- a/drivers/atmodem/atutil.h +++ b/drivers/atmodem/atutil.h @@ -115,6 +115,20 @@ static inline int

[PATCH] fixed typo in doc/emergency-call-handling.txt

--- doc/emergency-call-handling.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/emergency-call-handling.txt b/doc/emergency-call-handling.txt index 69b217d..0436047 100644 --- a/doc/emergency-call-handling.txt +++ b/doc/emergency-call-handling.txt @@ -14,7 +14,7 @@

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

Hi Slava, On 09/19/2018 06:14 PM, Slava Monich wrote: On 20/09/18 00:45, Denis Kenzior wrote: (ANY = PAP_CHAP, and don't ask me why we added new values to the beginning of the enum - it was before we started using binary plugins). I would be more than happy if upstream started to use the

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

On 20/09/18 00:45, Denis Kenzior wrote: (ANY = PAP_CHAP, and don't ask me why we added new values to the beginning of the enum - it was before we started using binary plugins). I would be more than happy if upstream started to use the same enum! That assumes that we should support your

Re: ublox TOBY-R200

Hi Frank, Please stop top-posting on this mailing list. We follow the accepted best practice of open source mailing lists and require replies to be in-line. Sep 19 20:17:41 gateway daemon.warn ofonod[152]: Context activated for driver that doesn't support automatic context activation. So

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

Hi Slava, I understand that! It makes things easier for you guys. But we had to avoid certain compile-time dependencies in ofono, and a straightforward (and perhaps the only) way to achieve that was to use binary plugins. For us plugin API is not subject to change (plugins don't necessarily

Re: ublox TOBY-R200

Hi Giacinto, I attached a better antenna to our custom board but I'm still getting the same results. AT+CSQ +CSQ: 24,4 OK # ./enable-modem Connecting modem /ublox_0... # ./create-internet-context hologram Found context /ublox_0/context1 Setting APN to hologram # ./online-modem Setting modem

Re: [PATCH 2/3] sim800: add udev detection

On Wed, Sep 19, 2018 at 03:03:57PM -0500, Denis Kenzior wrote: Hi, > Hi, > > >> > >>So I'm confused now. If sim800 is a serial device, why do you have all this > >>here? Shouldn't this be handled by setup_serial_modem ? > >> > > > >Because the modem was seen through a serial/USB converter, my

Re: [PATCH 2/3] sim800: add udev detection

Hi, So I'm confused now. If sim800 is a serial device, why do you have all this here? Shouldn't this be handled by setup_serial_modem ? Because the modem was seen through a serial/USB converter, my kernel sees it as a USB device. So I used this function. Should this be coded in a more

Re: [PATCH 2/3] sim800: add udev detection

On Wed, Sep 19, 2018 at 11:46:34AM -0500, Denis Kenzior wrote: Hi, > Hi, > > On 09/18/2018 03:36 PM, ClémentViel wrote: > >From: clem > > > >--- > > plugins/udevng.c | 49 + > > 1 file changed, 49 insertions(+) > > > >diff --git

Re: [PATCH 1/3] sim800: adding support for Simcom SIM800 modem

On Wed, Sep 19, 2018 at 08:03:27PM +0300, Pičugins Arsenijs wrote: Hi, I guess I submit it in a hurry and forgot to add the firmware version. BTW, your problem may be related to this. Are you sure your CMUX command is not returning an error ? Thus preventing ofono from enabling the modem ? I

Re: [PATCH 1/3] sim800: adding support for Simcom SIM800 modem

On Wed, Sep 19, 2018 at 11:51:26AM -0500, Denis Kenzior wrote: Hi, > Hi, > > On 09/18/2018 03:36 PM, ClémentViel wrote: > >From: clem > > > > You might want to describe how this is different from sim900 that it > warrants a fully separate driver? > > If there are only minor differences, then

Re: [PATCH 3/3] sim800: adding documentation to inform about the udev rule the user must add

>+To enable SIM900 module support you need to put the following BTW, there's a typo in your documentation patch - you're stillmentioning "SIM900" in the description. Cheers!Arsenijs 19.09.2018, 22:25, "Clement Viel" :On Wed, Sep 19, 2018 at 11:43:49AM -0500, Denis Kenzior wrote: Hi, On 09/18/2018

Re: [PATCH 3/3] sim800: adding documentation to inform about the udev rule the user must add

On Wed, Sep 19, 2018 at 11:43:49AM -0500, Denis Kenzior wrote: > Hi, > > On 09/18/2018 03:36 PM, ClémentViel wrote: > >From: clem > > Can you fix your Author information (see AUTHORS for an example). Otherwise > I cannot take these... Yep, I'll do it the right way > > > > >--- > >

Re: [PATCH 2/7] extended support for LTE and NR. Some minor fixes. part 2 of 7

Hi Giacinto, I had a look at this all, and I have a problem. I cannot check the parameters as they are entered one by one. Example: if I blank user/pwd when the authentication is changed to NONE, then if changed again to CHAP, the module will reject it. Shall I store the parameters, or keep

Re: [PATCH 2/7] extended support for LTE and NR. Some minor fixes. part 2 of 7

On Wed, Sep 19, 2018 at 6:30 PM Denis Kenzior wrote: > Hi Giacinto, > > > so, first the documentation? > > Correct. Whenever you touch something that affects the D-Bus API, it is > really preferable to have the D-Bus API changes in the preceding commit. > That way the reviewers can

Re: [PATCH 1/3] sim800: adding support for Simcom SIM800 modem

Hello! > You might want to describe how this is different from sim900 that it> warrants a fully separate driver? I've tried to apply this patch yesterday evening (since I too aminterested in SIM800 integration) and tried to apply it, patch 2doesn't apply on current master for some reason. Here's a

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

On Wed, Sep 19, 2018 at 6:54 PM Slava Monich wrote: > On 19/09/18 19:32, Denis Kenzior wrote: > > Hi Slava, > > > >> Anything in include is external API. We do maintain not just > >> out-of-tree, but binary plugins. Backward (binary!) compatibility a > >> must for us. Please do not break it. > >

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

On 19/09/18 19:32, Denis Kenzior wrote: Hi Slava, Anything in include is external API. We do maintain not just out-of-tree, but binary plugins. Backward (binary!) compatibility a must for us. Please do not break it. That is why we have 'OFONO_API_SUBJECT_TO_CHANGE' as a reminder. We mean

Re: [PATCH 1/3] sim800: adding support for Simcom SIM800 modem

Hi, On 09/18/2018 03:36 PM, ClémentViel wrote: From: clem You might want to describe how this is different from sim900 that it warrants a fully separate driver? If there are only minor differences, then this can be handled via UDEV attributes or querying +CGMM, etc. --- Makefile.am

Re: [PATCH 2/3] sim800: add udev detection

Hi, On 09/18/2018 03:36 PM, ClémentViel wrote: From: clem --- plugins/udevng.c | 49 + 1 file changed, 49 insertions(+) diff --git a/plugins/udevng.c b/plugins/udevng.c index 02d049e..9a1be6a 100644 --- a/plugins/udevng.c +++

Re: [PATCH 3/3] sim800: adding documentation to inform about the udev rule the user must add

Hi, On 09/18/2018 03:36 PM, ClémentViel wrote: From: clem Can you fix your Author information (see AUTHORS for an example). Otherwise I cannot take these... --- doc/sim800-modem.txt | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 doc/sim800-modem.txt diff --git

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

Hi Slava, Anything in include is external API. We do maintain not just out-of-tree, but binary plugins. Backward (binary!) compatibility a must for us. Please do not break it. That is why we have 'OFONO_API_SUBJECT_TO_CHANGE' as a reminder. We mean it. D-Bus API is stable, we never made

Re: [PATCH 2/7] extended support for LTE and NR. Some minor fixes. part 2 of 7

Hi Giacinto, so, first the documentation? Correct. Whenever you touch something that affects the D-Bus API, it is really preferable to have the D-Bus API changes in the preceding commit. That way the reviewers can cross-reference what is being proposed to the actual implementation.

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

On 19/09/18 18:21, Denis Kenzior wrote: Hi Giacinto, I would favour also renumbering with NONE on top, but I am not sure of the side effects everywhere, in case the values are used directly in commands. Actually there is no problem doing that.  The internal API is not stable.  Besides, it

Re: [PATCH 2/7] extended support for LTE and NR. Some minor fixes. part 2 of 7

Hi Denis, On Wed, Sep 19, 2018 at 5:04 PM Denis Kenzior wrote: > Hi Giacinto, > > On 09/19/2018 12:37 AM, Giacinto Cifelli wrote: > > --- > > src/gprs.c | 13 ++- > > src/lte.c | 372 > ++--- > > src/main.c | 5 - > > 3 files

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

Hi Giacinto, From the ./HACKING file I understood that the requirement is to split according to the top-level directories only, and to make sure not to break compilation. The rule provides a baseline minimum. It also implies that sometimes breaking compilation is inevitable. So long as

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

On Wed, Sep 19, 2018 at 4:09 PM Denis Kenzior wrote: > Hi Giacinto, > > Your patch series has 7 commits with the same header. That is nonsense. > Each commit header should be specific to what is contained inside and > preferably followed by a commit description. > > Read any one of the many

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

Hi Giacinto, I would favour also renumbering with NONE on top, but I am not sure of the side effects everywhere, in case the values are used directly in commands. Actually there is no problem doing that. The internal API is not stable. Besides, it will give all the guys who insist on

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

Hi Slava, On 09/19/2018 03:35 AM, Slava Monich wrote: On 19/09/18 08:37, Giacinto Cifelli wrote: ---   include/gprs-context.h |  1 +   include/lte.h  | 11 +--   2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/include/gprs-context.h b/include/gprs-context.h index

Re: [PATCH 3/7] extended support for LTE and NR. Some minor fixes. part 3 of 7

Hi Giacinto, On 09/19/2018 12:37 AM, Giacinto Cifelli wrote: --- drivers/atmodem/atutil.h | 14 + drivers/atmodem/cbs.c| 1 + drivers/atmodem/gprs-context.c | 2 + drivers/atmodem/gprs.c | 554 --

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

Hi Giacinto, Your patch series has 7 commits with the same header. That is nonsense. Each commit header should be specific to what is contained inside and preferably followed by a commit description. Read any one of the many 'How to submit a kernel patch' howtos in order to understand the

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

On Wed, Sep 19, 2018 at 10:35 AM Slava Monich wrote: > On 19/09/18 08:37, Giacinto Cifelli wrote: > > --- > > include/gprs-context.h | 1 + > > include/lte.h | 11 +-- > > 2 files changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/include/gprs-context.h

Re: [PATCH 1/7] extended support for LTE and NR. Some minor fixes. part 1 of 7

On 19/09/18 08:37, Giacinto Cifelli wrote: --- include/gprs-context.h | 1 + include/lte.h | 11 +-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/include/gprs-context.h b/include/gprs-context.h index 20ca9ef..8869c12 100644 --- a/include/gprs-context.h