[PATCH 1/4] n900: Use consistent naming in GPIO API

In addition, add header guards as the API can be used from more than one plugin. --- plugins/n900.c | 12 +++--- plugins/nokia-gpio.c | 106 ++ plugins/nokia-gpio.h | 37 +++-- 3 files changed, 85 insertions(+), 70

[PATCH 4/4] udev: Add bootstrapping for n950 plugin

--- plugins/udev.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 8cb87a5..fe18450 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -278,6 +278,8 @@ done: add_isi(modem, udev_device); else if

[PATCH 2/4] n950: Add new plugin for Nokia N950

--- plugins/n950.c | 563 1 files changed, 563 insertions(+), 0 deletions(-) create mode 100644 plugins/n950.c diff --git a/plugins/n950.c b/plugins/n950.c new file mode 100644 index 000..6c9a9da --- /dev/null +++ b/plugins/n950.c @@

[PATCH 3/4] build: Add n950 plugin to build

--- Makefile.am |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9cb490d..2586f5d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -147,6 +147,9 @@ builtin_sources += plugins/isiusb.c builtin_modules += n900 builtin_sources +=

Re: Anyone want to upstraem N950 patches from MeeGo/Mer?

Hi Marko, 2011/11/22 Marko Saukko marko.sau...@gmail.com: there are some Nokia N950 related ofono patches that never made to the upstream. I wonder if there is anyone that would be interested of fixing and upstreaming these? The patches seem to apply with minor modification on top of 1.0

Re: [PATCH 0/3] isimodem: Allow network registration automatically

Hi Iiro, 2011/8/3 iiro.kaihlani...@nokia.com: Network registration is disabled by default. Enable network registration and roaming  when network is started.  drivers/isimodem/debug.c                |    5 ++  drivers/isimodem/network-registration.c |   85 +++

Re: [PATCH 0/5] isimodem: Add functionality to UICC

Hi Iiro, 2011/8/3 iiro.kaihlani...@nokia.com: This patch adds some functionality to UICC which has been pretty much dummy so far.  Makefile.am  |    3 +-  drivers/isimodem/debug.c |  121 +  drivers/isimodem/debug.h |    2 +  drivers/isimodem/uicc.c  | 1282 The set that I

Re: [PATCH 2/3] isimodem: Allow network registration automatically

Hi Iiro, 2011/8/3 iiro.kaihlani...@nokia.com: diff --git a/drivers/isimodem/network-registration.c b/drivers/isimodem/network-registration.c index cc48579..ffcfab4 100644 --- a/drivers/isimodem/network-registration.c +++ b/drivers/isimodem/network-registration.c @@ -946,6 +946,84 @@

Re: Problems ofono 0.45 and Nokia 6760

On Thu, 2011-06-16 at 11:27 +0200, ext Claudio Degioanni wrote: So my advice is to simply use DUN via USB ACM interface. So I think the nokia driver might work better than the isiusb one in this case. I'm using embedded tegra2 system, in the past i have tested the connection on x86 machine

Re: Problems ofono 0.45 and Nokia 6760

Hi Claudio, On Wed, 2011-06-08 at 16:22 +0200, ext Claudio Degioanni wrote: Error org.ofono.Error.NotAttached: GPRS is not attached Has this been working before? It looks like the network registration status query fails with a SERVICE_NOT_IDENTIFIED service type. My suspicion is that the phone

Re: [PATCH] isimodem: Improper handling of missed call

Hi Arun, 2011/5/30 Arun Ravindran arun...@gmail.com: Can you post logs on such a successful case, if you have any around? tested once again, its working for me. I have attached the log here. But here i am using as n900 modem and not as isiusb . It seems to be working for me now using the

Re: build fail with --disable-atmodem

, but gets disabled along with atmodem. Maybe Marcel or Denis could take a look at that patch (reattaching it here). Cheers, Aki From 1920b813a4db120f0d6692e9d4d86f3fe313a263 Mon Sep 17 00:00:00 2001 From: Aki Niemi aki.ni...@nokia.com Date: Thu, 24 Mar 2011 17:30:12 +0200 Subject: [PATCH] build

Re: [PATCH] isimodem: Improper handling of missed call

Hi Arun, 2011/5/23 Arun Ravindran arun...@gmail.com: @@ -548,9 +555,26 @@ static void isi_call_notify(struct ofono_voicecall *ovc, struct isi_call *call)        case CALL_STATUS_MO_RELEASE:        case CALL_STATUS_MT_RELEASE: -       case CALL_STATUS_TERMINATED: +               /* +      

Re: [PATCH] isimodem: Improper handling of missed call

Hi Arun, 2011/5/18 Arun Ravindran arun...@gmail.com: +       case CALL_STATUS_MT_RELEASE: +               if ((call-prev_status == CALL_STATUS_MT_ALERTING) || +                               (call-prev_status == CALL_STATUS_COMING) || +                               (call-prev_status ==

Re: [PATCH] isiusb: wait for MTC transitions, too

Hi Pekka, 2011/4/18 pekka.pe...@nokia.com: From: Pekka Pessi pekka.pe...@nokia.com ---  plugins/isiusb.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) Patch has been pushed, thanks. Cheers, Aki ___ ofono mailing list

Re: [PATCH] isimodem: fix call_create_resp handling

Hi Pekka, 2011/4/12 pekka.pe...@nokia.com: From: Pekka Pessi pekka.pe...@nokia.com In case of call creation failure modem may return a valid call id in order to send CALL_SERVICE_DENIED_IND which we do not handle. Fixes MeeGo bug#15855. ---  drivers/isimodem/voicecall.c |   39

Re: [PATCH] isimodem: notify sms-status-reports, too

Hi Pekka, 2011/4/12 pekka.pe...@nokia.com: From: Pekka Pessi pekka.pe...@nokia.com ---  drivers/isimodem/sms.c |   11 ++-  1 files changed, 10 insertions(+), 1 deletions(-) I actually ended up pushing a fix for this as part of the wgmodem2.5 additions. Thanks anyway! Cheers, Aki

Re: [PATCH 1/1] isimodem: fix network registration for older modems

Hi Mika, 2011/3/24 Mika Liljeberg mika.liljeb...@nokia.com: ---  drivers/isimodem/network-registration.c |   10 --  1 files changed, 8 insertions(+), 2 deletions(-) Patch has been pushed. Thanks. Cheers, Aki ___ ofono mailing list

Re: [PATCH 1/2] isimodem/sim: added PIN and SIM state handling

Hi Pekka, 2011/3/24 pekka.pe...@nokia.com: From: Pekka Pessi pekka.pe...@nokia.com Using PN_SECURITY resource to obtain PIN statuses. Using ofono_sim_ready_notify() aka __ofono_sim_recheck_pin() to report the ready state. ---  drivers/isimodem/debug.c |   59 +  

[PATCH] build: Add gatchat to core sources

Otherwise, --disable-atmodem breaks build. --- Makefile.am |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Makefile.am b/Makefile.am index b0cbcd7..39d8962 100644 --- a/Makefile.am +++ b/Makefile.am @@ -154,8 +154,7 @@ endif if ATMODEM builtin_modules +=

Re: [RESEND 3 PATCH 00/13] IPv6 Support

Hi Denis, 2011/3/18 Denis Kenzior denk...@gmail.com: Unfortunately that ship has sailed.  Every vendor except Nokia uses AT command modems, or at least implements a (somewhat) full-featured AT backend. Not quite the way I see things. There are notable exceptions to this, for example, Qualcomm

Re: [PATCH] Isimodem: Crash while setting SCA

Hi Denis, 2011/3/11 Denis Kenzior denk...@gmail.com: diff --git a/drivers/isimodem/sms.c b/drivers/isimodem/sms.c index 957b342..c90c06d 100644 --- a/drivers/isimodem/sms.c +++ b/drivers/isimodem/sms.c @@ -292,7 +292,7 @@ static void isi_sca_set(struct ofono_sms *sms,               {

RE: [PATCH] atmodem: Enable network time for AT modem

Hi Jeevaka, On Tue, 2011-03-08 at 12:35 +0200, ext jeevaka.badrap...@elektrobit.com wrote: This log is taken some time back. Possible that Network Daylight Saving Time is received as part of the MM information message whereas it may not be in your case. If my memory serves, DST is optional in

Re: [PATCH] gisi: M6 coding style violation corrections

Hi Antti, 2011/3/4 Antti Paila antti.pa...@nokia.com: ---  gisi/iter.c |   16  1 files changed, 8 insertions(+), 8 deletions(-) Patch has been pushed. Thanks. Cheers, Aki ___ ofono mailing list ofono@ofono.org

Re: [PATCH v2 09/18] isimodem: clip colp clir colr wgmodem2.5

Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/call-settings.c |  711 +-  drivers/isimodem/call.h          |    9 +  drivers/isimodem/debug.c         |    4 +  

Re: [PATCH v2 10/18] isimodem: wgmodem2.5 added to voicecall

Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/call.h      |   82 -  drivers/isimodem/voicecall.c |  218 +-  2 files changed, 253

Re: [PATCH v2 12/18] isimodem: SS_GSM_BARRING_INFO added

Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com SS_GSM_BSC_INFO added. ---  drivers/isimodem/call-barring.c |   99 ++  1 files changed, 88 insertions(+), 11 deletions(-) Patch was

Re: [PATCH v2 14/18] isimodem: wgmodem2.5 added to ssn

Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/call-forwarding.c |    1 -  drivers/isimodem/ssn.c             |  406 +++-  2 files changed, 401 insertions(+), 6

Re: [PATCH v2 13/18] isimodem: wgmodem2.5 added to call-forwarding

Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/call-forwarding.c |   29 +  1 files changed, 25 insertions(+), 4 deletions(-) Patch has been applied. Some refactoring after

Re: [PATCH] gisi: Consumer functions for ISI message iterator

Hi Antti, 2011/3/3 Antti Paila antti.pa...@nokia.com: snip  struct _GIsiSubBlockIter { +       uint8_t cursor;        uint8_t *start;        uint8_t *end;        gboolean longhdr; The cursor actually needs to be 16 bits, because when the long header format is in use, that is what subblock

Re: [PATCH] isiusb: add message-waiting

Hi Jukka, 2011/3/3 Jukka Saunamaki jukka.saunam...@nokia.com: ---  plugins/isiusb.c |    5 +  1 files changed, 5 insertions(+), 0 deletions(-) Pushed, thanks. Cheers, Aki ___ ofono mailing list ofono@ofono.org

Re: [PATCH 3/5] cell-info: Atom for neighbor cell info

Hi Antti, 2011/2/14 Antti Paila antti.pa...@nokia.com: ---  src/cell-info.c |  475 +++  1 files changed, 475 insertions(+), 0 deletions(-)  create mode 100644 src/cell-info.c diff --git a/src/cell-info.c b/src/cell-info.c new file mode

Re: ofono patch review policy?

Hi George, 2011/3/1 George Matveev geo...@matveev.se: on February 6, I submitted a patch (isimodem): http://lists.ofono.org/pipermail/ofono/2011-February/008635.html But it is already March and the patch has never been reviewed nor formally rejected. Sorry, I had missed that. Other

Re: [PATCH 1/1] isimodem: group timeouts in enum, remove unused timeout

Hi George, 2011/2/6 George Matveev geo...@matveev.se: Introduce enum network_timeout for scan/registration timeouts, remove unused NETWORK_TIMEOUT. ---  drivers/isimodem/network.h |    8 +---  1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/isimodem/network.h

Re: [PATCH v2 04/18] plugins: add u8500 to udev

Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  plugins/ofono.rules |    3 +++  plugins/udev.c      |    2 ++  2 files changed, 5 insertions(+), 0 deletions(-) Patch applied. Thanks! Cheers, Aki

Re: [PATCH v2 06/18] src: add missing SIM enum to simutil.h

Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  src/simutil.h |    1 +  1 files changed, 1 insertions(+), 0 deletions(-) Applied this patch with minor tweak of the commit message. Cheers, Aki

Re: [PATCH v2 07/18] isimodem: code points uicc sim wgmodem2.5

Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  Makefile.am              |    4 +-  drivers/isimodem/debug.c |   84 +++  drivers/isimodem/debug.h |    1 +  drivers/isimodem/uicc.h  |  265

Re: [PATCH v2 15/18] isimodem: code points for sms wgmodem2.5

Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/debug.c |   56 ++  drivers/isimodem/debug.h |    1 +  drivers/isimodem/sms.h   |   34

Re: [PATCH v2 02/18] isimodem: added codepoints for u8500

Hi Andreas, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/debug.c |    1 +  drivers/isimodem/info.h  |    3 +++  2 files changed, 4 insertions(+), 0 deletions(-) Patch has been pushed. Thanks. Cheers,

Re: [PATCH v2 03/18] plugins: add plugin for u8500

Hi Andreas, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  Makefile.am     |    3 +  plugins/u8500.c |  708 +++  2 files changed, 711 insertions(+), 0 deletions(-)  

Re: [PATCH 09/18] isimodem: clip colp clir colr wgmodem2.5

Hi Andreas, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/call-settings.c |  697 +-  drivers/isimodem/call.h          |    9 +  drivers/isimodem/debug.c         |    

Re: [PATCH 11/18] isimodem: gprs-context updates wgmodem2.5

Hi, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/gprs-context.c |   95 +-  1 files changed, 62 insertions(+), 33 deletions(-) diff --git

Re: [PATCH 16/18] isimodem: sms updated with wgmodem2.5

Hi Andreas, 2011/2/16 Andreas WESTIN andreas.wes...@stericsson.com: This UICC stuff seems to be leftovers form patch 8/18. Well they are related to SMS, debug prints. But yes they are also UICC. Do you want them in patch 8 ? That would be my preference. That is, a patch to bring in the

Re: [PATCH 04/18] gisi: fix subscription for wgmodem2.5

Hi Andreas, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com:                if (legacy)                        msg[3 + count] = mux-resource; -               else +               else {                        /* Resource field is 32bit and Little-endian */                        

Re: [PATCH 03/18] isimodem: general build updates for wgmodem2.5

Hi, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/debug.c |   48 ++  drivers/isimodem/debug.h |    8 +++  drivers/isimodem/mtc.h   |   38

Re: [PATCH 04/18] gisi: fix subscription for wgmodem2.5

Hi Andreas, 2011/2/16 Andreas WESTIN andreas.wes...@stericsson.com: Tested and works fine, will submit a new patch for the u8500 plugin. This is not done in the n900 plugin though, perhaps not necessary ? The default is PN_DEV_HOST, which is what the N900 uses. Cheers, Aki

Re: [PATCH 07/18] isimodem: add wgmodem2.5 to devinfo

Hi, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com: @@ -111,17 +115,22 @@ static void isi_query_manufacturer(struct ofono_devinfo *info,        struct devinfo_data *dev = ofono_devinfo_get_data(info);        struct isi_cb_data *cbd = isi_cb_data_new(dev, cb, data); +       if (cbd

Re: [PATCH 16/18] isimodem: sms updated with wgmodem2.5

Hi, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/debug.c |   56 +++  drivers/isimodem/debug.h |    1 +  drivers/isimodem/sms.c   |  972 +++---  

Re: [PATCH 05/18] plugins: add plugin for u8500

Hi, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com: +static int u8500_probe(struct ofono_modem *modem) +{ +       const char *ifname = ofono_modem_get_string(modem, Interface); +       unsigned address = ofono_modem_get_integer(modem, Address); +       GIsiModem *isimodem; +      

Re: [PATCH] TODO: Add vCard export to SM/ME stores

Hi Marcel, 2010/11/23 Marcel Holtmann mar...@holtmann.org: So the aa{sv} parameter/return value would be of format: {   'name'    : string,   'group'   : string,   // optional, for eg. organization   'hidden'  : integer,  // boolean value: defaults to 0   'numbers' : array of dict {    

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

Hi, 2011/2/1 Aki Niemi aki.ni...@nokia.com: I'm starting to think me just saying this out loud is not concrete enough, so I guess one way forward here could be for me to go ahead and adapt e.g. the netreg driver to work with N900 and later ISI modems. The netreg driver would make a good

Re: [PATCH 1/1] gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions

Hi Rémi, 2011/1/28 Rémi Denis-Courmont remi.denis-courm...@nokia.com: On Friday 28 January 2011 13:37:10 ext Jessica Nilsson, you wrote: diff --git a/gisi/common.h b/gisi/common.h index 83a8cf5..c78f893 100644 --- a/gisi/common.h +++ b/gisi/common.h @@ -26,6 +26,8 @@  extern C {  #endif

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

Hi Andreas, 2011/2/3 Andreas WESTIN andreas.wes...@stericsson.com: I don't see what that has to do with the device supporting the PC suite USB profile, which allows modem access using cdc_phonet. Currently our platform does not support this. Well, I know of platforms that do, and have

[PATCH 1/2 v2] netreg: Add CPHS CSP implementation

--- src/network.c | 122 1 files changed, 96 insertions(+), 26 deletions(-) diff --git a/src/network.c b/src/network.c index bf61472..07f9cdf 100644 --- a/src/network.c +++ b/src/network.c @@ -42,7 +42,8 @@ enum

Re: [PATCH 1/2] isimodem: fix problems in call state reporting

Hi Pekka, 2011/2/2 pekka.pe...@nokia.com: From: Pekka Pessi pekka.pe...@nokia.com Do not report early incoming calls. Report disconnected state separately. Call ofono_voicecall_disconnected() only after call id is released. ---  drivers/isimodem/voicecall.c |   84

[PATCH 3/6] util: Add best dialect picker API

--- src/util.c | 64 src/util.h |7 ++ 2 files changed, 71 insertions(+), 0 deletions(-) diff --git a/src/util.c b/src/util.c index 547f38c..e1e8a0a 100644 --- a/src/util.c +++ b/src/util.c @@ -788,6 +788,70 @@ unsigned char

[PATCH 2/2] TODO: Remove completed CPHS CSP task

in the netreg atom. Also to accommodate this, there - probably needs to be a new 'forced' mode to indicate that manual network - selection is disabled. - - Priority: Medium - Complexity: C1 - Owner: Aki Niemi aki.ni...@nokia.com - - Support SIM authentication: SIM and AKA suites. Priority

[PATCH 1/2] netreg: Add CPHS CSP implementation

--- src/network.c | 121 1 files changed, 95 insertions(+), 26 deletions(-) diff --git a/src/network.c b/src/network.c index bf61472..ef0b37f 100644 --- a/src/network.c +++ b/src/network.c @@ -42,7 +42,8 @@ enum

Re: [PATCH 1/2] netreg: Add CPHS CSP implementation

Hi Denis, 2011/2/3 Denis Kenzior denk...@gmail.com: +     if (netreg-mode == NETWORK_REGISTRATION_MODE_AUTO_ONLY) +             return NULL; + So we might just return access_denied here as well. There is a reason for allowing this, namely that sometimes you want to re-run the logic for

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

On Wed, 2011-02-02 at 10:03 +0100, ext Andreas WESTIN wrote: On 2011-02-01 20:32, Aki Niemi wrote: Like I replied earlier, I don't see the need for this. Also, it will not work well with the isiusb plugin, which has the potential to work with any ISI modem. I'm not willing to break

Re: [PATCH] Phonesim HACKING updated to refer to phonesim.conf instead of modem.conf.

Hi Essi, 2011/2/1 Essi Vehmersalo essi.vehmers...@nokia.com: -automatically includes this option. +automatically includes this option. See phonesim.conf sample configuration +under ofono/plugins on how to configure oFono to use phonesim.   Run phonesim in foreground using the following

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

Hi Marcel, On Tue, 2011-02-01 at 16:43 +0100, ext Marcel Holtmann wrote: +enum isi_version { + ISI_20 = 0, + ISI_25 = 1 +}; so what is the final decision here now. ISI doing auto-detection and this gets not exposed to the modem drivers or we do. Like I replied earlier, I don't

Re: [PATCH] TODO: SMS Validity Period

Hi Marcel, 2011/1/31 Marcel Holtmann mar...@holtmann.org: How does a normal user actually know what this means for him and the network he is using? Is the network actually honoring these values at all these days? These are not clear to me either, so I don't see the point in exposing this

[RFC 0/6] Add configuration support via main.conf

Hi all, This set of patches adds support for oFono configuration settings via main.conf. First three add the file and routines for parsing that file; the following three take a parameter in the sms atom and makes it configurable. Cheers, Aki ___ ofono

[RFC 6/6] sms: Use main configuration for 16bit ref number

--- src/sms.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/sms.c b/src/sms.c index 7224bdf..48d2d81 100644 --- a/src/sms.c +++ b/src/sms.c @@ -842,7 +842,6 @@ static DBusMessage *sms_send_message(DBusConnection *conn, DBusMessage *msg, GSList *msg_list;

[RFC 4/6] conf: Add ref number setting for MessageManager

--- src/main.conf |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/main.conf b/src/main.conf index facb950..0b23998 100644 --- a/src/main.conf +++ b/src/main.conf @@ -2,3 +2,9 @@ # List of plugins that should not be loaded on oFono startup #DisablePlugins = +

[RFC 3/6] build: Add main.conf to the build

--- Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index f941a19..02ea2cb 100644 --- a/Makefile.am +++ b/Makefile.am @@ -35,7 +35,7 @@ endif confdir = $(sysconfdir)/ofono -conf_DATA = +conf_DATA = src/main.conf statedir =

[PATCH 0/4] Add support for CPHS customer service profile

Hi all, This series adds support for CPHS CSP PLMN mode into the netreg atom. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 0/4] Add support for CPHS customer service profile

Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: one open question here is still if we also have to disallow scanning when this is set? So we might wanna update the Scan() and Register() method with the proper error codes and put a note in there for mode = auto-only. Good point,

Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: diff --git a/src/network.c b/src/network.c index b5450ee..64734d0 100644 --- a/src/network.c +++ b/src/network.c @@ -64,6 +64,7 @@ struct ofono_netreg {       int cellid;       int technology;       int mode; +     gboolean

Re: [PATCH 0/4] Add support for CPHS customer service profile

Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: one open question here is still if we also have to disallow scanning when this is set? So we might wanna update the Scan() and Register() method with the proper error codes and put a note in there for mode = auto-only. Good

Re: [gprs-provision RFCPATCHv6 0/4] Plugin API for provisioning of GPRS context settings

Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: lets get this merged without support for SPN for now. We can easily add this later. So please fix Denis' comments and re-submit this without the SPN change. Andrew is currently looking into fixing the SIM reading race. Once that is

Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: That is how I originally had it, but this ends up being a bit less code. Also, I'd like to localize all of these constant strings into a single function and not sprinkle them across the code. so I am counting two callers to

Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: can you have a stab at this and check how a patch would look like if we just add another mode. If I am not mistaken we only have the extra code in the init_registration_status. I could be wrong here since I have not looked through that

Re: [PATCH 1/1] isimodem: Adding version isimodem and isimodem2.5

Hi, 2011/1/25 Marcel Holtmann mar...@holtmann.org: +enum isi_version { +     ISI_20 = 0, +     ISI_25 = 1 +}; + If we follow the same layout as with all other modem drivers, then the *modem.h should only contain the prototypes for the init callbacks.  extern struct ofono_modem

Re: [PATCH 1/1] isimodem: Adding version isimodem and isimodem2.5

Hi Marcel, 2011/1/25 Marcel Holtmann mar...@holtmann.org: So this clearly then is not suppose to be in isimodem.h and while at it, someone might wanna cleanup isi_modem_by_interface and move it to a better location. Done. Moved it to /dev/null. ;-) Cheers, Aki

Re: SAT support in oFono

Hi Lasse, 2011/1/24 Lasse Kunnasluoto lasse.kunnaslu...@tieto.com: Let us set aside the the merits of the use cases for these features for the moment ;)  Implementing Call control by USIM is fairly straightforward to do in the core.  However, no modem manufacturer currently allows us to have

Re: [PATCH 1/6] gprs-provision: add driver API header

Hi Jukka, 2011/1/24 Jukka Saunamaki jukka.saunam...@nokia.com: Then how about something like this: Lets make provisioning API synchronous (so that plugins do not need to care about SIM or other safety). In stead, if in gprs atom ofono_gprs_register() we notice the need for provisioning,  

Re: [PATCH 1/6] gprs-provision: add driver API header

Hi Denis, 2011/1/21 Denis Kenzior denk...@gmail.com: How exactly are you guaranteeing that 'nothing bad should happen'? There is no cancellation mechanism that I see.  Not to mention that the current ofono_sim_read API is not even safe either.  For exactly the same reasons. This is a problem

Re: [PATCH] isimodem: fix issue with user busy release

Hi Jeevaka, 2011/1/21 Jeevaka Badrappan jeevaka.badrap...@elektrobit.com: when the user rejects the incoming call, hangup_active will get called on the driver side whereas when the user rejects the waiting call, set_udub will get called on the driver side. ---  drivers/isimodem/voicecall.c

Re: [PATCH] isimodem: fix sending DTMF

Hi Kai, 2011/1/20 Kai Vehmanen kai.vehma...@nokia.com: isi_call_dtmf_send_resp() handles the success case incorrectly, and thus all send_tones attempts fail with bogus error codes. ---  drivers/isimodem/voicecall.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) Patch has been

Re: [PATCH 5/6] GPRS: document bearer property

Hi Rémi, 2011/1/19 Rémi Denis-Courmont remi.denis-courm...@nokia.com: ---  doc/connman-api.txt |   10 ++  1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/connman-api.txt b/doc/connman-api.txt index 22e02e5..13f622c 100644 --- a/doc/connman-api.txt +++

Re: [RFC] TODO: Move signal strength property to separate Agent API.

Hi Marcel, 2011/1/20 Marcel Holtmann mar...@holtmann.org: I don't think is needed. You do not get woken up until you tell D-Bus to wake you up on that PropertyChanged signal. You can even match the first parameter of that signal if you desire. I think this is still a worthy optimization,

[PATCH] core: Always return success to a no-op

A SetProperty that doesn't actually change the Online property's state when no change to that state is pending, should not fail. It should always succeed regardless of the current modem state. --- src/modem.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 3/5 v3] nettime: DBUS and compilation configuration

Hi Marcel, 2011/1/18 Marcel Holtmann mar...@holtmann.org: please don't implement org.ofono interface in timed. Just implement a timed specific (com.nokia.time) interface and punch the whole for that in the timed D-Bus policy. I think there is some disconnect here. The intention is to

[PATCH] voicecall: Fix emergency number handling

If the SIM is present but doesn't contain any emergency numbers, the set of emergency numbers needs to be reset to the default list. This patch fixes the list shown in the SIM present case by removing numbers from the list that are for the no-SIM case only. --- src/voicecall.c | 19

Re: [PATCH] voicecall: Fix emergency number handling

Self, 2011/1/19 Aki Niemi aki.ni...@nokia.com: @@ -2095,11 +2095,11 @@ static void ecc_g2_read_cb(int ok, int total_length, int record,        DBG(%d, ok);        if (!ok) -               return; +               goto check;        if (total_length 3) {                ofono_error

[PATCHv2] voicecall: Fix emergency number handling

If the SIM is present but doesn't contain any emergency numbers, the set of emergency numbers needs to be reset to the default list. This patch fixes the list shown in the SIM present case by removing numbers from the list any ENs that are for the no-SIM case only. --- src/voicecall.c |7

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

Hi Denis, 2011/1/18 Denis Kenzior denk...@gmail.com: I'm fine with forced-auto, but we might want to add a new error type to ofono.h (maybe something like ManualRegistrationNotAllowed) and return that error when trying to use Scan or NetworkOperator.Register. I was reusing the

[PATCH 0/6] Deprecate the Deregister() method

Hi All, This set of patches removes the Deregister() method from the netreg atom. This method serves no purpose, since the Online property is used to control oFono's radio on/off state. Cheers, Aki ___ ofono mailing list ofono@ofono.org

[PATCH 2/6] isimodem: Remove deregister implementation

--- drivers/isimodem/network-registration.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/isimodem/network-registration.c b/drivers/isimodem/network-registration.c index 47aaeb1..6518968 100644 --- a/drivers/isimodem/network-registration.c +++

[PATCH 1/6] netreg: Deprecate the deregister method

--- src/network.c | 37 ++--- 1 files changed, 2 insertions(+), 35 deletions(-) diff --git a/src/network.c b/src/network.c index ae0f334..1f66f34 100644 --- a/src/network.c +++ b/src/network.c @@ -43,8 +43,6 @@ enum network_registration_mode {

[PATCH 4/6] api: Remove deregister from modem driver API

--- include/netreg.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/netreg.h b/include/netreg.h index a88301d..26a3442 100644 --- a/include/netreg.h +++ b/include/netreg.h @@ -84,8 +84,6 @@ struct ofono_netreg_driver { void (*register_manual)(struct

[PATCH 3/6] atmodem: Remove deregister implementation

--- drivers/atmodem/network-registration.c | 20 1 files changed, 0 insertions(+), 20 deletions(-) diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c index e11c974..4b8cc34 100644 --- a/drivers/atmodem/network-registration.c +++

[PATCH 6/6] test: Remove deregister support from test script

--- test/test-network-registration |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/test/test-network-registration b/test/test-network-registration index a8bd141..0c25885 100755 --- a/test/test-network-registration +++ b/test/test-network-registration @@ -18,8 +18,6

[PATCH 5/6] doc: Remove deregister method documentation

--- doc/network-api.txt |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/doc/network-api.txt b/doc/network-api.txt index 3e705e6..75187cd 100644 --- a/doc/network-api.txt +++ b/doc/network-api.txt @@ -30,12 +30,6 @@ Methods dict GetProperties()

[PATCH 1/5] simutil: Add EFcsp file and service group IDs

--- src/simutil.h | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 7e386fa..61440a5 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -26,6 +26,7 @@ enum sim_fileid { SIM_EFLI_FILEID =

[PATCH 0/5] Implement CPHS CSP support

engine. ;) Aki Niemi (5): simutil: Add EFcsp file and service group IDs netreg: Add CPHS CSP PLMN mode implementation doc: Add documentation for 'forced-mode' doc: Add short mention of CPHS under standards TODO: Remove completed CPHS CSP task TODO| 13 doc

[PATCH 2/5] netreg: Add CPHS CSP PLMN mode implementation

--- src/network.c | 85 - 1 files changed, 84 insertions(+), 1 deletions(-) diff --git a/src/network.c b/src/network.c index ae0f334..927f7ce 100644 --- a/src/network.c +++ b/src/network.c @@ -66,6 +66,7 @@ struct ofono_netreg {

[PATCH 4/5] doc: Add short mention of CPHS under standards

--- doc/standards.txt |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/doc/standards.txt b/doc/standards.txt index 2b85cb0..35f2a3a 100644 --- a/doc/standards.txt +++ b/doc/standards.txt @@ -166,3 +166,12 @@ Describes the general background and assumption of

  1   2   3   >