Hi Lars,
On 8/17/20 2:58 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
The Quectel EC21 modem does not understand the AT+CPSB command, and we
did not find a suitable replacement in the
Quectel_EC25_AT_Commands_Manual_V1.3.pdf
AT+CPSB gives an error on this modem, so we just skip it.
---
Hi Lars,
On 8/13/20 8:33 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
The Quectel EC21 modem does not understand the AT+CPSB command, so
aquire the current packet switched bearer from quectel proprietary
QIND:"act" URC.
---
drivers/atmodem/gprs.c | 49
Hi Lars,
oFono driver interface is based on 27.007. So that means values defined in
27.007 do not need to be 'converted'. You can simply feed them in directly
if they follow 27.007.
Well, yes. I saw this. But unfortunately at this point what is expected
are the 27.007 values from AT+CPSB
Hi Lars,
On 8/11/20 6:42 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
The Quectel EC21 modem does not understand the AT+CPSB command, so
aquire the current packet switched bearer from CGREG URC.
---
drivers/atmodem/gprs.c | 32 ++--
1 file changed, 30
Hi Lars,
On 8/11/20 6:42 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
The distinction between OFONO_VENDOR_QUECTEL and
OFONO_VENDOR_QUECTEL_SERIAL does not suffice for EC21/EC25 in some
places, so introduce and use a new vendor:
OFONO_VENDOR_QUECTEL_EC2X
---
drivers/atmodem/sim.c
Hi Lars,
On 8/4/20 7:38 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
As there are some more sources of +QIND: activated, do now only update
voltage when we get the
+QIND: "vbatt",-1
but not on things like
+QIND: "act","LTE"
or
+QIND: "csq",20,99
---
plugins/quectel.c | 8 +---
1
Hi Lars,
On 8/4/20 7:38 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
Set the URC port of the Quectel EC21 to uart1 when it is used through
it's serial port. This setting is saved to non-volatile storage by the
modem automatically.
---
plugins/quectel.c | 6 --
1 file changed, 4
Hi Lars,
On 8/4/20 7:38 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
The distinction between OFONO_VENDOR_QUECTEL and
OFONO_VENDOR_QUECTEL_SERIAL does not suffice for EC21/EC25 in some
places, so introduce and use a new vendor:
OFONO_VENDOR_QUECTEL_EC2X
---
drivers/atmodem/lte.c
Hi Lars,
On 8/4/20 6:56 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
This reverts commit 1868dbf2b3e5929a7081b03a8ff76d214fd38624.
Development for this was done on EC21 firmware version
EC21EFAR06A01M4G_BETA0318. It now turns out, that actual release
firmware versions for this modem
Hi JongSeok,
On 7/30/20 9:20 PM, JongSeok Won wrote:
To support cell type LTE, the value of PCI, TAC, SNR is added
---
include/netmon.h | 3 +++
src/netmon.c | 21 +
2 files changed, 24 insertions(+)
All three applied, thanks.
Regards,
-Denis
Hi Pavel,
On 7/31/20 5:07 AM, Pavel Machek wrote:
Hi!
I have problems with getting CNMA to work, so I'm exploring other
possibilities. Apparently ofono should be able to work without
that.. but is it working properly?
ofonod[5218]: < \r\n+CIEV: 1,3\r\n
ofonod[5218]: < \r\n+CIEV: 1,4\r\n
Hi Lars,
Unfortunately I must come back to this issue.
I got hands on a few new EC21s here and guess what ?
The mux order is back to the original one again. This means, the aux
channel has to be the second channel.
So I did a bit of investigation why and when this happened. But
information is
Hi JongSeok,
On 7/20/20 4:16 AM, JongSeok Won wrote:
Added the protocol type of initial attach apn depends on protocol
type in LTE Atom.
---
drivers/rilmodem/lte.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Applied, thanks.
Regards,
-Denis
Hi JongSeok,
On 7/20/20 3:40 AM, JongSeok Won wrote:
---
include/netmon.h | 3 +++
src/netmon.c | 24 +++-
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/include/netmon.h b/include/netmon.h
index a99d6ca9..53f9d393 100644
--- a/include/netmon.h
+++
Hi JongSeok,
On 7/20/20 2:34 AM, JongSeok Won wrote:
---
drivers/rilmodem/netmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to
Hi Sean,
On 7/11/20 7:04 AM, Sean Nyekjaer wrote:
---
plugins/udevng.c | 2 ++
1 file changed, 2 insertions(+)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org
Hi Martin,
On 7/10/20 2:55 AM, Martin Hundebøll wrote:
Hi Denis,
Did this patch (and Sean's original one from november) never reach the mailing
list?
Hmm, I don't recall seeing this one. Feel free to resend it and I can take it.
Regards,
-Denis
Hi Shweta,
On 7/6/20 2:39 PM, shweta wrote:
From: Shweta Jain
---
plugins/xmm7xxx.c | 445 +-
1 file changed, 444 insertions(+), 1 deletion(-)
So when I tried to apply this patch, I got:
Applying: xmm7xxx-enable-esim-feature-in-xmm
Hi Shweta,
On 7/6/20 2:39 PM, shweta wrote:
From: Shweta Jain
---
gatchat/gatresult.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied after re-wording the commit message slightly.
Regards,
-Denis
___
ofono mailing list --
Hi Sergey,
On 6/27/20 6:08 AM, Sergey Matyukevich wrote:
Hi all,
These two simple patches enable oFono support for ELS81x modem using
cdc_ether/cdc_acm drivers. As far as I know, new firmwares for ELS81x
enable support for MBIM as well. But I have not yet tried that.
Regards,
Sergey
Sergey
Hi Jimmy,
On 6/26/20 1:36 AM, Jimmy Gysens wrote:
Commit 6c574ee24a57d0397e4e3c617016bf026405960a ("huawei: the AT^SYSCFGEX
command supports additional modes") has a mistake for acqorder "0201". It
should be UMTS and GSM preferred.
---
drivers/huaweimodem/radio-settings.c | 4 ++--
1 file
Hi Jimmy,
On 6/25/20 4:30 AM, Jimmy Gysens wrote:
After a context is detached, the context is not properly cleared. In
addition to releasing the context:
- Reset the context settings (IP, DNS, interface, ...).
- Signal the Active flag as false.
---
src/gprs.c | 24
Hi Jimmy,
On 6/25/20 4:28 AM, Jimmy Gysens wrote:
Add a reset function to the modem driver. This function can be used to hard
reset the device. This is an alternative in case the (*enable) and
(*disable) functions are not supported.
I'm confused, how are you even powering the modem up if
Hi Jimmy,
On 6/25/20 4:28 AM, Jimmy Gysens wrote:
Huawei devices can have support for ^REJINFO unsolicited event. This event
provides useful info, regarding to the network attached state, for higher
level applications.
This commit adds an additional property RejectInfo to the PropertyChanged
Hi Jimmy,
On 6/25/20 4:29 AM, Jimmy Gysens wrote:
When initializing a Huawei device, send the AT command to restore the
default AT settings on device restart.
Huawei stores all APN settings, which can cause issues when changing the
APN. The AT command makes sure the device starts from a clean
Hi Jimmy,
On 6/25/20 4:29 AM, Jimmy Gysens wrote:
- LTE and UMTS preferred (acqorder = 0302);
AT^SYSCFGEX="0302",4000,2,4,4000
- UMTS and GSM preferred (acqorder = 0201);
AT^SYSCFGEX="0201",4000,2,4,4000
For AT^SYSCFG, the modes are not available.
---
Hi Jimmy,
On 6/25/20 4:29 AM, Jimmy Gysens wrote:
There are manufacturers, like Huawei, returning profile 0 as the minimum
PDP/EPS context ID. Profile 0, however, is the default profile used to
register to the LTE network. It contains manufacturer specific settings and
should not be created by
Hi Slava,
On 6/16/20 5:40 PM, Slava Monich wrote:
---
src/lte.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to
Hi Slava,
On 6/16/20 5:31 PM, Slava Monich wrote:
That does happen in real life.
---
src/smsutil.c | 23 +++
src/smsutil.h | 1 +
2 files changed, 16 insertions(+), 8 deletions(-)
Applied, thanks.
Regards,
-Denis
___
ofono
Hi Shweta,
On 6/11/20 2:06 AM, shweta wrote:
From: Shweta Jain
---
plugins/xmm7xxx.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
This patch does not apply cleanly. In fact, I see three distinct series from
you and it isn't clear in what order I would
Hi Shweta,
On 6/11/20 2:06 AM, shweta wrote:
From: Shweta Jain
Can you elaborate a bit more why this code is no longer needed? Also, how does
the driver now guarantee that +CUSATP will be received by the stk atom? I
believe this was originally added for those devices that didn't shut
Hi Christophe,
On 6/11/20 4:12 AM, Christophe Ronco wrote:
AT^SYSCFGEX must be used on LTE Huawei modems to enable LTE support.
But some modems (or firmwares?) do not support this command and AT^SYSCFG
must be used to get/set radio settings.
This has been introduced in commit:
Hi Tony,
All we need to do with the TS 27.010 packets is parse the network
strength, operate the voice modem, ack SMS notifications, and pass all
the other notifications to the qmimodem to deal with over USB.
To me it seems ideal would be simple read/write type functions in
Hi Marius,
On 6/10/20 8:44 AM, Marius Gripsgard wrote:
This implements data capability bearer notify to qmi modem.
Since this is included in the serving system response this
just adds a new data extraction for dc.
---
drivers/qmimodem/gprs.c | 27 +++
Hi Marius,
On 6/9/20 3:21 PM, Marius Gripsgard wrote:
This implements data capability bearer notify to qmi modem.
Since this is included in the serving system response this
just adds a new data extraction for dc.
---
drivers/qmimodem/gprs.c | 29 +
Hi Pavel,
On 6/8/20 6:59 PM, Pavel Machek wrote:
Hi!
I'd really like to get support for Droid 4 modem... unfortunately it
is quite special. Few words about Droid 4 modem protocol:
I'm not sure what is the best way to support it. I was not able to get
atchat.c to work with it (and I
Hi Pavel,
On 5/19/20 3:50 AM, Pavel Machek wrote:
Hi!
In doc/sim-api.txt, there are some properties marked read/write, but I
don't see documented way to change those properties. Someone may want
to fix that up.
Ah thanks for pointing this out. Should now be fixed upstream by commit
Hi Lars,
On 5/29/20 7:43 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
The Quectel EC21 does only work correctly, if the mux channel used for
aux is the first mux channel. It does only put it's URC messages in the
first mux channel, so this has to be the aux channel in our case.
To be
Hi Lars,
On 5/28/20 4:32 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
The Quectel EC21 does only work correctly, if the mux channel used for
aux is the first mux channel. It does only put it's URC messages in the
first mux channel, so this has to be the aux channel in our case.
To be
Hi Lars,
On 5/26/20 5:16 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
The Quectel EC21 does only work correctly, if the mux channel used for
aux is the first mux channel. It does only put it's URC messages in the
first mux channel, so this has to be the aux channel in our case.
---
Hi Lars,
On 5/26/20 5:16 AM, poesc...@lemonage.de wrote:
From: Lars Poeschel
This patchset adds support for the quectel EC21 LTE modem connected
through its serial port.
Lars Poeschel (7):
quectel: Add Quectel EC21 to known serial modems
quectel: use lte atom on EC21
quectel: Query
Hi,
On 4/5/20 6:26 AM, JongSeok Won wrote:
oFono cannot determines the call of direction when the voicecall
is triggered in rilmodem
---
drivers/rilmodem/voicecall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Regards,
-Denis
Hi Tarmo,
Once a proper database is used, this mostly goes away as an issue. We
did add the SPN field to MBPI schema in the olden days. The problem
is that nobody actually updated the MBPI database to take advantage of
this.
Hmm, maybe my memory is faulty (it has been ~9 years now), but I
Hi Tarmo,
I don't see how am I going to solve this. The end user cannot configure
the device (there's no user interaction whatsoever). I could not find
the mythical Android database at the time (I do now - it's at
Hi Mattias,
On 3/11/20 7:46 AM, mattias.mans...@verisure.com wrote:
We are writing a ofono driver/plugin for a new Quectel modem based on a qualcomm chipset.
This modem has a wwan interface that needs to be "connected" after the context
is activated, partially to allow the host to run dhcp.
Hi,
In my case automatic provisioning always fails:
- the database has multiple entries for basically every operator/country
mbpi is just not a very good database. It provides lots of duplicates
and doesn't distinguish by spn last I checked. Ubuntu Touch folks used
the android apndb and
Hi Nicola,
No top posting please.
On 3/4/20 11:00 AM, nick83ola wrote:
Hi Giacinto,
We have a web application that is talking to connman and ofono over dbus.
We present the user with the list and once is connected to a profile
connman remembers
it so if I connect again the same modem connman
Hi Nicola,
On 3/2/20 10:31 AM, Nicola Lunghi wrote:
if the mobile provider information database has multiple apn settings for the
same operator, ofono was throwing an error and creating a default internet
context with an empty apn.
This patch will instead allow the automatic creation of
Hi Joey,
On 3/4/20 1:16 AM, j...@joeyhewitt.com wrote:
dbus_validate_path() is used several times. dbus's NEWS says it was
added in 1.5.12.
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Regards,
-Denis
Hi Richard,
On 2/18/20 3:19 AM, Richard Röjfors wrote:
Hi,
Ofono (at least for ublox) is always powering off the radio during start.
This can of course be handy of programmatic reasons to bring the modem
to a known state.
Some configuration requires the radio to be turned off; for instance
Hi Richard,
On 2/14/20 3:06 AM, richard.rojf...@gmail.com wrote:
From: Richard Röjfors
In the case a unsolicited indication for UREG was received
while the status was polled. The poll response failed to parse.
This since the unsolicited indication only carries one
parameter, while the poll
Hi Pali,
On 2/13/20 12:32 PM, Pali Rohár wrote:
At the time this was all done in software.
CVSD was never done in software. Always in hardware. As said, even now I
was not able to find bluetooth HW which would allow to do CVSD in software.
I don't remember the exact details. I seem to
Hi Pali,
Used by who? Gateway role is fully broken and client (hfp) role is used
I guess that depends on your perspective. I've already pointed out that
the desktop 'AG' use case was never something we needed to implement.
If you want to fix oFono to do that, great. If you want to write
Hi Pali,
On 1/8/20 3:25 PM, Pali Rohár wrote:
Hello!
Somehow this went straight to my Junk folder, so I didn't see this
message at all until now.
Audio application (e.g. pulseaudio) really do not want to handle two
separate services to monitor and process HSP/HFP devices. >
For audio
Hi,
Additionnal informations:
versions:
```
# ofonod -v
1.24
The 'none' authentication method type was added in oFono 1.26. So your
version is a bit outdated.
Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email
this down for you.
Regards,
-Denis
>From 8e78d4dba5d54b4b1175a53973ceb6f829c22bfa Mon Sep 17 00:00:00 2001
From: Denis Kenzior
Date: Fri, 7 Feb 2020 11:06:32 -0600
Subject: [PATCH] allowed-apns: Do not try to unregister unnecessarily
allowed-apns plugin will try to uregis
Hi Richard,
On 2/4/20 6:21 AM, richard.rojf...@gmail.com wrote:
From: Richard Röjfors
Instead of implementing an own copy of requesting and parsing
CREG, reuse the existing one from at-modem.
---
drivers/ubloxmodem/network-registration.c | 40 +--
1 file changed, 16
Hi,
Sorry, I am still learning dbus command and syntax, can the
NetworkMonitor interface be run via
dbus-send?
It can... Using dbus-send is not too user-friendly though. I'd suggest
a UI based tool. Something like d-feet, or qdbusviewer.
dict entry(
Hi,
On 1/21/20 7:56 PM, JH wrote:
Hi,
I have been looking for getting RSRQ and RSRP values from ofono dbus
commands, but I could not find much information how to get RSRQ and
RSRP in debus-send commands, which following interface contains RSRQ
and RSRP? And how could I access thos RSRQ and
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org
Hi Pali,
Do you have a reasonable solution also for second issue?
HSP profile has always been a problem child. It isn't really all that
useful as a profile, and given how minimal it is, the right place for it
always seemed to be inside Pulse Audio itself. This is what Marcel & I
agreed
Hi Antara,
On 12/19/19 6:57 AM, Antara Borwankar wrote:
On XMM modems SIM is busy after PUK is entered. CME ERROR: 14
is received for AT+CPIN? query. Therefore polling for CPIN: READY
state.
---
drivers/atmodem/sim.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Hi Antara,
On 12/19/19 6:57 AM, Antara Borwankar wrote:
In case of error in sim_pin_query_cb function. pin_type is set
to -1. This is causing segmentation fault in function
sim_passwd_name due to invalid index pin_type = -1. Fixing this
issue by handling error case before calling
Hi Antara,
On 12/19/19 6:56 AM, Antara Borwankar wrote:
+XSIM:7 state as defined in xmm7560 functional AT specification
only indicates ready for attach.
+CPIN: READY is received after SIM is completely initialized.
Also indicating readiness of Phonebook and SMS. Hence moving the
creation of
Hi Antara,
On 12/16/19 4:37 AM, Antara Borwankar wrote:
+XSIM:7 state as defined in xmm7560 functional AT specification
Is this different compared to earlier models?
only indicates ready for attach. PB ready and SMS ready has to be
quired seperately using +XSIMSTATE command after +XSIM:12
Hi Richard,
On 12/11/19 1:13 PM, richard.rojf...@gmail.com wrote:
From: Richard Röjfors
To be considered attached on LTE a context should be activated.
But in case the context got deactivated we did not update
the attached state, it remained attached.
That caused the connection manager to try
Hi Richard,
On 12/10/19 6:58 AM, richard.rojf...@gmail.com wrote:
From: Richard Röjfors
Applied, thanks.
Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org
Hi Jimmy,
On 11/19/19 4:53 AM, Jimmy Gysens wrote:
Hi,
After unplugging a Huawei USB dongle, the 'atoms' in oFono are removed via
'flush_atoms'.
Every atom has a destruct function pointer, used as a - yes - destructor.
When unplugging a dongle, connected via PPP, oFono will remove the
Hi David,
On 11/17/19 4:03 PM, David Lechner wrote:
This sets the executable bit on the only two files in the test directory
that do not already have it set.
---
test/set-sms-alphabet | 0
test/test-serving-cell-info | 0
2 files changed, 0 insertions(+), 0 deletions(-)
mode change
Hi Jonah,
On 11/12/19 3:37 PM, Jonah Brüchert wrote:
* Allows us to notice when a function becomes source incompatible in a Qt major
release,
and our implementation stops overriding.
---
src/aidapplication.cpp | 3 ++-
src/aidapplication.h| 4 ++--
src/callmanager.h
Hi Jonah,
On 11/12/19 3:37 PM, Jonah Brüchert wrote:
Done using the modernize-use-bool-literals of clang-tidy
---
src/qsmsmessage.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
Hi Jonah,
On 11/12/19 3:37 PM, Jonah Brüchert wrote:
Done using the cppcoreguidelines-pro-type-cstyle-cast check of clang-tidy
---
src/aidapplication.cpp | 2 +-
src/phonesim.cpp | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
Regards,
-Denis
Hi Jonah,
On 11/12/19 3:37 PM, Jonah Brüchert wrote:
Done using the google-readability-casting check of clang-tidy
---
src/callmanager.cpp | 6 +-
src/hardwaremanipulator.cpp | 12 +-
src/phonesim.cpp | 62 +++---
src/qatresult.cpp| 10 +-
Hi Jonah,
On 11/12/19 3:37 PM, Jonah Brüchert wrote:
---
configure.ac| 2 +-
src/control.cpp | 18 +-
src/control.h | 4 ++--
3 files changed, 12 insertions(+), 12 deletions(-)
Patches 4-9 applied, thanks.
Regards,
-Denis
Hi Jonah,
On 11/12/19 3:37 PM, Jonah Brüchert wrote:
* Update CXX Standard to 14 to be able to use qOverload()
---
configure.ac| 4 +--
src/callmanager.cpp | 22 ++---
src/control.cpp | 77 +
src/phonesim.cpp| 56
Hi Jonah,
On 11/12/19 3:37 PM, Jonah Brüchert wrote:
Done using the modernize-use-nullptr check of clang-tidy
---
src/aidapplication.h | 2 +-
src/callmanager.h | 2 +-
src/conformancesimapplication.cpp | 2 +-
src/control.cpp | 2 +-
Hi Jonah,
No top posting please :)
On 11/7/19 4:26 AM, Jonah Brüchert wrote:
Hi Denis,
Thank you very much for applying the patches!
As mentioned earlier I have worked on a few additional commits to
completely replace all deprecated Qt APIs.
This is not strictly required until Qt6 is
Hi Jonah,
On 10/30/19 3:37 PM, Jonah Brüchert wrote:
From: Simon Busch
Co-authored-by: Martin Jansa
Co-authored-by: Jonah Brüchert
Co-authored-by: Alexander Akulich
---
Makefile.am | 4 +++-
configure.ac| 15 ---
src/control.cpp | 4 ++--
Hi Jonah,
On 10/29/19 11:58 AM, Jonah Brüchert wrote:
Hi,
first of all, thanks for the review!
The current structure of the commits is purely for historical reasons,
since this is a collection of patches by different people that are all
required for the Qt5 port. The Signed-off-by exist for
Hi Jonah,
On 10/27/19 11:30 AM, Jonah Brüchert wrote:
From: Simon Busch
Signed-off-by: Simon Busch
Signed-off-by: Martin Jansa
We don't use Signed-off-by, so please drop this in the future.
---
Makefile.am | 2 +-
configure.ac| 6 +++---
src/control.cpp | 4 ++--
Hi Antara,
On 10/14/19 11:50 PM, Antara Borwankar wrote:
Earlier SMS atom was being created based on +XSIMSTATE command,
which is a proprietary command for intel modems.
But this logic fails in case of SIM hot swap when +XSIMSTATE
value received is not handled in notify function.
Which value
Hi Richard,
On 10/1/19 3:10 PM, richard.rojf...@gmail.com wrote:
From: Richard Röjfors
There was a race condition where a context might be
registered before the netreg status updates to LTE.
The code took for granted the context is activated after
the technology update. With this change, any
Hi Martin,
On 10/7/19 4:39 PM, Martin Hundebøll wrote:
The in-kernel implementation of gsm0710 causes deadlocks in the
kernel[1], so switch the default back to the user-space implementation
in ofono.
The change also removes the timeout-callback used to defer disabling the
n_gsm line
Hi Martin,
On 10/7/19 4:39 PM, Martin Hundebøll wrote:
Use at_util_sim_state_query_new() to query the sim inserted state. Once
that returns, the locked state is queried by issuing a AT+CPIN? command.
If not locked, a timer is started to query the quectel init status of
the sim. Once the init
Hi Martin,
On 10/8/19 1:44 PM, Martin Hundebøll wrote:
With the reference in place in received_data(), the address sanitizer
now encounters a use-after-free when the destroy notification is
dispatched for the read watcher (see below).
Fix this by remove the destroy notification callback, as it
Hi Martin,
On 10/8/19 1:44 PM, Martin Hundebøll wrote:
When closing down a cmux object, the address sanitizer detects a
use-after-free in gatmux.c (see below).
Avoid this by taking a reference to the mux object during the processing
in received_data().
Applied, thanks.
Regards,
-Denis
Hi Martin,
I'm afraid this isn't enough, as I still get use-after-free when
using gatmux in the quectel plugin (see attached log).
That buffer size check is a bit dubious and should never happen in
practice, it is also something that one cannot recover from if the
condition does get hit. I
Hi Martin,
@@ -646,13 +653,6 @@ void g_at_mux_unref(GAtMux *mux)
}
}
-static void read_watcher_destroy_notify(gpointer user_data)
-{
- GAtMux *mux = user_data;
-
- mux->read_watch = 0;
-}
-
gboolean g_at_mux_start(GAtMux *mux)
{
if (mux->channel == NULL)
@@
Hi Martin,
On 10/7/19 1:37 PM, Martin Hundebøll wrote:
Why not do something like:
g_at_mux_ref(mux);
for (i = 1; i <= MAX_CHANNELS && !mux->shutdown; i++) {
int offset = i / 8;
int bit = i % 8;
Hi Richard,
This is strange.
I use gmail smtps, but to check if they tamper with the emails,
I cloned a fresh ofono and ran git am and pasted my email,
it did work(?).
Not sure. I've been using the same process for >10 years now and other
patches obtained the same day worked fine. What
Hi Richard,
On 9/30/19 2:04 PM, richard.rojf...@gmail.com wrote:
From: Richard Röjfors
It turns out that both L2xx and L4xx modems are a bit
buggy when it comes to send CREG URC's when the tech changes.
Try to overcome this by subscribing to both UREG and CREG,
and poll the other when any of
Hi Martin,
@@ -227,12 +227,15 @@ static void dispatch_sources(GAtMuxChannel *channel,
GIOCondition condition)
static gboolean received_data(GIOChannel *channel, GIOCondition cond,
gpointer data)
{
- GAtMux *mux = data;
+
Hi Martin,
So I wonder whether instead of fully reverting back to CMUX (only to
put in n_gsm in later) you might want to just keep both around and use
a /etc/quectel.conf or OFONO_QUECTEL_MUX=n_gsm|internal instead?
I'd prefer a single method to keep the needed testing to a minimum.
I
Hi Richard,
On 9/29/19 2:39 PM, richard.rojf...@gmail.com wrote:
From: Richard Röjfors
It turns out that both L2xx and L4xx modems are a bit
buggy when it comes to send CREG URC's when the tech changes.
Try to overcome this by subscribing to both UREG and CREG,
and poll the other when any of
Hi Antara,
On 9/27/19 12:51 AM, Antara Borwankar wrote:
Adding support for enumerating PCIe types of modems in ofono
---
plugins/udevng.c | 178 +--
1 file changed, 135 insertions(+), 43 deletions(-)
+static struct {
I made this
Hi Antara,
On 9/27/19 1:46 AM, Antara Borwankar wrote:
Added handling for cid 0 in +CGDCONT callback.
---
drivers/atmodem/gprs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
index 16f4927..defbba0 100644
---
Hi Martin,
My theory is this:
* The main loop has (at least) two pending sources:
1) a gatchat callback to e.g. a plugin CFUN=0 command
2) rx data ready on the cmux uart channel
* The main loop calls the plugin callback first, where g_at_mux_unref()
is called
* The main
Hi Antara,
@@ -1612,16 +1631,8 @@ static void add_device(const char *syspath, const char
*devname,
if (devpath == NULL)
return;
- devnode = udev_device_get_devnode(device);
- if (devnode == NULL) {
- devnode =
Hi Antara,
On 9/26/19 4:46 AM, Borwankar, Antara wrote:
Hi Denis,
Regarding your below query
- Can you tell me why this new addition uses vid/pid with a 0x prefix while the
rest of the table does not? It seems weird & inconsistent.
Actually in case of pci device vendor and device id read
Hi Martin,
On 9/26/19 2:27 PM, Martin Hundebøll wrote:
The in-kernel implementation of gsm0710 causes deadlocks in the
kernel[1], so switch back to the user-space implementation in ofono.
[1]
https://lore.kernel.org/lkml/4b2455c0-25ba-0187-6df6-c63b4ccc6...@geanix.com/
---
plugins/quectel.c
101 - 200 of 3897 matches
Mail list logo
