Re: [PATCH] TODO: Add CDMA Voicecall Support Tasks

Hi Dara, On 12/02/2010 04:55 PM, Dara Spieker-Doyle wrote: --- TODO | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) Patch looks good to me, however it does not apply: fatal: cannot convert from unknown-8bit to UTF-8

Re: [PATCH 2/5] cdma-voicecall: Add CDMA MO Call Support

Hi Dara, If not, then using an enum defined in include/cdma-voicecall.h would be better. One major benefit of defining a dedicated enum for CDMA is the compiler checking that all enum values are being handled. If you re-use the GSM version you would have to resort to using default

RE: [PATCH 0/3] Attach GPRS on demand

Hi Denis, With these patches, GPRS context activation will cause oFono to automatically attempt GPRS attach if the modem is presently detached. Before I look at these patches: Have you considered fixing the attach behavior instead? I'm not quite sure what you mean here. There are

Re: [PATCH 1/5] cdma-voicecall: Add CDMA MO Call Support

Hi Dara, On 12/02/2010 05:31 PM, Dara Spieker-Doyle wrote: --- Makefile.am |2 +- include/cdma-voicecall.h | 82 ++ include/dbus.h |3 ++ include/types.h |8 4 files changed, 94 insertions(+),

Re: [PATCH 4/4] scripts: Added init.rc script

Hi Marcel, this is not an upstream oFono problem. This is package and distro specific. So I am not taking this patch. Fair enough, my mistake. Best Regards, Jessica ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] Fix test-sms build failure

Hi Leena, On 12/09/2010 01:18 AM, leena.gu...@wipro.com wrote: Fix for http://bugs.meego.com/show_bug.cgi?id=11081 --- unit/test-sms.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Patch looks fine, but does not apply due to mangling. Please update your MTA settings. In

Re: [PATCH 2/5] cdma-voicecall: Add CDMA MO Call Support

Hi Dara, On 12/02/2010 05:31 PM, Dara Spieker-Doyle wrote: --- Makefile.am |3 +- src/cdma-voicecall.c | 449 ++ src/common.c | 42 + src/common.h | 14 ++ src/ofono.h |3 + 5 files

Re: [PATCH 3/5] cdma-atmodem: Add CDMA MO Call Support

Hi Dara, On 12/02/2010 05:31 PM, Dara Spieker-Doyle wrote: --- Makefile.am |7 ++ configure.ac |5 + drivers/cdma-atmodem/atmodem.c | 47 + drivers/cdma-atmodem/atmodem.h | 26 + Lets call this cdmamodem/cdmamodem.[ch]

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

Hi Marcel, Please sync with Aki if it might not be better to do the vendor quirk system that we are using with atmodem. I am open here for suggestions and you guys have more experience in what can be shared and what is different. we will sync with Aki if there is a better way of

Re: [PATCH 4/5] cdmagen: Add CDMA MO Call Support

Hi Dara, On 12/02/2010 05:31 PM, Dara Spieker-Doyle wrote: --- Makefile.am |3 + plugins/cdmagen.c | 276 +++ plugins/ofono.rules |4 + I'd really prefer ofono.rules chunk to be in a separate patch plugins/udev.c |

Re: [PATCH 2/4]simutil: Changes to prepare for isimodem2.5

Hi Marcel, please write a proper commit message here. The subject is not acceptable since it misleads what this patch is doing. +#include types.h + What is this include for? Please remove it. So please be consistent with lower-case hex encoding. So 0x6f07 etc. Ok, fix commit

Re: [PATCH 0/3] Attach GPRS on demand

Hi Mika, On 12/09/2010 02:12 AM, mika.liljeb...@nokia.com wrote: Hi Denis, With these patches, GPRS context activation will cause oFono to automatically attempt GPRS attach if the modem is presently detached. Before I look at these patches: Have you considered fixing the attach

RE: [PATCH 0/3] Attach GPRS on demand

Hi Denis, I'm not quite sure what you mean here. There are many different cases, where the network can detach a UE from GPRS service. See possible detach causes in 24.008. Currently, oFono does not recover at all. Trying to figure out when GPRS is again available can get pretty

Re: [PATCH 0/3] Attach GPRS on demand

Hi Mika, On 12/09/2010 03:57 AM, mika.liljeb...@nokia.com wrote: Hi Denis, I'm not quite sure what you mean here. There are many different cases, where the network can detach a UE from GPRS service. See possible detach causes in 24.008. Currently, oFono does not recover at all. Trying

RE: [PATCH 0/3] Attach GPRS on demand

Hi Mika, I'm not quite sure what you mean here. There are many different cases, where the network can detach a UE from GPRS service. See possible detach causes in 24.008. Currently, oFono does not recover at all. Trying to figure out when GPRS is again available can get pretty

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

Hi Aki, The CBS topics set is simply not implemented in the current cbs driver. I suggest you create a patch for adding that into the current driver. And same for the clear_topics callback. Yes, I might be able to do that. I can not test it though, I haven't got any isimodem HW. I

RE: [PATCH 0/3] Attach GPRS on demand

Hi Denis, ConnMan really should not care whether we are attached or not. Why do you need a trigger in ConnMan, anyway? As far as I can see, a GPRS connection should only be activated if some client of ConnMan requests it. Actually it should care. We do safe-guard against attaching

RE: [PATCH 0/3] Attach GPRS on demand

Hi Marcel, so what about the cases when roaming is allowed or not? These needs to be taken into account and that is oFono's job. That is the reason why ConnMan follows the attach state. Since we don't wanna activate a context when roaming and data roaming is not allowed. Ok, I see the

RE: [PATCH 0/5] Call Counters (2nd)

Hi, On 09 Dec 2010, Marcel Holtmann wrote: - lots of modems still handle all audio and PA will know nothing about calls at all with these modems actually Denis raised the same question, but then again this is for a product specific requirement. And for that product we know that PA will

Re: [PATCH 0/3] Attach GPRS on demand

mika.liljeb...@nokia.com writes: Besides, ConnMan doesn't really work this way. Maybe in the future with the session API it would be able to, but not at the moment. I'll let Marcel explain this more if he wants too.. Admittedly, I haven't really looked at ConnMan. My assumption, though, is

[PATCH 2/6] huaweimodem: Add support for radio settings

--- Makefile.am |3 +- drivers/huaweimodem/huaweimodem.c|2 + drivers/huaweimodem/huaweimodem.h|3 + drivers/huaweimodem/radio-settings.c | 218 ++ 4 files changed, 225 insertions(+), 1 deletions(-) create mode 100644

[PATCH 3/6] huawei: Add support for radio settings

--- plugins/huawei.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 25dfaca..3c58c7f 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -43,6 +43,7 @@ #include ofono/gprs.h #include ofono/gprs-context.h #include

[PATCH 1/6] test: add scripts for setting frequency band

--- Makefile.am|4 +++- test/set-gsm-band | 25 + test/set-umts-band | 25 + 3 files changed, 53 insertions(+), 1 deletions(-) create mode 100755 test/set-gsm-band create mode 100755 test/set-umts-band diff --git a/Makefile.am

[PATCH 4/6] huaweimodem: cache mode in radio settings

Save the current and pending modes in radio_settings_data, so we can access them later. This patch also splits the parsing of ^SYSCFG response from the callback call. Then, it's possible to have more properties that use the same command as is the case of frequency band selection. ---

[PATCH 5/6] huaweimodem: always cache ^SYSCFG values when supported

When modem is supported, we need to cache the current values returned by ^SYSCFG command early on initialization. This will be used in future for frequency band selection that depends on the value of 'mode' property. --- drivers/huaweimodem/radio-settings.c | 21 - 1 files

[PATCH 6/6] huaweimodem: add frequency band selection support

--- drivers/huaweimodem/radio-settings.c | 172 - 1 files changed, 166 insertions(+), 6 deletions(-) diff --git a/drivers/huaweimodem/radio-settings.c b/drivers/huaweimodem/radio-settings.c index 1281d8b..d72a82c 100644 --- a/drivers/huaweimodem/radio-settings.c

Read/Write EFcfis/EFcphs-cff files-v3

Hi, This patch reads and writes the call forwarding unconditional status from and to the SIM depending on the SIM file availability. New property needs to be added due to the fact that number won't be available from the cphs-cff file. Incase of SIM, EFcphs-cff file holds call forwarding status

[PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff

--- src/call-forwarding.c | 256 - 1 files changed, 255 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index bb8aa37..085e638 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -34,6 +34,7

[PATCH 5/7] phonesim: Move call forwarding to post sim

--- plugins/phonesim.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/plugins/phonesim.c b/plugins/phonesim.c index c7ef0d7..b4795f2 100644 --- a/plugins/phonesim.c +++ b/plugins/phonesim.c @@ -635,6 +635,8 @@ static void phonesim_post_sim(struct ofono_modem *modem)

[PATCH 6/7] doc: Add new property to call forwarding

--- doc/call-forwarding-api.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/doc/call-forwarding-api.txt b/doc/call-forwarding-api.txt index 067531a..e8b4b9f 100644 --- a/doc/call-forwarding-api.txt +++ b/doc/call-forwarding-api.txt @@ -57,3 +57,8 @@ Properties

[PATCH 3/7] isigen: Move call forwarding to post sim

--- plugins/isigen.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c index 028f1b2..b7b7ab5 100644 --- a/plugins/isigen.c +++ b/plugins/isigen.c @@ -402,6 +402,7 @@ static void isigen_post_sim(struct ofono_modem *modem)

[PATCH 2/7] ifx: Move call forwarding to post sim

--- plugins/ifx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index 2f4c65b..48c985c 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -703,6 +703,7 @@ static void ifx_post_sim(struct ofono_modem *modem) ofono_stk_create(modem,

[PATCH 7/7] TODO: Marking the Read/Write EFcfis task as done

--- TODO |9 - doc/features.txt |5 + 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/TODO b/TODO index 8d771d6..45c3577 100644 --- a/TODO +++ b/TODO @@ -92,15 +92,6 @@ SMS SIM / SIM File system = -- Read / Write EFcfis. Call

RE: [PATCH 0/5] Call Counters (2nd)

Hi Kai, - lots of modems still handle all audio and PA will know nothing about calls at all with these modems actually Denis raised the same question, but then again this is for a product specific requirement. And for that product we know that PA will do the audio processing.

RE: [PATCH 0/5] Call Counters (2nd)

Hello Marcel, On 09 Dec 2010, Marcel Holtmann wrote: I share the concern for the IO/CPU cost, but I don't think it matters much in which daemon this is done. Especially if some slack is allowed for the timers (which should be the case), ofonod will be scheduled when the CPU is anyways woken

RE: [PATCH 0/5] Call Counters (2nd)

Hi Kai, I share the concern for the IO/CPU cost, but I don't think it matters much in which daemon this is done. Especially if some slack is allowed for the timers (which should be the case), ofonod will be scheduled when the CPU is anyways woken up (e.g. modem/audio interrupts wake up

Re: CAIF Protocol : oFono

Hi Sjur, We understand that CAIF is coming as kernel driver in linux 2.6.36. We are trying to write some test application which will make use of CAIF kernel driver to interact with ST-Ericsson Modem. When we connect any modem how OFono recognizes it? Is it based on rule mentioned in

Re: [RESEND PATCH] plugin: Add ste modem initd integration

Hi Sjur, This patch introduces auto discovery of ST-Ericsson modems. ST-Ericsson modems (M57XX, M7XX, M74XX) are managed by a Modem Init Daemon that is responsible for start/stop/restart flashing etc. This STE plugin monitors the modem state exposed from the Modem Init Damon Dbus API. When

Re: [RESEND PATCHv2 2/2] stemodem: Use RTNL to create network interfaces.

Hi Sjur, diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c index bfc0d65..21ca126 100644 --- a/drivers/stemodem/gprs-context.c +++ b/drivers/stemodem/gprs-context.c @@ -47,6 +47,7 @@ #include stemodem.h #include caif_socket.h #include if_caif.h +#include

Re: [PATCH] TODO: Add task for NITZ name support in netreg

Hi Denis, 2010/12/9 Denis Kenzior denk...@gmail.com: The NITZ notification does indeed arrive unsolicited.  However, no AT modem that I know of reports the received NITZ name.  This is only reported via COPS.  The best you can do is call COPS again after the driver reports

Initial support for Cinterion TC65 modem

This patch adds initial support for Cinterion TC65 type of modem. Cinterion TC65 doesn't always conform to the specifications and it is currently the only modem we are developing on, so it would be essential to have in oFono. Regards, Oskari Timperi

[PATCH] Add initial support for Cinterion TC65 modem

--- Makefile.am|3 + plugins/tc65.c | 279 2 files changed, 282 insertions(+), 0 deletions(-) create mode 100644 plugins/tc65.c diff --git a/Makefile.am b/Makefile.am index cdb3166..779df9b 100644 --- a/Makefile.am +++

[PATCH 0/4 v2] Network Time plugin

This series of patches introduces the network time part of the NITZ feature as outlined in 3GPP spec 22.042. The Network Time plugin has two DBUS interfaces for client applications: notification signal and polling method call. The time information consists of three dictionary entries: 1)

[PATCH 1/4 v2] plugins: Implementation of Network Time plugin

--- include/dbus.h|1 + plugins/nettime.c | 285 + 2 files changed, 286 insertions(+), 0 deletions(-) create mode 100644 plugins/nettime.c diff --git a/include/dbus.h b/include/dbus.h index 9e29afb..0c48f83 100644 --- a/include/dbus.h

[PATCH 3/4 v2] plugins: Test scripts for nettime plugin

--- test/get-nettime | 25 + test/test-nettime | 46 ++ 2 files changed, 71 insertions(+), 0 deletions(-) create mode 100755 test/get-nettime create mode 100755 test/test-nettime diff --git a/test/get-nettime

[PATCH 2/4 v2] plugins: Enabling nettime plugin in Makefile.am

--- Makefile.am | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index cdb3166..70162ec 100644 --- a/Makefile.am +++ b/Makefile.am @@ -296,6 +296,9 @@ builtin_modules += example_nettime builtin_sources += examples/nettime.c endif

[PATCH 4/4 v2] plugins: Documentation for nettime plugin

--- doc/network-time-api.txt | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) create mode 100644 doc/network-time-api.txt diff --git a/doc/network-time-api.txt b/doc/network-time-api.txt new file mode 100644 index 000..cb2b9d7 --- /dev/null +++