Hi Giacinto,
So please fix your commit description in the next version.
On 09/19/2018 10:50 PM, Giacinto Cifelli wrote:
---
drivers/gemaltomodem/gemaltomodem.c | 2 +
drivers/gemaltomodem/gemaltomodem.h | 3 +
drivers/gemaltomodem/gprs-context-wwan.c | 446
Hi Giacinto,
On 09/19/2018 10:32 PM, Giacinto Cifelli wrote:
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
Please squash this commit into the previous one. If you're adding new
files into the project, modifications to Makefile.am are exempted from
the 1 subdirectory / commit rul
Hi Giacinto,
On 09/19/2018 10:32 PM, Giacinto Cifelli wrote:
---
drivers/gemaltomodem/gemaltomodem.c | 3 +-
drivers/gemaltomodem/gemaltomodem.h | 3 +
drivers/gemaltomodem/voicecall.c| 965
3 files changed, 970 insertions(+), 1 deletion(-)
cre
Hi Giacinto,
I will check about the is_ready false, but definitely the
disconnect_handler is not called, I can tell you,
because on a special condition I have received a OPEN DONE with failure,
and the driver remained hanging.
However, after calling it, there is a second call to disconnect_hand
Hi Giacinto,
On 09/20/2018 12:03 PM, Giacinto Cifelli wrote:
hi Denis,
On Thu, 20 Sep 2018, 18:31 Denis Kenzior, <mailto:denk...@gmail.com>> wrote:
Hi Giacinto,
> The idea would be to just store the values in the driver but not
in the
> module,
>
Hi Giacinto,
The idea would be to just store the values in the driver but not in the
module,
and then send them before attaching, so that the verification can be
consistent and all,
just like for the gprs-context atom.
Yes, but that is not what you outlined in the code. You were watching
f
Hi Giacinto,
If you can apply directly it would be great, thanks.
Okay, applied with just the first chunk and a tweaked commit message.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono
Hi Giacinto,
static DBusMessage *lte_set_property(DBusConnection *conn,
DBusMessage *msg, void *data)
{
[...]
if (lte->driver->set_property)
lte->driver->set_property(...);
What is this buying you?
else if (lte->driver->set_default_attach_info)
lte->driver->set_default_attach_info(...);
else
Hi Giacinto,
I got this change from external branches.
I doubted it was needed anymore, but couldn't be sure that I had tested
all cases.
thank you for checking it, and it can then be left out.
I can apply this patch without the chunk in question. Or do you want to
resubmit?
Regards,
-
Hi Giacinto,
On 09/20/2018 12:08 AM, Giacinto Cifelli wrote:
---
drivers/atmodem/sms.c | 1 +
1 file changed, 1 insertion(+)
Applied after tweaking the commit description.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofo
Hi Giacinto,
On 09/19/2018 11:49 PM, Giacinto Cifelli wrote:
---
drivers/mbimmodem/mbimmodem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied after tweaking the commit description.
Regards,
-Denis
___
ofono mailing list
ofono@ofon
Hi Giacinto,
An actual description of what is happening would be helpful
On 09/19/2018 11:47 PM, Giacinto Cifelli wrote:
---
drivers/mbimmodem/mbim.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mbimmodem/mbim.c b/drivers/mbimmodem/mbim.c
index 9fcf44b..f4132d0 100644
--- a
Hi Giacinto,
On 09/19/2018 11:39 PM, Giacinto Cifelli wrote:
according to g_thread documentation, this call is no longer needed,
and starting from g_thread version 2.32 it must not be used
---
src/main.c | 5 -
1 file changed, 5 deletions(-)
Both applied after tweaking the commit messa
Hi Giacinto,
On 09/19/2018 11:42 PM, Giacinto Cifelli wrote:
---
src/gprs.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/gprs.c b/src/gprs.c
index 8f5d195..40f43e3 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -1642,6 +1642,9 @@ static void release_active_contexts(struct ofono_gp
Hi Giacinto,
On 09/19/2018 11:26 PM, Giacinto Cifelli wrote:
---
src/gprs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied after tweaking the commit message.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.of
Hi Giacinto,
On 09/19/2018 11:23 PM, Giacinto Cifelli wrote:
OFONO_GPRS_AUTH_METHOD_NONE disables the authentication
OFONO_GPRS_AUTH_METHOD_ANY tries first CHAP then PAP,
but only applies to supporting drivers and modules
No, we're not supporting METHOD_ANY for the reasons outlined already.
P
Hi Giacinto,
On 09/19/2018 10:25 PM, Giacinto Cifelli wrote:
---
drivers/atmodem/vendor.h | 1 +
1 file changed, 1 insertion(+)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofo
Hi Giacinto,
So just to make sure:
- Your commit header should be no longer than 50 characters
Your commit description can be as long as you need, but broken down into
72 character wide lines.
It looks like your description is included in the header. I can't apply
this :)
On 09/19/2018 10
Hi Giacinto,
On 09/19/2018 10:14 PM, Giacinto Cifelli wrote:
---
doc/emergency-call-handling.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.o
Hi Anirudh,
On 09/11/2018 03:32 AM, Anirudh Gargi wrote:
added CREG 'status' 6 and 7 for sms only registered state on E-UTRAN
for CREG cmd reply callback and URC notfiy.
---
drivers/atmodem/network-registration.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --g
Hi Anirudh,
On 09/10/2018 10:52 PM, Anirudh Gargi wrote:
CREG status 6 and 7 added in network registration status, sms atom
to consider new states also.
---
src/common.h | 14 --
src/sms.c| 2 ++
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/common.h b/
Hi Slava,
On 09/19/2018 06:14 PM, Slava Monich wrote:
On 20/09/18 00:45, Denis Kenzior wrote:
(ANY = PAP_CHAP, and don't ask me why we added new values to the
beginning of the enum - it was before we started using binary
plugins). I would be more than happy if upstream started to us
Hi Frank,
Please stop top-posting on this mailing list. We follow the accepted
best practice of open source mailing lists and require replies to be
in-line.
Sep 19 20:17:41 gateway daemon.warn ofonod[152]: Context activated for
driver that doesn't support automatic context activation.
So
Hi Slava,
I understand that! It makes things easier for you guys.
But we had to avoid certain compile-time dependencies in ofono, and a
straightforward (and perhaps the only) way to achieve that was to use
binary plugins. For us plugin API is not subject to change (plugins
don't necessarily
Hi,
So I'm confused now. If sim800 is a serial device, why do you have all this
here? Shouldn't this be handled by setup_serial_modem ?
Because the modem was seen through a serial/USB converter, my kernel sees it as
a USB device. So I used this function.
Should this be coded in a more gen
Hi Giacinto,
I had a look at this all, and I have a problem. I cannot check the
parameters as they are entered one by one.
Example: if I blank user/pwd when the authentication is changed to NONE,
then if changed again to CHAP, the module will reject it.
Shall I store the parameters, or keep th
Hi,
On 09/18/2018 03:36 PM, ClémentViel wrote:
From: clem
You might want to describe how this is different from sim900 that it
warrants a fully separate driver?
If there are only minor differences, then this can be handled via UDEV
attributes or querying +CGMM, etc.
---
Makefile.am
Hi,
On 09/18/2018 03:36 PM, ClémentViel wrote:
From: clem
---
plugins/udevng.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/plugins/udevng.c b/plugins/udevng.c
index 02d049e..9a1be6a 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng
Hi,
On 09/18/2018 03:36 PM, ClémentViel wrote:
From: clem
Can you fix your Author information (see AUTHORS for an example).
Otherwise I cannot take these...
---
doc/sim800-modem.txt | 7 +++
1 file changed, 7 insertions(+)
create mode 100644 doc/sim800-modem.txt
diff --git a/do
Hi Slava,
Anything in include is external API. We do maintain not just
out-of-tree, but binary plugins. Backward (binary!) compatibility a must
for us. Please do not break it.
That is why we have 'OFONO_API_SUBJECT_TO_CHANGE' as a reminder. We
mean it. D-Bus API is stable, we never made an
Hi Giacinto,
so, first the documentation?
Correct. Whenever you touch something that affects the D-Bus API, it is
really preferable to have the D-Bus API changes in the preceding commit.
That way the reviewers can cross-reference what is being proposed to
the actual implementation. Anyth
Hi Giacinto,
From the ./HACKING file I understood that the requirement is to
split according to the top-level directories only, and to make sure not
to break compilation.
The rule provides a baseline minimum. It also implies that sometimes
breaking compilation is inevitable. So long as the
Hi Giacinto,
I would favour also renumbering with NONE on top, but I am not sure of
the side effects everywhere, in case the values are used directly in
commands.
Actually there is no problem doing that. The internal API is not
stable. Besides, it will give all the guys who insist on maint
Hi Slava,
On 09/19/2018 03:35 AM, Slava Monich wrote:
On 19/09/18 08:37, Giacinto Cifelli wrote:
---
include/gprs-context.h | 1 +
include/lte.h | 11 +--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/gprs-context.h b/include/gprs-context.h
index
Hi Giacinto,
On 09/19/2018 12:37 AM, Giacinto Cifelli wrote:
---
drivers/atmodem/atutil.h | 14 +
drivers/atmodem/cbs.c| 1 +
drivers/atmodem/gprs-context.c | 2 +
drivers/atmodem/gprs.c | 554 --
drivers/
Hi Giacinto,
On 09/19/2018 12:37 AM, Giacinto Cifelli wrote:
---
src/gprs.c | 13 ++-
src/lte.c | 372 ++---
src/main.c | 5 -
3 files changed, 341 insertions(+), 49 deletions(-)
So you seem to have 3 completely unrelated things
Hi Giacinto,
Your patch series has 7 commits with the same header. That is nonsense.
Each commit header should be specific to what is contained inside and
preferably followed by a commit description.
Read any one of the many 'How to submit a kernel patch' howtos in order
to understand the be
Hi Giacinto,
yes, CGAUTH can be queried, but there is no fallback command in case it
fails, so it has to be pre-defined based on the model used.
You might have to show me more specifics. I don't see why we couldn't
query +CGAUTH=? in all cases and if it isn't supported, fall back to
vendor
Hi Giacinto,
So first of all, please stop top-posting on this mailing list. All
comments should be in-line.
enum gemalto_auth_type {
OV_GEMALTO_AUTH_CGAUTH = 0,
CGAUTH is a release 11 feature and should be simply probed for in the
gprs-context initialization procedure, similar to how we t
Hi Slava,
On 09/10/2018 02:56 PM, Slava Monich wrote:
Hi Denis,
Hi Slava,
On 09/10/2018 01:26 PM, Slava Monich wrote:
Hi Anirudh, Denis at al.
@@ -669,6 +669,10 @@ const char *registration_status_to_string(int
status)
return "unknown";
case NETWORK_REGISTRATION_STATUS_ROAMI
Hi Slava,
On 09/10/2018 01:26 PM, Slava Monich wrote:
Hi Anirudh, Denis at al.
@@ -669,6 +669,10 @@ const char *registration_status_to_string(int
status)
return "unknown";
case NETWORK_REGISTRATION_STATUS_ROAMING:
return "roaming";
+ case NETWORK_REGISTRATION_STAT
Hi Anirudh,
On 09/10/2018 12:15 AM, "Anirudh Gargi anirudh.gargi"@intel.com wrote:
Something is funny with your email address here..
From: Anirudh Gargi
CREG reports 6 and 7 for SMS only registration on E-UTRAN. Fix
sms atom to consider the new states while sending SMS.
---
drivers/atmodem
Hi Anirudh,
On 09/09/2018 11:42 PM, "Anirudh Gargi anirudh.gargi"@intel.com wrote:
From: Anirudh Gargi
In some case linux report 'driver' as valid yet vid and pid as NULL.
Adding NULL check to prevent seg fault.
Log:
ofonod[23829]: plugins/udevng.c:udev_start()
ofonod[23829]: plugins/udevng.c
Hi Christophe,
On 09/07/2018 09:29 AM, Christophe Ronco wrote:
Problem seen with a MC7304 modem and a roaming SIM card.
Status in org.ofono.NetworkRegistration properties ends up in "registered"
instead of roaming. Both AT command and qmicli indicates we are roaming.
Applied, thanks.
Regards
Hi Giacinto,
On 09/07/2018 03:09 AM, Giacinto Cifelli wrote:
Dear Denis, all,
while preparing the Gemalto driver, I see that there is a potential
shortcoming with the vendor structure in the atmodem. I can set
OFONO_VENDOR_GEMALTO_model, but this could be a very long list for all
options to
Hi Mark,
On 09/06/2018 11:31 AM, Mark van der Putten wrote:
In the gemalto plugin (static void gemalto_post_sim(struct ofono_modem
*modem)) or maybe something sooner in startup phase I would like to
implement AT^SGAUTH
Hmm, are you sure you actually need the AT^SGAUTH?
Gemalto is using the at
Hi Mattias,
On 08/31/2018 04:58 AM, Mattias Månsson wrote:
I would like to implement a periodic status check for our modem and
wonder if there is any support for this in ofono already. Some way to
get a periodic callback perhaps, where I could then run a few AT commands.
This is easily done
Hi,
On 08/29/2018 05:01 PM, d...@rivaretica.com wrote:
New to ofono: looking for documentation/pointers that can inform about
the best point in ofono to intercept Bluetooth audio packets from/to
headset to implement custom audio processing (and does audio stream even
thread through ofono?).
Hi Julien,
On 08/29/2018 09:48 AM, tournier.jul...@gmail.com wrote:
From: Julien Tournier
Hi Denis,
Here is the fixed patch for the +CMT notification parsing on some cinterion
modems that have a leading coma. I hope i took all your remarks into account
drivers/atmodem/sms.c | 21 +
Hi Martin,
+static int m95_probe(struct ofono_modem *modem)
+{
+ struct m95_data *data;
+
+ DBG("%p", modem);
+
+ data = g_new0(struct m95_data, 1);
+ if (data == NULL)
+ return -ENOMEM;
g_new0 cannot fail, so I would take this out
+
+ ofono_modem_
Hi Martin,
On 08/28/2018 02:45 AM, Martin Hundebøll wrote:
The AT command reference for Quectel M95 specifies that remaining SIM
pin retires can be queried using AT+QTRPIN, which responds with one
count for each pin-type:
+QTRPIN: 3,3,10,10
After entering the PIN code, enable an extra AT+CPIN?
Hi,
The commit header needs a bit of tweaking. It should be prefixed by the
driver name or core atom name. E.g.
atmodem: Handle broken +CMT notifications of some cinterion modems
On 08/28/2018 08:41 AM, tournier.jul...@gmail.com wrote:
Hi Denis,
I've recently found a bug in the +CMT notif
Hi Martin,
On 08/24/2018 06:34 AM, Martin Hundebøll wrote:
So far the driver is only tested with GPRS.
The modem uses GSM 07.10 multiplexing, which breaks when changing
functional modes (i.e. going from CFUN=4 to CFUN=1), the driver doesn't
implement online/offline states. It does support disab
Hi Martin,
On 08/24/2018 06:33 AM, Martin Hundebøll wrote:
Since the merge of udev.c into udevng.c all cleanup function must handle
both usb devices and serial devices. Add this distinction to
check_remove(), so that is doesn't try to iterate the .serial member as
if it were a .devices list.
---
Hi Giacinto,
On 08/09/2018 02:00 AM, Giacinto Cifelli wrote:
---
plugins/ublox.c | 9 +
1 file changed, 9 insertions(+)
I went ahead and applied this patch, but see my comment below:
diff --git a/plugins/ublox.c b/plugins/ublox.c
index cfcdd3f..28aaab4 100644
--- a/plugins/ublox.
Hi Giacinto,
On 08/06/2018 11:33 AM, Giacinto Cifelli wrote:
Dear all,
I have a question for the function build_cnmi_string() in
plugins/atmodem/sms.c
The numeric values appear corrupted, like "2310" instead of "2".
example, from an excerpt:
`default:
/* Sounds like 2 is the sanest mode */
Hi Christophe,
On 07/25/2018 08:45 AM, Christophe Ronco wrote:
When ofono dies while connected using PPP, modem AT channel is not put
back to command mode (tested with HUAWEI modems E3372 and MS2372).
If ofono is restarted, it won't be able to connect as it gets no answer
to AT commands on this
Hi Slava,
On 07/20/2018 12:35 PM, Slava Monich wrote:
Plugins may reference data structures allocated by each other.
They all need to be deinitialized first, only then it should be
safe to unload the libraries.
---
src/plugin.c | 15 ---
1 file changed, 12 insertions(+), 3 deletio
Hi Christophe,
The best course of action would be to have modem.disable() issue a
CFUN=0 equivalent that resets everything properly. If that's not
possible, then a solution along the lines of what you propose is
needed. E.g. sending a '+++' in at_gprs_context_remove if the state
isn't IDLE.
I
Hi Christophe,
On 07/13/2018 02:47 AM, Christophe Ronco wrote:
Hi,
I use a Huawei MS2372h-607. It is a classical AT+PPP modem. I have a
problem when I stop ofono while context is activated. When I restart
ofono (without unplugging the modem), I am not able to send any AT
command on Modem channe
Hi Christophe,
On 07/05/2018 03:45 AM, Christophe Ronco wrote:
APN has to be stored in settings file after it is modified in
ofono_gprs_cid_activated function.
---
src/gprs.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/gprs.c b/src/gprs.c
index 377eced..22d5e36 100644
--- a
Hi Christophe,
On 07/03/2018 03:40 AM, Christophe Ronco wrote:
Hi,
I am doing a test with a 4G SIM card with APN set in provisionning. I
've recently upgraded my Ofono version to 1.23.
My card gets LTE attach quickly, before it gets ServiceProviderName from
SIM card.
So ofono_gprs_cid_activated
Hi Slava,
I kind of like these getters for type safety but it's all up to you of
course.
Right, I can see value in getters for the common ones like sim, gprs &
voicecall. But I don't really want to have 20-30 of these functions
(one for each atom.) So at some point we have to draw the l
Hi Slava,
On 06/29/2018 08:57 AM, Slava Monich wrote:
---
include/modem.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/modem.h b/include/modem.h
index 005a42e..bed46c2 100644
--- a/include/modem.h
+++ b/include/modem.h
@@ -31,6 +31,7 @@ extern "C" {
struct ofono_modem;
st
Hi Slava,
On 06/28/2018 11:30 AM, Slava Monich wrote:
---
include/types.h | 1 +
1 file changed, 1 insertion(+)
All three applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono
Hi Slava,
On 06/28/2018 10:51 AM, Slava Monich wrote:
---
src/dbus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofon
Hi Slava,
On 06/28/2018 09:50 AM, Slava Monich wrote:
This allows plugins/drivers to be a bit more specific about
what went wrong.
---
src/dbus.c | 28
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/src/dbus.c b/src/dbus.c
index 3e1e162..7ea86ed 10
Hi Slava,
Also, enum ofono_clir_option (which seems to be a 27.007 thing too) is
defined in include/types.h which is a bit inconsistent.
It really isn't. The CLIR option is a bit special because it uses a
letter 'I', 'i' or default. I suppose we could have used a 'char' type
for this, but
Hi Slava,
On 06/21/2018 12:20 PM, Slava Monich wrote:
---
include/types.h | 31 +++
1 file changed, 31 insertions(+)
Can you help me understand what is the motivation behind this? In the
past we opted not to expose OFONO enums for well-known values (e.g.
thos
Hi Slava,
On 06/20/2018 10:06 AM, Slava Monich wrote:
---
include/voicecall.h | 2 ++
1 file changed, 2 insertions(+)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono
Hi Slava,
On 06/23/2018 11:08 AM, Slava Monich wrote:
FALSE means that struct voicecall passed in as a parameter
has been deallocated.
---
src/voicecall.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Is there an actual issue you're fixing? Or is this just a be paranoid
patch?
Hi Jason,
enable/power the modem through ofono and even register the SIM on the
network. From what I can tell, this bug seems to be present in all ofono
versions that don't use the he910.c plugin.
Maybe just the newer firmware behaves differently. I think the people
who merged the various t
Hi Arsenijs,
On 06/21/2018 06:37 PM, Pičugins Arsenijs wrote:
I'm now working on a SIM800 plugin, specifically, for a UART-connected SIM800
and a Raspberry Pi Zero. There are minor adjustments that we need to make, so
we've copied the SIM900 plugin to make sure that we can make adjustments in
a
Hi Mattias,
By the way, please no top-posting on this list.
Jun 20 13:44:03 lev-26e7jvbe ofonod[16440]: App> AT\r
Jun 20 13:44:03 lev-26e7jvbe ofonod[16440]: App< \r\nOK\r\n
Jun 20 13:44:03 lev-26e7jvbe ofonod[16440]: AppFinally woke up the modem
Jun 20 13:44:03 lev-26e7jvbe ofonod[16440]: App>
Hi Mattias,
On 06/20/2018 08:24 AM, Mattias Månsson wrote:
It seems we already use that parser though:
syntax = g_at_syntax_new_gsm_permissive();
chat = g_at_chat_new(channel, syntax);
Not sure then. Permissive should be taking care of the issue you
describe, e.g it skips any empty lines:
Hi Mattias,
On 06/20/2018 02:34 AM, Mattias Månsson wrote:
I'm integrating a new Cinterion module and have a small issue I haven't
been able to solve nicely in Ofono. One of their commands responds with
a list of stuff, followed by an OK but also after the OK there is an
empty line. Which is o
Hi Lars,
On 06/19/2018 03:19 AM, poesc...@lemonage.de wrote:
Hi!
I think I found a bug.
Commit 1d63b1d35 essentially breaks the sim900 driver for serial port
users.
Right. This looks like some wires being crossed. sim900 driver is only
meant for serial port usage. So listing it for 'opt
Hi Antara,
On 06/07/2018 05:26 AM, Antara Borwankar wrote:
From: Antara
handling of intel propriotery AT commands in atdriver for
intel modems.
Signed-off-by: Antara
Remember, no Signed-off-by for this project.
---
drivers/atmodem/cbs.c | 64
Hi Slava,
On 05/23/2018 08:48 AM, Slava Monich wrote:
And reset state to idle before unregistering the D-Bus interface.
This may occur e.g. when we receive REFRESH from STK.
---
src/ussd.c | 16
1 file changed, 16 insertions(+)
Applied, thanks.
Regards,
-Denis
__
Hi Florent,
On 05/22/2018 08:08 AM, Florent Beillonnet wrote:
---
plugins/gemalto.c | 2 ++
1 file changed, 2 insertions(+)
You really shouldn't need to do this given that you have a URC inside
gemalto_ciev_notify() that does exactly this already.
No, I think there's a tiny bug in the co
Hi Florent,
On 05/22/2018 08:08 AM, Florent Beillonnet wrote:
---
drivers/atmodem/sim.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
I went ahead and applied this after fixing up the commit header &
description. Please see doc/coding-style.txt, item M5 in particular.
Thank
Hi Varun,
On 05/23/2018 12:29 AM, Varun Gargi wrote:
---
plugins/udevng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo
Hi James,
On 05/22/2018 03:35 PM, James Prestwood wrote:
The return value from ofono_modem_register was not being checked. If this fails
the modem object is not setup and causes a crash. This was specifically seen
when using the mbim driver without having configured with mbim support.
Now the m
Hi Alexander, Joey,
On 05/12/2018 09:19 AM, Alexander Couzens wrote:
Hi Joey,
nice to hear, somebody else is using it.
The voicecall driver needs to be refactored as Denis already pointed
out on the mailinglist before it can go upstream.
If it wasn't clear from my earlier mail, I would like
Hi Bob,
On 05/14/2018 08:42 AM, Bob Ham wrote:
Setting AT+COLP=1 on the SIMCom SIM7100E causes oFono to stall and not
create a new VoiceCall object. We fix that by adding the SIMCOM
vendor ID to the list for whom we set AT+COLP=0 instead.
Both applied, thanks.
Regards
-Denis
__
Hi Harald,
ofono supports voice calls over qmi, right? Is it possible that
mdm6600 does not support them?
This reminds me... Weren't you the one who mentioned that you got
voicecalls working on QMI devices? Does that include the circuit
switched control operations (e.g. dial, etc) as well?
Hi Pavel,
ofono supports voice calls over qmi, right? Is it possible that
mdm6600 does not support them?
It looks like the QMI voicecall driver is just a stub with no operations
actually implemented.
Regards,
-Denis
___
ofono mailing list
ofono@of
Hi Pavel,
On 05/09/2018 01:57 PM, Pavel Machek wrote:
Hi!
If I attempt to do AT+CNMA=1, AT+CNMA=0 or just plain At=CNMA, it does
not like that, either, but with +CMS ERROR: 500.
CNMA=1 is required to work in PDU mode according to 27.005 btw. How about:
window.open();
window.throw(modem);
Hi Pavel,
If I attempt to do AT+CNMA=1, AT+CNMA=0 or just plain At=CNMA, it does
not like that, either, but with +CMS ERROR: 500.
CNMA=1 is required to work in PDU mode according to 27.005 btw. How about:
window.open();
window.throw(modem);
Heh :-). Well, there are two phones with reasonab
Hi Pavel,
On 05/09/2018 09:33 AM, Pavel Machek wrote:
Fix typo in location-reporting-api.txt.
AFAICT, at_cmt_notify() calls ofono_error even in case stuff is
okay. Fix that.
Move debug print to more useful place in setup_gobi().
Explain "delivery report" parameter in send-sms.
These mostly
Hi Mattias,
On 05/09/2018 03:28 AM, Mattias Månsson wrote:
I have a problem with a modem and USB suspend where the OK from some AT
commands are sometimes lost. This will be corrected by the vendor, but
it got me wondering how Ofono handles problems like this. As I can see,
there is no timeouts
Hi Pavel,
PDU Len 2, strlen 4
PDU last char 48
^ZCNMA=1,2
That looks correct. In fact that logic has been working for something
like 8-9 years, but it doesn't hurt to be paranoid and double check.
If I attempt to do AT+CNMA=1, AT+CNMA=0 or just plain At=CNMA, it does
not like that,
Hi Pavel,
On 05/08/2018 04:51 PM, Pavel Machek wrote:
Hi!
I have problems with incoming SMS. ofono tries to use +CNMI=1,2,2,1,0
AT+CNMI=?
< +CNMI: (0,1,2),(0,1,2,3),(0,2),(0,1,2),(0,1)
< OK
ofonod[3070]: drivers/atmodem/sms.c:build_cnmi_string()
ofonod[3070]: drivers/atmodem/sms.c:construct_
Hi Pavel,
On 05/08/2018 04:44 PM, Pavel Machek wrote:
Hi!
I have a motorola droid 4 here; it uses gsm 07.10 multiplex. Over
that, there are AT commands, but prefixed with serial numbers, in
U0001AT+FOOBAR form. Corresponding reply then has U0001 prefix, too.
Has anyone seen that before? Any hin
Hi James,
On 05/03/2018 05:30 PM, James Prestwood wrote:
---
src/simutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/of
Hi Bob,
On 04/30/2018 08:56 AM, Bob Ham wrote:
Add support for the SIM7100E modem. We add a new "sim7100" plugin
because there's no other AT-based modem that has support for both GPRS
and voice calls.
---
Makefile.am | 3 +
plugins/sim7100.c | 271
Hi Slava,
On 04/26/2018 09:00 AM, Slava Monich wrote:
---
include/modem.h | 2 ++
1 file changed, 2 insertions(+)
Both applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono
Hi Slava,
On 04/23/2018 10:33 AM, Slava Monich wrote:
Typically responses to USSD requests are coming with status
zero (NOTIFY) but some are coming with status 2 (TERMINATED).
If those contain data, the data should be presented to the user.
---
src/ussd.c | 15 ++-
1 file changed,
Hi Mark,
On 04/19/2018 10:54 AM, Mark van der Putten wrote:
Modem type PLS8-E, firmware 03.017
---
plugins/gemalto.c | 5 +
1 file changed, 5 insertions(+)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists
Hi Christophe,
On 04/13/2018 08:58 AM, Christophe Ronco wrote:
QMI_UIM_GET_CARD_STATUS is retried in more error cases
when trying to get password type.
In case of failure, driver report an error instead of
OFONO_SIM_PASSWORD_INVALID. This avoids a crash.
---
drivers/qmimodem/sim.c | 19 +++
601 - 700 of 4644 matches
Mail list logo
