Hi Jussi,
On 01/17/2011 05:34 AM, Jussi Kangas wrote:
> Hi again,
>
> This is third attempt to fix the problem where PUK required information
> is not shown correctly after user tries to change pin code too many
> times with wrong passwords. Basically solution is pretty much as in
> original made
Hi Jussi,
On 01/25/2011 09:34 AM, Jussi Kangas wrote:
>
> Hi, Denis.
>
>> So I'm mostly happy with this approach except that ofono_modem_reset is
>> too big of a hammer to use here. We need something that drops us back
>> to pre-sim state without having to re-power on the device (which is what
Hi Rafael,
On 01/25/2011 08:02 AM, Rafael Ignacio Zurita wrote:
> This set of patches extends OFONO_MAX_PHONE_NUMBER_LENGTH, splits
> common:valid_phone_number_format(), and adapts voicecall to valid
> the 80 character limit for outgoing calls.
>
> Rafael Ignacio Zurita (2):
> types: change OFO
Hi Tomasz,
> Shouldn’t ReleaseAndAnswere() release the active call and bring back the
> held one in such situation?
>
You shouldn't be using ReleaseAndAnswer in this case, instead you should
use SwapCalls. SwapCalls has the added benefit of allowing swapping of
held and active calls even if ther
Hi Jukka,
> +/* For gprs */
> +void __ofono_gprs_provision_get_settings(const char *mcc, const char *mnc,
> + const char *spn,
> + struct ofono_gprs_provision_data **settings,
> + int *count);
The __ofono prefix implies that this is priv
Hi Jukka,
On 01/25/2011 06:15 AM, Jukka Saunamaki wrote:
> ---
> src/gprs.c | 172
>
> 1 files changed, 162 insertions(+), 10 deletions(-)
>
> diff --git a/src/gprs.c b/src/gprs.c
> index 92d0b1a..3e281e5 100644
> --- a/src/gprs.c
>
Hi Tomasz,
On 01/25/2011 03:43 PM, Tomasz Gregorek wrote:
> Hi Denis
>
> 2011/1/25 Denis Kenzior mailto:denk...@gmail.com>>
>
> Hi Tomasz,
>
> > Shouldn’t ReleaseAndAnswere() release the active call and bring
> back the
> > held one
> Yep, Hangup or HangupMultiparty then SwapCalls. If you feel that a
> single operation to accomplish hangup + swap is required we can
> certainly consider it. For now it didn't pass our API is Minimal +
> Complete test. Perhaps ReleaseAndSwap()...?
>
>
> I would go with easy s
Hi Lucas,
On 01/25/2011 05:46 PM, Lucas De Marchi wrote:
> Use the enum values defined for CLIP, CNAP, CLIR, COLP and COLR.
> ---
> src/call-settings.c | 16
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
Hi Jarko,
On 01/26/2011 03:14 AM, Jarko Poutiainen wrote:
> Hi Denis,
>
> First sorry for slow reply.
>
> On Tue, 2011-01-18 at 23:50 +0200, Denis Kenzior wrote:
>>
>> So my thinking is that we should:
>> - Not update conditional cfs when cfu is active (wh
Hi Jukka,
On 01/26/2011 06:34 AM, Jukka Saunamaki wrote:
> Hello
>
> And again a patchset about automatic provisioning of GPRS context settings.
>
> Since the safe reading of EF-SPN turned out to be impossible until general
> solution is implemented, I must temporary give up my insistence on it
Hi Jeevaka,
On 01/26/2011 02:15 PM, Jeevaka Badrappan wrote:
> Fixes the crash seen with the null alpha identifier.
> Also removed the icon check as icon will always be a valid pointer.
> ---
> src/stk.c |7 ++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
Applied with a slightl
Hi Jeevaka,
On 01/26/2011 04:17 PM, Jeevaka Badrappan wrote:
> ---
> drivers/atmodem/voicecall.c | 12 ++--
> drivers/calypsomodem/voicecall.c |9 -
> drivers/hfpmodem/voicecall.c |4 ++--
> drivers/huaweimodem/voicecall.c |9 -
> drivers/ifxmodem/v
Hi Pekka,
On 01/20/2011 10:53 AM, pekka.pe...@nokia.com wrote:
> From: Pekka Pessi
>
> ---
> doc/gba-authentication.txt | 70
>
> 1 files changed, 70 insertions(+), 0 deletions(-)
> create mode 100644 doc/gba-authentication.txt
>
Can you do me
Hi Pekka,
On 01/21/2011 06:44 AM, pekka.pe...@nokia.com wrote:
> From: Pekka Pessi
>
> ---
> src/message-waiting.c | 13 ++---
> 1 files changed, 10 insertions(+), 3 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
___
ofono
Hi Pekka,
On 01/21/2011 06:44 AM, pekka.pe...@nokia.com wrote:
> From: Pekka Pessi
>
> ---
> src/message-waiting.c | 45 ++---
> 1 files changed, 30 insertions(+), 15 deletions(-)
>
> diff --git a/src/message-waiting.c b/src/message-waiting.c
> index 0
Hi Andras,
> This becomes a problem when there are multiple calls since it is not
> possible to determine to which call instance the indication is referring
> to.
> This raises the question where/how to show this type of properties?
Have you seen the thread from Pekka's previous attempt to defin
Hi Philippe,
> We have checked with Jeewaka what are the conditions related to the STK
> events 'User activity', 'idle screen available' and 'language selection'.
> It appears that whatever is the release, once the device is supporting a
> display and a keypad, those events are mandatory for GCF.
Hi Andras,
On 01/28/2011 11:13 AM, Andras Domokos wrote:
> Hi Denis,
>
> On 01/27/2011 06:01 PM, ext Denis Kenzior wrote:
>> Hi Andras,
>>
>>> This becomes a problem when there are multiple calls since it is not
>>> possible to determine to which call inst
Hi Lucas,
On 01/27/2011 08:39 PM, Lucas De Marchi wrote:
> Third version. It includes some changes suggested by Denis:
>
> - Get rid of the oldpath field in struct txq_backup_entry
> - Store the encoded uuid in struct txq_backup_entry
> - Use SMS_MSGID_FMT to get the file name
> - Some more clean
Hi Lucas,
On 01/27/2011 08:48 PM, Lucas De Marchi wrote:
> If file name had anything in the name after addr-msgid, it would be
> parsed as well. This is not what we want, since there could be temporary
> files lying around.
> ---
> src/smsutil.c |5 +++--
> 1 files changed, 3 insertions(+), 2
Hi Andrew,
On 01/28/2011 06:29 PM, Andrzej Zaborowski wrote:
> If the block is not in cache or if this is the last block of a last
> op in the queue, then fs->op_source might be left with the wrong
> value.
> ---
> src/simfs.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
Patc
Hi Andrew,
On 01/28/2011 06:29 PM, Andrzej Zaborowski wrote:
> ---
> src/simfs.c |4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofo
Hi Jeevaka,
On 01/29/2011 07:34 AM, Jeevaka Badrappan wrote:
> Hi,
>
> Memory allocation function for callback data change from g_try_new0 to
> g_new0. Due to this, NULL check done for callback data is removed.
>
> Regards,
> Jeevaka
>
All 11 patches have been applied, thanks.
Regards,
-Denis
Hi Jeevaka,
On 01/29/2011 12:21 PM, Jeevaka Badrappan wrote:
> ---
> drivers/atmodem/sim.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://l
Hi Jeevaka,
On 01/29/2011 12:24 PM, Jeevaka Badrappan wrote:
> ---
> drivers/hfpmodem/network-registration.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@
Hi Andrew,
>>> + switch (reset_state) {
>>> + case RESET_STATE_NOT_PRESENT:
>>> + ofono_sim_inserted_notify(sim, FALSE);
>>> + ofono_sim_inserted_notify(sim, TRUE);
>>
>> Are you sure we can do it this way? I would assume that the modem might
>> require some time t
Hi Andras,
On 01/31/2011 05:56 AM, Andras Domokos wrote:
> Here is a proposal for expanding the VoiceCallManager interface with
> call related Supplementary Services signals, and the VoiceCall
> interface with new properties.
>
> ---
> doc/call-barring-api.txt | 10 --
> doc/voice
Hi Jukka,
On 01/31/2011 12:13 AM, Jukka Saunamaki wrote:
> Hello
>
> On Thu, 2011-01-27 at 15:22 +0200, Jukka Saunamaki wrote:
>> Here is an asynchronous implementation of SIM Service Provider Name (EF-SPN)
>> getter API.
>> The trick is to delay setting sim ready until spn reading is finished.
Hi Marcel,
On 02/01/2011 04:38 AM, Marcel Holtmann wrote:
> Hi Denis,
>
>>> On Thu, 2011-01-27 at 15:22 +0200, Jukka Saunamaki wrote:
Here is an asynchronous implementation of SIM Service Provider Name
(EF-SPN) getter API.
The trick is to delay setting sim ready until spn reading
Hi Andras,
>>> +
>>> +boolean Forwarded
>>> +
>>> +Contains the indication whether the voice call is a
>>> +forwarded call or not.
>>> +
>> So just to clarify, this is usually set on a local Incoming / Waiting
>> call, correct?
> This property would apply to both, o
Hi Aki,
On 02/01/2011 02:38 PM, Aki Niemi wrote:
> Hi Denis,
>
> On Tue, 2011-02-01 at 09:14 -0600, ext Denis Kenzior wrote:
>>> does it really matter in the end? It gets read once and after that we
>>> are caching it on disk anyway.
>>>
>>
>&
Hi Pekka,
On 02/01/2011 04:22 PM, pekka.pe...@nokia.com wrote:
> From: Pekka Pessi
>
> There were some cases where Dial returned an incorrect call object,
> e.g., after oFono crash and recover.
> ---
> src/voicecall.c | 15 +++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
Hi Andras,
On 02/02/2011 01:51 AM, Andras Domokos wrote:
> Hi Denis,
>
> On 02/01/2011 05:54 PM, ext Denis Kenzior wrote:
>> Hi Andras,
>>
>>>>> +
>>>>> +boolean Forwarded
>>>>> +
>>>>> +Contain
Hi Jukka,
On 02/02/2011 01:19 AM, Jukka Saunamaki wrote:
> Hi Denis,
>
> On Tue, 2011-02-01 at 19:20 -0600, ext Denis Kenzior wrote:
>>> There is also this weird corner case when the SIM has no SPN available.
>>> AFAIK, a failed read isn't cached, so bootstrapp
Hi Pekka,
On 02/02/2011 08:57 AM, Pekka Pessi wrote:
> Hi Denis,
>
> 2011/2/2 Denis Kenzior :
>> On 02/01/2011 04:22 PM, pekka.pe...@nokia.com wrote:
>>> From: Pekka Pessi
>>>
>>> There were some cases where Dial returned an incorrect call objec
Hi Jeevaka,
On 02/02/2011 07:10 AM, Jeevaka Badrappan wrote:
> ---
> include/types.h |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis.
___
ofono mailing list
ofono@ofono.org
http://lists.
Hi Jeevaka,
On 02/02/2011 07:10 AM, Jeevaka Badrappan wrote:
> ---
> examples/nettime.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis.
___
ofono mailing list
ofono@ofono.org
http://lis
Hi Mikhail,
>
> Am I right in assuming that the SMS history roundtrip is not performed before
> acking the constituent TPDUs to the network? If it is, we have problems even
> regardless of D-Bus method call timeouts.
>
This has been discussed to death a bazillion times. So lets recap very
qu
Hi Lucas,
On 02/02/2011 12:53 PM, Lucas De Marchi wrote:
> If agent is not set to NULL after it's freed, the following situation
> would not work:
>
> smart_messaging_register_agent()
> smart_messaging_unregister_agent()
> smart_messaging_register_agent()
>
> And this one could potentially crash
Hi Andras,
> +
> + boolean ForwardedCall
> +
> + Contains the indication whether the incoming voice call
> + is a redirected call due to a call forwarding operation
> + or not.
Please drop the Call suffix, you are already on
Hi Kai,
> So handling this might still be useful even if reliable re-enabling
> of messages would not work reliably (assumption being that recycling and
> reregistering will reliably reenable message delivery). Or do you have
> practical experience of cases where even a power cycle won't help...
Hi Mikhail,
On 02/03/2011 05:57 AM, mikhail.zabal...@nokia.com wrote:
> Hi Denis,
>
>> -Original Message-
>> From: ext Denis Kenzior [mailto:denk...@gmail.com]
>> Sent: Wednesday, February 02, 2011 9:23 PM
>> To: ofono@ofono.org
>> Cc: Zabaluev Mikhai
Hi Mikhail,
>> I am not really getting what you are saying. oFono will reassembly the
>> message for you piece by piece. And we are making sure fragments are
>> stored reliably. However once the message is complete we give it to
>> history for further processing. Mainly to get it stored in the
>>
Hi Marit,
On 02/03/2011 07:13 AM, Marit Henriksen wrote:
> From: Marit Henriksen
>
> ---
> drivers/stemodem/voicecall.c |4
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/stemodem/voicecall.c b/drivers/stemodem/voicecall.c
> index fa078a8..2eaba8c 100644
>
Hi Marit,
On 02/03/2011 07:19 AM, Marit Henriksen wrote:
> From: Marit Henriksen
>
> - *ECAV UR code has been extended with a new state Released,
> sent immediately when MO call is released.
> - Apply rule M11 of coding style.
> ---
> drivers/stemodem/voicecall.c | 20 +++-
>
Hi Marit,
On 02/03/2011 07:15 AM, Marit Henriksen wrote:
> From: Marit Henriksen
>
> - Reset local_release when call is disconnected.
> - Change bitmap for affected types, ste_hangup is only called when
> call state is Incoming, Dialing, Alerting or Active.
> - Used macros instead of numbers w
Hi Marit,
On 02/03/2011 07:14 AM, Marit Henriksen wrote:
> From: Marit Henriksen
>
> ---
> test/hangup-active | 12 +---
> 1 files changed, 9 insertions(+), 3 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
___
ofono mailin
Hi Sjur / Simon,
On 01/29/2011 05:44 PM, Sjur Brændeland wrote:
> From: Simon Lethbridge
>
> This patch introduces support for Global Satellite Navigation System (GNSS),
> using the AT commands AT+CPOS and +CPOSR as specified 3GPP 27.007.
> ---
>
Patch has been applied, thanks.
Regards,
-Deni
Hi Andras,
>> The explanations you have should be applied to the type. Another point
>> is whether we want this signal on the call object itself. Question is
>> how reliably we can figure out the call index. At what point does CSSI
>> / CSSU fire, before or after the call goes to active / disco
Hi Andrew,
On 01/28/2011 06:29 PM, Andrzej Zaborowski wrote:
> There seems to be no reason that the fileinfo is cached for file
> read or block read requests but not info_only requests, so move
> code around to fix this. O_RDWR is changed to O_WRONLY for the
> cache file because the file is not b
Hi Andrew,
On 01/28/2011 06:29 PM, Andrzej Zaborowski wrote:
> This patch introduces sim FS contexts which are used to queue file
> read and write operations. When a context is freed all pending
> operations in that context are cancelled preventing callbacks from
> being called causing segfaults.
Hi Andrew,
On 02/03/2011 01:37 AM, Andrzej Zaborowski wrote:
> ---
> src/call-forwarding.c | 16 ++--
> src/cbs.c | 14 +-
> src/message-waiting.c | 37 --
> src/network.c | 18 +++--
> src/sim.c | 82 +++---
Hi Aki,
On 02/03/2011 07:20 AM, Aki Niemi wrote:
> ---
> src/smsutil.c | 10 --
> 1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/src/smsutil.c b/src/smsutil.c
> index 1762391..5c1ae4c 100644
> --- a/src/smsutil.c
> +++ b/src/smsutil.c
> @@ -2267,16 +2267,6 @@ char *
Hi Aki,
On 02/03/2011 07:20 AM, Aki Niemi wrote:
> ---
> src/util.c | 205
> +---
> src/util.h |1 -
> 2 files changed, 126 insertions(+), 80 deletions(-)
>
Patch has been applied, but I pushed some minor style issues thereafter.
Re
Hi Aki,
On 02/03/2011 07:20 AM, Aki Niemi wrote:
> ---
> src/util.c | 64
>
> src/util.h |7 ++
> 2 files changed, 71 insertions(+), 0 deletions(-)
> +unsigned char *convert_utf8_to_gsm_best_lang(const char *utf8, long len
Hi Aki,
On 02/03/2011 07:20 AM, Aki Niemi wrote:
> ---
> src/smsutil.c | 53 ++---
> src/smsutil.h | 12
> 2 files changed, 58 insertions(+), 7 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
__
Hi Aki,
On 02/03/2011 07:20 AM, Aki Niemi wrote:
> ---
> doc/message-api.txt | 14 ++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/doc/message-api.txt b/doc/message-api.txt
> index 1c68aee..d5a7b15 100644
> --- a/doc/message-api.txt
> +++ b/doc/message-api.t
Hi Aki,
> @@ -838,6 +860,9 @@ static DBusMessage *network_register(DBusConnection *conn,
>
> netreg->driver->register_auto(netreg, register_callback, netreg);
>
> + if (netreg->mode == NETWORK_REGISTRATION_MODE_AUTO_ONLY)
> + return NULL;
> +
So we might just return acce
Hi Aki,
On 02/03/2011 03:22 PM, Aki Niemi wrote:
> Hi Denis,
>
> 2011/2/3 Denis Kenzior :
>>> + if (netreg->mode == NETWORK_REGISTRATION_MODE_AUTO_ONLY)
>>> + return NULL;
>>> +
>>
>> So we might just return access_denied her
Hi Jeevaka,
On 02/03/2011 03:38 PM, Jeevaka Badrappan wrote:
> ---
> doc/overview.txt |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.
Hi Jeevaka,
On 02/03/2011 04:59 PM, Jeevaka Badrappan wrote:
> Hi,
>
>This patch adds the Sim Toolkit overview and feature list table.
> Fixes the indentation issue observed in the 1st version.
>
Excellent stuff, thanks for doing this.
Both patches have been applied.
Regards,
-Denis
_
Hi Sankar,
On 02/04/2011 06:38 AM, Sankar wrote:
> Hi,
>
> Using the Scan method call on the NetworkRegistration interface, I can
> query the available networks in the current region. Is there a way I can
> cancel this scan operation.?
We currently do not support AT command cancellation. Lots o
Hi Marit,
On 02/04/2011 08:40 AM, Marit Henriksen wrote:
> From: Marit Henriksen
>
> ---
> drivers/stemodem/voicecall.c |7 +++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
___
ofono m
Hi Amit,
On 02/03/2011 10:34 AM, Amit Mendapara wrote:
> The LW273 and LW272 devices are being distributed by BSNL in India
> with Teracom
> brand name. Both the devices have similar specs except data speed and
> having same
> usb id (230d:0001).
>
> Links:
>
> http://www.bsnl.in/service/3G/3G_f
Hi Mikhail,
> I totally agree. But it means that you have code in oFono to reliably store
> an ordered collection of stuff in a filesystem. I wouldn't like MeeGo
> developers to maintain very similar code in a different component, just for
> API adaptation reasons.
No we do not. We have code
Hi Mika,
> +enum ofono_gprs_addrconf {
> + OFONO_GPRS_ADDRCONF_NONE,
> + OFONO_GPRS_ADDRCONF_STATIC,
> + OFONO_GPRS_ADDRCONF_DHCP,
> +};
> +
What exactly is the _NONE addrconf for? And why don't we use a gboolean
here like before?
> struct ofono_gprs_primary_context {
> unsig
Hi Mika,
On 02/03/2011 03:03 AM, Mika Liljeberg wrote:
> ---
> include/gprs-context.h |2 +-
> src/gprs.c | 296
> +++-
> 2 files changed, 192 insertions(+), 106 deletions(-)
>
> diff --git a/include/gprs-context.h b/include/gprs-cont
Hi Mikhail,
On 02/04/2011 12:07 PM, mikhail.zabal...@nokia.com wrote:
> Hi,
>
>> -Original Message-
>> From: ext Denis Kenzior [mailto:denk...@gmail.com]
>> Sent: Friday, February 04, 2011 7:06 PM
>> To: ofono@ofono.org
>> Cc: Zabaluev Mikhail (Nokia-M
Hi Aki,
On 02/03/2011 07:20 AM, Aki Niemi wrote:
> ---
> src/sms.c | 91 +++-
> 1 files changed, 89 insertions(+), 2 deletions(-)
>
So I went ahead and applied this patch. I pushed some minor fixes
afterwards.
Regards,
-Denis
_
Hi Aki,
On 02/03/2011 07:20 AM, Aki Niemi wrote:
> ---
> doc/message-api.txt | 14 ++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
So this patch was actually against the wrong file. I went ahead and
fixed it up for you.
Regards,
-Denis
__
Hi Mikhail,
On 02/04/2011 12:52 PM, mikhail.zabal...@nokia.com wrote:
> Hi,
>
>> -Original Message-
>> From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On
>> Behalf Of ext Marcel Holtmann
>> Sent: Friday, February 04, 2011 8:13 PM
>> To: ofono@ofono.org
>> Subject: RE: [RFC
Hi Mikhail,
>> In the text message case we already provide the history plugin with
>> _everything_ that it needs. If you want to implement a particular API,
>> then history is the right avenue to do so. There is no inherent
>> benefit
>> of having oFono core do so and we do not want to introduce
Hi Mika,
On 02/07/2011 03:55 AM, mika.liljeb...@nokia.com wrote:
> Hi Denis,
>
> Thanks for the comments.
>
>>> +enum ofono_gprs_addrconf {
>>> + OFONO_GPRS_ADDRCONF_NONE,
>>> + OFONO_GPRS_ADDRCONF_STATIC,
>>> + OFONO_GPRS_ADDRCONF_DHCP,
>>> +};
>>> +
>>
>> What exactly is the _NONE addrc
Hi Andras,
> + CallForwarded(string type)
> +
> + Signal emitted when an outgoing voice call is made and
> + the call has been redirected to another number due to
> + the remote party's "Call Forwarding" Supplementary
> +
Hi Andrew,
> +void __ofono_sim_refresh(struct ofono_sim *sim, GSList *file_list,
> + ofono_bool_t full_file_change, ofono_bool_t naa_init)
> +{
> + GSList *l, *fl;
> + enum sim_reset {
> + RESET_REMOVE_ATOMS = OFONO_SIM_STATE_INSERTED,
> + R
Hi Andras,
On 02/07/2011 11:09 AM, Andras Domokos wrote:
> ---
> doc/call-barring-api.txt | 10 --
> doc/voicecall-api.txt| 11 +++
> doc/voicecallmanager-api.txt | 25 +
> 3 files changed, 36 insertions(+), 10 deletions(-)
>
Your patch
Hi Andre,
> @@ -1350,11 +1351,12 @@ static DBusMessage *manager_transfer(DBusConnection
> *conn,
>* implementing the call transfer operation for a call that is
>* still dialing/alerting.
>*/
> - numactive += voicecalls_num_connecting(vc);
> + numconn = voicecalls_n
Hi Andrew,
On 02/03/2011 07:20 PM, Andrzej Zaborowski wrote:
> This allows code that reads files from the SIM card to also watch for
> changes in these files signalled in a Refresh command by the SIM.
> ---
> include/sim.h |9 +
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
S
Hi Andrew,
> @@ -2030,6 +2042,59 @@ static gboolean handle_command_refresh(const struct
> stk_command *cmd,
> cmd->refresh.icon_id.qualifier);
> DBG("Alpha ID: %s", cmd->refresh.alpha_id);
>
> + sim_atom = __ofono_modem_find_atom(__ofono_atom_get_
Hi Andre,
On 02/07/2011 02:37 PM, andre matos wrote:
> Hi Denis,
>
> On Mon, Feb 7, 2011 at 8:46 PM, Denis Kenzior <mailto:denk...@gmail.com>> wrote:
>
> Hi Andre,
>
> > @@ -1350,11 +1351,12 @@ static DBusMessage
> *m
Hi Andrew,
>> if full_file_change or changed ef in (EFbdn, EFfdn, EFest, EFust, EFsst,
>> EFphase, EFad, EFcphs_info):
>>Remove all atoms in post_sim and post_online
>>Restart SIM initialization procedure
>
> I guess that is okay, as long as we remember to keep this list updated
>
Hi Andre,
> Are we reading the same code?
>
> for this case we have:
> numactive != 1 ==> true
> numheld != 1 ==> false
>
> (numactive != 1) && (numheld != 1) ==> false
>
Then shouldn't the patch simply be modified to if (numactive != 1 ||
numheld != 1)?
Regards,
-Denis
__
Hi Jeevaka,
On 02/07/2011 03:07 PM, Jeevaka Badrappan wrote:
> ---
> drivers/ifxmodem/voicecall.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
Hi Andre,
On 02/07/2011 03:48 PM, andre matos wrote:
> Hi Denis,
>
> On Mon, Feb 7, 2011 at 10:30 PM, Denis Kenzior <mailto:denk...@gmail.com>> wrote:
>
> Hi Andre,
>
> > Are we reading the same code?
> >
> > for this c
Hi Andre,
On 02/07/2011 05:56 AM, Andre Matos wrote:
> From: Andre Carvalho de Matos
>
> transfer method should fail if you have a multiparty call, according to 22.091
> section 8.11
> ---
> src/voicecall.c |6 --
> 1 files changed, 4 insertions(+), 2 deletions(-)
I pushed my own versi
Hi Andre,
> when submitting patches please follow our coding style guidelines. You
> had at least 1 style violation, namely rule M4.
>
>
> That is strange i run checkpatch on the code i did not get any warning.
> Is there a better script for the checking the patches before sending?
W
Hi Jeevaka,
On 02/07/2011 03:07 PM, Jeevaka Badrappan wrote:
> ---
> drivers/ifxmodem/voicecall.c | 51
> ++
> 1 files changed, 51 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c
> index 21e1944
Hi Jeevaka,
On 02/07/2011 03:07 PM, Jeevaka Badrappan wrote:
> ---
> drivers/ifxmodem/voicecall.c | 30 ++
> 1 files changed, 2 insertions(+), 28 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
___
ofono m
Hi Andrew,
if full_file_change:
notify all remaining watches
>>>
>>> In this case we have already reinitialised the SIM, so I think we
>>> don't need to do that.
>>
>> Actually we should for files that are read during pre-sim but are not
>> important enough. E.g. EFecc, EFli
Hi Andrew,
On 02/07/2011 08:22 PM, Andrzej Zaborowski wrote:
> On 8 February 2011 02:25, Denis Kenzior wrote:
>>>> Actually we should for files that are read during pre-sim but are not
>>>> important enough. E.g. EFecc, EFli, EFpl, EFiccid, etc.
>>>
>&
Hi Jeevaka,
On 02/07/2011 03:07 PM, Jeevaka Badrappan wrote:
> ---
> drivers/ifxmodem/voicecall.c | 170 -
> 1 files changed, 99 insertions(+), 71 deletions(-)
>
> diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c
> index 648f46b..c
Hi Jeevaka,
On 02/07/2011 05:02 PM, Jeevaka Badrappan wrote:
> ---
> drivers/stemodem/voicecall.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/stemodem/voicecall.c b/drivers/stemodem/voicecall.c
> index ca275cd..dd5d009 100644
> --- a/drivers/stemodem/voi
Hi Jussi,
On 02/07/2011 08:49 AM, Jussi Kangas wrote:
> ---
>
> Hi,
>
> Here is my second proposal for how to enable usage of SIM lock codes longer
> than eight digits. I removed the namespace problem and fixed a problem with
> puk reset.
>
> Br,
> Jussi
>
> include/sim.h |1 +
>
Hi Jussi,
On 02/08/2011 06:48 AM, Jussi Kangas wrote:
> ---
>
>
> Hi,
>
> On Tue, 2011-02-08 at 06:17 +0200, Denis Kenzior wrote:
>
> Why don't we keep things simple. Modify is_valid_pin to take a pin and
>> a min and max number of digits.
>>
>&g
Hi Jeevaka,
On 02/08/2011 11:04 AM, Jeevaka Badrappan wrote:
> ---
> drivers/ifxmodem/voicecall.c | 172
> --
> 1 files changed, 98 insertions(+), 74 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
___
Hi Dara,
On 02/08/2011 04:10 PM, Dara Spieker-Doyle wrote:
> Bad caps
>
> ---
> TODO |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.
Hi Gustavo,
On 02/08/2011 04:00 PM, Gustavo F. Padovan wrote:
> From: Frédéric Danis
>
> ---
> Makefile.am |1 +
> plugins/bluetooth.c | 247
> ++-
> plugins/bluetooth.h |9 ++
> 3 files changed, 254 insertions(+), 3 deletions(-)
Hi Gustavo,
This patch has been applied, but I refactored it heavily afterwards.
Can you make sure I didn't screw anything up?
Thanks,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Hi Gustavo,
On 02/08/2011 04:01 PM, Gustavo F. Padovan wrote:
> ---
> gatchat/gsmdial.c | 17 ++---
> 1 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/gatchat/gsmdial.c b/gatchat/gsmdial.c
> index 1be80e3..d54a26e 100644
> --- a/gatchat/gsmdial.c
> +++ b/gatchat/g
501 - 600 of 4644 matches
Mail list logo
