ppp issue

2011-01-26 Thread 黄叶青
Hi All, I have some issue at ppp phrase from huawei EM560. Here is the log, does anyony have any idea or give me some correct log to me to compare with. Thanks! [root@localhost gatchat]# ./gsmdial -l -a cmnet -c 1 -n /dev/ttyACM0 -m /dev/ttyACM2 Control: /dev/ttyACM0 Modem: /dev/ttyACM2 fd=3 by

Re: [PATCH] modem: do not allow more than one client to lock down

2011-01-26 Thread Marcel Holtmann
Hi Remi, src/modem.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) patch has been applied. However I added some paranoia protection for lock_owner reset to NULL. I know that in theory it is protected via lockdown == TRUE, but that is an issue bound to break something

[RFC 0/6] Add configuration support via main.conf

2011-01-26 Thread Aki Niemi
Hi all, This set of patches adds support for oFono configuration settings via main.conf. First three add the file and routines for parsing that file; the following three take a parameter in the sms atom and makes it configurable. Cheers, Aki ___ ofono

[RFC 6/6] sms: Use main configuration for 16bit ref number

2011-01-26 Thread Aki Niemi
--- src/sms.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/sms.c b/src/sms.c index 7224bdf..48d2d81 100644 --- a/src/sms.c +++ b/src/sms.c @@ -842,7 +842,6 @@ static DBusMessage *sms_send_message(DBusConnection *conn, DBusMessage *msg, GSList *msg_list;

[RFC 4/6] conf: Add ref number setting for MessageManager

2011-01-26 Thread Aki Niemi
--- src/main.conf |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/main.conf b/src/main.conf index facb950..0b23998 100644 --- a/src/main.conf +++ b/src/main.conf @@ -2,3 +2,9 @@ # List of plugins that should not be loaded on oFono startup #DisablePlugins = +

[RFC 3/6] build: Add main.conf to the build

2011-01-26 Thread Aki Niemi
--- Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index f941a19..02ea2cb 100644 --- a/Makefile.am +++ b/Makefile.am @@ -35,7 +35,7 @@ endif confdir = $(sysconfdir)/ofono -conf_DATA = +conf_DATA = src/main.conf statedir =

[PATCH 0/4] Add support for CPHS customer service profile

2011-01-26 Thread Aki Niemi
Hi all, This series adds support for CPHS CSP PLMN mode into the netreg atom. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] Don't use c++ keyword in public header files

2011-01-26 Thread Marcel Holtmann
Hi Lucas, - const char *old, const char *new, + const char *p_old, const char *p_new, ofono_sim_lock_unlock_cb_t cb, void *data); void (*lock)(struct ofono_sim *sim, enum ofono_sim_password_type type,

Re: [PATCH 0/4] Add support for CPHS customer service profile

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: one open question here is still if we also have to disallow scanning when this is set? So we might wanna update the Scan() and Register() method with the proper error codes and put a note in there for mode = auto-only. Good point,

Re: [PATCH 2/3] Use dist_ prefix as applicable

2011-01-26 Thread Marcel Holtmann
Hi Remi, Makefile.am | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/Makefile.am b/Makefile.am index f941a19..1f09c11 100644 --- a/Makefile.am +++ b/Makefile.am @@ -25,17 +25,17 @@ local_headers = $(foreach file,$(pkginclude_HEADERS) \ if DATAFILES

Re: SMS agent interface

2011-01-26 Thread Marcel Holtmann
Hi Oleg, If you aren't too busy, could you please check and comment on SMS agent interface? (the patches were sent on December 29th, maybe they were just missed somehow). Thanks! I think these got lost during the Christmas/New Years break. Can you please re-base them against the current

Re: [PATCH 0/4] Add support for CPHS customer service profile

2011-01-26 Thread Marcel Holtmann
Hi Aki, one open question here is still if we also have to disallow scanning when this is set? So we might wanna update the Scan() and Register() method with the proper error codes and put a note in there for mode = auto-only. Good point, it's also missing from the Scan()

Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: diff --git a/src/network.c b/src/network.c index b5450ee..64734d0 100644 --- a/src/network.c +++ b/src/network.c @@ -64,6 +64,7 @@ struct ofono_netreg {       int cellid;       int technology;       int mode; +     gboolean

Re: [PATCH 0/4] Add support for CPHS customer service profile

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: one open question here is still if we also have to disallow scanning when this is set? So we might wanna update the Scan() and Register() method with the proper error codes and put a note in there for mode = auto-only. Good

Re: [gprs-provision RFCPATCHv6 0/4] Plugin API for provisioning of GPRS context settings

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: lets get this merged without support for SPN for now. We can easily add this later. So please fix Denis' comments and re-submit this without the SPN change. Andrew is currently looking into fixing the SIM reading race. Once that is

[PATCH 2/2] Support for pkg-config

2011-01-26 Thread Rémi Denis-Courmont
--- .gitignore |1 + Makefile.am |3 +++ configure.ac |2 +- ofono.pc.in | 10 ++ 4 files changed, 15 insertions(+), 1 deletions(-) create mode 100644 ofono.pc.in diff --git a/.gitignore b/.gitignore index 7cfb1d9..59308be 100644 --- a/.gitignore +++ b/.gitignore @@

[PATCH 1/2] Use dist_ prefix as applicable

2011-01-26 Thread Rémi Denis-Courmont
--- Makefile.am | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/Makefile.am b/Makefile.am index f941a19..71365d7 100644 --- a/Makefile.am +++ b/Makefile.am @@ -25,7 +25,7 @@ local_headers = $(foreach file,$(pkginclude_HEADERS) \ if DATAFILES dbusconfdir =

Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

2011-01-26 Thread Marcel Holtmann
Hi Aki, -static const char *registration_mode_to_string(int mode) +static const char *registration_mode_to_string(int mode, gboolean forced_auto) { + if (forced_auto) + return auto-only; + I see the benefit of keeping this in this function, but I would not have

Re: [gprs-provision RFCPATCHv6 0/4] Plugin API for provisioning of GPRS context settings

2011-01-26 Thread Marcel Holtmann
Hi Aki, lets get this merged without support for SPN for now. We can easily add this later. So please fix Denis' comments and re-submit this without the SPN change. Andrew is currently looking into fixing the SIM reading race. Once that is done we can tackle the SPN part. Feel free to

Re: [PATCH 1/2] Use dist_ prefix as applicable

2011-01-26 Thread Marcel Holtmann
Hi Remi, Makefile.am | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) patch has been applied, but in the future please prefix the subject with something like build: or similar. Regards Marcel ___ ofono mailing list

Re: [PATCH 2/2] Support for pkg-config

2011-01-26 Thread Marcel Holtmann
Hi Remi, .gitignore |1 + Makefile.am |3 +++ configure.ac |2 +- ofono.pc.in | 10 ++ 4 files changed, 15 insertions(+), 1 deletions(-) create mode 100644 ofono.pc.in diff --git a/.gitignore b/.gitignore index 7cfb1d9..59308be 100644 --- a/.gitignore +++

Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: That is how I originally had it, but this ends up being a bit less code. Also, I'd like to localize all of these constant strings into a single function and not sprinkle them across the code. so I am counting two callers to

Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

2011-01-26 Thread Marcel Holtmann
Hi Aki, Just on a different thought here. The NETWORK_REGISTRATION_MODE_* is local to src/network.c. We could just add the AUTO_ONLY mode there. The only downside I is see the already nasty init_registration_status check, but that might be acceptable compared to crippling the string

Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann mar...@holtmann.org: can you have a stab at this and check how a patch would look like if we just add another mode. If I am not mistaken we only have the extra code in the init_registration_status. I could be wrong here since I have not looked through that

[PATCH 2/5] ofono.h: add gprs-provision

2011-01-26 Thread Jukka Saunamaki
--- src/ofono.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index e48dbf6..056c7f1 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -420,3 +420,12 @@ void __ofono_nettime_info_received(struct ofono_modem *modem, #include

[PATCH 1/5] gprs-provision: add driver API header

2011-01-26 Thread Jukka Saunamaki
--- Makefile.am |3 +- include/gprs-provision.h | 59 ++ 2 files changed, 61 insertions(+), 1 deletions(-) create mode 100644 include/gprs-provision.h diff --git a/Makefile.am b/Makefile.am index f941a19..f543135 100644 ---

[PATCH 5/5] gprs-provision: add example context provisioning driver

2011-01-26 Thread Jukka Saunamaki
--- Makefile.am |3 ++ examples/provision.c | 95 ++ 2 files changed, 98 insertions(+), 0 deletions(-) create mode 100644 examples/provision.c diff --git a/Makefile.am b/Makefile.am index 9c4f383..c70dcbf 100644 --- a/Makefile.am

[PATCH 4/5] gprs: add gprs context provisioning

2011-01-26 Thread Jukka Saunamaki
--- src/gprs.c | 99 +-- 1 files changed, 95 insertions(+), 4 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 92d0b1a..7fad23b 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -43,6 +43,8 @@ #include common.h #include storage.h

[PATCH 3/5] gprs-provision: add driver API sources

2011-01-26 Thread Jukka Saunamaki
--- Makefile.am |2 +- src/gprs-provision.c | 104 ++ 2 files changed, 105 insertions(+), 1 deletions(-) create mode 100644 src/gprs-provision.c diff --git a/Makefile.am b/Makefile.am index f543135..9c4f383 100644 --- a/Makefile.am

[gprs-provision PATCHv7 0/5] Plugin API for provisioning of GPRS context settings

2011-01-26 Thread Jukka Saunamaki
Hello And again a patchset about automatic provisioning of GPRS context settings. Since the safe reading of EF-SPN turned out to be impossible until general solution is implemented, I must temporary give up my insistence on it. So the following provisioning driver API must be considered as

[PATCH] test: Add support for DisplayActionInformation

2011-01-26 Thread Jeevaka Badrappan
--- test/test-stk-menu |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/test/test-stk-menu b/test/test-stk-menu index 85b98ca..639fe77 100755 --- a/test/test-stk-menu +++ b/test/test-stk-menu @@ -192,6 +192,12 @@ class StkAgent(dbus.service.Object): if

Re: [PATCH 2/2] Support for pkg-config

2011-01-26 Thread Rémi Denis-Courmont
On Wednesday 26 January 2011 13:27:23 ext Marcel Holtmann, you wrote: prefix=@prefix@ exec_prefix=@exec_prefix@ libdir=@libdir@ includedir=@includedir@ plugindir=${libdir}/@PACKAGE@/plugins Name: @PACKAGE@ Description: oFono - Open Source Telephony Requires: glib-2.0 dbus-1 Version:

Re: [PATCH 2/2] Support for pkg-config

2011-01-26 Thread Marcel Holtmann
Hi Remi, prefix=@prefix@ exec_prefix=@exec_prefix@ libdir=@libdir@ includedir=@includedir@ plugindir=${libdir}/@PACKAGE@/plugins Name: @PACKAGE@ Description: oFono - Open Source Telephony Requires: glib-2.0 dbus-1 Version: @VERSION@ Libs: -module -avoid-version

Re: [PATCH] test: Add support for DisplayActionInformation

2011-01-26 Thread Marcel Holtmann
Hi Jeevaka, test/test-stk-menu |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] stk: Fix issue in stk_alpha_id_set

2011-01-26 Thread Jeevaka Badrappan
Fixes the crash seen when the null alpha identifier. Also removed the icon check as icon will always be a valid pointer. --- src/stk.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/stk.c b/src/stk.c index 29d2087..c968eef 100644 --- a/src/stk.c +++ b/src/stk.c @@

Bug tracking for oFono

2011-01-26 Thread Sjur Brændeland
Hi, I notice that there has been a couple of bug reports sent on this list lately, and usually the response is care to send a patch for it?. oFono homepage states: A bug tracking system is in the process of being set up. What is the status of this? It seems to be possible to submit bugs on

[PATCH v3 1/7] gps: add public header

2011-01-26 Thread Rafael Ignacio Zurita
--- Makefile.am |2 +- include/gps.h | 76 + 2 files changed, 77 insertions(+), 1 deletions(-) create mode 100644 include/gps.h diff --git a/Makefile.am b/Makefile.am index 9933e32..7374f70 100644 --- a/Makefile.am +++

[PATCH v3 4/7] plugins: add gps atom to mbm

2011-01-26 Thread Rafael Ignacio Zurita
--- plugins/mbm.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/plugins/mbm.c b/plugins/mbm.c index 4048f6a..3732735 100644 --- a/plugins/mbm.c +++ b/plugins/mbm.c @@ -45,6 +45,7 @@ #include ofono/gprs.h #include ofono/gprs-context.h #include ofono/log.h

[RFC 1/5] gprs: Update documentation for IPv6

2011-01-26 Thread Mika Liljeberg
--- doc/connman-api.txt | 48 +++- 1 files changed, 43 insertions(+), 5 deletions(-) diff --git a/doc/connman-api.txt b/doc/connman-api.txt index 22c59dc..b885725 100644 --- a/doc/connman-api.txt +++ b/doc/connman-api.txt @@ -152,6 +152,15 @@

Re: Ofono CF states not always correct

2011-01-26 Thread Denis Kenzior
Hi Jarko, On 01/26/2011 03:14 AM, Jarko Poutiainen wrote: Hi Denis, First sorry for slow reply. On Tue, 2011-01-18 at 23:50 +0200, Denis Kenzior wrote: So my thinking is that we should: - Not update conditional cfs when cfu is active (whether via GetProperties or mmi) - only clear the

[PATCH v2] stk: Fix issue in stk_alpha_id_set

2011-01-26 Thread Jeevaka Badrappan
Fixes the crash seen with the null alpha identifier. Also removed the icon check as icon will always be a valid pointer. --- src/stk.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/stk.c b/src/stk.c index 29d2087..8ae3346 100644 --- a/src/stk.c +++

[PATCH v3] stk: Fix issue in stk_alpha_id_set

2011-01-26 Thread Jeevaka Badrappan
Fixes the crash seen with the null alpha identifier. Also removed the icon check as icon will always be a valid pointer. --- src/stk.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/stk.c b/src/stk.c index 29d2087..b0be7b8 100644 --- a/src/stk.c +++ b/src/stk.c

Re: [gprs-provision PATCHv7 0/5] Plugin API for provisioning of GPRS context settings

2011-01-26 Thread Denis Kenzior
Hi Jukka, On 01/26/2011 06:34 AM, Jukka Saunamaki wrote: Hello And again a patchset about automatic provisioning of GPRS context settings. Since the safe reading of EF-SPN turned out to be impossible until general solution is implemented, I must temporary give up my insistence on it.

Re: [PATCH v3] stk: Fix issue in stk_alpha_id_set

2011-01-26 Thread Denis Kenzior
Hi Jeevaka, On 01/26/2011 02:15 PM, Jeevaka Badrappan wrote: Fixes the crash seen with the null alpha identifier. Also removed the icon check as icon will always be a valid pointer. --- src/stk.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) Applied with a slightly

Re: [PATCH v3 7/7] gps: add documentation

2011-01-26 Thread Gustavo F. Padovan
Hi Rafael, * Rafael Ignacio Zurita rafael.zur...@profusion.mobi [2011-01-26 12:32:54 -0300]: --- Makefile.am |3 +- doc/gps-api.txt | 49 ++ 2 files changed, 51 insertions(+), 1 deletions(-) create mode 100644

Re: [PATCH v3 2/7] gps: add gps atom and gpsagent implementations

2011-01-26 Thread Rafael Ignacio Zurita
Hi Gustavo, On Wed, Jan 26, 2011 at 07:51:57PM -0200, Gustavo F. Padovan wrote: Hi Rafael, * Rafael Ignacio Zurita rafael.zur...@profusion.mobi [2011-01-26 12:32:49 -0300]: --- Makefile.am|3 +- src/gps.c | 326

Re: [PATCH v3 2/7] gps: add gps atom and gpsagent implementations

2011-01-26 Thread Gustavo F. Padovan
* Rafael Ignacio Zurita rafael.zur...@profusion.mobi [2011-01-26 19:11:46 -0300]: Hi Gustavo, On Wed, Jan 26, 2011 at 07:51:57PM -0200, Gustavo F. Padovan wrote: Hi Rafael, * Rafael Ignacio Zurita rafael.zur...@profusion.mobi [2011-01-26 12:32:49 -0300]: --- Makefile.am

[PATCH 0/1] Remove ofono_cug_option

2011-01-26 Thread Jeevaka Badrappan
Hi, Following patch removes the ofono_cug_option enum and its usage across ofono. Regards, Jeevaka Jeevaka Badrappan (1): remove ofono_cug_option drivers/atmodem/voicecall.c | 12 ++-- drivers/calypsomodem/voicecall.c |9 - drivers/hfpmodem/voicecall.c |4

[PATCH 1/1] remove ofono_cug_option

2011-01-26 Thread Jeevaka Badrappan
--- drivers/atmodem/voicecall.c | 12 ++-- drivers/calypsomodem/voicecall.c |9 - drivers/hfpmodem/voicecall.c |4 ++-- drivers/huaweimodem/voicecall.c |9 - drivers/ifxmodem/voicecall.c | 12 ++-- drivers/isimodem/voicecall.c |

Re: [PATCH 1/1] remove ofono_cug_option

2011-01-26 Thread Denis Kenzior
Hi Jeevaka, On 01/26/2011 04:17 PM, Jeevaka Badrappan wrote: --- drivers/atmodem/voicecall.c | 12 ++-- drivers/calypsomodem/voicecall.c |9 - drivers/hfpmodem/voicecall.c |4 ++-- drivers/huaweimodem/voicecall.c |9 -

Re: [PATCH 1/3] message-waiting: check for NULL argument

2011-01-26 Thread Denis Kenzior
Hi Pekka, On 01/21/2011 06:44 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com --- src/message-waiting.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 2/3] message-waiting: add allocation checks

2011-01-26 Thread Denis Kenzior
Hi Pekka, On 01/21/2011 06:44 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com --- src/message-waiting.c | 45 ++--- 1 files changed, 30 insertions(+), 15 deletions(-) diff --git a/src/message-waiting.c

RE: [PATCH v5] ifx: Adding modem selftest for Infineon modem

2011-01-26 Thread Benis, Robertino
Hi Marcel, Infineon modem selftest, during ifx_enable(). Two steps trigger, with timeout. In case one fails, modem will not power up. snip + flags = g_io_channel_get_flags(data-device) | G_IO_FLAG_NONBLOCK; + g_io_channel_set_flags(data-device, flags, NULL); + +

Re: [gprs-provision PATCHv7 0/5] Plugin API for provisioning of GPRS context settings

2011-01-26 Thread Jukka Saunamaki
Hello Denis, On Wed, 2011-01-26 at 14:56 -0600, ext Denis Kenzior wrote: And again a patchset about automatic provisioning of GPRS context settings. Since the safe reading of EF-SPN turned out to be impossible until general solution is implemented, I must temporary give up my insistence

Re: [gprs-provision PATCHv7 0/5] Plugin API for provisioning of GPRS context settings

2011-01-26 Thread Marcel Holtmann
Hi Denis, And again a patchset about automatic provisioning of GPRS context settings. Since the safe reading of EF-SPN turned out to be impossible until general solution is implemented, I must temporary give up my insistence on it. So the following provisioning driver

Re: [RFC] doc: Proposal for LTE/IMS API.

2011-01-26 Thread Rémi Denis-Courmont
Hello, On Wednesday 26 January 2011 16:59:03 ext Sjur Brændeland, you wrote: Features: - The QoS information is presented as an array of QoS settings with an associated list IP Packet Filters. Only the QoS data for connection context of type IMS will be reported. The

Re: EF-SPN API (was: [gprs-provision PATCHv7 0/5] Plugin API for provisioning of GPRS context settings)

2011-01-26 Thread Jukka Saunamaki
Hi Marcel, On Thu, 2011-01-27 at 08:37 +0100, ext Marcel Holtmann wrote: you can have a look on what it would take to store a) read SPN in the SIM atom and store it and b) let netreg atom use that value. Simple solution for this would be something like: ... don't make this