Re: [PATCH 1/2] gprs:Add code to handle AT+CGDCONT

Hi Denis and Marcel, Hi Denis, --- include/gprs.h |2 + src/gprs.c | 63 2 files changed, 65 insertions(+), 0 deletions(-) So I went in a slightly different direction with the emulator API. Can you please have a look?

[PATCH] test: fix parameter type error in 'test-advice-of-charge'-script

--- test/test-advice-of-charge |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/test-advice-of-charge b/test/test-advice-of-charge index d71b7c6..9f3f655 100755 --- a/test/test-advice-of-charge +++ b/test/test-advice-of-charge @@ -73,7 +73,7 @@ if __name__ ==

Re: [PATCH 04/18] gisi: fix subscription for wgmodem2.5

Hi Andreas, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com:                if (legacy)                        msg[3 + count] = mux-resource; -               else +               else {                        /* Resource field is 32bit and Little-endian */                        

Re: [PATCH 03/18] isimodem: general build updates for wgmodem2.5

Hi, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/debug.c |   48 ++  drivers/isimodem/debug.h |    8 +++  drivers/isimodem/mtc.h   |   38

Re: [PATCH 04/18] gisi: fix subscription for wgmodem2.5

Hi Aki, On 2011-02-16 12:16, Aki Niemi wrote: Curly brackets are either in both if and else, or in neither. I actually prefer not to have them here, since the first line is just a comment in the else statement. ;) Yes you're right :) This is not necessary, as a modem plugin is supposed to

Re: [PATCH 04/18] gisi: fix subscription for wgmodem2.5

Hi Andreas, 2011/2/16 Andreas WESTIN andreas.wes...@stericsson.com: Tested and works fine, will submit a new patch for the u8500 plugin. This is not done in the n900 plugin though, perhaps not necessary ? The default is PN_DEV_HOST, which is what the N900 uses. Cheers, Aki

[PATCH 1/1] src: out of bounds problem in smsutil

--- This one was exposed when wgmodem2.5 CBS was run with valgrind. Best Regards, Jessica Nilsson src/smsutil.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 5524932..b3a1ba1 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@

Re: [PATCH 07/18] isimodem: add wgmodem2.5 to devinfo

Hi, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com: @@ -111,17 +115,22 @@ static void isi_query_manufacturer(struct ofono_devinfo *info,        struct devinfo_data *dev = ofono_devinfo_get_data(info);        struct isi_cb_data *cbd = isi_cb_data_new(dev, cb, data); +       if (cbd

Re: [PATCH 16/18] isimodem: sms updated with wgmodem2.5

Hi, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/debug.c |   56 +++  drivers/isimodem/debug.h |    1 +  drivers/isimodem/sms.c   |  972 +++---  

Re: [PATCH 05/18] plugins: add plugin for u8500

Hi, 2011/2/15 Andreas Westin andreas.wes...@stericsson.com: +static int u8500_probe(struct ofono_modem *modem) +{ +       const char *ifname = ofono_modem_get_string(modem, Interface); +       unsigned address = ofono_modem_get_integer(modem, Address); +       GIsiModem *isimodem; +      

Re: [PATCH 16/18] isimodem: sms updated with wgmodem2.5

Hi, On 2011-02-16 15:22, Aki Niemi wrote: Hi, 2011/2/15 Andreas Westinandreas.wes...@stericsson.com: From: Jessica Nilssonjessica.j.nils...@stericsson.com --- drivers/isimodem/debug.c | 56 +++ drivers/isimodem/debug.h |1 + drivers/isimodem/sms.c | 972

Re: [PATCH 1/1] src: out of bounds problem in smsutil

Hi Jessica, On 02/16/2011 06:04 AM, Jessica Nilsson wrote: --- This one was exposed when wgmodem2.5 CBS was run with valgrind. Best Regards, Jessica Nilsson Can you post the actual error and the data this happened on? src/smsutil.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH 05/18] plugins: add plugin for u8500

On 2011-02-16 15:26, Aki Niemi wrote: Hi, 2011/2/15 Andreas Westinandreas.wes...@stericsson.com: +static int u8500_probe(struct ofono_modem *modem) +{ + const char *ifname = ofono_modem_get_string(modem, Interface); + unsigned address = ofono_modem_get_integer(modem, Address); +

Re: [PATCH] plugins/ofono.rules: add ID for Sierra Wireless MC8790

Hi Jan, On 02/16/2011 09:34 AM, Jan Luebbe wrote: --- plugins/ofono.rules |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 1/1] src: out of bounds problem in smsutil

On 2011-02-16 16:25, Denis Kenzior wrote: Hi Jessica, On 02/16/2011 06:04 AM, Jessica Nilsson wrote: --- This one was exposed when wgmodem2.5 CBS was run with valgrind. Best Regards, Jessica Nilsson Can you post the actual error and the data this happened on? src/smsutil.c |2 +-

Re: [PATCH 1/1] src: out of bounds problem in smsutil

Hi Andreas, } /* Space for ranges, commas and terminator null */ -ret = g_new(char, len + nelem); +ret = g_new0(char, len + nelem + 1); I'm having trouble seeing how the old code was wrong. nelem contains the number of elements. Since the last element does not end

Re: [PATCH 17/18] isimodem: CBS for wgmodem2.5

Hi Andreas, +static void reset_buf(char *buf, char *buf_2, int buf_len) +{ + memset(buf, '\0', buf_len); + memset(buf_2, '\0', buf_len); +} + +static int get_topics_len(const char *topics) +{ + int i = 0; + int k = 0; + int length = 0; + char buf[6]; +

Re: [PATCH 1/1] src: out of bounds problem in smsutil

Hi, Valgrind complains that we step outside the allocated memory by 1 byte since we loop the string with: while (*topics != '\0') the allocated memory is the size of the string and any \0 ends up outside. At least that's my interpretation. It might be your loop is actually going past the

[PATCH] bluetooth: disconnect HFP AG clients

Clients should be disconnected when VoiceCall atom is unregistered --- plugins/hfp_ag.c | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/plugins/hfp_ag.c b/plugins/hfp_ag.c index cbf3ccd..5fba13d 100644 --- a/plugins/hfp_ag.c +++ b/plugins/hfp_ag.c @@

[PATCH] TODO: Add STK class 'e' tasks

--- TODO | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 9bd21d6..80b68fb 100644 --- a/TODO +++ b/TODO @@ -337,6 +337,36 @@ Sim Toolkit Priority: High Complexity: C8 +- Support of the BIP (Bearer Independent

Re: [PATCH] bluetooth: rename hfp.c in hpf_hf.c

Hi Frédéric, On 02/16/2011 10:25 AM, Frédéric Danis wrote: --- Makefile.am |2 +- plugins/hfp.c| 719 -- plugins/hfp_hf.c | 719 ++ 3 files changed, 720 insertions(+),

Re: [V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

Hi Martin, On 02/15/2011 01:03 AM, Xu, Martin wrote: Denis/Marcel: -Original Message- From: Denis Kenzior [mailto:denk...@gmail.com] Sent: Tuesday, February 15, 2011 4:28 AM To: ofono@ofono.org Cc: Xu, Martin Subject: Re: [V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

[PATCH 1/2] gsmdial: add option for Bluetooth DUN dialing

--- gatchat/gsmdial.c | 19 --- 1 files changed, 16 insertions(+), 3 deletions(-) diff --git a/gatchat/gsmdial.c b/gatchat/gsmdial.c index 1be80e3..bae5efb 100644 --- a/gatchat/gsmdial.c +++ b/gatchat/gsmdial.c @@ -56,6 +56,7 @@ static gboolean option_legacy = FALSE; static

Re: [V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

Hi Denis, This contradicts commit bb58a729073abcb6c5b0b2fb8b120973dfa42a07. I can't quite understand why Dietrich needs to this commit. We formal configure can just make EM770W works. Could you help on this? The Huawei firmware is funny, it can actually reconfigure the modem and pcui

RE: [PATCH] Enable hs 2330 MBM modem

Hi Zhigan, + g_str_has_suffix(desc, Data Modem) || I think this should be Module Data Modem. This is confusing part, with my test with this modem on MeeGo image, the Module Data Modem doesn't work and only Data Modem works. So I think it should be ok. looks wrong

RE: [PATCH] Enable hs 2330 MBM modem

I think this should be Module Data Modem. looks wrong to me. Please get the lsusb -v out for this modem where it lists the interface strings. Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber1 bAlternateSetting 0