Hi,
Please ignore the mails I just sent today. It seems git-send-email cached my
mail threads locally
and still try to resend them when I come back to the office.
The mail contents are exactly the same as I sent last week.
Regards,
Zhenhua
___
ofono
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> +static void hfp_call_volume_initialized(gpointer user_data) {
>> +struct ofono_call_volume *cv = user_data;
>> +struct cv_data *vd = ofono_call_volume_get_data(cv); +
>> +DBG("");
>> +
>> +g_at_chat_register(vd->chat, "+VGS:", vgs
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> There're two cases of outgoing call: dial from HF or dial from phone.
>>
>> In the first case, some phones may not support enhanced call status
>> (AT+CLCC) to query outgoing number. So we need to pass struct
>> atd_cb_data to fill in the number
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> +static void reset_to_single_call(struct voicecall_data *vd) {
>> + struct ofono_call *oc = vd->calls->data;
>> +
>> + vd->call = oc;
>> + vd->cind_val[HFP_INDICATOR_CALL] = 1;
>> +
>> + if (oc->direction == 1)
>> +
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> +ofono_voicecall_notify(vc, call);
>> +
>
> As I mentioned above, you do not need to do this. oFono will
> synthesize the outgoing call properly. Worst case we will
> send a PropertyChanged signal after CLCC is polled and the new number
> i
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> First, call->status should be 1 stead of 2 in the loop. Second, it's
>> incorrect to set status to hold because later callheld=1 will swap
>> call status back. So active->hold->active again is not correct.
>
> Unfortunately we do need to put the
Hi Marcel,
Marcel Holtmann wrote:
> Hi Zhenhua,
>
>> When using CHLD=2x in multiparty call, call_held is 1 and we should
>> not swap all active->held. So we cannot save this pull in private
>> chat. ---
>> drivers/hfpmodem/voicecall.c | 50
>> +
>> 1 fil
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> Use AT+CLCC to get current call list.
>
> So I did things 'slightly' differently. The new setup should
> be much simpler for both the plugin and the core. I've tested
> it on phonesim, but not on HFP.
> Can you let me know if there are any issu
Hi,
Zhang, Zhenhua wrote:
> We should remove all atoms when we disable the modem. In
> function set_powered, we remove all atoms if modem is powered down by
> dbus call. ---
> src/modem.c |3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
Let me explain more
Hi,
Zhang, Zhenhua wrote:
> If we are in multiparty call, remote AG won't update indicator
> if any call in multiparty call is released by CHLD=1x. So we have to
> poll it periodically. ---
> drivers/hfpmodem/voicecall.c | 37
> +
&
Hi,
Zhang, Zhenhua wrote:
> Use AT+CHLD=1x to release a specific call if AG supports that. ---
> drivers/hfpmodem/voicecall.c | 51
> +-
> 1 files changed, 50 insertions(+), 1 deletions(-)
>
Update the patch to initlize 'struct rel
Hi,
Zhang, Zhenhua wrote:
> Similar to atmodem, We need schedule CLCC poll in the ring
> notify in case AG doesn't send CLIP notification to us. If
> CLIP comes right after RING, we cancel the CLCC poll. ---
> drivers/hfpmodem/voicecall.c | 15 +++
> 1 files ch
Hi,
Zhang, Zhenhua wrote:
> Hi,
>
> Zhang, Zhenhua wrote:
>> If we are in multiparty call, remote AG won't update indicator if any
>> call in multiparty call is released by CHLD=1x. So we have to poll
>> it periodically. --- dri
Hi,
Zhang, Zhenhua wrote:
> Hi,
>
> Zhang, Zhenhua wrote:
>> Similar to atmodem, We need schedule CLCC poll in the ring notify in
>> case AG doesn't send CLIP notification to us. If CLIP comes right
>> after RING, we cancel the CLCC poll. ---
>&g
Xu, Martin wrote:
>> -Original Message-
>> From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On
>> Behalf Of Marcel Holtmann Sent: Friday, December 25, 2009 12:22 AM
>> To: ofono@ofono.org
>> Subject: Merry Christmas to everyone
>>
>> Hello everyone,
>>
>> and Santa is coming
Hi,
I found N900 could not be powered on by atgen driver due to baud rate problem.
If I add 'Baud=115200' into modem.conf, everything is fine. In gatchat/gattty.c,
the default baud rate is B0 which looks not correct, so I wonder whether we
should set the default baud rate to some values like minic
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> +gboolean g_at_util_set_io(GIOChannel *io)
>
> Rename this g_at_util_setup_io
>
>> +typedef void (*GAtDisconnectFunc)(gpointer user_data); typedef void
>> +(*GAtDebugFunc)(const char *str, gpointer user_data);
>
> These don't belong here, creat
Hi Feifei,
You can see ofono/plugins/example_history.c for getting history. You can
customize your own plugin to record the sms/voicecall history into file or
database as you want. You can "export OFONO_AT_DEBUG=1; ofono/src/ofonod -nd"
to see oFono debug log.
Regards,
Zhenhua
Hi Padovan,
Gustavo F. Padovan wrote:
>> New version of the patches. Known issues:
>> "'org.bluez.HandsfreeAgent.Release' part not implemented" and it's
>> not working with more than one bluetooth devices in some cases.
>> Comments are welcome.
>>
>
> Another new version of the patches. Now ofo
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> ---
>> gatchat/gatserver.c | 182
>> +++---
>> gatchat/gatserver.h | 7 ++- 2 files changed, 133 insertions(+),
>> 56 deletions(-)
>>
>> -at_command_notify(server, buf, prefix, type);
>> +n
Hi Padovan,
Gustavo F. Padovan wrote:
> Hi all,
>
> I'm starting the DUN Client implementation for the Linux
> Stack. DUN is the Bluetooth dial-up network profile. It makes
> possible share internet connection between two Bluetooth
> devices. That is my Google Summer of Code project for this year
Hi Padovan,
Gustavo F. Padovan wrote:
> Hi Zhenhua,
>
> * Zhang, Zhenhua [2010-04-27 10:14:38
> +0800]:
>
>> Hi Padovan,
>>
>> Gustavo F. Padovan wrote:
>>> Hi all,
>>>
>>> I'm starting the DUN Client implementation for the
Hi,
I am now working on modem emulator and one usage is for DUN server role. Since
Padovan is working on client role, it's good to share my rough thinking for
server side implementation. Here are the simple steps I have:
1. Create an oFono emulator atom in oFono. It's the emulator manager that
Hi Padovan,
Gustavo F. Padovan wrote:
> Hi Zhenhua,
>
> * Zhang, Zhenhua [2010-04-27 15:53:54
> +0800]:
>
>> Hi,
>>
>> I am now working on modem emulator and one usage is for DUN
> server role. Since Padovan is working on client role, it's
> goo
Hi,
Zhang, Zhenhua wrote:
> Sometimes, Udev device 'remove' event could not report correct
> parent node of current udev_device. Current code replies on
> the devpath attached on the parent node to find modem and then
> remove it.
>
> This fix is to change the way to
Hi,
Zhang, Zhenhua wrote:
> To avoid the race condition that modem is registered before we
> retrieve the data device property.
> ---
The second patch is for MBM modem only. We should retrieve data device property
before register the modem. Please review it. Thanks.
Regards
Hi Krishna,
From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On
Behalf Of krishna k
Sent: Monday, May 10, 2010 1:24 PM
To: ofono@ofono.org
Subject: How to start ofono-phonesim in ubuntu-10.04 -reg
Hi Yoon,
Th
Hi Krishna,
From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On
Behalf Of krishna k
Sent: Monday, May 10, 2010 2:43 PM
To: ofono@ofono.org
Subject: How to start ofono-phonesim in ubuntu-10.04 -reg
Hi Zhenhua,
Hi Krishna,
From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On
Behalf Of krishna k
Sent: Monday, May 10, 2010 4:13 PM
To: ofono@ofono.org
Subject: How to start ofono-phonesim in ubuntu-10.04 -reg
Hi Yoon,
I
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> +static gboolean search_entry(const char *str, struct error_entry
>> *e, +int maxentries, +
>> enum
> ofono_error_type type,
>> +
Hi Kalle,
Kalle Valo wrote:
> Kalle Valo writes:
>
>> while working on third version of my huawei gprs patches I noticed
>> that this commit breaks huawei:
>>
>> commit af976f7e524746b1b55645967e11ab8250f593a8
>> Author: Zhenhua Zhang
>> Date: Tue May 11 09:04:28 2010 +0800
>>
>> Fix Us
Hi Padovan,
Gustavo F. Padovan wrote:
> --- plugins/bluetooth.c | 482
> +++
> plugins/hfp.c | 458
>
> 2 files changed, 518 insertions(+), 422 deletions(-)
>
> diff --git a/plugins/bluetooth.c b
Hi Valo,
Kalle Valo wrote:
> ---
>
> drivers/atmodem/gprs-context.c | 56
> +---
> 1 files changed, 18 insertions(+), 38 deletions(-)
>
> diff --git a/drivers/atmodem/gprs-context.c
> b/drivers/atmodem/gprs-context.c
> index ba5f0c0..794db8a 100644
> --- a/dr
Hi Kalle,
Kalle Valo wrote:
> Hi,
>
> I mentioned this briefly on irc, but I'll inform it here as well. This
> patch broke ofono support for my Huawei E1552:
>
> commit 6ab0b6f29acc8f6b2a5f3b94c02c405ee7318244
> Author: Marcel Holtmann
> Date: Sun Jun 6 15:51:36 2010 -0700
>
>Fix detecti
Hi,
Zhenhua Zhang wrote:
> ---
> gatchat/gsmdial.c | 17 +++--
> 1 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/gatchat/gsmdial.c b/gatchat/gsmdial.c
> index 59f1a5c..d6cacc5 100644
> --- a/gatchat/gsmdial.c
> +++ b/gatchat/gsmdial.c
I think we should delay the p
Hi, Ye,
First, please send plain text mail to oFono mailing list next time. Please see
my reply below.
Regards,
Zhenhua
From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On
Behalf Of Huang, Ye
Sent: Monday, June 14, 2010 10:24 AM
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> 1. Add interface to set PPP server info by g_at_ppp_set_server_info.
>> 2. Pass local and peer address through IPCP handshaking.
>> ---
>
> Its great that you're working on the PPP Server extensions.
> Can I get you to
> submit a patch taking own
Hi,
I updated patch 1/5 according to the comments. The rest 4 patches were
unchanged with the previous version.
Please review them. Thanks!
Regards,
Zhenhua
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> static enum rcr_result ipcp_rcr(struct pppcp_data *pppcp,
>> const struct
> pppcp_packet *packet,
>> guint8 **new_options,
> guint16 *new_len)
>> {
>> struct ppp_opti
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
+void ipcp_set_server_info(struct pppcp_data *pppcp, guint32
local_addr, + guint32
> peer_addr, + guint32 dns1, guint32 dns2,
+ guint32 nbns1, guint32 nbns2
Hi Andrew,
andrzej zaborowski wrote:
> Hi,
>
> I have a minimal GUI client that I recently started using for testing
> some new ofono features, and thought that others might want to use
> something like that too. It currently only supports Voicecall atom
> (two-party calls only), voicemail, PIN
Hi Marcel,
Marcel Holtmann wrote:
> Hi Zhenhua,
>
>> Change static IP netmask to 255.255.255.255.
>> ---
>> drivers/mbmmodem/gprs-context.c |2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mbmmodem/gprs-context.c
> b/drivers/mbmmodem/gprs-context.c
>> in
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> 1. Add interface to set PPP server info by g_at_ppp_set_server_info.
>> 2. Pass local and peer address through IPCP handshaking.
>
> Ok getting pretty close now :)
>
>> +static void ipcp_reset_server_config_options(struct ipcp_data
>> *ipcp) +{
Hi Denis,
Zhang, Zhenhua wrote:
> Hi Denis,
>
>> As mentioned above, if Primary / Secondary NBNS server is sent
>> by the client,
>> we need to Conf-Rej just those options to the client. Any
>> other unrecognized
>> options should also be Conf-Rejected. The
Hi Denis,
Zhenhua Zhang wrote:
> So that gsmdial and wvdial could talk to test-server and establish
> PPP connection. ---
> gatchat/test-server.c | 131
> ++---
> 1 files changed, 123 insertions(+), 8 deletions(-)
>
> diff --git a/gatchat/test-server.c
Hi Kalle,
Kalle Valo wrote:
> Hi,
>
> (gdb) bt
> #0 0x7790b642 in IA__g_atomic_int_exchange_and_add
>(atomic=0x0, val=-1) at
> /build/buildd/glib2.0-2.25.8/glib/gatomic-gcc.c:30 #1
> 0x004325a3 in g_at_ppp_unref (ppp=0x0) at
>gatchat/gatppp.c:448 #2 0x00448e12 i
Hi,
Zhang, Zhenhua wrote:
> Hi Kalle,
>
> Kalle Valo wrote:
>> Hi,
>>
>> (gdb) bt
>> #0 0x7790b642 in IA__g_atomic_int_exchange_and_add
>> (atomic=0x0, val=-1) at
>> /build/buildd/glib2.0-2.25.8/glib/gatomic-gcc.c:30 #1
>>
Hi Marcel,
Marcel Holtmann wrote:
> Hi Zhenhua Zhang,
>
>> Huawei EM770W is a 3G WCDMA modem that supports
>> HSPA/UMTS/EDGE/GPRS/GSM data service and WCDMA/GSM short message
>> services. It also has voice call capability that supports both 2G
>> and 3G network. --- plugins/huawei.c| 31
>>
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>>> static void server_destroy(gpointer user)
>>> @@ -706,15 +825,11 @@ static void server_destroy(gpointer user)
>>>
>>> static void set_raw_mode(int fd)
>>> {
>>> - struct termios options;
>>> -
>>> - tcgetattr(fd,&options);
>>> -
>>> - /* S
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>>> static void server_destroy(gpointer user)
>>> @@ -706,15 +825,11 @@ static void server_destroy(gpointer user)
>>>
>>> static void set_raw_mode(int fd)
>>> {
>>> - struct termios options;
>>> -
>>> - tcgetattr(fd,&options);
>>> -
>>> - /* S
Hi Suraj,
suraj wrote:
> Hi Zhenhua,
>
>
> On Wed, 2010-05-05 at 06:27 +0530, Zhang, Zhenhua wrote:
>> Hi Padovan,
>>
>> Gustavo F. Padovan wrote:
>>> Hi Zhenhua,
>>>
>>> * Zhang, Zhenhua [2010-04-27 15:53:54
>>> +0800]:
&
Hi,
Zhenhua Zhang wrote:
> If we destroy PPP instance from g_at_ppp_unref, we should not invoke
> io disconnect function. ---
> gatchat/gathdlc.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gatchat/gathdlc.c b/gatchat/gathdlc.c
> index 08a1939..0186e46 100644
> --
Hi Marcel,
Marcel Holtmann wrote:
> Hi Zhenhua,
>
>> Use cfmakeraw to disable echoing and special characters processing.
>> If we don't turn off ICRNL, TTY layer translates \r\n to \n\n. ---
>> gatchat/test-server.c |8 +++-
>> 1 files changed, 3 insertions(+), 5 deletions(-)
>>
>> diff
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> @@ -278,6 +278,7 @@ void g_at_hdlc_unref(GAtHDLC *hdlc)
>> hdlc->record_fd = -1; }
>>
>> +g_at_io_set_disconnect_function(hdlc->io, NULL, NULL);
>
> Since GAtHDLC does not set the disconnect function, this really
> belongs in GAtPPP.
Hi,
[Fix misleading title and content in previous 0/15 mail. Sorry for that.]
This series are based on the previous 6 patches "Add oFono DUN emulator" sent
on July 5th. It implements the main functionality of DUN server and interact
with GPRS atom to create DUN context. You can use gatchat/test
Hi Remi,
Marcel Holtmann wrote:
> Hi Remi,
>
>>> +static void cfun_cb(GAtServerRequestType type, GAtResult *cmd,
>>> + gpointer user_data) +{
>>> + struct ofono_emulator *e = user_data;
>>> + char buf[50];
>>> +
>>> + switch (type) {
>>> + case G_AT_SERVE
Marcel Holtmann wrote:
> Hi Zhenhua,
>
>> We use IPCP NAK response to stall the progress of acquiring the
>> client IP address from DHCP server. So we need to increase the max
>> failure of NAKs in IPCP handshaking. ---
>> gatchat/ppp_cp.c |8 ++--
>> gatchat/ppp_cp.h |2 +-
>> ga
Hi Padovan,
Gustavo F. Padovan wrote:
> Hi Zhenhua,
>
> * Zhenhua Zhang [2010-07-05 13:45:05 +0800]:
>
>> Add bluetooth_register_service() and bluetooth_unregister_service()
>> where bluetooth profiles plugins like DUN GW can register themselves
>> per adapter. It shares existing bluetooth fram
Hi Arun,
Marcel Holtmann wrote:
> Hi Arun,
>
>> I am trying to compile Ofono in Maemo Scratchbox SDK enviornment.
>>
>> Here is the bootstrap-configure output:
>>
> ---
> ---
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> +#define OFONO_EMULATOR_INTERFACE "org.ofono.Emulator"
>
> So my suggestion is to keep it simple and not include the D-Bus
> interface for the emulator at all for now.
That's fine. Will remove them.
>> +
>> +#include
>> +
>> +struct ofono_emul
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
>> I grabed code from obex to register&start DUN GW service
> when we parse adapter properties. From patch 6/6, you can see
> my current implementation is to find the first powered modem
> that having GRPS atom. Load settings from modem.conf could be
Hi Remi,
Rémi Denis-Courmont wrote:
> On Tue, 20 Jul 2010 11:28:59 +0200, "Alan KREUTZ"
> wrote:
>> 1-Is, the fact to test oFono ISI driver with a Nokia phone, the
>> only way to test ISI drivers or is there a simulator like phonesim
>> for ISI driver?
>
> Yes.
>
>> 2-How to test oFono
Hi Matthias,
Matthias Günther wrote:
> Hi Yang,
>
>> http://matgnt.wordpress.com/2010/07/19/qt-ofono-d-bus-and-qml-part-1/
>> http://matgnt.wordpress.com/2010/07/19/qt-ofono-d-bus-and-qml-part-2/
>> http://matgnt.wordpress.com/2010/07/19/qt-ofono-d-bus-and-qml-part-3/
>
> I h
Hi Kalle,
Zhenhua Zhang wrote:
> Huawei modem closes the modem port after PPP disconnect. So the
> channel
> of gatchat is NULL in ppp_disconnect. In such case, we should not
> resume
> the chat and call disconnect function when removing the context.
> Secondly, before removing the gprs context,
Hi Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
> On 07/26/2010 09:39 PM, Zhenhua Zhang wrote:
>> Huawei modem closes the modem port after PPP disconnect. So the
>> channel
>> of gatchat is NULL in ppp_disconnect. In such case, we should not
>> resume
>> the chat and call disconnect function whe
Hi Padovan,
Gustavo F. Padovan wrote:
> dun_enable() is called by setting the Powered property to true.
> It creates a rfcomm link throught the BlueZ Serial API.
> ---
> drivers/dunmodem/dunmodem.h |1 +
> plugins/bluetooth.h |1 +
> plugins/dun.c | 61
> +
Hi Padovan,
Gustavo F. Padovan wrote:
> dun_enable() is called by setting the Powered property to true.
> It creates a rfcomm link throught the BlueZ Serial API.
> ---
> drivers/dunmodem/dunmodem.h |1 +
> plugins/bluetooth.h |1 +
> plugins/dun.c | 61
> +
Hi Padovan,
Gustavo F. Padovan wrote:
> Add a still dummy DUN code, now it can only creates and removes
> modems.
> The DUN plugin follows the HFP one a lot, the is basics a copy of some
> HFP plugin's parts.
> ---
> Makefile.am |6 ++
> drivers/dunmodem/dunmodem.c | 51 +++
Hi Florian,
Florian Mayer (Mayer Electronics) wrote:
> Hello,
>
> we encountered the following problem with the EM770W: If the
> SIM card is
> plugged in after our test system is powered on, it is not
> recognised in
> ofono. Even if we restart ofonod after plugging in the SIM
> card. We use
> th
Hi Emmanuel,
Berthier, Emmanuel wrote:
> Hi,
>
> I use ofono 0.25 and encounter a segmentation fault when
> trying to put the modem OffLine (flight mode).
>
> The AT command sent to modem is:
>
> AT+CFUN=4
>
> The modem replies with:
>OK
>+CREG=0
>
> Then, in c
Hi Marcel,
Marcel Holtmann wrote:
> Hi Zhenhua,
>
>> This series unregister AT notifiers in removing various AT modem
>> drivers when modem goes to offline mode. Please review them.
>
> just a heads up here that Denis and I talked about this. And we are
> going to fix this inside GAtChat in the
Hi Marcel,
Marcel Holtmann wrote:
> Hi Zhenhua,
>
>> Defines APIs to send final/intermediate/unsolicited result to DUN
>> client. ---
>> include/emulator.h |2 ++
>> src/emulator.c | 28
>> src/ofono.h| 11 +++
>> 3 files changed, 41 inser
Hi Marcel,
Marcel Holtmann wrote:
> Hi Zhenhua,
>
>> DUN server may create one primary context if none of contexts
>> existing on the GPRS atom.
>
> so Denis and I had a chat about this. And we agreed that oFono core
> should just create one Internet context if none exists. If the plugin
> drive
Hi Sjur,
Sjur Br?ndeland wrote:
> Denis Kenzior wrote:
>>> I thought of one more issue with voice calls.
>>> I don't think it is safe to to terminate emergency calls using
>>> release_specific, AT+CHLD=1X. At least this don't work for STE
>>> modems.
>>>
>>> I suggest calls in state active shou
Hi Marcel,
Marcel Holtmann wrote:
> Hi Steven,
>
>> I have a little question just as the title said?
>> In Ofono how to connect PPP to Linux socket, when we receive packet
>> from network, how the packet go through the kernel to application？
>>
>> modem -->PPP-->? --> linux kernel(network part)-
Hi Steven,
Steven wrote:
> Hi Zhang
> Zhang, Zhenhua wrote:
>> Hi Marcel,
>>
>> Marcel Holtmann wrote:
>>> Hi Steven,
>>>
>>>> I have a little question just as the title said?
>>>> In Ofono how to connect PPP to Linux socket, w
Hi Steven,
Steven wrote:
> Hi Zhang,
>
> Zhang, Zhenhua wrote:
>> Hi Steven,
>>
>> Steven wrote:
>>> Hi Zhang
>>> Zhang, Zhenhua wrote:
>>>> Hi Marcel,
>>>>
>>>> Marcel Holtmann wrote:
>>>>>
Hi Steven,
Steven wrote:
> Hi,
>
> In function ppp_receive, we first check the protocol type of this
> frame
> like:
>
> guint16 protocol = ppp_proto(buf);
>
> and here we assumed the length of the protocol field is 16 bits, but
> in
> RFC 1661, the protocol field should be one or two octet
Hi Steven,
Steven wrote:
> Hi Zhenhua
>
> Zhang, Zhenhua wrote:
>> Hi Steven,
>>
>> Steven wrote:
>>> Hi,
>>>
>>> In function ppp_receive, we first check the protocol type of this
>>> frame like:
>>>
>>>
Hi Steven,
Steven wrote:
> Hi Zhenhua,
>
> Zhang, Zhenhua wrote:
>> Hi Steven,
>>
>> Steven wrote:
>>> Hi Zhenhua
>>>
>>> Zhang, Zhenhua wrote:
>>>> Hi Steven,
>>>>
>>>> Steven wrote:
>>>>
Hi, Denis,
Denis Kenzior wrote:
> Hi Zhenhua,
>
> On 08/30/2010 04:50 AM, Zhenhua Zhang wrote:
>> HFP modem doesn't have IMSI at all. In order to notify SIM ready to
>> the core, we create a special sim driver with a faked IMSI number.
>
> Can you try after commit 88024972df46d4ababbaf39354615e8
Hi Holtmann,
Marcel Holtmann wrote:
> Hi Zhenhua,
>
>> Support to load or not load specific plugin when ofono is started.
>> E.g., use 'ofonod -P hfp' to disable hfp plugin.
>> ---
>> src/main.c | 11 ++-
>> 1 files changed, 10 insertions(+), 1 deletions(-)
>
> patch has been applied.
Hi,
Yang Gu wrote:
> Phonesim is most of time a convenient way to test oFono. For example,
> it can be used to test MO call, as well as MT call.
> And talking about test area, test automation is quite important
> regarding to both efficiency and effectiveness. In the test of MO
> call, scripts ca
Hi Moises,
Denis Kenzior wrote:
> Hi Moises,
>
>> I was advised by padovan on IRC that I should try dbus >= 1.3 ... I
>> am going to try that today, I was putting that off cuz this seemed
>> like a lower level issue and upgrading dbus seemed like non-trivial
>> since many things depend on dbus an
Hi Silva,
From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On
Behalf Of Moises Silva
Sent: Tuesday, September 28, 2010 10:45 AM
To: ofono@ofono.org
Subject: Re: Using ofono HFP
On Mon, Sep 27, 2010 at 9:26 PM, Zhang
Hi Silva,
Moises Silva wrote:
> On Mon, Sep 27, 2010 at 9:26 PM, Zhang, Zhenhua
> wrote:
>>
>> Right. See bluez/audio/unix.c for BlueZ part SCO code that
> cooperate with pulseaudio. BlueZ sends SCO fd to pulseaudio via UNIX
>> type socks.
>
> This put me in
Hi Silva,
Moises Silva wrote:
> On Tue, Sep 28, 2010 at 10:50 PM, Denis Kenzior
> wrote:
>> The second descriptor (what ipc.c and ipc.h deal with) is used to
>> pass the SCO fd to PulseAudio or gStreamer. This fd is used for
>> Audio. Marcel or Johan might know better, but I think the reason for
Hi,
Attached is the patch to unref GIOChannel in g_at_chat_new_from_tty. If the
GAtChat is created from g_at_chat_new, the reference count of channel is
increased by g_io_add_watch_full(channel), so we need to unref it.
If GAtChat is failed to create, we also need to unref channel to free it.
Hi,
Attached is the patch to add call-volume interface for Ofono. It exposes two
properties: 'SpeakerVolume' and 'MicrophoneVolume' to allow user could control
phone volume through lower level driver. The ofono_call_volume_notify() is
used to report call volume property change notification to the
Hi Marcel,
Marcel Holtmann wrote:
> Hi Zhenhua,
>
>> +#define CALL_VOLUME_INTERFACE "org.ofono.CallVolume"
>
> we have to stop doing this. Start using this:
>
> #define FOO_INTERFACE OFONO_SERVICE ".FooInterface"
>
>> +static void call_volume_unregister(struct ofono_atom *atom);
>
> That for
Hi,
Attached patch is the Bluetooth handsfree profile (HFP) support for oFono. It
includes hfp plugin and the basic driver backend framework. The plugin use
'AT+BRSF=118' to inform AG supported features and perform serivce level
connection in modem's power on stage. The voicecall driver for HFP i
Hi Padovan,
Gustavo F. Padovan wrote:
> Hi Zhenhua,
>
> This patch fix compiler warnings into your HFP patch. I didn't looked
> to the code and what it does yet.
>
Thanks for your patch. I will turn on the maintainer mode from now on.
> Regards,
>
> Gustavo
Regards,
Zhenhua
__
Hi,
Attached is update patch for handsfree profile plugin. I move most stuff in
drivers/hfpmodem/hfp.c into plugins/hfp.c and simplify them. GSList *indies
is replaced as two indexable arrays (cind_names and cind_values), to improve
efficiency when we need access name and value by index. The whol
Allow g_at_result_iter_next_unquoted_string to handle the bracket when parsing
string like chld (1, 2). Original, it returns '1' and '2)'. Now it returns '1'
and '2'. g_at_result_iter_close_list handles the right bracket later.
---
gatchat/gatresult.c |4 ++--
1 files changed, 2 insertions(+),
Hi,
The first patch is to handle right bracket in at command parser. It's
identical with the previous patch I sent in the list.
The second patch depends on the first one so I resend it again. It implements
voicecall driver for handsfree profile and use AT+CIEV indicator to notify call
status chan
Hi,
Below patch is to replace Glib type with standard C type in hfpmodem.h, like
guint, guint8, etc.
Please review it.
Regards,
Zhenhua
---
drivers/hfpmodem/hfpmodem.h |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/hfpmodem/hfpmodem.h b/drivers/hfpmode
Hi Padovan,
Gustavo F. Padovan wrote:
> Hi Zhenhua,
>
> on compiling your code I got this:
>
> cc1: warnings being treated as errors
> drivers/hfpmodem/voicecall.c: In function 'chld_cb':
> drivers/hfpmodem/voicecall.c:539: error: 'ag_mpty_feature' may be used
> uninitialized in this function
>
Inline release_id() in voicecall.c
---
drivers/atmodem/voicecall.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c
index f0c8d93..51b3a19 100644
--- a/drivers/atmodem/voicecall.c
+++ b/drivers/atmodem/voicecall.c
Hi,
Below patch is to rename call_compare and call_compare_by_status into atutil.c
so that they could be shared by atmodem and hfpmodem drivers.
---
drivers/atmodem/atutil.c| 27 +++
drivers/atmodem/atutil.h|2 ++
drivers/atmodem/voicecall.c | 39 +++--
Hi,
HFP voicecall driver uses AT+CIEV indicator to notify call status update
according to Bluetooth HFP spec v1.5. First version support single call, multi
call support will be ready soon.
---
Makefile.am |3 +-
drivers/hfpmodem/hfpmodem.c |3 +
drivers/hfpmodem/voiceca
1 - 100 of 104 matches
Mail list logo
