D21490: Draw line caption for non-PDF documents

tobiasdeiminger added a comment. Does anybody feel like adding a nice UI for this feature? :-) In it's simplest form it would be a "show caption" checkbox in the straight line tool. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21490 To: tobiasdeiminger Cc:

D21416: Add icons for line annotation arrow styles to combo box

tobiasdeiminger marked an inline comment as done. tobiasdeiminger added a comment. In D21416#471795 , @davidhurka wrote: > For dark color themes: maybe the color of the adjacent text would be good as foreground color for the icons. Don’t know,

D21490: Draw line caption for non-PDF documents

tobiasdeiminger edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21490 To: tobiasdeiminger Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21248: Add line annotation ending arrows for non PDF documents

tobiasdeiminger added a dependent revision: D21490: Draw line caption for non-PDF documents. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21248 To: tobiasdeiminger, #okular, aacid Cc: ngraham, sander, knambiar, okular-devel, joaonetto, tfella, darcyshen, aacid

D21490: Draw line caption for non-PDF documents

tobiasdeiminger created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. tobiasdeiminger requested review of this revision. REVISION SUMMARY Line captions are already implemented in poppler / PDF generator (can't be enabled in okular UI yet, but that's

D21416: Add icons for line annotation arrow styles to combo box

tobiasdeiminger updated this revision to Diff 58872. tobiasdeiminger added a comment. Define TermStyle list outside the loop. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21416?vs=58688=58872 BRANCH feature/lineannoticons REVISION DETAIL

D10859: Improve layout of annotation configuraton dialogs

davidhurka added a comment. In D10859#471799 , @ngraham wrote: > I don't think the section headings really added much. Most of them were group boxes with one item, which is pointless. When using a FormLayout style, in general you want to make

D10859: Improve layout of annotation configuraton dialogs

ngraham added a comment. I don't think the section headings really added much. Most of them were group boxes with one item, which is pointless. When using a FormLayout style, in general you want to make the labels self-explanatory as much as possible so you don't need section headers. To

D21416: Add icons for line annotation arrow styles to combo box

davidhurka added a comment. The UI looks good and I understand the code. :) For dark color themes: maybe the color of the adjacent text would be good as foreground color for the icons. Don’t know, but maybe QGuiApplication::pallete().color(QPalette::WindowText)? REPOSITORY R223

D10859: Improve layout of annotation configuraton dialogs

davidhurka added a comment. Just tried this. Maybe you can bring back the section headings, which were group box labels before? Straight Line got many options recently. Not working buddys (probably a problem with PixmapPreviewSelector): Popup-Note -> Icon (Alt + i) Stamp -> Stamp

D10859: Improve layout of annotation configuraton dialogs

aacid added inline comments. INLINE COMMENTS > ngraham wrote in annotationwidgets.cpp:206 > For this one, `FieldsStayAtSizeHint` might be better, and then we just set > sensible sizehints for anything that winds up too small. That's basically > what we're doing for all our QML software. In

D10859: Improve layout of annotation configuraton dialogs

ngraham added a comment. Thanks! Much simpler indeed. INLINE COMMENTS > simgunz wrote in annotationwidgets.cpp:206 > Is it correct to set this growth policy? I have not found any guideline on > the HIG. Compared to the grid layout where label and widget take the same > amount of horizontal

D21281: [RFC] Write a bit Documentation for Part and PageView

davidhurka added a comment. Got an overview of open-a-document methods in the Detailed Description of Part. Helped me a lot, can it stay there? I made some method descriptions a bit more robust to future changes (I think) by making them more abstact and focusing a bit more on the

D21281: [RFC] Write a bit Documentation for Part and PageView

davidhurka updated this revision to Diff 58857. davidhurka added a comment. - Add structure to open*(url) methods documentation, shown in Detailed Description of Part - Make showMenu() documentation more generic. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

[okular] [Bug 407998] Okular scales down pages when printing

https://bugs.kde.org/show_bug.cgi?id=407998 --- Comment #8 from Nate Graham --- Darn. That would be a good bug to file against Neon | Snaps. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 407998] Okular scales down pages when printing

https://bugs.kde.org/show_bug.cgi?id=407998 --- Comment #7 from Sergio --- Wanted to give 1.7.x a try and tried installing the snap. That does not work, though. t.qpa.xcb: could not connect to display :0 qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.

[okular] [Bug 408075] New: Okular flips pages if history is exhausted while using the back / forward keyboard shortcuts

https://bugs.kde.org/show_bug.cgi?id=408075 Bug ID: 408075 Summary: Okular flips pages if history is exhausted while using the back / forward keyboard shortcuts Product: okular Version: 1.7.1 Platform: Other

D10859: Improve layout of annotation configuraton dialogs

knambiar added a comment. Tested, LGTM. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham Cc: aacid, okular-devel, knambiar, ngraham, joaonetto, tfella, darcyshen

[okular] [Bug 408056] Activating edit tool automatically

https://bugs.kde.org/show_bug.cgi?id=408056 --- Comment #2 from Martin --- Thank you Oliver! Good to know it exist :) -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 408056] Activating edit tool automatically

https://bugs.kde.org/show_bug.cgi?id=408056 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de

[okular] [Bug 408056] New: Activating edit tool automatically

https://bugs.kde.org/show_bug.cgi?id=408056 Bug ID: 408056 Summary: Activating edit tool automatically Product: okular Version: 1.5.3 Platform: Other OS: Linux Status: REPORTED Severity: wishlist

D10859: Improve layout of annotation configuraton dialogs

simgunz added a comment. Using the QFormLayout simplified the code a quite a bit! Regarding the stamp annotation tool, I have aligned the combobox to the top, because I have not found a way to vertically align the label. Though I will soon open a new review with some changes for that

D10859: Improve layout of annotation configuraton dialogs

simgunz updated this revision to Diff 58817. simgunz added a comment. - Use form layout instead of grid layout - Set label alignment and field growth policy - Resort code of line annotation - Fix wrong widget set as parent - Move line termination styles before leaders style - Align