[okular] [Bug 476981] Binary Factory build #1575 is missing one .exe from /bin -- Configure backend doesn't work

https://bugs.kde.org/show_bug.cgi?id=476981 Andre Heinecke changed: What|Removed |Added CC||aheine...@gnupg.org --- Comment #3 from Andre

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

https://bugs.kde.org/show_bug.cgi?id=408272 Andre Heinecke changed: What|Removed |Added CC||aheine...@gnupg.org --- Comment #12 from

Re: Okular with GnuPG / Gpg4win

Hi, On Tuesday 16 May 2023 23:55:00 CEST Albert Astals Cid wrote: > The text looks reasonable to me, but i guess we'd definitely want some input > from the KDE Promo folks. Want me to involve them or will you? I already did start on that yesterday.

Okular with GnuPG / Gpg4win

Hi, our integration of Okular and GnuPG (and later on GnuPG VS-Desktop) is nearly finished. Not everything is upstream yet but we see no roadblocks on the way that might cause us to abort so we would like to go ahead and announce this a bit more. Attached is a first draft of a statement about

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

aheinecke added inline comments. INLINE COMMENTS > aacid wrote in builtin.js:99 > Can you try what adobe reader does? If it behaves the same it's more than fine Acrobat saves the "internal text" as the annotation value and the formatted text in the "object" To clarify (As I don't really know

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

aheinecke added inline comments. INLINE COMMENTS > aheinecke wrote in builtin.js:99 > I'm not sure I understand the question. I understand it that you are > concerned that the actual value of the field is changed by formatting and the > user is then confused if he mixes the format when

D13171: Add support for form text formatting

aheinecke added inline comments. INLINE COMMENTS > aacid wrote in form.h:298 > Do we need these two to be virtual? i.e do you envision a case in which a > backend generator would want to reimplement them? It seems to me this is > mostly an "internal storage" area for the core and the backends

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

aheinecke updated this revision to Diff 36278. aheinecke added a comment. Force consistent locale in calculate text test to avoid different results. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13172?vs=36276=36278 REVISION DETAIL

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

aheinecke updated this revision to Diff 36276. aheinecke added a comment. Update the calculatetexttest and simpleCalculate PDF with formatting removed from the fields in simple calculate. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13172?vs=35087=36276

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

aheinecke planned changes to this revision. aheinecke added a comment. Just noticed that this breaks the calculatetexttest as I've accidentally also added Formatting (which Acrobat did automatically) on the calculated fields in that test document. REPOSITORY R223 Okular REVISION DETAIL

D13171: Add support for form text formatting

aheinecke added a comment. The test is D13588 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13171 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D13588: Add test for field number formatting

aheinecke created this revision. aheinecke added a reviewer: aacid. aheinecke added a project: Okular. Restricted Application added a subscriber: okular-devel. aheinecke requested review of this revision. REVISION SUMMARY This adds a test document with most formatting options directly

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

aheinecke added a comment. Apologies for the delay. Some travel, some sick days and some other work and the weeks fly by ;-) I'm getting back to this now. INLINE COMMENTS > aacid wrote in builtin.js:99 > Not having a document to test makes this a bit harder, but let's say i write > a

D13171: Add support for form text formatting

aheinecke added a comment. Yes, I plan to add a test for this. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13171 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

aheinecke updated this revision to Diff 35087. aheinecke added a comment. Remove spurious comment REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13172?vs=35086=35087 REVISION DETAIL https://phabricator.kde.org/D13172 AFFECTED FILES

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

aheinecke updated this revision to Diff 35086. aheinecke added a comment. Removed to currency and extended numberToString to handle this, too. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13172?vs=35028=35086 REVISION DETAIL

D13170: Add test for additional form actions

aheinecke added a comment. In D13170#270082 , @aheinecke wrote: > In D13170#269657 , @aacid wrote: > > > QTest::qWait( 100 ); is bad as you probably already guessed since it's "machine dependant".

D13170: Add test for additional form actions

aheinecke updated this revision to Diff 35084. aheinecke added a comment. Use QTRY instead of QTest::wait. This is acutally much faster. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13170?vs=35022=35084 REVISION DETAIL

D13170: Add test for additional form actions

aheinecke added a comment. In D13170#269657 , @aacid wrote: > QTest::qWait( 100 ); is bad as you probably already guessed since it's "machine dependant". Yeah, looked fishy ;-) Although stuff like that is used in part test on other

D13171: Add support for form text formatting

aheinecke added a comment. In D13171#269646 , @aacid wrote: > I'm not very happy of the internalText method/storage in form, ideally, the text in core/form should always be the internal text, and if there's a formatted text that needs to be

D12665: Support additional widget actions in PDF Forms

aheinecke added inline comments. INLINE COMMENTS > aacid wrote in formwidgets.cpp:1078 > Can you please add that explanation either as a comment somewhere in the code > or as part of the git commit? It'll make it easier to find next time someone > looks at the code and wonders why it has an

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

aheinecke created this revision. aheinecke added a reviewer: aacid. aheinecke added a project: Okular. Restricted Application added a subscriber: okular-devel. aheinecke requested review of this revision. REVISION SUMMARY This adds utility functions to util to work with QLocale for formatting

D13171: Add support for form text formatting

aheinecke created this revision. aheinecke added a reviewer: aacid. aheinecke added a project: Okular. Restricted Application added a subscriber: okular-devel. aheinecke requested review of this revision. REVISION SUMMARY With formatting there is an internal value, which represents the true

D13170: Add test for additional form actions

aheinecke created this revision. aheinecke added a reviewer: aacid. aheinecke added a project: Okular. Restricted Application added a subscriber: okular-devel. aheinecke requested review of this revision. REVISION SUMMARY This tests the newly added additional widget actions. TEST PLAN Passes

D12665: Support additional widget actions in PDF Forms

aheinecke updated this revision to Diff 35015. aheinecke added a comment. Don't eat the MouseRelease event if it is outside the widget REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12665?vs=35014=35015 REVISION DETAIL https://phabricator.kde.org/D12665

D12665: Support additional widget actions in PDF Forms

aheinecke updated this revision to Diff 35014. aheinecke added a comment. - Fixed precedence of activation action over mouse release action. - Only activate mouse released if release is inside the widget. - Fixed check for Poppler 0.65 REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D12665: Support additional widget actions in PDF Forms

aheinecke planned changes to this revision. aheinecke added inline comments. INLINE COMMENTS > aacid wrote in formwidgets.cpp:1073 > This still triggers if you press the button inside a form, move the mouse > outside the form and release, not sure this is "according to spec", it says > "An

D12825: Fix recalculating forms twice

aheinecke updated this revision to Diff 35008. aheinecke added a comment. Include duplicate cals from editFormList and editFormCombo REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12825?vs=33987=35008 REVISION DETAIL https://phabricator.kde.org/D12825

D12825: Fix recalculating forms twice

aheinecke added a comment. I'll upload a new patch. (sorry for delaying my okular work, I'm currently still a bit swamped by the efail hype) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D12825: Fix recalculating forms twice

aheinecke added a comment. Ugh, Sorry for overlooking these. Yes. They also call notifyFormChanges in their redo. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D12825: Fix recalculating forms twice

aheinecke added a comment. To clarify: d->m_undoStack->push( uc ); results in: EditFormTextCommand::redo() https://cgit.kde.org/okular.git/tree/core/documentcommands.cpp#n513 which calls: m_docPriv->notifyFormChanges( m_pageNumber );

D12825: Fix recalculating forms twice

aheinecke added a comment. I did not know when adding f0a80a67 that pushing to the undoStack automatically executes the redo function. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825

D12825: Fix recalculating forms twice

aheinecke created this revision. aheinecke added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. aheinecke requested review of this revision. REVISION SUMMARY As a side effect of f0a80a67

D12665: Support additional widget actions in PDF Forms

aheinecke updated this revision to Diff 33810. aheinecke added a comment. - Removed a spurious emit when calling signalAction. - Updated to API of update poppler patch. - Fixed leaking the additional actions. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D12665: Support additional widget actions in PDF Forms

aheinecke updated this revision to Diff 33630. aheinecke added a comment. Changed mouseRelease event to fallback to activationAction Some formatting. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12665?vs=33497=33630 BRANCH master REVISION DETAIL

D12665: Support additional widget actions in PDF Forms

aheinecke planned changes to this revision. aheinecke added a comment. MouseReleased indeed needs some different handling. It only works in the tests for the Button's as they trigger the "MouseReleased" action as the activation action. As we need a generic way to trigger activation

D12665: Support additional widget actions in PDF Forms

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY This adds support for actions associated with form fields through corresponding annotation widgets. TEST PLAN Still needs a

[okular] [Bug 306818] Okular cannot close instructions overlay in PDF

https://bugs.kde.org/show_bug.cgi?id=306818 --- Comment #8 from Andre Heinecke <aheine...@intevation.de> --- This example is extra fun... Although it uses the Hide Actions, which we now support, the trigger is different and not yet supported. The "Help" overlay

[okular] [Bug 306855] Support Javascript

https://bugs.kde.org/show_bug.cgi?id=306855 Andre Heinecke <aheine...@intevation.de> changed: What|Removed |Added Blocks|306818 | Reference

[okular] [Bug 306818] Okular cannot close instructions overlay in PDF

https://bugs.kde.org/show_bug.cgi?id=306818 Andre Heinecke <aheine...@intevation.de> changed: What|Removed |Added Depends on|306855 | Version

D10932: [Okular] Option to reset forms

aheinecke added a comment. Reset-Form Actions are specified in Adobe's PDF Reference as: > A reset-form action resets selected interactive form fields to their default values; > that is, it sets the value of the V entry in the field dictionary to that of the DV entry > (see Table

D11609: Add support for chained / next actions

aheinecke added a comment. In D11609#253518 , @sander wrote: > > I've tried to create a test document with Adobe Acrobat Pro DC but ended up > > frustrated and unable to create Movie or Rendition Actions (except for the Page Open Action).

D11609: Add support for chained / next actions

aheinecke updated this revision to Diff 33048. aheinecke added a comment. Removed unused deletion prevention for media links. Noted instead that nextActions containing MovieActions or RenditionActions are unsupported. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D11609: Add support for chained / next actions

aheinecke added a comment. Right, I overlooked this a bit and assumed that the references were resolved on demand. But I think we could also say that we should resolve the MediaLinkReferences of the next actions, too. Looking at this more I see the problem that if we have a movie

D11609: Add support for chained / next actions

aheinecke updated this revision to Diff 32471. aheinecke added a comment. Changed to handle deletion of the link actions more explicit and to compile against the commited poppler patch. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11609?vs=30302=32471

D11597: Add test for visibility changes

aheinecke updated this revision to Diff 32469. aheinecke added a comment. Fixed visibilitytest.pdf which was somehow broken with the last update. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11597?vs=31744=32469 REVISION DETAIL

[okular] [Bug 307304] Javascript in forms not working correctly

https://bugs.kde.org/show_bug.cgi?id=307304 Andre Heinecke <aheine...@intevation.de> changed: What|Removed |Added Assignee|okular-devel@kde.org|

D11609: Add support for chained / next actions

aheinecke added a subscriber: aacid. aheinecke added inline comments. INLINE COMMENTS > generator_pdf.cpp:475 > +// poppler links > +popplerLink->setNextLinks( QVector< Poppler::Link * >() ); > +} @aacid When you commited the corresponding poppler patch you did not add this

D11597: Add test for visibility changes

aheinecke updated this revision to Diff 31744. aheinecke added a comment. Added nasty circular next actions REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11597?vs=30278=31744 REVISION DETAIL https://phabricator.kde.org/D11597 AFFECTED FILES

D11608: Add support for Next actions following an action

aheinecke abandoned this revision. aheinecke added a comment. Please see the freedesktop issue for the latest patch. REVISION DETAIL https://phabricator.kde.org/D11608 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham

D11596: Add support for dynamic visibility

aheinecke updated this revision to Diff 31736. aheinecke added a comment. Changed from single targetName to QVector targets API REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11596?vs=30277=31736 REVISION DETAIL https://phabricator.kde.org/D11596

D11594: Add support for hide action

aheinecke abandoned this revision. aheinecke added a comment. Please see the freedesktop issue for the last version of this patch. It was updated there. REVISION DETAIL https://phabricator.kde.org/D11594 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham

D11595: Qt5: Allow setting of visibility

aheinecke abandoned this revision. aheinecke added a comment. This was pushed by Albert with poppler rev 3e040896 REVISION DETAIL https://phabricator.kde.org/D11595 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham

D11608: Add support for Next actions following an action

aheinecke added a comment. Freedesktop bug is: https://bugs.freedesktop.org/show_bug.cgi?id=105759 REVISION DETAIL https://phabricator.kde.org/D11608 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham

D11594: Add support for hide action

aheinecke added a comment. Freedesktop bugzilla entry for this is: https://bugs.freedesktop.org/show_bug.cgi?id=105758 REVISION DETAIL https://phabricator.kde.org/D11594 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham

D11595: Qt5: Allow setting of visibility

aheinecke added a comment. Done: https://bugs.freedesktop.org/show_bug.cgi?id=105757 I'm leaving the differential open here (and will update it if neccessary) so that it is clear in the task which patches belong together and will close this revision once it was accepted to poppler.

D11609: Add support for chained / next actions

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY This adds support for multiple actions following each other through the "Next" value of Action dictionaries. TEST PLAN

D11608: Add support for Next actions following an action

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY Next actions are action dictionaries or an array of action dictonaries. "Next" is an entry in the general action dictionary.

D11594: Add support for hide action

aheinecke added inline comments. INLINE COMMENTS > Link.h:468 > + > + // According to spec the target can be either: > + // a) A text string containing the fully qualified name of the target I've looked at the spec but did not understand what should be happening with "An indirect reference

D11597: Add test for visibility changes

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY The test only tests what is currently supported so it does not yet test radio buttons and action chains. But the

D11596: Add support for dynamic visibility

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY This adds the hidden property to JavaScript fields and uses it to implement support for HideAction. TEST PLAN Unit test in

D11595: Qt5: Allow setting of visibility

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY Extends Qt5 API to allow setting visibility flags TEST PLAN Autotest in Okular BRANCH master REVISION DETAIL

D11594: Add support for hide action

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY The hide action can be used to show / hide fields. TEST PLAN Unit test using this action in okular REVISION DETAIL

D10864: Poppler: Add read only setter for form fields

aheinecke closed this revision. aheinecke added a comment. Thanks! REVISION DETAIL https://phabricator.kde.org/D10864 To: aheinecke, #okular, aacid Cc: aacid, michaelweghorn, ngraham

D10869: [5/5] Add test for read only set and checkbox calculate

aheinecke updated this revision to Diff 29920. aheinecke added a comment. Added test for save / load of readOnly values REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10869?vs=28711=29920 BRANCH master REVISION DETAIL

D10864: Poppler: Add read only setter for form fields

aheinecke added a comment. With this change saving / loading the read only state works. REVISION DETAIL https://phabricator.kde.org/D10864 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham

D10864: Poppler: Add read only setter for form fields

aheinecke updated this revision to Diff 29917. aheinecke added a comment. Added object dict / xref update so that the Read Only state is saved. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10864?vs=28112=29917 REVISION DETAIL https://phabricator.kde.org/D10864 AFFECTED FILES

D10864: Poppler: Add read only setter for form fields

aheinecke added a comment. I've started to look at saving this on Friday. I'm a bit confused as the ReadOnly is a Field value and not a Widget Annotation value and the Adobe Spec says that it is ignored for Widget Annotations. Saving a document with Adobe after changing a ReadOnly field

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke updated this revision to Diff 29566. aheinecke added a comment. Remove superfluous check / reorder in PageView::notifySetup As noted by aacid we don't need the check anymore now that setCanBeFilled does not access the underlying fields. REPOSITORY R223 Okular CHANGES SINCE

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke added inline comments. INLINE COMMENTS > aacid wrote in pageview.cpp:1002 > Ok, so now that setCanBeFilled doesn't access the form, do we really need > this extra if? No. :-) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10865 To: aheinecke, #okular Cc:

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke updated this revision to Diff 29471. aheinecke added a comment. Removed check for readOnly in setCanBeFilled REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10865?vs=28706=29471 REVISION DETAIL https://phabricator.kde.org/D10865 AFFECTED FILES

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke added inline comments. INLINE COMMENTS > aacid wrote in formwidgets.cpp:310 > sure, if allowfillforms is false, we will call setCanBeFilled with false and > it will be setEnabled to false. > > What I am asking is why do we need to call isReadOnly here. As far as i > understand if

D10869: [5/5] Add test for read only set and checkbox calculate

aheinecke updated this revision to Diff 28711. aheinecke added a comment. No changes, only updated for context. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10869?vs=28120=28711 REVISION DETAIL https://phabricator.kde.org/D10869 AFFECTED FILES

D10868: [4/5] Fix CheckBox script usage

aheinecke updated this revision to Diff 28710. aheinecke added a comment. No changes, only updated to get context REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10868?vs=28119=28710 REVISION DETAIL https://phabricator.kde.org/D10868 AFFECTED FILES

D10867: [3/5] Add support to set read only from scripts

aheinecke marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10867 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham

D10867: [3/5] Add support to set read only from scripts

aheinecke updated this revision to Diff 28708. aheinecke added a comment. Added @since marker to setReadOnly REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10867?vs=28115=28708 REVISION DETAIL https://phabricator.kde.org/D10867 AFFECTED FILES

D10866: [2/5] Implement generic version of Form Widgets refresh

aheinecke updated this revision to Diff 28707. aheinecke added a comment. Updated without setVisibility implicit handling of isReadOnly REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10866?vs=28114=28707 REVISION DETAIL https://phabricator.kde.org/D10866

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke updated this revision to Diff 28706. aheinecke added a comment. Removed implicit readOnly handling in setVisiblitiy and updated callers instead. Also the differential is now published with arcanist ;-) REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke added a comment. In D10865#217744 , @aacid wrote: > BTW next time please use arc so phabricator shows the context of the diff. Apologies, I'll try. While I like phabricator I'm not very skilled with arcanist, yet. :-} INLINE

D10869: [5/5] Add test for read only set and checkbox calculate

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10869 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10869: [5/5] Add test for read only set and checkbox calculate

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY It's a real world screnario to have checkboxes that toggle the read only state for other fields. The test is a parttest

D10868: [4/5] Fix CheckBox script usage

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10868 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10868: [4/5] Fix CheckBox script usage

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY This implements setting / getting the value of buttons, which is important for checkboxes in scripts. It also moves the

D10867: [3/5] Add support to set read only from scripts

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10867 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10867: [3/5] Add support to set read only from scripts

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY This makes it possible to set the read only state from scripts. Requires Poppler master with the patch attached to the parent

D10866: [2/5] Implement generic version of Form Widgets refresh

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY The FormWidgetInterface now has a generic slotRefresh that refreshes what all widgets have in common. This is the read-only

D10866: [2/5] Implement generic version of Form Widgets refresh

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10866 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke added inline comments. INLINE COMMENTS > pageview.cpp:1002 > } > -else > +else if ( !( setupFlags & Okular::DocumentObserver::UrlChanged ) > ) > { Without this change the PartTest::testSaveAsUndoStackForms would segfault because the

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10865 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY This is more of a cleanup patch that removes the obsolete m_canBeEnabled member variable which was a leftover IMO from a time

D10864: Poppler: Add read only setter for form fields

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY Read only is modifiable from AcroForm scripts. As such we need to add setting it to the data model of Poppler. - I

D10864: Poppler: Add read only setter for form fields

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REVISION DETAIL https://phabricator.kde.org/D10864 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10073: [PATCH 1/4] Add JavaScript Event Object handling

aheinecke updated this revision to Diff 27658. aheinecke added a comment. Removed check for page in field wrapping. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10073?vs=27264=27658 REVISION DETAIL https://phabricator.kde.org/D10073 AFFECTED FILES

D10547: Recalculate forms after command form changes

aheinecke updated this revision to Diff 27600. aheinecke retitled this revision from "[PATCH] Recalculate forms after command form changes" to "Recalculate forms after command form changes". aheinecke edited the test plan for this revision. aheinecke added a comment. Extended

D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

aheinecke added inline comments. INLINE COMMENTS > aacid wrote in document.cpp:1139 > This is problematic since it will leave a dangling event pointer for any > Action::Script action executed through Document::processAction that doesn't > come from this function. Sorry I can't follow you

D10073: [PATCH 1/4] Add JavaScript Event Object handling

aheinecke added inline comments. INLINE COMMENTS > aacid wrote in kjs_field.cpp:217 > Why the new if? It is not assured in kjs_event.cpp eventGetSource and eventGetTarget that the targetPage / sourcePage is not null. This depends a how the event object is set up. Although I think that

D10547: [PATCH] Recalculate forms after command form changes

aheinecke added a comment. In D10547#207085 , @ltoscano wrote: > (I can't comment on the content of the stream of the patches, but I think you don't need the [PATCH] in the title in any of them - they are clearly patches if they are defined

D10547: [PATCH] Recalculate forms after command form changes

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY notifyFormChanged is called by documentcommands when Form fields are changed. E.g. by Undo / Redo. We need to recalculate

D10547: [PATCH] Recalculate forms after command form changes

aheinecke added a task: T7805: Okular: Add support for JavaScript AFSimple_Calculate and textfield content calculation. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10547 To: aheinecke, #okular Cc: michaelweghorn, ngraham, simgunz, aacid

D10073: [PATCH 1/4] Add JavaScript Event Object handling

aheinecke marked 3 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10073 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham, simgunz

  1   2   >