Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Feb. 8, 2014, 3:14 p.m., Christoph Feck wrote: > > Thanks for this feature, Jonathan! > > > > I just tried Okular from master, and noticed that QTabWidget adds a frame > > around the page view. Is using QTabWidget::setDocumentMode(false) an > > option, at least for the case, where the tab

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Feb. 8, 2014, 3:14 p.m., Christoph Feck wrote: > > Thanks for this feature, Jonathan! > > > > I just tried Okular from master, and noticed that QTabWidget adds a frame > > around the page view. Is using QTabWidget::setDocumentMode(false) an > > option, at least for the case, where the tab

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Feb. 8, 2014, 3:14 p.m., Christoph Feck wrote: > > Thanks for this feature, Jonathan! > > > > I just tried Okular from master, and noticed that QTabWidget adds a frame > > around the page view. Is using QTabWidget::setDocumentMode(false) an > > option, at least for the case, where the tab

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/#review49254 --- Thanks for this feature, Jonathan! I just tried Okular from m

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/ --- (Updated Feb. 8, 2014, 11:16 a.m.) Status -- This change has been ma

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/#review49244 --- This review has been submitted with commit 0a982319f466dd6204

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Jan. 28, 2014, 12:01 a.m., Albert Astals Cid wrote: > > Can you confirm that > > > > diff --git a/part.rc b/part.rc > > index 6b1f44e..0b9cee5 100644 > > --- a/part.rc > > +++ b/part.rc > > @@ -84,7 +84,7 @@ > > > > > > > > - > > + > > > >&Help > > >

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Jan. 28, 2014, 12:01 a.m., Albert Astals Cid wrote: > > Can you confirm that > > > > diff --git a/part.rc b/part.rc > > index 6b1f44e..0b9cee5 100644 > > --- a/part.rc > > +++ b/part.rc > > @@ -84,7 +84,7 @@ > > > > > > > > - > > + > > > >&Help > > >

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/#review48432 --- Can you confirm that diff --git a/part.rc b/part.rc index 6b

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/ --- (Updated Jan. 19, 2014, 9:34 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Jan. 15, 2014, 11:33 p.m., Albert Astals Cid wrote: > > Can you investigate this? > > > > Open two files in two tabs: > > * Go to tab 2 > > * Press Ctrl+F > > * Press Esc > > * Search bar closes > > * Press Ctrl+F > > * Go to tab 1 > > * Go to tab 2 > > * Press Esc > > * Search bar

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Jan. 15, 2014, 11:33 p.m., Albert Astals Cid wrote: > > Can you investigate this? > > > > Open two files in two tabs: > > * Go to tab 2 > > * Press Ctrl+F > > * Press Esc > > * Search bar closes > > * Press Ctrl+F > > * Go to tab 1 > > * Go to tab 2 > > * Press Esc > > * Search bar

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Jan. 15, 2014, 11:33 p.m., Albert Astals Cid wrote: > > Can you investigate this? > > > > Open two files in two tabs: > > * Go to tab 2 > > * Press Ctrl+F > > * Press Esc > > * Search bar closes > > * Press Ctrl+F > > * Go to tab 1 > > * Go to tab 2 > > * Press Esc > > * Search bar

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/#review47475 --- Can you investigate this? Open two files in two tabs: * Go t

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Jan. 12, 2014, 9:57 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 181 > > > > > > This check seems a bit weird, i don't even think you need it, but if > > you want one check there shouldn't you b

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/ --- (Updated Jan. 13, 2014, 12:24 a.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Jan. 12, 2014, 9:57 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 181 > > > > > > This check seems a bit weird, i don't even think you need it, but if > > you want one check there shouldn't you b

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Jan. 12, 2014, 9:57 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 181 > > > > > > This check seems a bit weird, i don't even think you need it, but if > > you want one check there shouldn't you b

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/#review47271 --- shell/shell.cpp

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/ --- (Updated Jan. 11, 2014, 10:32 p.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/#review47221 --- Open a file, press Ctrl+W -> crash - Albert Astals Cid On J

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/#review47217 --- shell/shell.cpp

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Dec. 29, 2013, 7:44 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 203 > > > > > > I'd like if you kept the OpenInNewTab/OpenInNewShell in a configuration > > setting so people were not forced to

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/ --- (Updated Jan. 9, 2014, 12:15 a.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Dec. 29, 2013, 7:44 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 203 > > > > > > I'd like if you kept the OpenInNewTab/OpenInNewShell in a configuration > > setting so people were not forced to

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Dec. 29, 2013, 7:44 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 203 > > > > > > I'd like if you kept the OpenInNewTab/OpenInNewShell in a configuration > > setting so people were not forced to

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Dec. 29, 2013, 7:44 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 203 > > > > > > I'd like if you kept the OpenInNewTab/OpenInNewShell in a configuration > > setting so people were not forced to

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Dec. 29, 2013, 7:44 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 203 > > > > > > I'd like if you kept the OpenInNewTab/OpenInNewShell in a configuration > > setting so people were not forced to

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/ --- (Updated Jan. 3, 2014, 2:24 a.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/#review46407 --- Code looks good in general, some small comments shell/shell.

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/ --- (Updated Dec. 16, 2013, 6:58 a.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Oct. 1, 2013, 6:57 p.m., Fabio D'Urso wrote: > > Hi! :) > > I have neither tested nor read the whole patch in depth, I've only had a > > look at your description and made a few tests. > > > > We had a discussion at the okular BOF this summer, and we decided that it's > > better to avoid h

Re: [Okular-devel] Review Request 110914: Tabbed interface

El Dimecres, 16 d'octubre de 2013, a les 23:19:51, Albert Astals Cid va escriure: > El Dimecres, 16 d'octubre de 2013, a les 18:36:52, Jonathan Doman va escriure: > > > On Oct. 1, 2013, 6:57 p.m., Fabio D'Urso wrote: > > > > Hi! :) > > > > I have neither tested nor read the whole patch in depth,

Re: [Okular-devel] Review Request 110914: Tabbed interface

El Dimecres, 16 d'octubre de 2013, a les 18:36:52, Jonathan Doman va escriure: > > On Oct. 1, 2013, 6:57 p.m., Fabio D'Urso wrote: > > > Hi! :) > > > I have neither tested nor read the whole patch in depth, I've only had a > > > look at your description and made a few tests. > > > > > > We had a d

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Oct. 1, 2013, 6:57 p.m., Fabio D'Urso wrote: > > Hi! :) > > I have neither tested nor read the whole patch in depth, I've only had a > > look at your description and made a few tests. > > > > We had a discussion at the okular BOF this summer, and we decided that it's > > better to avoid h

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/#review41071 --- Hi! :) I have neither tested nor read the whole patch in depth,

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/#review38895 --- I'm going to be on holiday most of september, so unless someone

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote: > > part.cpp, line 838 > > > > > > This looks a bit weird, you never initialize nor use m_dbusObjectName > > for anything other than for calling unregisterO

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote: > > shell/main.cpp, line 112 > > > > > > This looks like a separate feature than the tabs feature, maybe makes > > sense to split it to a different review t

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 20, 2013, 9:40 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 669 > > > > > > one more nitpick about style, when comparing pointers just do > > > > "if (part)" instead of "if (part !=

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 20, 2013, 9:40 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 669 > > > > > > one more nitpick about style, when comparing pointers just do > > > > "if (part)" instead of "if (part !=

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/ --- (Updated Aug. 23, 2013, 8:06 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote: > > part.cpp, line 838 > > > > > > This looks a bit weird, you never initialize nor use m_dbusObjectName > > for anything other than for calling unregisterO

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote: > > part.cpp, line 838 > > > > > > This looks a bit weird, you never initialize nor use m_dbusObjectName > > for anything other than for calling unregisterO

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/#review38244 --- shell/shell.cpp

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote: > > shell/main.cpp, line 112 > > > > > > This looks like a separate feature than the tabs feature, maybe makes > > sense to split it to a different review t

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote: > > part.cpp, line 838 > > > > > > This looks a bit weird, you never initialize nor use m_dbusObjectName > > for anything other than for calling unregisterO

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/ --- (Updated Aug. 18, 2013, 11:37 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote: > > shell/main.cpp, line 53 > > > > > > Just commenting here, but please try to review all your code. It's good > > if you can try to make all the variables

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 14, 2013, 10:29 p.m., Albert Astals Cid wrote: > > shell/shell.h, line 49 > > > > > > Why are you changing the dbus names? This will break whatever scripts > > people where using. > > Jonathan Doman wro

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/#review38086 --- part.cpp

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/ --- (Updated Aug. 17, 2013, 3:06 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 14, 2013, 10:29 p.m., Albert Astals Cid wrote: > > shell/shell.h, line 49 > > > > > > Why are you changing the dbus names? This will break whatever scripts > > people where using. > > Jonathan Doman wro

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 14, 2013, 10:29 p.m., Albert Astals Cid wrote: > > shell/shell.h, line 49 > > > > > > Why are you changing the dbus names? This will break whatever scripts > > people where using. It seems my experience

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On Aug. 14, 2013, 10:29 p.m., Albert Astals Cid wrote: > > When I started looking at dbus, I couldn't get anything to work. Whenever I tried to run any org.kde.okular method in qdbusviewer, it would say "unable to find method" or something similar. So I thought the problem might be related t

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/#review37814 --- shell/shell.h

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On June 9, 2013, 10:29 p.m., Albert Astals Cid wrote: > > part.cpp, line 305 > > > > > > Please avoid reformating source code, makes it harder to review > > Albert Astals Cid wrote: > Hello? Is anyone there

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/ --- (Updated Aug. 3, 2013, 10:03 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 110914: Tabbed interface

> On June 9, 2013, 10:29 p.m., Albert Astals Cid wrote: > > part.cpp, line 305 > > > > > > Please avoid reformating source code, makes it harder to review Hello? Is anyone there? - Albert

Re: [Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/#review34000 --- We are in feature freeze for 4.11 so this will have to wait for

[Okular-devel] Review Request 110914: Tabbed interface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/ --- Review request for Okular. Description --- This patch adds support fo