[Okular-devel] [okular] [Bug 325650] New: reading direction Right to Left

https://bugs.kde.org/show_bug.cgi?id=325650 Bug ID: 325650 Summary: reading direction Right to Left Classification: Unclassified Product: okular Version: 0.17.1 Platform: unspecified OS: Linux Status:

[Okular-devel] [okular] [Bug 325650] reading direction Right to Left

https://bugs.kde.org/show_bug.cgi?id=325650 --- Comment #3 from Fahad Al-Saidi fahad.alsa...@gmail.com --- This option gives the control over the order of pages when the view mode is facing pages (Center First page). I have attached two screen-shots one from adobe reader after enabling Reading

[Okular-devel] [okular] [Bug 325650] reading direction Right to Left

https://bugs.kde.org/show_bug.cgi?id=325650 --- Comment #4 from Fahad Al-Saidi fahad.alsa...@gmail.com --- Created attachment 82675 -- https://bugs.kde.org/attachment.cgi?id=82675action=edit Adobe reader- reading direction options (Right to Left) -- You are receiving this mail because: You

[Okular-devel] [okular] [Bug 325650] reading direction Right to Left

https://bugs.kde.org/show_bug.cgi?id=325650 --- Comment #5 from Fahad Al-Saidi fahad.alsa...@gmail.com --- Created attachment 82676 -- https://bugs.kde.org/attachment.cgi?id=82676action=edit Okular- the current reading direction (left to right) -- You are receiving this mail because: You

[Okular-devel] [okular] [Bug 353299] Text search does not work in Arabic

https://bugs.kde.org/show_bug.cgi?id=353299 --- Comment #1 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- Created attachment 94769 --> https://bugs.kde.org/attachment.cgi?id=94769=edit an arabic odt file -- You are receiving this mail because: You are the assignee fo

[Okular-devel] [okular] [Bug 353299] New: Text search does not work in Arabic

https://bugs.kde.org/show_bug.cgi?id=353299 Bug ID: 353299 Summary: Text search does not work in Arabic Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

[Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

c736759 Diff: https://git.reviewboard.kde.org/r/125442/diff/ Testing --- Test in Arabic & Hebrew pdfs and it works fine. Thanks, Fahad Al-Saidi ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

. Diffs - ui/searchlineedit.cpp c736759 Diff: https://git.reviewboard.kde.org/r/125442/diff/ Testing (updated) --- Tested in Arabic & Hebrew pdfs and it works fine. Thanks, Fahad Al-Saidi ___ Okular-devel mailing list Okular-devel@kde

[Okular-devel] [okular] [Bug 353300] New: Text search does not work in Arabic

https://bugs.kde.org/show_bug.cgi?id=353300 Bug ID: 353300 Summary: Text search does not work in Arabic Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

[Okular-devel] [okular] [Bug 353300] Text search does not work in Arabic

https://bugs.kde.org/show_bug.cgi?id=353300 --- Comment #1 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- Created attachment 94770 --> https://bugs.kde.org/attachment.cgi?id=94770=edit an arabic epub file -- You are receiving this mail because: You are the assignee fo

[Okular-devel] [okular] [Bug 353302] Txt Backend does not display Arabic text

https://bugs.kde.org/show_bug.cgi?id=353302 --- Comment #1 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- Created attachment 94771 --> https://bugs.kde.org/attachment.cgi?id=94771=edit an arabic txtfile -- You are receiving this mail because: You are the assignee fo

[Okular-devel] [okular] [Bug 353302] New: Txt Backend does not display Arabic text

https://bugs.kde.org/show_bug.cgi?id=353302 Bug ID: 353302 Summary: Txt Backend does not display Arabic text Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity:

[Okular-devel] [okular] [Bug 207748] LTR languages searches text backwards

https://bugs.kde.org/show_bug.cgi?id=207748 Fahad Al-Saidi <fahad.alsa...@gmail.com> changed: What|Removed |Added CC||faha

[Okular-devel] [okular] [Bug 353301] New: Text search does not work in Arabic

https://bugs.kde.org/show_bug.cgi?id=353301 Bug ID: 353301 Summary: Text search does not work in Arabic Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

[Okular-devel] [okular] [Bug 353301] Text search does not work in Arabic

https://bugs.kde.org/show_bug.cgi?id=353301 --- Comment #1 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- the file is larger then 4 MB, so I couldn't attach it. However, here is the link: http://downloads.hindawi.org/books/19395315.mobi -- You are receiving this mail becaus

[Okular-devel] [okular] [Bug 351670] Error opening arabic named PDFs

https://bugs.kde.org/show_bug.cgi?id=351670 Fahad Al-Saidi <fahad.alsa...@gmail.com> changed: What|Removed |Added CC||faha

[Okular-devel] [okular] [Bug 325650] reading direction Right to Left

https://bugs.kde.org/show_bug.cgi?id=325650 --- Comment #13 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- This patch adds RTL reading mode to okular in following view modes: - facing pages. - facing ( center first page). - Overview. As well as adds “Right to left reading direction “

[Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- I have tested in pdf & ODF files and it works fine. Thanks, Fahad Al-Saidi ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review92546 --- On Sept. 25, 2015, 4:05 p.m., Fahad Al-Saidi wrote: > > --- &

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review92307 --- any feedback? - Fahad Al-Saidi On Sept. 25, 2015, 4:05

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

9945522 conf/dlggeneralbase.ui 03d5d5d conf/okular.kcfg d90fe23 ui/pageview.cpp 26373bb Diff: https://git.reviewboard.kde.org/r/125397/diff/ Testing --- I have tested in pdf & ODF files and it works fine. Thanks, Fahad Al-S

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

view97739 --- On July 21, 2016, 5:07 a.m., Fahad Al-Saidi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

> On July 21, 2016, 11:03 p.m., Albert Astals Cid wrote: > > Ship It! > > Fahad Al-Saidi wrote: > Great. > > Olivier Churlaud wrote: > Can you ship it Fahad? Or should I in your behalf? I can if I know :-) I am new here so any informoati

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

ed e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review97673 --- On July 21, 2016, 5:07 a.m., Fahad Al-Saidi wrote: > > --- > This is an automatically generate

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- I have tested in pdf & ODF files and it works fine. Thanks, Fahad Al-Saidi ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

> On July 21, 2016, 9:18 a.m., Olivier Churlaud wrote: > > Is the "future work" a lot to do? Because if is part of solving your > > problem, you should had this to the review. > > Fahad Al-Saidi wrote: > Well, the bug itself needs to be retest

Re: [Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

rd.kde.org/r/125442/#review97695 --- On Sept. 29, 2015, 5:42 a.m., Fahad Al-Saidi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: [Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

> On July 21, 2016, 9:18 a.m., Olivier Churlaud wrote: > > Is the "future work" a lot to do? Because if is part of solving your > > problem, you should had this to the review. > > Fahad Al-Saidi wrote: > Well, the bug itself needs to be retest

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

://git.reviewboard.kde.org/r/125397/diff/ Testing --- I have tested in pdf & ODF files and it works fine. Thanks, Fahad Al-Saidi ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[okular] [Bug 207748] LTR languages searches text backwards

https://bugs.kde.org/show_bug.cgi?id=207748 --- Comment #17 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- this bug also effect the copying the RTL text. the copied text is reversed. -- You are receiving this mail because: You are the assignee for the bug.

D10455: Add RTL support for search, copy & paste in pdf

fahadalsaidi added a comment. In D10455#263014 , @ngraham wrote: > @fahadalsaidi, are you able to work on those? Sorry, I don't have knowledge & time to fix the memory leaks. For the other question , I've already answered, here is it:

[okular] [Bug 207748] LTR languages searches text backwards

https://bugs.kde.org/show_bug.cgi?id=207748 --- Comment #19 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- I think the problem form QT interface for poppler. please see this bug https://bugs.freedesktop.org/show_bug.cgi?id=105015 -- You are receiving this mail because: You are the as

D10455: add rtl support to textpage

fahadalsaidi created this revision. fahadalsaidi added a reviewer: Okular. fahadalsaidi added a project: Okular. fahadalsaidi requested review of this revision. REVISION SUMMARY Right now all text are sorted in LTR order in TextPagePrivate::correctTextOrder() regardless from where they come.

[okular] [Bug 207748] LTR languages searches text backwards

https://bugs.kde.org/show_bug.cgi?id=207748 --- Comment #21 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- I proposed another patch to fix this bug, here https://phabricator.kde.org/D10455 -- You are receiving this mail because: You are the assignee for the bug.

D10455: add rtl support to textpage

fahadalsaidi added reviewers: aacid, ltoscano. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10455 To: fahadalsaidi, #okular, aacid, ltoscano Cc: michaelweghorn, ngraham, aacid

[okular] [Bug 207748] LTR languages searches text backwards

https://bugs.kde.org/show_bug.cgi?id=207748 --- Comment #20 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- I think I've found where is the problem. It is from TextPagePrivate::correctTextOrder(), it sorts words & characters to be LTR using theses compareTinyTextEntityY & compareT

[okular] [Bug 390357] auto tests fails

https://bugs.kde.org/show_bug.cgi?id=390357 --- Comment #5 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- (In reply to Albert Astals Cid from comment #4) > So you're hitting a qFatal? What is the output of the command? I guess that > would be a good hint of what your problem is

[okular] [Bug 390355] New: crash when open Arabic xps file

https://bugs.kde.org/show_bug.cgi?id=390355 Bug ID: 390355 Summary: crash when open Arabic xps file Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

[okular] [Bug 390355] crash when open Arabic xps file

https://bugs.kde.org/show_bug.cgi?id=390355 --- Comment #1 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- Created attachment 110595 --> https://bugs.kde.org/attachment.cgi?id=110595=edit second example produced by MS office 2016 -- You are receiving this mail because: You are the

D10455: add rtl support to textpage

fahadalsaidi updated this revision to Diff 27038. fahadalsaidi edited the summary of this revision. fahadalsaidi added a comment. Well, I was over-optimistic. This patch is related only to BUG: 207748 & BUG:184399. The other back-ends have many problem not related to this patch as

[okular] [Bug 390357] auto tests fails

https://bugs.kde.org/show_bug.cgi?id=390357 --- Comment #3 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- sorry, the problem is not from cmake. When I debug it, okular crash when open the doc, here it the debug: Thread 3 (Thread 0x7fffdbd71700 (LWP 376)): #0 0x75af474d i

[okular] [Bug 390357] auto tests fails

https://bugs.kde.org/show_bug.cgi?id=390357 --- Comment #6 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- Ok, I found the problem, I have to set Set LD_LIBRARY_PATH Set QT_PLUGIN_PATH Set XDG_DATA_DIRS in qtcreator in order to run & debug the test correctly. Please close this bug

[okular] [Bug 390357] New: auto tests fails

https://bugs.kde.org/show_bug.cgi?id=390357 Bug ID: 390357 Summary: auto tests fails Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority:

D10455: add rtl support to textpage

fahadalsaidi added a comment. @aacid I want to write autotest but there is a bug #390357 in cmake test. I will try make autotest smiliar to test311232() but there is a problem, the pdf file doesn't load probably and it give me in an empty m_generator. please have a look on it. REPOSITORY

D10455: Add RTL support for search, copy & paste in pdf

fahadalsaidi retitled this revision from "add rtl support to textpage" to "Add RTL support for search, copy & paste in pdf". fahadalsaidi edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10455 To: fahadalsaidi, #okular, aacid,

D10455: add rtl support to textpage

fahadalsaidi updated this revision to Diff 27043. fahadalsaidi edited the summary of this revision. fahadalsaidi added a comment. add autotest for searching in Arabic REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10455?vs=27038=27043 BRANCH master

[okular] [Bug 390356] New: wrong render for arabic xps

https://bugs.kde.org/show_bug.cgi?id=390356 Bug ID: 390356 Summary: wrong render for arabic xps Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

D10455: Add RTL support for search, copy & paste in pdf

fahadalsaidi added a comment. @aacid any feedback? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10455 To: fahadalsaidi, #okular, aacid, ltoscano Cc: ngraham, michaelweghorn, simgunz, aacid

D10455: Add RTL support for search, copy & paste in pdf

fahadalsaidi updated this revision to Diff 27517. fahadalsaidi added a comment. - use QTRY_COMPARE REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10455?vs=27043=27517 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10455 AFFECTED FILES

D10455: Add RTL support for search, copy & paste in pdf

fahadalsaidi added a comment. @aacid Thanks for the feedback. > I'm still unconvinced the text reversion is happening at the proper level. I really a new to okular's code, so please guide me to the right direction. > And you have a memory leak in your function as reported by

D10455: Add RTL support for search, copy & paste in pdf

fahadalsaidi added a comment. @chfanzil , thanks for testing and sharing your findings. The patch doesn't touch search logic , it deals only with inner text layer in okular. @aacid sorry to get to you late but Unfortunately I couldn't figure out how to fix the leak, my knowledge in C++

[Okular-devel] [okular] [Bug 207748] LTR languages searches text backwards

https://bugs.kde.org/show_bug.cgi?id=207748 --- Comment #10 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- This bug needs retest against Poppler >= 0.40 because there of this: https://bugs.freedesktop.org/show_bug.cgi?id=55977 -- You are receiving this mail because: You are the

[Okular-devel] [okular] [Bug 207748] LTR languages searches text backwards

https://bugs.kde.org/show_bug.cgi?id=207748 --- Comment #12 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- Created attachment 100228 --> https://bugs.kde.org/attachment.cgi?id=100228=edit arabic text -- You are receiving this mail because: You are the assignee fo

[Okular-devel] [okular] [Bug 207748] LTR languages searches text backwards

https://bugs.kde.org/show_bug.cgi?id=207748 --- Comment #13 from Fahad Al-Saidi <fahad.alsa...@gmail.com> --- you can search using this word: "بسم" in attached arabic text pdf if you find it, it means it is fixed in upstream otherwise the problem in okular. -- You are rec