[okular] [Bug 403263] Okular scales down pages when printing

https://bugs.kde.org/show_bug.cgi?id=403263 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #1

[okular] [Bug 286825] Okular should generate PDFs when printing instead of GhostScript

https://bugs.kde.org/show_bug.cgi?id=286825 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #16

[okular] [Bug 286825] Okular should generate PDFs when printing instead of GhostScript

https://bugs.kde.org/show_bug.cgi?id=286825 --- Comment #17 from Oliver Sander --- Two other approaches to reducing the use of ghostscript are https://git.reviewboard.kde.org/r/130055/ and https://phabricator.kde.org/D7949 -- You are receiving this mail because: You are the assignee for

[okular] [Bug 403627] okular cant properly display pdf

https://bugs.kde.org/show_bug.cgi?id=403627 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #1

[okular] [Bug 286825] Okular should generate PDFs when printing instead of GhostScript

https://bugs.kde.org/show_bug.cgi?id=286825 --- Comment #19 from Oliver Sander --- The reviewboard patch I mentioned is the content of the pdfprintpdf branch. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 403627] okular cant properly display pdf

https://bugs.kde.org/show_bug.cgi?id=403627 --- Comment #7 from Oliver Sander --- > I have too many accounts, I'd rather not sign up with another new account, if > you have an account can you please report it for me? Not me. If that bug isn't important enough to you to get a

D19539: Replace some iterator loops by range-based for

sander created this revision. sander added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. sander requested review of this revision. REVISION SUMMARY As the title says. In my humble opinion this makes the code *much* easier to read. TEST PLAN No

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander updated this revision to Diff 53196. sander edited the summary of this revision. sander edited the test plan for this revision. sander added a comment. Make the new touch screen behavior optional. There are three choices now in 'preferences->presentation': - Forward/Backward: Tapp

D19539: Replace some iterator loops by range-based for

sander added a comment. You may want to read up on range-based for; it is very helpful. In such a for-loop, `auto` always means "the type of a container entry". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19539 To: sander, #okular Cc: davidhurka, okular-devel, t

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. Not sure I fully understand your proposal. What happens if I uncheck the first option, check the second one, and then tap on the left half of the screen? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: g

D19539: Replace some iterator loops by range-based for

sander added a comment. Fine with me, too. If somebody is in favour of `auto`, please say so now. Otherwise I will remove the `auto`s from the patch. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19539 To: sander, #okular Cc: aacid, davidhurka, okular-devel, tfel

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. If I understand Albert correctly he wants to have the current behavior as an option. Your proposal does not offer that, does it? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: gbodley, michaelweghorn, a

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. That's the current behavior, only with different UI text, right? That's fine with me. I will provide an updated patch within the next few days. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: gbodley, m

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. > That's the current behavior, ... Meaning: That is the current behavior *of the patch*, ... REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: gbodley, michaelweghorn, aacid, ngraham, okular-devel, tfel

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. > What is the behavior of the mouse buttons? In other words can the left mouse button make it go forward without being anywhere on the screen, and the right button make if go backwards. Yes, doesn't that work for you? The complete logic is in the method `mous

Re: GSoC

Hi Aryan, great to hear you are interested in contributing to Okular. How much programming experience do you have? Have you already downloaded and build the Okular source code? As this years projects mainly deal with annotations in pdf files I suggest you also build a local version of the pop

D19539: Replace some iterator loops by range-based for

sander updated this revision to Diff 53294. sander added a comment. - Do not use `auto` in range-based for - Use `qDeleteAll` where appropriate REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19539?vs=53191&id=53294 REVISION DETAIL https://phabricator.kd

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander updated this revision to Diff 53295. sander added a comment. UI reworded following Nate's suggestions REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18118?vs=53196&id=53295 REVISION DETAIL https://phabricator.kde.org/D18118 AFFECTED FILES conf/d

D19539: Replace some iterator loops by range-based for

sander updated this revision to Diff 53383. sander added a comment. Ugly; didn't know about 'hidden detaches'. New patch with `qAsConst`. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19539?vs=53294&id=53383 REVISION DETAIL https://phabricator.kde.o

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. Albert, is this okay for you now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: sander, gbodley, michaelweghorn, aacid, ngraham, okular-devel, tfella, darcyshen

Re: Introduction and expression of interest in GSoC

Hi Umang, great to hear you are interested in Okular development. At least the "showing" part of the project proposal is really mostly work in poppler, so you may want to familiarize yourself with that. Poppler has a looong list of open bugs, so certainly there are a few that are suitable to ge

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander edited the summary of this revision. sander edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham, aacid Cc: sander, gbodley, michaelweghorn, aacid, ngraham, okular-devel, tfella, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander updated this revision to Diff 53691. sander added a comment. - 'sides' --> 'side' - updated old comment REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18118?vs=53295&id=53691 REVISION DETAIL https://phabricator.kde.org/D18118 AFFECTED FILES co

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham, aacid Cc: sander, gbodley, michaelweghorn, aacid, ngraham, okular-devel, tfella, darcyshen

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

This revision was automatically updated to reflect the committed changes. Closed by commit R223:50bfd9fe8645: Presentation: optionally go to prev. page when touching left half of the page (authored by sander). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1811

D19539: Replace some iterator loops by range-based for

sander added a comment. Albert, is this okay now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19539 To: sander, #okular Cc: aacid, davidhurka, okular-devel, tfella, ngraham, darcyshen

D19702: Page changes triggered by mouse clicks should all happen on button release

sander created this revision. sander added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. sander requested review of this revision. REVISION SUMMARY Previously this was inconsistent: left button clicks triggered page changes at release, but right bu

[okular] [Bug 405462] wrong display of annotation

https://bugs.kde.org/show_bug.cgi?id=405462 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #1

D19539: Replace some iterator loops by range-based for

sander updated this revision to Diff 53942. sander added a comment. Removed those four `aAsConst` again. I have been shying away from `arc` because I didn't want to learn yet another tool just for those few Okular patches that I submit. But if that makes *your* life more difficult (didn

D19702: Page changes triggered by mouse clicks should all happen on button release

sander updated this revision to Diff 53954. sander added a comment. Updated the comment REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19702?vs=53714&id=53954 REVISION DETAIL https://phabricator.kde.org/D19702 AFFECTED FILES ui/presentationwidget.cpp

D19702: Page changes triggered by mouse clicks should all happen on button release

sander marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19702 To: sander, #okular, ngraham, aacid Cc: aacid, okular-devel, tfella, ngraham, darcyshen

[okular] [Bug 405542] freehand line changes to panning after 1 stroke

https://bugs.kde.org/show_bug.cgi?id=405542 Oliver Sander changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution

[okular] [Bug 405542] freehand line changes to panning after 1 stroke

https://bugs.kde.org/show_bug.cgi?id=405542 --- Comment #4 from Oliver Sander --- > But currently, every stroke becomes a new annotation. I think that's a separate issue. -- You are receiving this mail because: You are the assignee for the bug.

Okular on Windows again?

Dear Okular team, at my day job there is potential need for Okular running on Windows. There used to be Windows binaries of Okular, and in my own experience they worked quite nicely. Unfortunately, those binaries disappeared from the web a few years ago. What would it take to make up-to-date Win

Re: Okular on Windows again?

> I might be wrong, but there are binary factory packages for Okular here: > > https://binary-factory.kde.org/job/Okular_Nightly_win32/335/ Interesting. So most of the difficult work has been done already. We could a) Place a link on the Okular download page to those nightly builds, marking i

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

sander added a comment. I tried this on my ThinkPad Yoga 12, which comes with a stylus to write on the screen with. I confirm that this patch noticeably improves the scrolling behavior when using the stylus for scrolling. I am curious though: what are the downsides to enabling tablet ev

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

sander added a comment. I do use my stylus for drawing on slides in presentation mode. I am not particularly happy with the quality of that, but compressing tablet events doesn't seem to make it worse. So no objections from my side. REPOSITORY R223 Okular REVISION DETAIL https://phabr

Re: Okular on Windows again?

>> a) Place a link on the Okular download page to those nightly builds, >> marking it clearly as "Experimental, may eat your $whatever". >> >> b) Do actual windows releases as described under >> >>http://kfunk.org/2017/11/17/kde-binary-factory/ "Now what to do..." >> >> Is that a possibility

D19702: Page changes triggered by mouse clicks should all happen on button release

sander added a comment. Is this okay now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19702 To: sander, #okular, ngraham, aacid Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen

Editing features

Dear Okular developers, at my day job I get asked about certain (pdf) editing features in Okular. Specifically, people would like to be able to delete and reorder pages, merge two documents, etc. In the past, such editing features have been contentious, with people wishing Okular to remain a pure

Re: GSoC

all my previous work for past 7 months with KDE which will include > my okular work too. > > My Phabricator profile: > https://phabricator.kde.org/people/revisions/13005/ > > My okular revisions: > https://phabricator.kde.org/D18744 > https://phabricator.kde.org/D187

D20165: Mention Windows nightly builds at binary-factory.kde.org

sander created this revision. sander added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. sander requested review of this revision. REVISION SUMMARY These Windows builds may not be of super-high quality, but we will not attract more Windows develope

Re: Editing features

> "Okular is a universal document viewer", yes we have *very light editing* but > that's what people expect in a viewer. I don't think the general public > expects a viewer to let them remove pages or reorder them. I am not convinced of this claim. >> * A separate competitive pdf editing applic

D20165: Mention Windows nightly builds at binary-factory.kde.org

sander added a comment. It seems that I cannot write to this repository (I could only clone the anonymous git). Do I need extra rights? Can somebody push the patch for me? REPOSITORY R575 Okular Website (okular.kde.org) REVISION DETAIL https://phabricator.kde.org/D20165 To: sander, #ok

D20194: Fix a typo

sander created this revision. sander added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. sander requested review of this revision. REVISION SUMMARY Mac Os --> Mac OS REPOSITORY R575 Okular Website (okular.kde.org) REVISION DETAIL https://phabr

Re: Editing features

> I'd consider operations like separate, unite, reorder, remove, rotate and > maybe even crop still as "light editing". I'd like 'em. Just like gwenview > lets you resize, crop, flip - despite being a viewer. Indeed! I have no ambition to replicate Inkscape/Scribus in Okular. > Would it be rea

D20194: Fix a typo

sander updated this revision to Diff 55304. sander added a comment. Changed Mac OS X to macOS everywhere. REPOSITORY R575 Okular Website (okular.kde.org) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20194?vs=55254&id=55304 REVISION DETAIL https://phabricator.kde.org/D20194 A

[okular] [Bug 406269] New: pdf document with empty signature field is claimed to be signed

https://bugs.kde.org/show_bug.cgi?id=406269 Bug ID: 406269 Summary: pdf document with empty signature field is claimed to be signed Product: okular Version: unspecified Platform: Other OS: Linux

[okular] [Bug 406350] New: Typo in German translation

https://bugs.kde.org/show_bug.cgi?id=406350 Bug ID: 406350 Summary: Typo in German translation Product: okular Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Pri

[okular] [Bug 406269] pdf document with empty signature field is claimed to be signed

https://bugs.kde.org/show_bug.cgi?id=406269 --- Comment #2 from Oliver Sander --- Okay, so not a bug. But can we improve the text somehow to make it clearer that the signatures are shitty broken? "This document is signed" sounds too positive. Unfortunately, not being a signature or

[okular] [Bug 406269] pdf document with empty signature field is claimed to be signed

https://bugs.kde.org/show_bug.cgi?id=406269 Oliver Sander changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail

D20351: Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle

sander added a comment. I like the color part of this patch. As for the line width: As mentioned, '3' is arbitrary. You need to find a width that takes current dpi into account. Ideally, the width should be what later gets written into the pdf file. The fact that the rectangle is

D20351: Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle

sander added a comment. Consider splitting the color change into a separate patch. That part seems to be uncontroversial. The problem with the '3' is that its perceived thickness depends on your screen size and resolution. What looks good to you may look bad on somebody else's compute

D20437: Make selection scrolling go at 60 fps

sander added a comment. How did you determine the value of the `damping` variable? You write With this patch this automatic scrolling goes at 60 fps instead of 10, I made it so that the speed of the scroll is the same. If somebody in the future changes the scroll speed, will you h

D20437: Make selection scrolling go at 60 fps

sander added a comment. Hi Kezi, I don't have a good answer to all that, I am just a bit distrustful regarding hard-coded constants like '6'. But I acknowledge that there are situations where they cannot be avoided. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D204

D20437: Make selection scrolling go at 60 fps

sander added a comment. Thanks! I am happy with these comments (except maybe that people may read the "/ 60 fps" in line 3770 as a division). REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20437 To: kezik, #okular, aacid Cc: sander, ngraham, aacid, ahmedbilal, okul

D20437: Make selection scrolling go at 60 fps

sander accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20437 To: kezik, #okular, aacid, sander Cc: sander, ngraham, aacid, ahmedbilal, okular-devel, kezik, joaonetto, tfella, darcyshen

[okular] [Bug 406489] Can not save image in pdf file use okular

https://bugs.kde.org/show_bug.cgi?id=406489 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #6

[okular] [Bug 406489] Can not save image in pdf file use okular

https://bugs.kde.org/show_bug.cgi?id=406489 --- Comment #8 from Oliver Sander --- But that doesn't save the actual image, but rather its rendering at the current solution, right? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 354248] Freehand annotation confuses tablet and touch events

https://bugs.kde.org/show_bug.cgi?id=354248 --- Comment #3 from Oliver Sander --- The patch you link to has been in Okular for a number of years. IIRC its state is 'discarded' because it was moved to phabricator for the final review. As for the trouble with freehand drawing: I h

Re: Would anyone want to co-mentor GSOC?

I volunteer to help, but I'd rather not be primary mentor of a project (for lack of skills). Best, Oliver On 01.05.19 01:16, Albert Astals Cid wrote: > What the subject says. > > Cheers, > Albert > > signature.asc Description: OpenPGP digital signature

Re: Would anyone want to co-mentor GSOC?

> I could only dedicate < 1h / week or so. I know that's a > poor commitment, even for co-mentoring. If you say it's > useful I'll sign up anyway and hope Oliver would join too. If Tobias is there to answer the difficult questions I can take care of the easy ones. :-) signature.asc Description:

D20760: Okular Annotation: add support for line ending style for Straight Line tool

sander added a comment. > I'd advocate to implement drawing the lines by code, i.e. QPainter::drawLine and friends. Then reuse the same code to draw icons. Agreed, but that is too much for a single patch. Rajeesh, nice patch! Can you get rid of the unicode symbols in the source cod

D20760: Okular Annotation: add support for line ending style for Straight Line tool

sander added a comment. Thanks! Will commit on tuesday, if nowbody objects. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20760 To: knambiar, #okular, #vdg Cc: sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D20760: Okular Annotation: add support for line ending style for Straight Line tool

sander accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20760 To: knambiar, #okular, #vdg, sander Cc: sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D20760: Okular Annotation: add support for line ending style for Straight Line tool

sander added a comment. I tried the circle line endings and they look a bit strange to me: F6810572: okular-strange-circle-line-ending.png Is this really how they are supposed to look? If not, is this a poppler bug, or is Okular missing some furth

D20760: Okular Annotation: add support for line ending style for Straight Line tool

sander added a comment. At least squares and diamonds are incorrect, too. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20760 To: knambiar, #okular, #vdg, sander, ngraham Cc: sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen,

D20760: Okular Annotation: add support for line ending style for Straight Line tool

sander added a comment. I think it should. But not in this patch. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20760 To: knambiar, #okular, #vdg, sander, ngraham Cc: sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D20760: Okular Annotation: add support for line ending style for Straight Line tool

sander added a comment. I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch. Rajeesh, thanks for the patch. I'd be happy to see more of your patches in the future. REPOSITORY

D20760: Okular Annotation: add support for line ending style for Straight Line tool

This revision was automatically updated to reflect the committed changes. Closed by commit R223:db2dcdade399: Okular Annotation: add support for line ending style for Straight Line tool (authored by knambiar, committed by sander). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20760?vs=57

[okular] [Bug 407338] Okular segfaults when opening a file digitally signed with portablesigner and Acrobat Reader

https://bugs.kde.org/show_bug.cgi?id=407338 Oliver Sander changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0

D21069: [RFC] Improve documentation of Document::setPageTextSelection()

This revision was automatically updated to reflect the committed changes. Closed by commit R223:9791d2591689: Improve documentation of Document::setPageTextSelection() (authored by davidhurka, committed by sander). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21069?vs=57709&id=57794#toc

D21202: Added basic JavaScript functions to support animated PDF

sander added inline comments. INLINE COMMENTS > kjs_document.cpp:277 > +QVector< Page * >::const_iterator pIt = doc->m_pagesVector.constBegin(), > pEnd = doc->m_pagesVector.constEnd(); > +for ( ; pIt != pEnd; ++pIt ) > +{ Please use a range-based for loop. REPOSITORY R223 Okular

D21136: Fix line annotation leader line angle

sander accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH fix_leaderline_angle (branched from master) REVISION DETAIL https://phabricator.kde.org/D21136 To: tobiasdeiminger, sander Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen,

D21092: Okular Annotation: use the new signal-slot connect syntax

sander added a comment. > I'm afraid we'll have similar objections to the endStyle, though, specifically “PDF only” — would that be okay? IMO it would be okay. Plus, with the help of Tobias maybe you can even teach Okular how to draw the start/end markers for non-pdf documents in a separ

D21202: Added basic JavaScript functions to support animated PDF

sander added inline comments. INLINE COMMENTS > kjs_document.cpp:139 > + > +for ( Page * pIt : doc->m_pagesVector ) > +{ As you were using const iterators before: Shouldn't this be `qAsConst(doc->m_pagesVector)` to avoid unnecessary detaching? > kjs_document.cpp:142 > +const Q

[okular] [Bug 395497] Menubar - No text

https://bugs.kde.org/show_bug.cgi?id=395497 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #20

D21202: Added basic JavaScript functions to support animated PDF

sander added inline comments. INLINE COMMENTS > joaonetto wrote in kjs_display.cpp:40 > And this does not compile `g_displayProto` needs to be a `std::unique_ptr` for this to compile. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21202 To: joaonetto, aacid, #okular C

D21248: WIP: Add line annotation ending arrows for non PDF documents

sander added a comment. > Is there an existing class for affien matrix operations? What about `QMatrix` or `QTransform`? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21248 To: tobiasdeiminger Cc: sander, knambiar, okular-devel, joaonetto, tfella, ngraham, darc

D21248: Add line annotation ending arrows for non PDF documents

sander added inline comments. INLINE COMMENTS > pagepainter.cpp:450 > // draw LineAnnotation MISSING: all > if ( type == Okular::Annotation::ALine ) > { Is that `MISSING` comment still relevant? What exactly does it mean anyway? > pagepainter

[okular] [Bug 343834] Okular doesn't print some form fields

https://bugs.kde.org/show_bug.cgi?id=343834 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #4

D21320: Fix build with poppler < 0.51

sander accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH Applications/19.04 REVISION DETAIL https://phabricator.kde.org/D21320 To: volkov, #okular, sander Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21320: Fix build with poppler < 0.51

sander added a comment. My error. Apologies! REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21320 To: volkov, #okular, sander Cc: aacid, joaonetto, okular-devel, tfella, ngraham, darcyshen

[okular] [Bug 407961] Trying to open "Chuuko demo Koi ga Shitai" Volume 2 and it crashes on open

https://bugs.kde.org/show_bug.cgi?id=407961 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #1

[okular] [Bug 408056] Activating edit tool automatically

https://bugs.kde.org/show_bug.cgi?id=408056 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de Status

D21416: Add icons for line annotation arrow styles to combo box

sander accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21416 To: tobiasdeiminger, #okular, sander Cc: davidhurka, knambiar, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21248: Add line annotation ending arrows for non PDF documents

sander accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH feature/drawlineendings REVISION DETAIL https://phabricator.kde.org/D21248 To: tobiasdeiminger, #okular, aacid, sander Cc: ngraham, sander, knambiar, okular-devel, joaonetto, tfel

D21416: Add icons for line annotation arrow styles to combo box

sander added a comment. Does https://phabricator.kde.org/D21543 help? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21416 To: tobiasdeiminger, #okular, sander Cc: bcooksley, davidhurka, knambiar, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

https://bugs.kde.org/show_bug.cgi?id=408272 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #5

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

https://bugs.kde.org/show_bug.cgi?id=408272 --- Comment #7 from Oliver Sander --- Indeed, that's probably even better. (I have experienced that evince 'problem' as well.) -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 408640] 30 second delay to open windows for two okular processes that are started together

https://bugs.kde.org/show_bug.cgi?id=408640 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #1

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander created this revision. sander added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. sander requested review of this revision. REVISION SUMMARY Previously, when using a screen scaling factor larger than 1, the drawings by mouse or stylus in pre

[okular] [Bug 384143] HiPDI: freehand line in presentation mode is blocky

https://bugs.kde.org/show_bug.cgi?id=384143 --- Comment #1 from Oliver Sander --- Patch at https://phabricator.kde.org/D21836 -- You are receiving this mail because: You are the assignee for the bug.

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21836 To: sander, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

Re: Moving to invent.kde.org

> So maybe we can move forward! (if I can suggest anything, I would just make > sure that the repository is set to rebase on master when merging a single > branch to not clutter the history). Sorry for being late, but +1 for gitlab! signature.asc Description: OpenPGP digital signature

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander added reviewers: ngraham, tobiasdeiminger. sander added a comment. Ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21836 To: sander, #okular, ngraham, tobiasdeiminger Cc: okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander added a comment. Path quality gets even better (slightly) if I replace the sequence of lines drawn by `SmoothPathEngine` with a `QPainterPath`. Do you prefer this change right here or in a separate patch on top? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander marked an inline comment as done. sander added inline comments. INLINE COMMENTS > tobiasdeiminger wrote in presentationwidget.cpp:900 > Maybe use a scoped > > const QSizeF pmSize { geom.width() * dpr, geom.height() * dpr }; > > instead of repeatedly recalculating width and height? Oka

D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode

sander updated this revision to Diff 60149. sander marked an inline comment as done. sander added a comment. - Use `localPos` instead of `screenPos` - Factor out intermediate Pixmap size computations - Use `QPainterPath` for smoother paths REPOSITORY R223 Okular CHANGES SINCE LAST UPDAT

[okular] [Bug 409013] Fix background color and frame of search result

https://bugs.kde.org/show_bug.cgi?id=409013 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #6

<    3   4   5   6   7   8   9   10   11   >