lexdem added a comment.
In https://phabricator.kde.org/D8385#161288, @rkflx wrote:
> In https://phabricator.kde.org/D8385#161287, @lexdem wrote:
>
> > The main conversation happens in #kde-devel, right? Or there is chat in
Phabricator too?
>
>
> While Phab has a chat (icon
lexdem added a comment.
In https://phabricator.kde.org/D8385#161286, @rkflx wrote:
> I had this already prepared (look at the commit timestamp), and scheduled
for tomorrow. But if you want it now, you get it now :)
>
> Thanks again for the patch, looking forward to more
lexdem added a comment.
Week already passed? :) I just waiting to continue coding and still didn't
ruin the workflow for this commit :)
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8385
To: lexdem, #okular, rkflx, ngraham
Cc: ltoscano, aacid, rkflx, ngraham
lexdem added a comment.
In https://phabricator.kde.org/D8385#160109, @rkflx wrote:
> > So, if there are a lot of products with new features, they're bundled to
some new version? Like from 16.12 to 17.04 . Is this also controlled by any
kind of CI, to bundle them? Sorry, if I ask too
lexdem added a comment.
Thank you, I will wait for this :)
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8385
To: lexdem, #okular, rkflx
Cc: ltoscano, aacid, rkflx, ngraham
lexdem edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8385
To: lexdem, #okular
Cc: ltoscano, aacid, rkflx, ngraham
lexdem added a comment.
Yep, sorry. Fixed
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8385
To: lexdem, #okular
Cc: ltoscano, aacid, rkflx, ngraham
lexdem added a comment.
In https://phabricator.kde.org/D8385#158072, @rkflx wrote:
> In https://phabricator.kde.org/D8385#158066, @lexdem wrote:
>
> > @ngraham , changed to the "FEATURE"
>
>
> You changed it to `**FEATURE**`, but the tooling handling this
lexdem edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8385
To: lexdem, #okular
Cc: ltoscano, aacid, rkflx, ngraham
lexdem added a comment.
@ltoscano , Thanks, got it. So, if there are a lot of products with `new
features`, they're bundled to some new version? Like from 16.12 to 17.04 . Is
this also controlled by any kind of CI, to bundle them? Sorry, if I ask too
much, I'm just curious about the whole
lexdem added a comment.
@rkflx , Thanks, that was exactly what I wanted to know about the processes
in landing of patches here, in Phabricator :)
@ngraham , changed to the "FEATURE"
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8385
To: lexdem, #okular
Cc:
lexdem edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8385
To: lexdem, #okular
Cc: ltoscano, aacid, rkflx, ngraham
lexdem updated this revision to Diff 21091.
lexdem added a comment.
Ok, i got you. Let it be just this small :'D
P.S. about zoom. I will try to implement that ASAP.
P.P.S Could anyone link me to documentation of whole phabricator-distro
process? I mean, which stages should pass the patch
lexdem added a comment.
In https://phabricator.kde.org/D8385#157503, @rkflx wrote:
> Here is another idea which should accommodate the use case of the bug
reporter (not sure how difficult this would be to implement, though):
>
> In the Overview columns combobox, introduce an Auto
lexdem added a comment.
In https://phabricator.kde.org/D8385#157468, @ngraham wrote:
> 1. The word "less" should be replaced with "fewer" in all the places where
you've used it. Less is used for an indeterminate quantity (e.g. less rice,
less water, less bad). Fewer is used for anything
lexdem updated this revision to Diff 21027.
lexdem added a comment.
Renamed all occurrences of word "less"
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8385?vs=21022=21027
REVISION DETAIL
https://phabricator.kde.org/D8385
AFFECTED FILES
lexdem created this revision.
lexdem added a reviewer: Okular.
lexdem added a project: Okular.
REVISION SUMMARY
This is a patch for the following request: 355283
The principle is simple. User toggles the checkbox, which enables overriding
the default columns for Overview mode, if the
lexdem added a comment.
In https://phabricator.kde.org/D7848#146398, @aacid wrote:
> I have to ask, i need your real name to give you proper copyright
attribution and "Lex Dem" doesn't really look like a russian name, could you
please confirm your real name?
Alex
lexdem added a comment.
In https://phabricator.kde.org/D7848#146378, @aacid wrote:
> Did you upload a wrong diff?
Sorry for such a mess. First time commiting
INLINE COMMENTS
> aacid wrote in part.cpp:2206
> Why commented code?
Actually, not sure, if need this lines. Okay, I'll
lexdem updated this revision to Diff 19597.
lexdem added a comment.
Fixed wrong diff
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7848?vs=19595=19597
REVISION DETAIL
https://phabricator.kde.org/D7848
AFFECTED FILES
part.cpp
part.h
To: lexdem,
lexdem updated this revision to Diff 19595.
lexdem added a comment.
Shortened from searching bookmark to just remove with viewport
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7848?vs=19594=19595
REVISION DETAIL
https://phabricator.kde.org/D7848
lexdem updated this revision to Diff 19594.
lexdem added a comment.
Removed commented lines
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7848?vs=19589=19594
REVISION DETAIL
https://phabricator.kde.org/D7848
AFFECTED FILES
part.cpp
part.h
To:
lexdem edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7848
To: lexdem, #okular
Cc: aacid
lexdem updated this revision to Diff 19589.
lexdem added a comment.
removed typo in "rename"
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7848?vs=19586=19589
REVISION DETAIL
https://phabricator.kde.org/D7848
AFFECTED FILES
part.cpp
part.h
To:
lexdem created this revision.
lexdem added a reviewer: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
Fix to the bug:357626
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7848
AFFECTED FILES
part.cpp
part.h
To: lexdem, #okular
Cc: aacid
25 matches
Mail list logo
