KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/4/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Mon, 13 Nov 2017 08:03:55 + Build duration: 15 min and counting JUnit Tests Name:

D8642: Rework saving of annotations and form data

aacid marked 3 inline comments as done. aacid added a comment. In https://phabricator.kde.org/D8642#164520, @lueck wrote: > In https://phabricator.kde.org/D8642#164036, @aacid wrote: > > > Note KDE Applications 17.12 is Nov 16, it would be great if we could get this in, so please try

D8642: Rework saving of annotations and form data

aacid marked 12 inline comments as done. aacid added inline comments. INLINE COMMENTS > mlaurent wrote in documenttest.cpp:112 > closeDocument delete m_document with a deleteLater or we need to delete it > before finish method ? delete added. > mlaurent wrote in document.cpp:4388 >

D8415: Soften correctness of image file open check

trufanov added a comment. Ok, I've added a warning for this. Please check wording - english isn't my native language. Feel free to change it. Attached are screenshots of Okular showing current warning for eng and rus locales.F5489936: Screenshot_20171113_113818.png

D8642: Rework saving of annotations and form data

aacid added a comment. In https://phabricator.kde.org/D8642#165611, @michaelweghorn wrote: > > Open pdf file, add anotation, close app > > You get dialog about losing changes, check that save, discard, cancel all do what they say > > This works as described. One additional thought

D8642: Rework saving of annotations and form data

michaelweghorn added a comment. In https://phabricator.kde.org/D8642#167020, @aacid wrote: > In https://phabricator.kde.org/D8642#165611, @michaelweghorn wrote: > > > > Open pdf file, add anotation, close app > > > You get dialog about losing changes, check that save, discard,

D8642: Rework saving of annotations and form data

rkflx added a comment. In https://phabricator.kde.org/D8642#167025, @aacid wrote: > > 1. [Ctrl] + [S] saves and is visible in Configure Shortcuts, but does not show up in the menu. > > Works just fine here. To clarify, in the File menu, I only see Save As, but no entry for

[okular] [Bug 386110] ctrl+f highlighting only works for low zoom levels

https://bugs.kde.org/show_bug.cgi?id=386110 David Edmundson changed: What|Removed |Added CC|

[okular] [Bug 386111] Selecting text moves it one pixel towards the bottom

https://bugs.kde.org/show_bug.cgi?id=386111 David Edmundson changed: What|Removed |Added CC|

D8642: Rework saving of annotations and form data

aacid added a comment. In https://phabricator.kde.org/D8642#166340, @rkflx wrote: > Another great feature \o/. Good news, I cannot reproduce or even describe the single crash I got and **there are only small issues to be fixed before this can land (IMHO). The rest is optional

D8642: Rework saving of annotations and form data

aacid added a comment. In https://phabricator.kde.org/D8642#166462, @rkflx wrote: > Most of my final checks passed, there is one more serious problem though: > > 23. Data loss on external change despite trying to save: Open, add annotation, change file externally, wait for warning,

[okular] [Bug 386316] Faster scroll speed for arrow keys

https://bugs.kde.org/show_bug.cgi?id=386316 --- Comment #2 from muntoo...@gmail.com --- The issue with PgUp/PgDown is that it does the entire screen and you lose surrounding context. Perhaps fast-scrolling can be done by a modifier like: `Shift-Up/Down` or `Ctrl-Up/Down`. This is similar to

D8415: Soften correctness of image file open check

ngraham added a comment. Actually @trufanov, would you mind doing it? I'd rather not commandeer your revision or commit it by hand, both of which will break the history here on phabricator. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham,

D8642: Rework saving of annotations and form data

aacid added a comment. In https://phabricator.kde.org/D8642#167049, @rkflx wrote: > In https://phabricator.kde.org/D8642#167025, @aacid wrote: > > > > 1. [Ctrl] + [S] saves and is visible in Configure Shortcuts, but does not show up in the menu. > > > > Works just fine here. >

D8642: Rework saving of annotations and form data

lueck added a comment. In https://phabricator.kde.org/D8642#167017, @aacid wrote: > In https://phabricator.kde.org/D8642#164520, @lueck wrote: > > > In https://phabricator.kde.org/D8642#164036, @aacid wrote: > > > > > Note KDE Applications 17.12 is Nov 16, it would be great if we

D8642: Rework saving of annotations and form data

lueck added a comment. In https://phabricator.kde.org/D8642#167017, @aacid wrote: > In https://phabricator.kde.org/D8642#164520, @lueck wrote: > > > In https://phabricator.kde.org/D8642#164036, @aacid wrote: > > > > > Note KDE Applications 17.12 is Nov 16, it would be great if we

D8642: Rework saving of annotations and form data

rkflx added a comment. > Ah, you want save to be only enabled when the file has been modified? I don't see this being a common pattern for the Save action , e.g. kate doesn't do that, libreoffice doesn't do that. Indeed, I missed this (still consider it a bug, though). LibreOffice used

D8642: Rework saving of annotations and form data

aacid added a comment. In https://phabricator.kde.org/D8642#166482, @rkflx wrote: > > 2. Got several "Lost annotation on document save, something went wrong" on the console. However, to prevent data loss this should show a warning in the UI and allow aborting (just show the warning

D8415: Soften correctness of image file open check

ngraham added a comment. Yeah, in the above screenshot, `reader.errorString()` seems to have returned "Unable to read image data" which is not very helpful. How about a single line and the following text: > This document appears malformed. Here is a best approximation of the document's

D8415: Soften correctness of image file open check

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular, aacid Cc: aacid, progwolff, ngraham

D8415: Soften correctness of image file open check

ngraham accepted this revision. ngraham added a comment. @trufanov, would you like to make that change? If not I can do it, and either way, let's land this tonight. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular, aacid Cc: aacid,

Re: Review Request 130226: CHM Generator Lib Update

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130226/#review103842 --- generators/CMakeLists.txt Lines 45 (patched)

D8415: Soften correctness of image file open check

aacid accepted this revision. aacid added a comment. Personally i'd change the : for a . But i don't really care, go ahead i'd say. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular, aacid Cc: aacid, progwolff, ngraham

D8415: Soften correctness of image file open check

trufanov added a comment. @ngraham Feel free to do it yourself. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular, aacid Cc: aacid, progwolff, ngraham

D8415: Soften correctness of image file open check

ngraham added a comment. OK, will do! REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular, aacid Cc: aacid, progwolff, ngraham

D8415: Soften correctness of image file open check

aacid added a comment. @ngraham you seem like a native speaker, please commit this with proper english-ness REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular, aacid Cc: aacid, progwolff, ngraham

D8415: Soften correctness of image file open check

ngraham added a comment. I am, yes. How does this sound? > This document appears malformed. Error: [error message] > Here is a best approximation of the document's intended appearance: This wording (or something similar) has the benefit that it casts Okular as a hero--bravely

D8642: Rework saving of annotations and form data

aacid added a comment. In https://phabricator.kde.org/D8642#167301, @lueck wrote: > In https://phabricator.kde.org/D8642#167017, @aacid wrote: > > > In https://phabricator.kde.org/D8642#164520, @lueck wrote: > > > > > In https://phabricator.kde.org/D8642#164036, @aacid wrote: >

D8415: Soften correctness of image file open check

aacid added a comment. Sounds good, do we actually get a meaningful error message in this case? If not i'd say just remove the "Error: [error message]" part. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular, aacid Cc: aacid,

D8642: Rework saving of annotations and form data

aacid added a comment. In https://phabricator.kde.org/D8642#167178, @rkflx wrote: > > Ah, you want save to be only enabled when the file has been modified? I don't see this being a common pattern for the Save action , e.g. kate doesn't do that, libreoffice doesn't do that. > >