Re: bind_src_by_address() is disabled?

2015-01-12 Thread Ben Greear
On 01/12/2015 11:22 AM, Mike Christie wrote: On 1/9/15, 8:28 PM, Thomas Dwyer III wrote: Hi folks, I spent some time browsing through this forum but I was unable to find an explanation for this comment referring to the disabled bind_src_by_address() function in io.c: *This is not supported

Re: iscsi_tcp bound to network interface issues after iscsid: retry login for ISCSI_ERR_HOST_NOT_FOUND

2015-01-12 Thread Mike Christie
On 01/12/2015 01:42 PM, Chris Leech wrote: On Mon, Jan 12, 2015 at 01:33:23PM -0600, Mike Christie wrote: I'm not sure we can remove bind_ep if we still want to support the cxgb3i and bnx2i general iface names. I am not sure what you mean here. Are saying you can use cxgbi and bnx2i but not

Re: bind_src_by_address() is disabled?

2015-01-12 Thread Ben Greear
On 01/12/2015 11:48 AM, Mike Christie wrote: On 1/12/15, 1:29 PM, Ben Greear wrote: On 01/12/2015 11:22 AM, Mike Christie wrote: On 1/9/15, 8:28 PM, Thomas Dwyer III wrote: Hi folks, I spent some time browsing through this forum but I was unable to find an explanation for this comment

Re: bind_src_by_address() is disabled?

2015-01-12 Thread Mike Christie
On 1/9/15, 8:28 PM, Thomas Dwyer III wrote: Hi folks, I spent some time browsing through this forum but I was unable to find an explanation for this comment referring to the disabled bind_src_by_address() function in io.c: *This is not supported for now, because it is not exactly what we

Re: [PATCHv2 0/9] Rewrite event handling

2015-01-12 Thread Andy Grover
On 01/06/2015 12:17 AM, Mike Christie wrote: Was the last issue the case where if actor_schedule_private gets 0 for delay_secs or does that just work? Not sure I quite follow but actor_schedule_private with 0 for delay_secs should be fine -- the actor is put on the ready_list straightaway and

small set of minor fixes

2015-01-12 Thread Chris Leech
Clearing out the backlog of a few minor issues, and the iscsiuio socket activation support. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to

[PATCH 3/5] iscsid: fix order of setting uid/gid and drop supplementary groups

2015-01-12 Thread Chris Leech
If using the user and group ID settings together the existing order of calling setuid first will almost always cause the setgid call to fail, assuming the new effective user id does not have the CAP_SETGID capability. The effective group ID needs to change first. While we're at it, if iscsid is

[PATCH 4/5] iscsiuio CFLAGS fixes

2015-01-12 Thread Chris Leech
try and keep existing CFLAGS from environment for packagers --- iscsiuio/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iscsiuio/configure.ac b/iscsiuio/configure.ac index d619598..7ee1e73 100644 --- a/iscsiuio/configure.ac +++ b/iscsiuio/configure.ac @@ -53,7

[PATCH 1/5] guard against NULL ptr during discovery from unexpected event

2015-01-12 Thread Chris Leech
When demand loading drivers during discovery, iscsiadm can receive an unexpected netlink event, like a link up, when looking for a discovery session login status. That could expose krecv_conn_state to a connection without a valid recv_context pointer. Guard against that to prevent the NULL

[PATCH 2/5] add discovery as a valid mode in iscsiadm.8

2015-01-12 Thread Chris Leech
--- doc/iscsiadm.8 | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/iscsiadm.8 b/doc/iscsiadm.8 index 9a945d1..05793b2 100644 --- a/doc/iscsiadm.8 +++ b/doc/iscsiadm.8 @@ -174,13 +174,13 @@ for session mode). .TP \fB\-m, \-\-mode \fIop\fR specify the mode.

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-12 Thread Mike Christie
On 01/11/2015 03:23 AM, Sagi Grimberg wrote: On 1/9/2015 8:00 PM, Michael Christie wrote: SNIP Session wide command sequence number synchronization isn't something to be removed as part of the MQ work. It's a iSCSI/iSER protocol requirement. That is, the expected + maximum sequence

Re: iscsi_tcp bound to network interface issues after iscsid: retry login for ISCSI_ERR_HOST_NOT_FOUND

2015-01-12 Thread Mike Christie
On 1/11/15, 11:37 PM, Chris Leech wrote: On Thu, Jan 08, 2015 at 08:40:17PM -0600, Mike Christie wrote: On 01/08/2015 11:11 AM, Chris Leech wrote: On Thu, Jan 08, 2015 at 10:36:59AM -0600, Michael Christie wrote: On Jan 6, 2015, at 6:40 PM, Chris Leech cle...@redhat.com wrote: Hi all, It

Re: iscsi_tcp bound to network interface issues after iscsid: retry login for ISCSI_ERR_HOST_NOT_FOUND

2015-01-12 Thread Chris Leech
On Mon, Jan 12, 2015 at 01:33:23PM -0600, Mike Christie wrote: I'm not sure we can remove bind_ep if we still want to support the cxgb3i and bnx2i general iface names. I am not sure what you mean here. Are saying you can use cxgbi and bnx2i but not specify a iface name that is associated

Re: bind_src_by_address() is disabled?

2015-01-12 Thread Mike Christie
On 1/12/15, 1:29 PM, Ben Greear wrote: On 01/12/2015 11:22 AM, Mike Christie wrote: On 1/9/15, 8:28 PM, Thomas Dwyer III wrote: Hi folks, I spent some time browsing through this forum but I was unable to find an explanation for this comment referring to the disabled bind_src_by_address()

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-12 Thread Mike Christie
On 01/11/2015 03:40 AM, Sagi Grimberg wrote: On 1/9/2015 10:19 PM, Mike Christie wrote: On 01/09/2015 12:28 PM, Hannes Reinecke wrote: On 01/09/2015 07:00 PM, Michael Christie wrote: On Jan 8, 2015, at 11:03 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Thu, 2015-01-08 at 15:22

Re: iscsi_tcp bound to network interface issues after iscsid: retry login for ISCSI_ERR_HOST_NOT_FOUND

2015-01-12 Thread Mike Christie
On 01/12/2015 01:50 PM, Mike Christie wrote: On 01/12/2015 01:42 PM, Chris Leech wrote: On Mon, Jan 12, 2015 at 01:33:23PM -0600, Mike Christie wrote: I'm not sure we can remove bind_ep if we still want to support the cxgb3i and bnx2i general iface names. I am not sure what you mean here.

Re: 2 iscsid processes started

2015-01-12 Thread Mike Christie
On 01/09/2015 07:46 AM, Mathieu Bouillaguet wrote: Hi, I have two questions regarding open-iscsi. 1) I experience the same as exposed by the person in this post : http://forum.proxmox.com/threads/6415-iscsid-it-starts-two-process When I execute iscsid by hand or startup the service, two

Re: [PATCH 5/5] iscsiuio systemd socket activation support

2015-01-12 Thread Eddie Wai
I'm surprised that this change hasn't made it upstream yet. I worked on it back when and here's my ACK for it. Thanks for the patch again, Chris. acked-by: Eddie Wai eddie@broadcom.com Eddie On Mon, 2015-01-12 at 11:24 -0800, Chris Leech wrote: Signed-off-by: Chris Leech

Re: [PATCHv2 0/9] Rewrite event handling

2015-01-12 Thread Mike Christie
On 01/12/2015 01:59 PM, Andy Grover wrote: An executing actor can call actor_schedule() (either with a zero or nonzero delay) to run another actor. If the delay is zero then the new actor will be run before the current invocation of actor_poll() exits. Doh. My eyes must have been cross eyed at

Re: [PATCH] fix regression in iscsi_tcp iface binding

2015-01-12 Thread Mike Christie
On 01/11/2015 11:36 PM, Chris Leech wrote: The changes in retry login for ISCSI_ERR_HOST_NOT_FOUND caused sessions using the iscsi_tcp transport bound to a network iface to fail to connect due to the host lookup failing (iscsi_tcp hosts are dynamically allocated per-session). This marks

Re: bind_src_by_address() is disabled?

2015-01-12 Thread Mike Christie
On 01/12/2015 01:59 PM, Ben Greear wrote: On 01/12/2015 11:48 AM, Mike Christie wrote: On 1/12/15, 1:29 PM, Ben Greear wrote: On 01/12/2015 11:22 AM, Mike Christie wrote: On 1/9/15, 8:28 PM, Thomas Dwyer III wrote: Hi folks, I spent some time browsing through this forum but I was

Re: Problem setting host net params via iscsiuio on first try: bad error message

2015-01-12 Thread Mike Christie
Thanks. I merged and pushed these patches. When you get some time, reply to that mail I sent offlist about how long it is taking for the set host net params to succeed, so I can fix my login/init patch as needed. On 12/11/2014 01:53 PM, The Lee-Man wrote: Hi Mike: I have started working more

Re: iscsi_tcp bound to network interface issues after iscsid: retry login for ISCSI_ERR_HOST_NOT_FOUND

2015-01-12 Thread Mike Christie
On 1/12/15, 2:20 PM, Mike Christie wrote: On 01/12/2015 01:50 PM, Mike Christie wrote: On 01/12/2015 01:42 PM, Chris Leech wrote: On Mon, Jan 12, 2015 at 01:33:23PM -0600, Mike Christie wrote: I'm not sure we can remove bind_ep if we still want to support the cxgb3i and bnx2i general iface

Re: 2 iscsid processes started

2015-01-12 Thread Mathieu Bouillaguet
Le lun. 12 janv. 2015 21:45, Mike Christie micha...@cs.wisc.edu a écrit : Thanks for the explanation. I use an home made slackware init script. I only tried to start it by hand to understand what was going on. I found a fix following the related debian bug :

Re: bind_src_by_address() is disabled?

2015-01-12 Thread Thomas Dwyer III
I think user error on my part caused my followup replies to post with the wrong email address (one that has not joined this group). Maybe that's why I don't see them in this thread? Sorry about that. Let me try again... On Monday, January 12, 2015 at 12:54:38 PM UTC-8, Mike Christie wrote: ...