Antw: Re: [PATCH 2/2] iscsi tools: Enhance the discovery code for iser

2014-02-02 Thread Ulrich Windl
Mike Christie micha...@cs.wisc.edu schrieb am 01.02.2014 um 06:14 in Nachricht 52ec82ce.7040...@cs.wisc.edu: On 1/26/14 8:03 AM, Or Gerlitz wrote: For proper discovery support, the iser transport needs the ISCSI_PARAM_DISCOVERY_SESS hint before the login PDU is sent. For that end, issue the

Re: [PATCH 2/2] iscsi tools: Enhance the discovery code for iser

2014-02-01 Thread Or Gerlitz
On Sat, Feb 1, 2014 at 7:14 AM, Mike Christie micha...@cs.wisc.edu wrote: On 1/26/14 8:03 AM, Or Gerlitz wrote:@@ -1406,6 +1406,17 @@ redirect_reconnect: if ((session-t-caps CAP_LOGIN_OFFLOAD)) goto start_conn; + if(!strcmp(session-t-name, iser)) { +

Re: [PATCH 2/2] iscsi tools: Enhance the discovery code for iser

2014-02-01 Thread Mike Christie
On 2/1/14 2:42 PM, Or Gerlitz wrote: On Sat, Feb 1, 2014 at 7:14 AM, Mike Christie micha...@cs.wisc.edu wrote: On 1/26/14 8:03 AM, Or Gerlitz wrote:@@ -1406,6 +1406,17 @@ redirect_reconnect: if ((session-t-caps CAP_LOGIN_OFFLOAD)) goto start_conn; +

Re: [PATCH 2/2] iscsi tools: Enhance the discovery code for iser

2014-02-01 Thread Or Gerlitz
On 02/02/2014 06:12, Mike Christie wrote: On 2/1/14 2:42 PM, Or Gerlitz wrote: At this time (e.g after bind and before sending login) I need only the session discovery yes/no set param, this goes down to different buffer management strategy for discovery vs. normal sessions in iser. I

Re: [PATCH 2/2] iscsi tools: Enhance the discovery code for iser

2014-01-31 Thread Mike Christie
On 1/26/14 8:03 AM, Or Gerlitz wrote: For proper discovery support, the iser transport needs the ISCSI_PARAM_DISCOVERY_SESS hint before the login PDU is sent. For that end, issue the call to iscsi_session_set_params before starting the login code in case the transport is iser. Signed-off-by: