Re: lio-target crashes when windows initiator logs in

2009-12-09 Thread Pasi Kärkkäinen
On Tue, Dec 08, 2009 at 10:13:16AM -0800, ablock wrote: Hi, I have problems with the lio-target software. I tried lio-core-2.6.31 and lio-core-2.6. I compiled it together with lio-utils under ubuntu 9.10 and debian 5.0. Ubuntu and debian was installed in a virtual machine. I used virtual

Re: lio-target crashes when windows initiator logs in

2009-12-09 Thread ablock
Hello, sorry, I realized my mistake when the submit button was pressed. I also posted the Question in the lio-target-group. You can delete the posting in this group or leave it. Maybe somebody can also help me in this group. A. Block On 9 Dez., 11:55, Pasi Kärkkäinen pa...@iki.fi wrote: On Tue,

[PATCH RFC] use _bh locking in iscsi_queuecommand

2009-12-09 Thread Or Gerlitz
Both the TX (iscsi_queuecommand, iscsi_xmit_task, iscsi_conn_send_pdu) and the RX (iscsi_complete_pdu and iser/tcp as well) code flows compete on the session lock. Since the RX flow runs in softirq/bh/tasklet context, if it cuts the TX flow on the same cpu, a deadlock may happen. To prevent that,

Re: [PATCH RFC] use _bh locking in iscsi_queuecommand

2009-12-09 Thread Or Gerlitz
Mike, I am debugging some enhancement to iser and came a cross this. I really don't see why it haven't hit anyone in the past, any idea? One more thing which I'd be happy to understand are what the rational behind the spin_unlock(host-host_lock) call in iscsi_queuecommand beginning and

Re: Unable to apply kernel/2.6.26_compat.patch from git master branch

2009-12-09 Thread Boaz Harrosh
On 12/08/2009 09:15 PM, Yangkook Kim wrote: Hi, you are back. I think for your patch, you want to include open_iscsi_compat.h in it. I included open_iscsi_compat.h and created a patch. Please check it. I have a quetion about creating a patch agaist files in sub-directory. I used git

Re: [PATCH RFC] use _bh locking in iscsi_queuecommand

2009-12-09 Thread Mike Christie
Or Gerlitz wrote: Both the TX (iscsi_queuecommand, iscsi_xmit_task, iscsi_conn_send_pdu) and the RX (iscsi_complete_pdu and iser/tcp as well) code flows compete on the session lock. Since the RX flow runs in softirq/bh/tasklet context, if it cuts the TX flow on the same cpu, a deadlock may

Re: [PATCH RFC] use _bh locking in iscsi_queuecommand

2009-12-09 Thread Or Gerlitz
Mike Christie micha...@cs.wisc.edu wrote: The scsi_host_template-queuecommand function is called by scsi-ml with irqs disabled spin_lock_irqsave(host-host_lock, flags) thanks for clarifying that, specifically do you refer to scsi.c :: scsi_dispatch_cmd()? at some point I was LXR-ing for

Re: [PATCH RFC] use _bh locking in iscsi_queuecommand

2009-12-09 Thread Mike Christie
Or Gerlitz wrote: Mike Christie micha...@cs.wisc.edu wrote: The scsi_host_template-queuecommand function is called by scsi-ml with irqs disabled spin_lock_irqsave(host-host_lock, flags) thanks for clarifying that, specifically do you refer to scsi.c :: scsi_dispatch_cmd()? at some point

Re: [PATCH 4/5] BNX2I - Task management ABORT TASK fixes

2009-12-09 Thread Mike Christie
Anil Veerabhadrappa wrote: * Due to typo error driver was failing TMF Abort Task request when ctask-sc != NULL. Fixed code to fail TMF ABORT Task request only when ctask-sc == NULL * Clear age component (19 most significant bits) of reference ITT carried in iSCSI TMF

Re: [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver

2009-12-09 Thread Mike Christie
Anil Veerabhadrappa wrote: * Add code to enumerate 5771E device Signed-off-by: Anil Veerabhadrappa ani...@broadcom.com --- drivers/scsi/bnx2i/bnx2i_init.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_init.c

Re: [PATCH 2/5 ] BNX2I - Adjust sq_size module parametr to power of 2 only if a non-zero value is specified

2009-12-09 Thread Mike Christie
Anil Veerabhadrappa wrote: * This issue was discovered during 10G iscsi testing * Default value of 'sq_size' module parameter is '0' which means driver should use predefined SQ queue size when setting up iscsi connection. * roundup_pow_of_two(0) results in '1' and

Re: [PATCH 5/5] BNX2I - minor code cleanup and update driver version

2009-12-09 Thread Mike Christie
Anil Veerabhadrappa wrote: * Removed duplicate function call and not-so-useful comment line Signed-off-by: Anil Veerabhadrappa ani...@broadcom.com --- drivers/scsi/bnx2i/bnx2i_init.c |4 ++-- drivers/scsi/bnx2i/bnx2i_iscsi.c |2 -- 2 files changed, 2 insertions(+), 4

Re: [PATCH 3/5] BNX2I - update CQ arming algorith for 5771x chipsets

2009-12-09 Thread Mike Christie
Anil Veerabhadrappa wrote: * Only affects 5771x (10G chipsets) devices Why don't you do it on 1 gig? Is it just not worth it or is it no possible due to some limitation? -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group,

Re: Need help with multipath and iscsi in CentOS 5.4

2009-12-09 Thread Mike Christie
Kyle Schmitt wrote: I'm cross-posting here from linux-iscsi-users since I've seen no linux-scsi-users would be for centos 4. Centos 5 uses a different initiator, but you are the right place finally :) traffic in the weeks since I posted this. Hi, I needed a little help or advice with my

Re: Another Kernel Oops?

2009-12-09 Thread Mike Christie
Qinghua(Kevin) Ye wrote: Hi All, I encountered another kernel oops in the open-iscsi code. Not sure if it is fixed in the new code, but I would like to have some idea about it. Thanks. My setup: Ubuntu 8.04 with kernel 2.6.24-24-generic. Open-iscsi 2.0-870.3 The kernel oops happens

Re: Another Kernel Oops?

2009-12-09 Thread Qinghua(Kevin) Ye
Hi Mike, Yes, as I said the target node crashed and then the open-icssi kernel oops happens. So far I only hit it once. I'll try to see if I can reproduce it. Kevin On Wed, Dec 9, 2009 at 8:00 PM, Mike Christie micha...@cs.wisc.edu wrote: Qinghua(Kevin) Ye wrote: Hi All, I encountered

[PATCH 1/1] cxgb3i: Fix a login over vlan issue

2009-12-09 Thread kxie
[PATCH 1/1] cxgb3i: Fix a login over vlan issue From: Karen Xie k...@chelsio.com Fix a login over vlan issue, when parent interface is vlan and we are using cxgb3i sepecific private ip address in '/etc/iscsi/ifaces/' iface file. Acked-by: Karen Xie k...@chelsio.com Signed-off-by: Rakesh Ranjan

RE: [PATCH 1/1] cxgb3i: Fix a login over vlan issue

2009-12-09 Thread Karen Xie
Hi, thanks, Mike. It looks like the original patch somehow did not make into the linux-scsi list at all for some reason: tried to search for it but could not find it. We are re-submitting it just to make sure. Best regards, Karen -Original Message- From: Mike Christie