Re: I want to contribute
Hi, Kindly note, This is not related to Chelsio in anyway and it is something I am interested in doing in my free time. I would also not like to work on anything related to any vendor. I would like to work on kernel related stuff. For now, I would like to start by improving whats already there. Anything is fine. Thank you, Vivek S On Jun 30, 2:23 am, Mike Christie micha...@cs.wisc.edu wrote: On 06/28/2011 11:50 AM, Vivek wrote: Hi guys, I have knowledge of iSCSI protocol and would like to contribute to this project. Kindly let me know if there are any task that I can take up. We have lots of stuff. What do you like to work on? Do you want to work on chelsio related items (cxgb3i/cxgb4i) or anything? Do you prefer kernel work or userspace work? Do you like working on performance related stuff (kill some locking in the kernel code, improve IO paths, make structs per cpu, etc), or cleanup type of stuff, or do you want to add some smaller features that users have been asking for (improved logging support in the tools, make iscsiadm -m session -P 3 display more info, etc) or do you like management/libs/tools type of stuff? -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 3/4 v2] BNX2I: Changed the nopout_wqe-lun memcpy to use sizeof instead
On Fri, 2011-06-24 at 15:20 -0500, Mike Christie wrote:
On 06/23/2011 05:51 PM, Eddie Wai wrote:
Modified the memcpy of nopout_wqe-lun to use sizeof(struct scsi_lun)
instead of the hardcoded value 8 as noted by review comments.
Signed-off-by: Eddie Wai eddie@broadcom.com
---
drivers/scsi/bnx2i/bnx2i_hwi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
index 2a1bb9f..ba2f96e 100644
--- a/drivers/scsi/bnx2i/bnx2i_hwi.c
+++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
@@ -551,7 +551,7 @@ int bnx2i_send_iscsi_nopout(struct bnx2i_conn
*bnx2i_conn,
nopout_wqe-op_code = nopout_hdr-opcode;
nopout_wqe-op_attr = ISCSI_FLAG_CMD_FINAL;
- memcpy(nopout_wqe-lun, nopout_hdr-lun, 8);
+ memcpy(nopout_wqe-lun, nopout_hdr-lun, sizeof(struct scsi_lun));
if (test_bit(BNX2I_NX2_DEV_57710, ep-hba-cnic_dev_type)) {
u32 tmp = nopout_wqe-lun[0];
This patch and Andy your patch [PATCH] iscsi: Use struct scsi_lun in
iscsi structs instead of u8[8] are going to conflict with each other.
And Eddie, I think you missed some other instances where 8 is hardcoded.
Agreed, I skipped this one for now ... please resubmit against scsi-misc
if more work is needed.
Thanks,
James
--
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
Re: I want to contribute
On 06/30/2011 12:43 AM, yodeveloper wrote: Hi, Kindly note, This is not related to Chelsio in anyway and it is something I am interested in doing in my free time. I would also not like to work on anything related to any vendor. I would like to work on kernel related stuff. For now, I would like to start by improving whats already there. Anything is fine. Ok, I will write up some items that you might find interesting and send them to the list. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: unable to login to targets with be2iscsi
On 06/29/2011 09:28 AM, Seth Simons wrote: I've managed to get this target to work now. The steps I had to take were: - Use the latest 2.6.39 kernel and open-iscsi userland (to make be2iscsi work) - Disable the 'Load Balancing' feature on the HP P4300s (to make the target behave itself) Confusingly, the 'load balancing' option on the P4300 works perfectly when using either the qla4xxx or iscsi_tcp drivers. Not sure why, though i'll continue to play around with it. Thanks for reporting back. Does load balancing mean that the target does login redirect (the initiator logs into one portal then the target will redirect the initiator to a portal it thinks will be better)? -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: unable to login to targets with be2iscsi
On 06/30/2011 06:48 PM, Mike Christie wrote: On 06/29/2011 09:28 AM, Seth Simons wrote: I've managed to get this target to work now. The steps I had to take were: - Use the latest 2.6.39 kernel and open-iscsi userland (to make be2iscsi work) - Disable the 'Load Balancing' feature on the HP P4300s (to make the target behave itself) Confusingly, the 'load balancing' option on the P4300 works perfectly when using either the qla4xxx or iscsi_tcp drivers. Not sure why, though i'll continue to play around with it. Thanks for reporting back. Does load balancing mean that the target does login redirect (the initiator logs into one portal then the target will redirect the initiator to a portal it thinks will be better)? Seth, ignore the question above. I can replicate it here. Jay, have you tested be2iscsi with the HP box mentioned above, or have you tested with a Equalogic box or tested with any box that does login redirect? I used tgtd then set the redirect address like this: tgtadm --op update --mode target --tid 1 --name RedirectAddress --value 10.76.0.30 tgtadm --op update --mode target --tid 1 --name RedirectPort --value 3260 tgtadm --op update --mode target --tid 1 --name RedirectReason --value Temporary tgtadm --op show --mode target --tid 1 RedirectAddress=10.76.0.30 RedirectPort=3260 RedirectReason=Temporary -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: unable to login to targets with be2iscsi
On 06/30/2011 08:59 PM, Mike Christie wrote: On 06/30/2011 06:48 PM, Mike Christie wrote: On 06/29/2011 09:28 AM, Seth Simons wrote: I've managed to get this target to work now. The steps I had to take were: - Use the latest 2.6.39 kernel and open-iscsi userland (to make be2iscsi work) - Disable the 'Load Balancing' feature on the HP P4300s (to make the target behave itself) Confusingly, the 'load balancing' option on the P4300 works perfectly when using either the qla4xxx or iscsi_tcp drivers. Not sure why, though i'll continue to play around with it. Thanks for reporting back. Does load balancing mean that the target does login redirect (the initiator logs into one portal then the target will redirect the initiator to a portal it thinks will be better)? Seth, ignore the question above. I can replicate it here. Ignore my request to ignore my questions. It seems to be a issue with tgtd for me. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: I want to contribute
Thank you. I was also thinking on the lines of writing a ToDo document that has a list of pending items, enhancements and features that need to be implemented. This saves a lot of time for people who want to contribute. They can quickly pick up things that they are interested in by reading the document. We can pool things that are pending at one place and I am ready write the document. On Fri, Jul 1, 2011 at 3:43 AM, Mike Christie micha...@cs.wisc.edu wrote: On 06/30/2011 12:43 AM, yodeveloper wrote: Hi, Kindly note, This is not related to Chelsio in anyway and it is something I am interested in doing in my free time. I would also not like to work on anything related to any vendor. I would like to work on kernel related stuff. For now, I would like to start by improving whats already there. Anything is fine. Ok, I will write up some items that you might find interesting and send them to the list. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
