[PATCH 7/7] open-isns: Fix warnings reported by gcc-4.5.2

2011-07-20 Thread Jim Ramsay
Unused symbols and type mis-matches. Signed-off-by: Jim Ramsay jim_ram...@dell.com --- utils/open-isns/client.c |2 ++ utils/open-isns/db-file.c |4 ++-- utils/open-isns/objects.h |1 + utils/open-isns/socket.c |2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 1/7] Fix dcb_app.c compile error with old kernels

2011-07-20 Thread Jim Ramsay
Linux kernels 2.6.28 and earlier do not have RTM_GETDCB or RTM_SETDCB defined in their rtnetlink.h. Defining them in dcb_app.c should be safe since they have not changed their numerical value since they were introduced in 2.6.29. Signed-off-by: Jim Ramsay jim_ram...@dell.com --- usr/dcb_app.c |

Re: A set of minor bug fixes and enhancements

2011-07-20 Thread Jim Ramsay
On Jul 8, 6:52 pm, Mike Christie wrote: On 07/08/2011 05:47 PM, Mike Christie wrote: On 07/08/2011 08:42 AM, Jim Ramsay wrote: I have a set of minor changes I've made while developing the Multisession and Leading-login support that I think may be beneficial to the open-iscsi project as

[PATCH 4/7] Revise bind_conn_to_iface logic

2011-07-20 Thread Jim Ramsay
This now explicitly enforces the logic already hinted at, which should prefer hardware address over net_ifacename in all circumstances. Previously the 'else if' was always being executed. Signed-off-by: Jim Ramsay jim_ram...@dell.com --- usr/io.c | 16 +--- 1 files changed, 9

[PATCH 3/7] iscsid: In foreground mode, treat SIGINT like SIGTERM

2011-07-20 Thread Jim Ramsay
This allows ^C to exit iscsid but only when it is running in foreground mode, which is useful for testing. Signed-off-by: Jim Ramsay jim_ram...@dell.com --- usr/iscsid.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/usr/iscsid.c b/usr/iscsid.c index

[PATCH 5/7] iscsi tools: Fix warnings reported by gcc-4.5.2

2011-07-20 Thread Jim Ramsay
A majority of these have to deal with ignored return values. Some of the others are just unused variables or functions. One warning remains at link-time for iscsistart: iscsi_util.c:267: warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries

[PATCH 6/7] fwparam_ibft: Fix warnings reported by gcc-4.5.2

2011-07-20 Thread Jim Ramsay
A simple cast for the qsort comparison parameter, and an updated prom_lex.c generated by flex-2.5.35 Signed-off-by: Jim Ramsay jim_ram...@dell.com --- utils/fwparam_ibft/fwparam_ppc.c |2 +- utils/fwparam_ibft/prom_lex.c| 173 -

Re: [PATCH 3/7] iscsid: In foreground mode, treat SIGINT like SIGTERM

2011-07-20 Thread Bart Van Assche
On Wed, Jul 20, 2011 at 3:06 PM, Jim Ramsay jim_ram...@dell.com wrote: This allows ^C to exit iscsid but only when it is running in foreground mode, which is useful for testing. Signed-off-by: Jim Ramsay jim_ram...@dell.com ---  usr/iscsid.c |    5 +  1 files changed, 5 insertions(+), 0

Re: iscsiadm command line syntax

2011-07-20 Thread Mike Christie
On 07/19/2011 10:35 AM, Vivek S wrote: So how do we go about this ? Shall we remove discovery mode completely We cannot remove it now. I think we have only had 1 release with discoverydb support. I do not think anyone would have had time to convert over. In general if we want to remove

Re: TODO list- userspace2.

2011-07-20 Thread Mike Christie
On 07/19/2011 12:32 PM, rahul gupta wrote: Hi Mike, As we discussed last week, I have taken up TODO- userspace list item #2. I have analysed and coded on some part of it on this weekend :- For timeout and CHAP I have taken following parameters values from /sys and printed it. [root@a