Any update ?
On Tue, Aug 30, 2011 at 8:44 PM, Vivek S vivek...@gmail.com wrote:
Added comments for structures and functions.
As for being a masochist, I tried, but couldn't take it ;-P.
On Tue, Aug 30, 2011 at 12:31 PM, Ulrich Windl
ulrich.wi...@rz.uni-regensburg.de wrote:
Vivek S
On 09/03/2011 04:02 AM, Vivek S wrote:
Any update ?
Looks ok. Thanks for all your work on it. And thanks to Ulrich for the
review.
Just one stye comment though. The coding style we follow has us put the
leading { on the first line for structs, for, and if/else blocks. So
+struct option_help
Thanks a lot Mike !
Will follow the coding style more rigourously the next time I submit a
patch.
On Sat, Sep 3, 2011 at 10:08 PM, Mike Christie micha...@cs.wisc.edu wrote:
On 09/03/2011 04:02 AM, Vivek S wrote:
Any update ?
Looks ok. Thanks for all your work on it. And thanks to Ulrich
On 08/31/2011 11:57 AM, Aastha Mehta wrote:
Hello,
Attached is the patch for the first kernel TODO item in the TODO list
circulated earlier. I could not send the patch through git send-email, so
have attached it here.
Thanks,
Aastha.
- You do not need the changes to
Hi,
I have not done any changes to prom_lex.c. The diff shows something because
of difference in the two git sources downloaded. How do I drop the changes?
Will git diff --check suffice?
Please confirm if I should #define the error messages or not. If yes, will
macro name pattern like
Before I patch again, would like to show you the files. Have added a default
case in the err_code_to_string() function. Also removed the extra err_string
variable I used previously in the function. Each case now directly returns
the appropriate message from the table directly, as no other work is
