Re: [PATCH v3 0/2] Fix scsi device's iodone_cnt mismatch with iorequest_cnt

2022-11-30 Thread Martin K. Petersen
On Wed, 23 Nov 2022 20:21:35 +0800, Wenchao Hao wrote: > Following scenario would make scsi_device's iodone_cnt mismatch with > iorequest_cnt even if there is no request on this device any more. > > 1. request timeout happened. If we do not retry the timeouted command, >this command would be

Re: [PATCH] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param

2022-11-30 Thread Martin K. Petersen
On Tue, 22 Nov 2022 18:11:05 +, Wenchao Hao wrote: > There are two iscsi_set_param() functions individually defined > in libiscsi.c and scsi_transport_iscsi.c which is confused. > > So rename the one in scsi_transport_iscsi.c to iscsi_if_set_param(). > > Applied to 6.2/scsi-queue, thanks!

Re: [PATCH] scsi:iscsi: Record session's startup mode in kernel

2022-11-30 Thread Mike Christie
On 11/30/22 5:05 PM, Lee Duncan wrote: > On 11/30/22 12:08, Mike Christie wrote: >> On 11/30/22 1:53 PM, Lee Duncan wrote: >>> Have you already worked on the open-iscsi side of this? No reason for >>> duplicate development. >> >> I think you missed his reply where he said he was missed the >>

Re: [PATCH] scsi:iscsi: Record session's startup mode in kernel

2022-11-30 Thread 'Lee Duncan' via open-iscsi
On 11/30/22 12:08, Mike Christie wrote: On 11/30/22 1:53 PM, Lee Duncan wrote: Have you already worked on the open-iscsi side of this? No reason for duplicate development. I think you missed his reply where he said he was missed the iscsid.safe_logout setting. No, I saw that, but I

Re: [PATCH] scsi:iscsi: Record session's startup mode in kernel

2022-11-30 Thread Mike Christie
On 11/30/22 1:53 PM, Lee Duncan wrote: > Have you already worked on the open-iscsi side of this? No reason for > duplicate development. I think you missed his reply where he said he was missed the iscsid.safe_logout setting. -- You received this message because you are subscribed to the

Re: [PATCH] scsi:iscsi: Record session's startup mode in kernel

2022-11-30 Thread 'Lee Duncan' via open-iscsi
[A much-reduced CC list, since my reply doesn't need wide distribution.] On 11/23/22 09:27, Wenchao Hao wrote: On Thu, Nov 24, 2022 at 12:51 AM Lee Duncan wrote: On 11/22/22 20:41, Wenchao Hao wrote: On 2022/11/23 4:00, Lee Duncan wrote: On 11/22/22 13:30, Wenchao Hao wrote: There are 3