Re: RFC: do we need a new list for kernel patches

2009-06-11 Thread Hans de Goede
On 06/11/2009 07:41 PM, Mike Christie wrote: Hey, It seems like we have a lot of members on the list that are not kernel developers, but we now have 5 iscsi drivers (qla4xxx, bnx2i, cxgb3i, iscsi_tcp and ib_iser) with another being written. So it seems like we are going to have lots of

Re: [PATCH 3/4] iscsi class, libiscsi: Add net config.

2009-06-08 Thread Hans de Goede
On 06/08/2009 10:24 PM, Mike Christie wrote: Hans de Goede wrote: snip Sorry for jumping in the middle of a thread, I missed the libiscsi in the subject. Can someone please resent me the libiscsi part of this patchset so that I can review it ? (I'm the libiscsi author

Re: LPGL status of libiscsi

2009-06-01 Thread Hans de Goede
On 06/01/2009 04:19 AM, Mike Christie wrote: Echo Six wrote: What is the current status of libiscsi? Will it ever be released LGPL? I have not merged it because I think it needs iface support. Or if not iface support, then some way for it to be used with bnx2i and cxgb3i. For the

Re: Issues with intel firmware initiator, ibft and 2-way chap

2009-03-20 Thread Hans de Goede
Konrad Rzeszutek wrote: Sure, if you can tell me how to get the blob? gcc find_ibft.c -o find_ibft sudo ./find_ibft blob Hi All, Sorry for the long delay. Here is a reminder of what this what about, when doing 2 way chap, booting from an intel server nic with ibft, there is no way to

Re: Issues with intel firmware initiator, ibft and 2-way chap

2009-02-03 Thread Hans de Goede
Mike Christie wrote: Konrad Rzeszutek wrote: On Mon, Feb 02, 2009 at 11:39:18AM +0100, Hans de Goede wrote: Hi, When using 2-way chap and booting from an intel network card with intel firmware initiator, their is no way to specify the username in the firmware initiator for the reverse

Re: Issues with intel firmware initiator, ibft and 2-way chap

2009-02-03 Thread Hans de Goede
Konrad Rzeszutek wrote: On Tue, Feb 03, 2009 at 10:30:13AM +0100, Hans de Goede wrote: Mike Christie wrote: Konrad Rzeszutek wrote: On Mon, Feb 02, 2009 at 11:39:18AM +0100, Hans de Goede wrote: Hi, When using 2-way chap and booting from an intel network card with intel firmware

Issues with intel firmware initiator, ibft and 2-way chap

2009-02-02 Thread Hans de Goede
Hi, When using 2-way chap and booting from an intel network card with intel firmware initiator, their is no way to specify the username in the firmware initiator for the reverse chap, nor does it care what username the target provides. However under sysfs (ibft) there is a reverse username

Re: PATCH: do not use exit()

2009-01-29 Thread Hans de Goede
Ulrich Windl wrote: On 28 Jan 2009 at 22:51, Hans de Goede wrote: Hi All, While testing I noticed that idbm_lock() uses exit when it cannot lock, leading to interesting effect when using it from libiscsi, when typing import libiscsi in python as normal user, my entire python

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Hans de Goede
Ulrich Windl wrote: On 28 Jan 2009 at 22:49, Hans de Goede wrote: Hi, While testing I noticed that iscsiadmin -m fw does not work properly on newer (rawhide atleast) kernels, the attached patch (already applied to the Fedora devel packages) fixes this. Hi! I have almost

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Hans de Goede
Bart Van Assche wrote: On Thu, Jan 29, 2009 at 12:34 AM, Mike Christie micha...@cs.wisc.edu wrote: strncat(dev_dir, /, FILENAMESZ); strncat(dev_dir, dent-d_name, FILENAMESZ); I assume the third argument should have been FILENAMESZ -

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Hans de Goede
Ulrich Windl wrote: On 28 Jan 2009 at 17:34, Mike Christie wrote: strncat(dev_dir, dent-d_name, FILENAMESZ); Hi, once again: The third argument of strncpy() counts the bytes to be added, not the bytes that are already there, so the code may not do what some

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Hans de Goede
Mike Christie wrote: Mike Christie wrote: Hans de Goede wrote: Yes it does the same thing, is this from the open-iscsi VCS ? and where do I find that ? Ok, I will merge up your code instead with the fixes in the thread. Thanks! Here is the rediffed patch. I used strncat here

PATCH: fix iBFT firmware reading with newer kernels

2009-01-28 Thread Hans de Goede
Hi, While testing I noticed that iscsiadmin -m fw does not work properly on newer (rawhide atleast) kernels, the attached patch (already applied to the Fedora devel packages) fixes this. Regards, Hans --~--~-~--~~~---~--~~ You received this message because you

PATCH: do not use exit()

2009-01-28 Thread Hans de Goede
Hi All, While testing I noticed that idbm_lock() uses exit when it cannot lock, leading to interesting effect when using it from libiscsi, when typing import libiscsi in python as normal user, my entire python interpreter exited, not good. The attached patch instead returns an error code, and

Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-21 Thread Hans de Goede
Hans de Goede wrote: On Tue, Jan 20, 2009 at 07:58:07PM +0100, Hans de Goede wrote: Hi, Konrad Rzeszutek wrote: Thanks for the review! I presume you have run this program (and the test-code) through valgrind with no memory leaks? Erm

Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-20 Thread Hans de Goede
Bart Van Assche wrote: On Mon, Jan 19, 2009 at 4:35 PM, Hans de Goede hdego...@redhat.com wrote: - libiscsi_discover_sendtargets - maybe (very maybe) the int port could be dropped and const char *address could be of the form address_or_host[:port

Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-20 Thread Hans de Goede
Hi, Konrad Rzeszutek wrote: Thanks for the review! I presume you have run this program (and the test-code) through valgrind with no memory leaks? Erm, no, has iscsiadm been run through valgrind? If not I'm not going to be running libiscsi through it either (sorry) libiscsi builds on

Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-19 Thread Hans de Goede
Bart Van Assche wrote: On Mon, Jan 19, 2009 at 2:07 PM, Hans de Goede hdego...@redhat.com wrote: Therefore we would like to export (some) of the functionality of iscsiadm as a C-library. Great ! I've got documentation of the proposed API here: http://people.atrpms.net/~hdegoede/html

Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-19 Thread Hans de Goede
Boaz Harrosh wrote: Hans de Goede wrote: Hi All, The API currently offers pretty minimal functionality (just what we need in anaconda) I'm fine with extending this (patches welcome). But currently I would like to focus on the set of functionality as the current API offers and try