> Or, is there other ways to hit this that you are seeing? If there are
> then forget what I wrote in the last mail :)
No, I don't know of another way to hit this organically. With the change
you suggested, if someone sets a scsi device to the "running" state
concurrently with the kernel onlining
On 8/29/22 9:21 PM, michael.chris...@oracle.com wrote:
> On 8/29/22 4:51 PM, Uday Shankar wrote:
>>> So we could just add a CAP_SCSI_EH_TRANSPORT OFFLINE flag to
>>> the iscsi_transport->caps struct. When userspace sees that then
>>> it knows the kernel will now do the right thing.
>>>
>>> The
On 8/29/22 4:51 PM, Uday Shankar wrote:
>> So we could just add a CAP_SCSI_EH_TRANSPORT OFFLINE flag to
>> the iscsi_transport->caps struct. When userspace sees that then
>> it knows the kernel will now do the right thing.
>>
>> The drawback is that we have to patch userspace and then also
>> get
> So we could just add a CAP_SCSI_EH_TRANSPORT OFFLINE flag to
> the iscsi_transport->caps struct. When userspace sees that then
> it knows the kernel will now do the right thing.
>
> The drawback is that we have to patch userspace and then also
> get the the new CAP_SCSI_EH_TRANSPORT_OFFLINE
On 8/29/22 3:00 PM, Uday Shankar wrote:
>> I hit the hang below and it should be fixed in this set:
>>
>>
> I hit the hang below and it should be fixed in this set:
>
> https://lore.kernel.org/all/20211105221048.6541-1-michael.chris...@oracle.com/
I hit the hang I described while running a kernel with your fix in. My
hang does not involve scsi-eh; it happens when a transport error is
detected by the
: remove onlining of devices via sysfs
Bump and CC maintainers.
On Thu, Aug 11, 2022 at 05:40:30PM -0600, Uday Shankar wrote:
> In setup_full_feature_phase, iscsid calls into the kernel via
> start_conn, then sets all the relevant device states to "running" via
> session_online_dev
Bump and CC maintainers.
On Thu, Aug 11, 2022 at 05:40:30PM -0600, Uday Shankar wrote:
> In setup_full_feature_phase, iscsid calls into the kernel via
> start_conn, then sets all the relevant device states to "running" via
> session_online_devs. This second step is redundant since start_conn will
In setup_full_feature_phase, iscsid calls into the kernel via
start_conn, then sets all the relevant device states to "running" via
session_online_devs. This second step is redundant since start_conn will
set the device states to running. Moreover, it can cause tasks to hang
forever: between
