Re: [PATCH] Add fwparam_ibft commandline program

2008-04-10 Thread Hannes Reinecke
Hi Mike, Mike Christie wrote: Hannes Reinecke wrote: For boot from iSCSI we need to the fwparam_ibft program to setup the network correctly. This patch moves the fwparam_ibft files into a library and adds a new program fwparam_ibft to print out the network parameter. Why do you need a

[PATCH] Add fwparam_ibft commandline program

2008-04-09 Thread Hannes Reinecke
For boot from iSCSI we need to the fwparam_ibft program to setup the network correctly. This patch moves the fwparam_ibft files into a library and adds a new program fwparam_ibft to print out the network parameter. Signed-off-by: Hannes Reinecke [EMAIL PROTECTED] --- Makefile

Re: [PATCH] Add fwparam_ibft commandline program

2008-04-09 Thread Konrad Rzeszutek
- for (i = 0; i 8; i++) - snprintf(buf++, size--, %x, lun[i]); Why not just change that to %08x ? Ignore that. I was thinking to take out the loop, but forgot that the lun isn't an ASCIIZ string. --~--~-~--~~~---~--~~ You received this

Re: [PATCH] Add fwparam_ibft commandline program

2008-04-09 Thread Mike Christie
Hannes Reinecke wrote: For boot from iSCSI we need to the fwparam_ibft program to setup the network correctly. This patch moves the fwparam_ibft files into a library and adds a new program fwparam_ibft to print out the network parameter. Why do you need a new program to print out the

Re: [PATCH] Add fwparam_ibft commandline program

2008-04-09 Thread Konrad Rzeszutek
On Wed, Apr 09, 2008 at 04:20:45PM -0500, Mike Christie wrote: Hannes Reinecke wrote: For boot from iSCSI we need to the fwparam_ibft program to setup the network correctly. This patch moves the fwparam_ibft files into a library and adds a new program fwparam_ibft to print out the

Re: [PATCH] Add fwparam_ibft commandline program

2008-04-09 Thread Mike Christie
Mike Christie wrote: Hannes Reinecke wrote: For boot from iSCSI we need to the fwparam_ibft program to setup the network correctly. This patch moves the fwparam_ibft files into a library and adds a new program fwparam_ibft to print out the network parameter. Why do you need a new program