Mike Christie wrote:
>>> Oh yeah, I removed the suspend check in iscsi_sw_tcp_xmit_segment, but
>>> we can still hit the exception in #2. If we hit the sendtmo, then part
>>> of the pdu could be sent. We would then hit another suspend bit check
>>> higher up or if you use that one patch where EAGA
Hannes Reinecke wrote:
> Mike Christie wrote:
>> On 08/07/2009 09:59 PM, Mike Christie wrote:
>>> On 08/07/2009 05:27 AM, Hannes Reinecke wrote:
When checking for the SUSPEND bit we have to make sure
to transfer complete PDUs, otherwise the target will barf.
>>>
>>> What do you mean
Hannes Reinecke wrote:
>> 2. If we get suspended because of a TMF cleanup, then we would hit that,
>> but when the xmit thread resumes conn->task will be this task so we will
>> start it up again.
>> - The exception is here if conn->task is the one we are aborting or
>> is affected by the rese
Mike Christie wrote:
> On 08/07/2009 09:59 PM, Mike Christie wrote:
>> On 08/07/2009 05:27 AM, Hannes Reinecke wrote:
>>> When checking for the SUSPEND bit we have to make sure
>>> to transfer complete PDUs, otherwise the target will barf.
>>>
>>
>>
>> What do you mean it will barf?
>>
>> We norma
Mike Christie wrote:
> On 08/07/2009 05:27 AM, Hannes Reinecke wrote:
>> When checking for the SUSPEND bit we have to make sure
>> to transfer complete PDUs, otherwise the target will barf.
>>
>
>
> What do you mean it will barf?
>
> We normally will eventually send the other part of the PDU. W
On 08/07/2009 09:59 PM, Mike Christie wrote:
> On 08/07/2009 05:27 AM, Hannes Reinecke wrote:
>> When checking for the SUSPEND bit we have to make sure
>> to transfer complete PDUs, otherwise the target will barf.
>>
>
>
> What do you mean it will barf?
>
> We normally will eventually send the oth
On 08/07/2009 05:27 AM, Hannes Reinecke wrote:
> When checking for the SUSPEND bit we have to make sure
> to transfer complete PDUs, otherwise the target will barf.
>
What do you mean it will barf?
We normally will eventually send the other part of the PDU. We have
these cases:
1. If we are
When checking for the SUSPEND bit we have to make sure
to transfer complete PDUs, otherwise the target will barf.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/iscsi_tcp.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi