Re: [PATCH 1/2] iscsi_flash_sysfs: Add flash target mgmt support through sysfs.
-Original Message- From: Mike Christie Reply-To: "open-iscsi@googlegroups.com" Date: Wednesday 7 November 2012 11:39 AM To: Lalit Chandivade Cc: Vikas , "open-iscsi@googlegroups.com" , Ravi Anand , Adheer Chandravanshi Subject: Re: [PATCH 1/2] iscsi_flash_sysfs: Add flash target mgmt support through sysfs. >On 11/04/2012 11:17 PM, Lalit Chandivade wrote: >> Mike, >> >> The related options are clubbed as a bit map, each bit means something >>within an option. >> I am trying to give few examples for each option, >> >> + FLASH_TGT_OPTIONS, >> This is an IPv6 target >> This is a discovery target (send target) >> >> + FLASH_TGT_ISCSI_OPTIONS, >> Data Digest is enabled >> Header Digest is enabled >> >> + FLASH_TGT_TCP_OPTIONS, >> Disable TCP Scale Window >> >> + FLASH_TGT_IP_OPTIONS, >> Disable Fragmentation > >Did I misread the code? The defs for the bits are qla specific right now >right? I am just asking to move the definitions for the bits to the >iscsi_flash_sysfs code, so it is usable and defined for all drivers that >use the interface. It should be such that if we have a qla4xxx target >and a be2iscsi target then writing the same bitmap to the options file >turns/off the same features Mike, We modified code as per you comments to make it more generic. I am sending RFC_V2 of kernel patched in next email. We are still working on iscsiadm code. Thanks, Vikas. This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 1/2] iscsi_flash_sysfs: Add flash target mgmt support through sysfs.
On 11/04/2012 11:17 PM, Lalit Chandivade wrote: > Mike, > > The related options are clubbed as a bit map, each bit means something within > an option. > I am trying to give few examples for each option, > > + FLASH_TGT_OPTIONS, > This is an IPv6 target > This is a discovery target (send target) > > + FLASH_TGT_ISCSI_OPTIONS, > Data Digest is enabled > Header Digest is enabled > > + FLASH_TGT_TCP_OPTIONS, > Disable TCP Scale Window > > + FLASH_TGT_IP_OPTIONS, > Disable Fragmentation Did I misread the code? The defs for the bits are qla specific right now right? I am just asking to move the definitions for the bits to the iscsi_flash_sysfs code, so it is usable and defined for all drivers that use the interface. It should be such that if we have a qla4xxx target and a be2iscsi target then writing the same bitmap to the options file turns/off the same features. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
RE: [PATCH 1/2] iscsi_flash_sysfs: Add flash target mgmt support through sysfs.
Mike,
The related options are clubbed as a bit map, each bit means something within
an option.
I am trying to give few examples for each option,
+ FLASH_TGT_OPTIONS,
This is an IPv6 target
This is a discovery target (send target)
+ FLASH_TGT_ISCSI_OPTIONS,
Data Digest is enabled
Header Digest is enabled
+ FLASH_TGT_TCP_OPTIONS,
Disable TCP Scale Window
+ FLASH_TGT_IP_OPTIONS,
Disable Fragmentation
Yes, this approach can setup a discovery portal, the way you tell the
difference is by looking at the FLASH_TGT_OPTIONS.
Do let us know how to proceed?
Thanks,
Lalit.
> -Original Message-
> From: Mike Christie [mailto:micha...@cs.wisc.edu]
> Sent: Friday, November 02, 2012 5:58 AM
> To: Vikas Chaudhary
> Cc: open-iscsi@googlegroups.com; Lalit Chandivade; Ravi Anand; Adheer
> Chandravanshi
> Subject: Re: [PATCH 1/2] iscsi_flash_sysfs: Add flash target mgmt support
> through sysfs.
>
> On 10/15/2012 07:01 AM, vikas.chaudh...@qlogic.com wrote:
> > +
> > +enum iscsi_flash_tgt_properties_enum {
>
>
> > + FLASH_TGT_OPTIONS,
> > + FLASH_TGT_ISCSI_OPTIONS,
> > + FLASH_TGT_TCP_OPTIONS,
> > + FLASH_TGT_IP_OPTIONS,
>
> What are the options? I saw a ipv6 one. What are the rest? Am I am going to
> say, make them generic? :)
>
> Does this also export/setup discovery portals for send targets discovery?
> How can I tell the difference?
This message and any attached documents contain information from QLogic
Corporation or its wholly-owned subsidiaries that may be confidential. If you
are not the intended recipient, you may not read, copy, distribute, or use this
information. If you have received this transmission in error, please notify the
sender immediately by reply e-mail and then delete this message.
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 1/2] iscsi_flash_sysfs: Add flash target mgmt support through sysfs.
On 11/01/2012 07:27 PM, Mike Christie wrote:
> On 10/15/2012 07:01 AM, vikas.chaudh...@qlogic.com wrote:
>> +
>> +enum iscsi_flash_tgt_properties_enum {
>
>
>> +FLASH_TGT_OPTIONS,
>> +FLASH_TGT_ISCSI_OPTIONS,
>> +FLASH_TGT_TCP_OPTIONS,
>> +FLASH_TGT_IP_OPTIONS,
>
> What are the options? I saw a ipv6 one. What are the rest? Am I am going
> to say, make them generic? :)
>
> Does this also export/setup discovery portals for send targets
> discovery? How can I tell the difference?
>
Could you also make sure the fields in this patch are named the same as
in common iscsi code like libiscsi and scsi_transport_iscsi? The
segments one stood out. I did not check every one.
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 1/2] iscsi_flash_sysfs: Add flash target mgmt support through sysfs.
On 10/15/2012 07:01 AM, vikas.chaudh...@qlogic.com wrote:
> +
> +enum iscsi_flash_tgt_properties_enum {
> + FLASH_TGT_OPTIONS,
> + FLASH_TGT_ISCSI_OPTIONS,
> + FLASH_TGT_TCP_OPTIONS,
> + FLASH_TGT_IP_OPTIONS,
What are the options? I saw a ipv6 one. What are the rest? Am I am going
to say, make them generic? :)
Does this also export/setup discovery portals for send targets
discovery? How can I tell the difference?
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
