Re: [PATCH] Add logging to scsi_transport_iscsi.c

2009-07-30 Thread Mike Christie
Erez Zilber wrote: > On Thu, Jul 30, 2009 at 6:37 AM, Mike Christie wrote: >> On 07/26/2009 08:48 AM, Erez Zilber wrote: >>> I've attached a new version. I hope it's better. Whenever possible, >>> there's a dbg statement before& after. For example, if we free the >>> conn object, I can't put a db

Re: [PATCH] Add logging to scsi_transport_iscsi.c

2009-07-30 Thread Erez Zilber
On Thu, Jul 30, 2009 at 6:37 AM, Mike Christie wrote: > On 07/26/2009 08:48 AM, Erez Zilber wrote: >> I've attached a new version. I hope it's better. Whenever possible, >> there's a dbg statement before&  after. For example, if we free the >> conn object, I can't put a dbg call after it (because

Re: [PATCH] Add logging to scsi_transport_iscsi.c

2009-07-29 Thread Mike Christie
On 07/26/2009 08:48 AM, Erez Zilber wrote: > I've attached a new version. I hope it's better. Whenever possible, > there's a dbg statement before& after. For example, if we free the > conn object, I can't put a dbg call after it (because conn is already > NULL). If you still see specific things th

Re: [PATCH] Add logging to scsi_transport_iscsi.c

2009-07-24 Thread Mike Christie
On 07/22/2009 09:01 AM, Erez Zilber wrote: > Logging for connections and sessions in the scsi_transport_iscsi module > is now controlled by module parameters. > > Signed-off-by: Erez Zilber > Thanks! Looks good. Just one comment. Sometimes there is a dbg statement after we do something that can