RE: iSCSI Connection failure with bnx2i transport

2009-10-12 Thread Narendra_K
Hello, >-Original Message- >From: Ulrich Windl [mailto:ulrich.wi...@rz.uni-regensburg.de] >Sent: Monday, October 12, 2009 4:23 PM >To: open-iscsi@googlegroups.com >Cc: Chenault, Thomas; K, Narendra >Subject: Re: iSCSI Connection failure with bnx2i transport > &g

Re: iSCSI Connection failure with bnx2i transport

2009-10-12 Thread Ulrich Windl
On 29 Sep 2009 at 9:56, Benjamin Li wrote: > > - memcpy(path_rsp->mac_addr, mac_addr, sizeof(mac_addr)); > > + memcpy(path_rsp->mac_addr, mac_addr, 6); Using unnamed constants looks like poor programming style. Isn't there a symbolic name for that? Would sizeof(path_rsp->mac_addr) work? R

Re: iSCSI Connection failure with bnx2i transport

2009-09-29 Thread Benjamin Li
Thanks for catching this bug Thomas and testing this bug Narendra. The patch looks good. Reviewed-by: Benjamin Li On Tue, 2009-09-29 at 09:03 -0700, shyam_i...@dell.com wrote: > 1. Install Red Hat Enterprise Linux 5.4 snapshot 5 i386 on a server with > Broadcom iSCSI offload capable LOMs. >