Re: [Openais] [PATCH] Allow nss building conditionally with rpmbuild operation

On Fri, Sep 02, 2011 at 09:56:14AM -0700, Steven Dake wrote: Signed-off-by: Steven Dake sd...@redhat.com ACK --- corosync.spec.in |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/corosync.spec.in b/corosync.spec.in index 74ab851..5c651aa 100644 ---

Re: [Openais] Corosync 2.0 Feature Request: Replace objdb/confdb with something easier to use

On Thu, Aug 25, 2011 at 05:16:20AM +0200, Fabio M. Di Nitto wrote: On 08/25/2011 04:56 AM, Angus Salkeld wrote: Possible Solutions == 1] API We really just want to get/set values do we really need a tree? as you already mentioned before, tree make it easy to load

Re: [Openais] [PATCH] Remove hdb.h header includes from unnecessary files

On Tue, Aug 23, 2011 at 01:03:48PM -0700, Steven Dake wrote: The files in this patch do not use the hdb.h header. ACK Signed-off-by: Steven Dake sd...@redhat.com --- exec/totemrrp.c |1 - exec/totemsrp.c |1 - exec/totemudp.c |1 - exec/totemudp.h |1 -

Re: [Openais] [PATCH] Get rid of hdb usage in totempg.h interface

On Tue, Aug 23, 2011 at 02:13:07PM -0700, Steven Dake wrote: hdb has some expense and is not necessary in the totempg.so runtime. This patch removes the dependence on hdb and instead uses a direct pointer. ACK Signed-off-by: Steven Dake sd...@redhat.com --- exec/main.c

Re: [Openais] [PATCH] use va version of external log function

On Mon, Aug 22, 2011 at 12:47:05PM -0700, Steven Dake wrote: This removes a sprintf operation in the totem and ipc logging operations ACK, will now need the latest libqb (else you can put a configure check for that function). -A Signed-off-by: Steven Dake sd...@redhat.com --- exec/main.c

Re: [Openais] [PATCH] Move cs_queue.h from include directory to exec directory

On Mon, Aug 22, 2011 at 12:53:41PM -0700, Steven Dake wrote: This file is only used by totemsrp.c. Move out of general include directory. ACK -A Signed-off-by: Steven Dake sd...@redhat.com --- exec/Makefile.am|2 +- exec/cs_queue.h | 229

Re: [Openais] [PATCH] Add totempg_threaded_mode_enable() api

On Mon, Aug 22, 2011 at 03:30:49PM -0700, Steven Dake wrote: This API allows totem to operate as a multithreaded library. Performance is better without threads but some library users may only have multithreaded systems. In the corosync case where we have removed threads, this reduces cpu

Re: [Openais] [PATCH] Use qb_hdb instead of mutex based hdb code

On Mon, Aug 22, 2011 at 08:08:09PM -0700, Steven Dake wrote: Rid ourselves of the mutex usage still in the code base ACK -Angus Signed-off-by: Steven Dake sd...@redhat.com --- include/corosync/hdb.h | 307 +++- lcr/Makefile.am|3

Re: [Openais] [PATCH] Add code comment mapping message handler defines

On Wed, Aug 17, 2011 at 12:47:49PM +1200, Tim Beale wrote: As a corosync-newbie it can be hard to bridge the gap between where a particular message is sent and where the receive handler processes it, and vice versa. --- Thanks Tim, Applied. -Angus exec/totemsrp.c | 16 ++--

Re: [Openais] CPG client can lockup if the local node is in the downlist

On Wed, Aug 17, 2011 at 01:19:53PM +1200, Tim Beale wrote: Hi, I'm resending this patch in a separate thread because I think this part of the cluster formation problems I'm seeing has been overlooked. The patch attached is one way of addressing the problem, but I'm open to alternatives.

Re: [Openais] [PATCH] Allow compile master on RHEL 6

On Tue, Aug 09, 2011 at 09:23:50AM +0200, Jan Friesse wrote: corosync_timer_handle_t is know conditionally defined to prevent double definition causing compile fault on RHEL 6 systems. Reviewed-by: Angus Salkeld asalk...@redhat.com Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec

Re: [Openais] [PATCH 1/4] Fix problem in totemiba where incorrect define is used (and also not defined)

On Tue, Aug 09, 2011 at 02:55:03PM -0700, Steven Dake wrote: Signed-off-by: Steven Dake sd...@redhat.com Reviewed-by: Angus Salkeld asalk...@redhat.com --- exec/totemiba.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/exec/totemiba.c b/exec/totemiba.c index

Re: [Openais] [PATCH 2/4] Define totemiba_log_printf properly

On Tue, Aug 09, 2011 at 02:55:04PM -0700, Steven Dake wrote: Signed-off-by: Steven Dake sd...@redhat.com Reviewed-by: Angus Salkeld asalk...@redhat.com --- exec/totemiba.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/exec/totemiba.c b/exec/totemiba.c

Re: [Openais] [PATCH 3/4] properly define rec_token_cq_send_event_fn

On Tue, Aug 09, 2011 at 02:55:05PM -0700, Steven Dake wrote: Signed-off-by: Steven Dake sd...@redhat.com Reviewed-by: Angus Salkeld asalk...@redhat.com --- exec/totemiba.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/exec/totemiba.c b/exec/totemiba.c index

Re: [Openais] [PATCH 4/4] Remove -lcoroipcc from tools/Makefile.am notifyd

On Tue, Aug 09, 2011 at 02:55:06PM -0700, Steven Dake wrote: Signed-off-by: Steven Dake sd...@redhat.com Reviewed-by: Angus Salkeld asalk...@redhat.com --- tools/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am

[Openais] [PATCH] Add systemd unit files for corosync and corosync-notifyd

Signed-off-by: Angus Salkeld asalk...@redhat.com --- configure.ac |8 corosync.spec.in | 12 init/.gitignore |2 ++ init/Makefile.am | 15 +++ init/corosync-notifyd.service.in | 11

Re: [Openais] what's the usage/function of /etc/corosync/uidgid.d and service.d

On Tue, Aug 02, 2011 at 03:36:39PM +0800, Yingliang Yang wrote: Hi, In the directory /etc/corosync, there are 2 sub-directory called 'uidgid.d' and 'service.d', I'd like to know their usage and functions, would anyone please help to answer that? thank you very much! It is so other

Re: [Openais] Corosync 2.0 Feature Request: merge libqb patch series

On Mon, Aug 08, 2011 at 12:00:47PM +1000, Angus Salkeld wrote: Hi All the topic-libqb patches are Ack'ed. Now they need merging into master. All good to go? Steve ACK'ed on IRC... All pushed to master. -Angus Regards Angus Salkeld

[Openais] [PATCH] Make realtime scheduling optional not the default.

Signed-off-by: Angus Salkeld asalk...@redhat.com --- configure.ac |6 ++ exec/main.c| 21 +++-- man/corosync.8 |7 +-- 3 files changed, 26 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 35e3cfb..e00edeb 100644

[Openais] Corosync 2.0 Feature Request: merge libqb patch series

Hi All the topic-libqb patches are Ack'ed. Now they need merging into master. All good to go? Regards Angus Salkeld ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais

[Openais] [PATCH 6/6] Update TODOs

Signed-off-by: Angus Salkeld asalk...@redhat.com --- TODO | 73 + 1 files changed, 19 insertions(+), 54 deletions(-) diff --git a/TODO b/TODO index 9a2db8f..fa30e36 100644 --- a/TODO +++ b/TODO @@ -3,69 +3,34 @@ The Corosync

[Openais] [PATCH 2/6] Use PATH_MAX for file path size

Signed-off-by: Angus Salkeld asalk...@redhat.com --- lib/cpg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/cpg.c b/lib/cpg.c index caf3efe..71704c0 100644 --- a/lib/cpg.c +++ b/lib/cpg.c @@ -777,7 +777,7 @@ cs_error_t cpg_zcb_alloc ( void **buffer

[Openais] [PATCH 3/6] Fix some compiler warnings

Signed-off-by: Angus Salkeld asalk...@redhat.com --- configure.ac |4 +- exec/crypto.c |2 - exec/main.c |3 -- exec/objdb.c | 76 lib/confdb.c |3 ++ services/confdb.c |7 +++- services/cpg.c

Re: [Openais] [PATCH] Fix usage of strerror_r on GNU systems

On Mon, Jun 27, 2011 at 03:34:56PM +1000, Angus Salkeld wrote: Wouldn't it be cleaner if we put this macro in logsys.h: #define log_perror(err_num, level, format, args...) do { \ ... #endif Then use it like a normal log function: log_perror(errno, LOG_ERR, bad stuff); It then logs

Re: [Openais] [PATCH] Fix usage of strerror_r()/perror()

(), ENTER(), LEAVE(), etc) while only some are in lower case (log_printf(), log_rec()). Well I suppose that's OK then - good work. Reviewed-by: Angus Salkeld asalk...@redhat.com On 27.06.2011 13:17, Angus Salkeld wrote: Cool, much better. Any reason for the capitals? Not a big deal but the other

Re: [Openais] [PATCH] Fix usage of strerror_r on GNU systems

Wouldn't it be cleaner if we put this macro in logsys.h: #define log_perror(err_num, level, format, args...) do { \ ... #endif Then use it like a normal log function: log_perror(errno, LOG_ERR, bad stuff); It then logs: ERR bad stuff : error string -Angus On Fri, Jun 24, 2011 at 03:17:50PM

Re: [Openais] [PATCH 2/3] coroipcc: check recvmsg result in socket_recv

, I don't why left Linux out. Reviewed-by: Angus Salkeld asalk...@redhat.com Signed-off-by: Jan Friesse jfrie...@redhat.com --- lib/coroipcc.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/coroipcc.c b/lib/coroipcc.c index b017155..d1f82e0 100644

Re: [Openais] [PATCH 1/3] confdb: Properly check result of object_find_create

. Reviewed-by: Angus Salkeld asalk...@redhat.com Signed-off-by: Jan Friesse jfrie...@redhat.com --- services/confdb.c | 29 + 1 files changed, 21 insertions(+), 8 deletions(-) diff --git a/services/confdb.c b/services/confdb.c index b57a041..64def8a 100644

Re: [Openais] [Pacemaker] Linux HA on debian sparc

On Tue, May 31, 2011 at 06:25:56PM -0300, william felipe_welter wrote: Thanks Steven, Now im try to run on the MCP: - Uninstall the pacemaker 1.0 - Compile and install 1.1 But now i have problems to initialize the pacemakerd: Could not initialize Cluster Configuration Database API

Re: [Openais] [Pacemaker] Linux HA on debian sparc

of memory it is taken care of the the third mmap which maps the address back to the top of the file for you. This means you don't have to worry about ringbuffer wrapping which can be a headache. -Angus 2011/5/31 Angus Salkeld asalk...@redhat.com On Tue, May 31, 2011 at 06:25:56PM -0300

Re: [Openais] [PATCH] Add coverity target to corosync makefile.am

On Thu, May 19, 2011 at 07:54:20PM -0700, Steven Dake wrote: Allow a make coverity target for those developers with coverity tools available to them. Gasp, no configure check for coverity? -Angus Signed-off-by: Steven Dake sd...@redhat.com --- Makefile.am |5 + 1 files changed,

Re: [Openais] [PATCH 1/2] Store cpg process information in objdb

Hi Just one comments inline. -Angus On Wed, May 11, 2011 at 05:35:44PM +0200, Jan Friesse wrote: Information about processes using cpg are now stored in objdb. Each process info is object stored in cpg object, with nodeid, pid and group name keys. --- services/cpg.c | 124

Re: [Openais] [PATCH] totemsrp: Enhance mcast failure detection

Looks good. Reviewed-by: Angus Salkeld asalk...@redhat.com On Wed, May 04, 2011 at 05:27:11PM +0200, Jan Friesse wrote: memb_state_gather_enter increase stats.continuous_gather only if previous state was gather also. This should happen only if multicast is not working properly (local firewall

[Openais] [PATCH 07/10] CTS: fix syntax error in log message

Signed-off-by: Angus Salkeld asalk...@redhat.com --- cts/corotests.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cts/corotests.py b/cts/corotests.py index ede2a5d..8175042 100644 --- a/cts/corotests.py +++ b/cts/corotests.py @@ -907,7 +907,7 @@ class

[Openais] [PATCH 04/10] autobuild: improve messages

Signed-off-by: Angus Salkeld asalk...@redhat.com --- autobuild.sh | 37 +++-- 1 files changed, 19 insertions(+), 18 deletions(-) diff --git a/autobuild.sh b/autobuild.sh index 17e1a37..01ecf9c 100755 --- a/autobuild.sh +++ b/autobuild.sh @@ -1,6 +1,6 @@ #!/bin

[Openais] [PATCH 02/10] CTS: send with correct number of iovecs

Else payload won't be sent Signed-off-by: Angus Salkeld asalk...@redhat.com --- cts/agents/cpg_test_agent.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cts/agents/cpg_test_agent.c b/cts/agents/cpg_test_agent.c index e668737..86191cb 100644 --- a/cts/agents

[Openais] [PATCH 10/10] cpg: fix sync master selection when one node paused.

) largest (previous #nodes - #nodes know to have left) 2) (then as a tie-breaker) node with smallest nodeid Signed-off-by: Angus Salkeld asalk...@redhat.com --- services/cpg.c | 23 ++- 1 files changed, 18 insertions(+), 5 deletions(-) diff --git a/services/cpg.c b/services

[Openais] [PATCH 08/10] CTS: sort the configuration - prevent duplicates in the config file

Signed-off-by: Angus Salkeld asalk...@redhat.com --- cts/corosync.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/cts/corosync.py b/cts/corosync.py index 0fce75e..bcaa796 100644 --- a/cts/corosync.py +++ b/cts/corosync.py @@ -180,7 +180,8 @@ class corosync_flatiron

[Openais] [PATCH 01/10] CTS: timer should not be on the stack

Signed-off-by: Angus Salkeld asalk...@redhat.com --- cts/agents/cpg_test_agent.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cts/agents/cpg_test_agent.c b/cts/agents/cpg_test_agent.c index a0af9c1..e668737 100644 --- a/cts/agents/cpg_test_agent.c +++ b/cts/agents

[Openais] [PATCH 06/10] CTS: bump up log messages of failed RPC

Signed-off-by: Angus Salkeld asalk...@redhat.com --- cts/corosync.py | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/cts/corosync.py b/cts/corosync.py index 70dff3c..0fce75e 100644 --- a/cts/corosync.py +++ b/cts/corosync.py @@ -425,8 +425,10 @@ class TestAgent

[Openais] [PATCH 05/10] CTS: don't force all-once (breaks random tests)

Signed-off-by: Angus Salkeld asalk...@redhat.com --- cts/corolab.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cts/corolab.py b/cts/corolab.py index 340c751..3541f47 100755 --- a/cts/corolab.py +++ b/cts/corolab.py @@ -133,7 +133,7 @@ class CoroLabEnvironment(CtsLab

Re: [Openais] [PATCH 2/2] Align ipc on 8 byte boundaries

Reviewed-by: Angus Salkeld asalk...@redaht.com On Mon, Jan 03, 2011 at 04:40:55PM -0700, Steven Dake wrote: Align all ipc messages on 8 byte boundaries. This alignment will remove bus errors on systems that can't access non-byte aligned data and should improve performance. Signed-off

Re: [Openais] [PATCH 1/2] Fix problem where unaligned totemip address access would result in bus error on non-unaligned-safe architectures.

Missed this: Reviewed-by: Angus Salkeld asalk...@redhat.com On Mon, Jan 03, 2011 at 04:40:54PM -0700, Steven Dake wrote: Signed-off-by: Steven Dake sd...@redhat.com --- exec/totemip.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/exec/totemip.c b/exec

[Openais] [PATCH] IPC: place calls to stats functions outside of mutexes

This is to prevent nasty deadlocks between IPC and objdb. Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/coroipcs.c | 55 --- 1 files changed, 36 insertions(+), 19 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index

Re: [Openais] [PATCH 1/1] whitetank: Return error if there is no space for semaphore

On Thu, Mar 17, 2011 at 05:56:46PM +0100, Jan Friesse wrote: open_ais_service_connect creates SYS V semaphores and shms. If system limit for semaphores/shms is exceeded code looped in endless cycle. Reviewed-by: Angus Salkeld asalk...@redhat.com Now ENOSPC is correctly handled

[Openais] [openais-whitetank PATCH 2/2] IPC: if shmget() or semget() return ENOSPC then exit the while loop.

I noticed this while testing the high FD usage patch. It can get stuck in the while loop. Signed-off-by: Angus Salkeld asalk...@redhat.com --- lib/util.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/util.c b/lib/util.c index f285eb5..76b3891 100644 --- a/lib

[Openais] [openais-whitetank PATCH 1/2] IPC: handle maximum use of file descriptors gracefully.

If we get EMFILE from accept() then withdraw the published server listening socket. Then when a connection closes see if we need to re-publish the server sockect. Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/ipc.c | 161 +-- 1

[Openais] [PATCH 1/3] NOTIFYD: fix retrieving the application's parent name.

Signed-off-by: Angus Salkeld asalk...@redhat.com --- tools/corosync-notifyd.c | 14 +++--- 1 files changed, 3 insertions(+), 11 deletions(-) diff --git a/tools/corosync-notifyd.c b/tools/corosync-notifyd.c index 7af573c..4a58189 100644 --- a/tools/corosync-notifyd.c +++ b/tools

[Openais] [PATCH 3/3] STATS: add the service name to the connection name.

of the dbus/snmp events what is going on. Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/coroipcs.c | 106 +++ 1 files changed, 99 insertions(+), 7 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index b64c5a9..bfb638b 100644

[Openais] [PATCH 2/3] NOTIFYD: prevent duplicate quorate events.

Signed-off-by: Angus Salkeld asalk...@redhat.com --- tools/corosync-notifyd.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/tools/corosync-notifyd.c b/tools/corosync-notifyd.c index 4a58189..7f231fa 100644 --- a/tools/corosync-notifyd.c +++ b/tools/corosync

[Openais] [PATCH] STATS: add the service name to the connection name.

of the dbus/snmp events what is going on. Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/coroipcs.c | 26 +++--- exec/util.c | 47 +++ exec/util.h |6 ++ 3 files changed, 72 insertions(+), 7 deletions(-) diff

[Openais] [PATCH] Fix shutdown when a confdb client is still connected

() before the object gets destroyed. Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/coroipcs.c |2 +- services/confdb.c |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index 29655ba..dbafb18 100644 --- a/exec

Re: [Openais] coroipcc_dispatch_get return values

On Mon, Mar 21, 2011 at 06:46:03PM +0530, Ramesh Random wrote: Hi, i am using coroipcc_dispatch_get() to read the asynchronous buffer response. i am not able to differentiate between return values for it CS_ERR_TRY_AGAIN and CS_OK. i tried to look into source code of

[Openais] [PATCH] notifyd: dispatch only one message at a time.

This is avoid getting stuck in the dispatch processing messages when the user is trying to shutdown the service. Signed-off-by: Angus Salkeld asalk...@redhat.com --- tools/corosync-notifyd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/corosync-notifyd.c b

Re: [Openais] [PATCH 1/3] Fix the ttl defaults and range

On Tue, Mar 15, 2011 at 08:30:10AM +0100, Fabio M. Di Nitto wrote: Patch 1 and 2 ACK. I´ll leave 3 to Steven, but it looks good. applied + pushed. -Angus Fabio ___ Openais mailing list Openais@lists.linux-foundation.org

[Openais] [PATCH 1/3] Fix the ttl defaults and range

1) both IPv4 and IPv6 mcast should default to ttl=1 2) the range should be 0..255 0 is valid meaning localhost only (cluster of one) Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/totemconfig.c | 10 +++--- man/corosync.conf.5 |2 +- 2 files changed, 4 insertions(+), 8

[Openais] [PATCH 2/3] Remove the ttl option from udpu and rely on the kernel ttl setting.

Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/totemconfig.c |5 + exec/totemudpu.c| 21 - man/corosync.conf.5 |1 + 3 files changed, 6 insertions(+), 21 deletions(-) diff --git a/exec/totemconfig.c b/exec/totemconfig.c index 7039ba0..0b9732b

[Openais] [PATCH 3/3] Fix some set but not used warnings [-Wunused-but-set-variable]

Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/logsys.c |5 + exec/main.c|3 --- exec/syncv2.c |9 +++-- exec/totemconfig.c |2 +- exec/totempg.c |3 +-- exec/totemsrp.c| 15 --- exec/totemudp.c

Re: [Openais] [PATCH] Add Doxyfile to .gitignore

g, ya I forgot that bit. Applied. -Angus On Sat, Mar 12, 2011 at 06:37:53AM -0600, Russell Bryant wrote: Signed-off-by: Russell Bryant russ...@russellbryant.net --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index

Re: [Openais] [PATCH 3/3] Fix some set but not used warnings [-Wunused-but-set-variable]

On Mon, Mar 14, 2011 at 08:57:06PM -0500, Russell Bryant wrote: On Mon, Mar 14, 2011 at 6:44 PM, Angus Salkeld asalk...@redhat.com wrote: -       res = totempg_groups_mcast_joined (sync_group_handle, +       (void)totempg_groups_mcast_joined (sync_group_handle,                iovec, 1

Re: [Openais] [PATCH] Convert existing documentation to doxygen format.

content. Reviewed-by: Angus Salkeld asalk...@redhat.com Nice work, applied. Signed-off-by: Russell Bryant russ...@russellbryant.net --- exec/main.h | 10 ++- exec/mainconfig.h|4 +- exec/service.h | 13 ++- exec/tlist.h

Re: [Openais] [PATCH] Convert existing documentation to doxygen format.

On Tue, Mar 08, 2011 at 05:00:34PM -0600, Russell Bryant wrote: On Tue, Mar 8, 2011 at 2:06 PM, Steven Dake sd...@redhat.com wrote: A developer internals guidebook would be immensely helpful - as long as it can be segregated from the external consumable APIs in the documentation. I

Re: [Openais] [PATCH] Fix abort when token is lost in RECOVERY state

old_ring_state_saved; exec/totemsrp.c:instance-old_ring_state_saved = 1; exec/totemsrp.c:instance-old_ring_state_saved = 0; Reviewed-by: Angus Salkeld asalk...@redhat.com Signed-off-by: Steven Dake sd...@redhat.com --- exec/totemsrp.c | 59

Re: [Openais] [PATCH] Convert existing documentation to doxygen format.

Hi Russell Some gneral comments: 1) I don't think you need all those \brief keywords. I think they look quite ugly in the code. Below works fine for me and is cleaner. /** * this is always a brief * * leave a line and this is the vebose description. */ 2) I think there little point

Re: [Openais] [PATCH] Don't assert when ring id file is less then 8 bytes

fresh ring id file data when the incorrect number of bytes are read from the ring id. Amend to use sizeof the strerror string length and PATH_MAX for the path length. Signed-off-by: Steven Dake sd...@redhat.com Reviewed-by: Angus Salkeld asalk...@redhat.com I hope the change from: read (fd

Re: [Openais] [Corosync] Automate corosync-generate

know ... I want automate the creation of the authkeys file. That might be problematic, corosync-keygen requires you to type on the keyboard - try it by it's self. Thanks Camille 2011/2/20 Angus Salkeld asalk...@redhat.com On Thu, Feb 17, 2011 at 02:14:07PM +0100, Camille Néron wrote

Re: [Openais] [PATCH] Add -l option to corosync-keygen.

On Sun, Feb 20, 2011 at 07:48:59PM -0600, Russell Bryant wrote: Add -l option to corosync-keygen. You should also update the man page: man/corosync-keygen.8 -Angus This option (-l or --less-secure) causes corosync-keygen to read from /dev/urandom instead of /dev/random to ensure that no

Re: [Openais] [Corosync] Automate corosync-generate

On Thu, Feb 17, 2011 at 02:14:07PM +0100, Camille Néron wrote: Hello, I'm French user, so sorry for my English :-). I need to automate the installation and configuration of Pacemaker and I encounter a problem when I want script corosync-generate. This command need I tape on my keyboard.

Re: [Openais] Corosync compile fail in Ubuntu Server

On Sun, Feb 20, 2011 at 12:45:32AM +0100, Alessio Gennari wrote: Hello to everyone, I'm tryingo to compile Corosync 1.3.0 in a Ubuntu Server 10.10 64bit system: after autogen.sh when I run configure, I receive a syntax error at row with PKG_CHECK_MODULE(nss,nss). I have heard of this before -

Re: [Openais] error with master master drbd config

On Sun, Feb 20, 2011 at 12:52:32AM +0100, Thomas Elsäßer wrote: hi all, I suggest you try the pacemaker mailing list :pacema...@oss.clusterlabs.org. -Angus i have a problem wtih my cluster. I have a resource with drbd master master here my config: the homeFS is not running (with ocfs2)

[Openais] [PATCH] autobuild: clean the build dir first.

This deletes files like .version that cause problems. Signed-off-by: Angus Salkeld asalk...@redhat.com --- autobuild.sh |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/autobuild.sh b/autobuild.sh index df429ef..17e1a37 100755 --- a/autobuild.sh +++ b/autobuild.sh

[Openais] [PATCH] CTS: temp remove troublesome tests.

as a manual ssh works fine. Basically I think it's more important the we get reliable testing than have these test in there. Signed-off-by: Angus Salkeld asalk...@redhat.com --- cts/corotests.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cts/corotests.py b/cts

Re: [Openais] [PATCH] Make node state a string (not an integer)

Salkeld wrote: Ryan noticed this inconsistency, all other status's are string so this should be too. Signed-off-by: Angus Salkeld asalk...@redhat.com --- conf/COROSYNC-MIB.txt|6 +- tools/corosync-notifyd.c | 11 +-- 2 files changed, 2 insertions(+), 15 deletions

[Openais] [PATCH] Fix merge markers in spec file

Signed-off-by: Angus Salkeld asalk...@redhat.com --- corosync.spec.in |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/corosync.spec.in b/corosync.spec.in index 1eb07f0..ba54123 100644 --- a/corosync.spec.in +++ b/corosync.spec.in @@ -2,8 +2,6 @@ %global numcomm

[Openais] [PATCH] Make node state a string (not an integer)

Ryan noticed this inconsistency, all other status's are string so this should be too. Signed-off-by: Angus Salkeld asalk...@redhat.com --- conf/COROSYNC-MIB.txt|6 +- tools/corosync-notifyd.c | 11 +-- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/conf

Re: [Openais] [PATCH 1/5] Add dbus and snmp notifier

On Tue, Feb 01, 2011 at 07:14:22AM -0600, Russell Bryant wrote: +int +main(int argc, char *argv[]) +{ +       int ch; + +       conf[CS_NTF_FG] = 0; +       conf[CS_NTF_LOG] = 0; +       conf[CS_NTF_STDOUT] = 0; +       conf[CS_NTF_SNMP] = 0; +       conf[CS_NTF_DBUS] = 0; +

Re: [Openais] [PATCH 2/5] Fix plugin logic and SNMP/DBUS logic

On Tue, Feb 01, 2011 at 08:51:43AM -0700, Steven Dake wrote: Can you amend your first patch with this change? Well, it's Lon's patch. If he doesn't mind sure. -Angus Regards -steve On 01/31/2011 08:16 PM, Angus Salkeld wrote: From: Lon Hohberger l...@redhat.com Signed-off-by: Lon

[Openais] [PATCH] MIB: expand the descriptions of the notifications

Signed-off-by: Angus Salkeld asalk...@redhat.com --- conf/COROSYNC-MIB.txt | 20 +--- 1 files changed, 17 insertions(+), 3 deletions(-) diff --git a/conf/COROSYNC-MIB.txt b/conf/COROSYNC-MIB.txt index c8a257a..b62ffa3 100644 --- a/conf/COROSYNC-MIB.txt +++ b/conf/COROSYNC

[Openais] topic-snmp patch series

This is a first cut of the snmp series. Thanks to Lon for his mib work! Reviewers please look at: 1) the init script (order requires). 2) There is a man page. Some of the TODO section could be put into it. Can you check the arguments -f -d -s -l -o -m to make sure they don't clash with

[Openais] [PATCH 2/5] Fix plugin logic and SNMP/DBUS logic

From: Lon Hohberger l...@redhat.com Signed-off-by: Lon Hohberger l...@redhat.com Signed-off-by: Angus Salkeld asalk...@redhat.com --- tools/corosync-notifyd.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tools/corosync-notifyd.c b/tools/corosync-notifyd.c

[Openais] [PATCH 4/5] Match up MIB to notifyd add SNMP quorum events

From: Lon Hohberger l...@redhat.com Signed-off-by: Lon Hohberger l...@redhat.com Reviewed-by: Angus Salkeld asalk...@redhat.com --- tools/corosync-notifyd.c | 77 ++ 1 files changed, 64 insertions(+), 13 deletions(-) diff --git a/tools/corosync

[Openais] [PATCH 5/5] SPEC: remove duplicate corosync-blackbox

Signed-off-by: Angus Salkeld asalk...@redhat.com --- corosync.spec.in |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/corosync.spec.in b/corosync.spec.in index aec13c6..79d4c28 100644 --- a/corosync.spec.in +++ b/corosync.spec.in @@ -112,7 +112,6 @@ fi %files %defattr

[Openais] [PATCH 3/5] Make SNMP MIB match what is being sent over DBUS

From: Lon Hohberger l...@redhat.com Signed-off-by: Lon Hohberger l...@redhat.com Reviewed-by: Angus Salkeld asalk...@redhat.com --- conf/COROSYNC-MIB.txt | 237 + 1 files changed, 119 insertions(+), 118 deletions(-) diff --git a/conf/COROSYNC

[Openais] [PATCH 1/5] Add dbus and snmp notifier

This is to send dbus events on major cluster events: - membership changes - application connect/dissconnet from corosync - quorum changes dbus events can then be converted into snmp traps by foghorn or corosync-notifyd can be run to directly send snmp traps. Signed-off-by: Angus Salkeld asalk

[Openais] snmp support in corosync

status (just to keep it simple). Feel free to contribute, just note I am going on holiday for 2 weeks and Steven will continue this work. Read the TODO section to see how to run/test and what needs doing. Regards Angus Salkeld Example dbus signals output from dbus-monitor --system signal sender

[Openais] some generic confdb fixes I need for topic-snmp

Hi These are needed for topic-snmp but could be put straight into master. -Angus ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais

[Openais] [PATCH 3/4] CONFDB: fix parent_get response id

Signed-off-by: Angus Salkeld asalk...@redhat.com --- services/confdb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/services/confdb.c b/services/confdb.c index b9de935..78770ed 100644 --- a/services/confdb.c +++ b/services/confdb.c @@ -565,7 +565,7 @@ static void

[Openais] [PATCH 1/4] STATS: increase the space for application names

Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/coroipcs.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index 703802a..1897231 100644 --- a/exec/coroipcs.c +++ b/exec/coroipcs.c @@ -1545,8 +1545,8 @@ static char

Re: [Openais] [PATCH] Handle delayed multicast packets that occur with swithes

and once reaching the const value, marks it as missing in the retransmit list. This improves performance and doesn't display warning messages about missed multicast messages when operating in these switching environments. Reviewed-by: Angus Salkeld asalk...@redhat.com -Angus Signed-off

[Openais] [PATCH 2/4] remove unused function declaration

Signed-off-by: Angus Salkeld asalk...@redhat.com --- tools/corosync-objctl.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/tools/corosync-objctl.c b/tools/corosync-objctl.c index 131bc2b..2332b79 100644 --- a/tools/corosync-objctl.c +++ b/tools/corosync-objctl.c

[Openais] [PATCH 3/4] Add missing entries into .gitignore

Signed-off-by: Angus Salkeld asalk...@redhat.com --- .gitignore |2 ++ test/.gitignore |4 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index d853a2a..ec5b871 100644 --- a/.gitignore +++ b/.gitignore @@ -3,8 +3,10 @@ *.lcrso *.so

[Openais] [PATCH 4/4] Handle make rpms on branches with no tags

CTS tests rpm building. This just uses the branch name instead of a tag (if no tag). Also move shell scripting into build-aux/git-spec-version Signed-off-by: Angus Salkeld asalk...@redhat.com --- Makefile.am| 39 +- build-aux/git-spec-version | 66

[Openais] [PATCH 1/4] fix timersub warning on freebsd

Make them all protected by #ifndef timersub Signed-off-by: Angus Salkeld asalk...@redhat.com --- services/pload.c | 21 ++--- test/cpgbench.c| 20 ++-- test/cpgbenchzc.c | 18 +- tools/corosync-pload.c | 18

[Openais] [PATCH openais/whitetank] Make controlled shutdowns faster.

. Original-Author: Christine Caulfield ccaul...@redhat.com Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/totemnet.c | 14 +++ exec/totemsrp.c | 69 ++- 2 files changed, 82 insertions(+), 1 deletions(-) diff --git a/exec/totemnet.c

[Openais] [PATCH master] Fix a confusing error conversion.

Also use hdb_error_to_cs() as expected. (won't change behavior but will better match the other uses of it). Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/coroipcs.c |6 +++--- exec/util.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/exec

[Openais] [PATCH] CPG: make sure coroipcc_service_disconnect() is always called.

This prevents a shared mem leak if corosync dies while clients are connected. Calling cpg_finalize() did not release the shared mem as coroipcc_msg_send_reply_receive() returned an error and thus coroipcc_service_disconnect() did not get called. Signed-off-by: Angus Salkeld asalk...@redhat.com

Re: [Openais] corosync 1.3.0 not stable under load

On Wed, Dec 22, 2010 at 08:52:30AM +, Dietmar Maurer wrote: Corosync v1.3.0 (single node) Debian Squeeze AMD64 with latest 2.6.32 kernel When I run corosync-pload it prints: # corosync-pload Init result 1 The process never stops (but I can stop it with cntrl-c), but it seems to

Re: [Openais] problem with on-fail actions

On Wed, Dec 22, 2010 at 01:43:48PM +0100, Haussecker, Armin wrote: In our 2-node-cluster with pacemaker 1.1.2 and corosync 1.2.1 we have defined a resource 'auvm1' with 'on-fail=restart' for op's start and monitor and we have set 'on-fail=restart' in op_defaults. The resource 'auvm1' was

[Openais] [PATCH] IPC: send failure message to client if memory maps fail

If any sys call in memory_map() fails the failure currently gets ignored. Now we pass a CS_ERR_LIBRARY back to the client app. Signed-off-by: Angus Salkeld asalk...@redhat.com --- exec/coroipcs.c | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a/exec

[Openais] more patches for topic-libqb

These iron out some bugs and generally improve the topic branch. I'll look into whether or not the CPG patches are applicable to the master branch. Regards Angus ___ Openais mailing list Openais@lists.linux-foundation.org

  1   2   3   4   5   6   >