[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr into lp:carriers-deliveries

2014-01-20 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr into lp:carriers-deliveries. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr into lp:carriers-deliveries

2014-01-20 Thread noreply
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr into lp:carriers-deliveries has been updated. Status: Needs review = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/opening_entry_foreign_currency_fix_mdh into lp:ocb-addons

2014-01-20 Thread Holger Brunn (Therp)
Review: Approve Thanks for this one! As it was merged into upstream and already got back to ocb via the replay script, I'll set this MP to 'merged' -- https://code.launchpad.net/~camptocamp/ocb-addons/opening_entry_foreign_currency_fix_mdh/+merge/197526 Your team OpenERP Community Backports

Re: [Openerp-community-reviewer] [Merge] lp:~gdgellatly/server-env-tools/base-synchro-7.0 into lp:server-env-tools

2014-01-20 Thread Joël Grand-Guillaume
Review: Needs Information Hi, First of all, thank you a lot for all this work, my further comment doesn't criticize any of your investment in here. As this module has been abandoned by OpenERP, I'm not sure it's good to have it in our community modules. For what I know about this module he

Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical_refactoring_step_I into lp:oemedical

2014-01-20 Thread Pedro Manuel Baeza
Review: Needs Information Hi, Mario, Thanks for your great efforts to bring this project to a usable state. Waiting for a deeper review, I have seen something that flash me and want you to tell: you told about a new module called oemedical_first_name to split personal names in two, but this

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1267845-product-and-category-search-improved-usability into lp:ocb-addons/6.1

2014-01-20 Thread Holger Brunn (Therp)
Review: Needs Fixing 18: add spaces between operators 21: this seems to be one line too much 33: that's not safe against searching for ' / ' or the like, I'd wrap that into an if category_names: 33, 36: shouldn't strip(product_category_separator + ' ') be enough? (the space just to be safe

Re: [Openerp-community-reviewer] [Merge] lp:~jeffery9/ocb-addons/ocb-addons into lp:ocb-addons

2014-01-20 Thread Holger Brunn (Therp)
setting to work in progress due to inactivity -- https://code.launchpad.net/~jeffery9/ocb-addons/ocb-addons/+merge/193883 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~jeffery9/ocb-addons/ocb-addons into lp:ocb-addons

2014-01-20 Thread Holger Brunn (Therp)
The proposal to merge lp:~jeffery9/ocb-addons/ocb-addons into lp:ocb-addons has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~jeffery9/ocb-addons/ocb-addons/+merge/193883 --

Re: [Openerp-community-reviewer] [Merge] lp:~grupocitec/ocb-addons/report_webkit_custom_paper_size into lp:ocb-addons

2014-01-20 Thread Holger Brunn (Therp)
any input from the webkit people? -- https://code.launchpad.net/~grupocitec/ocb-addons/report_webkit_custom_paper_size/+merge/195418 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh into lp:partner-contact-management

2014-01-20 Thread Leonardo Pistone @ camptocamp
Review: Approve code review You're right Pedro, sorry for not coming back. I update my review, just for the record. -- https://code.launchpad.net/~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh/+merge/197400 Your team Partner and Contact Core Editors is subscribed to

[Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1-sort-events-mat into lp:ocb-addons/6.1

2014-01-20 Thread noreply
The proposal to merge lp:~hirt/ocb-addons/6.1-sort-events-mat into lp:ocb-addons/6.1 has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~hirt/ocb-addons/6.1-sort-events-mat/+merge/196434 --

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1104766-ignore-canceled-moves into lp:ocb-addons/6.1

2014-01-20 Thread noreply
The proposal to merge lp:~yann-papouin/ocb-addons/6.1-bug-1104766-ignore-canceled-moves into lp:ocb-addons/6.1 has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1104766-ignore-canceled-moves/+merge/197753 --

[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-addons/6.1-fix-935564 into lp:ocb-addons/6.1

2014-01-20 Thread noreply
The proposal to merge lp:~pedro.baeza/ocb-addons/6.1-fix-935564 into lp:ocb-addons/6.1 has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~pedro.baeza/ocb-addons/6.1-fix-935564/+merge/197737 --

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/6.1-lp1244663_failing_test_purchase_double_validation into lp:ocb-addons/6.1

2014-01-20 Thread noreply
The proposal to merge lp:~therp-nl/ocb-addons/6.1-lp1244663_failing_test_purchase_double_validation into lp:ocb-addons/6.1 has been updated. Status: Needs review = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename into lp:ocb-web/6.1

2014-01-20 Thread Holger Brunn (Therp)
Review: Approve code review -- https://code.launchpad.net/~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename/+merge/27 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

[Openerp-community-reviewer] [Bug 1195904] Re: [trunk/7.0] [Firefox] graphs - TypeError cur is null

2014-01-20 Thread Bharat Devnani (Open ERP)
** Changed in: openobject-addons Status: Fix Committed = Incomplete -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/1195904 Title: [trunk/7.0] [Firefox] graphs - TypeError cur

[Openerp-community-reviewer] [Bug 1195904] Re: [trunk/7.0] [Firefox] graphs - TypeError cur is null

2014-01-20 Thread Acsone
Hello Bharat, Why this status change? -sbi -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/1195904 Title: [trunk/7.0] [Firefox] graphs - TypeError cur is null Status in OpenERP

Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical_refactoring_step_I into lp:oemedical

2014-01-20 Thread Mario Arias
Hi Pedro, In fact it is based on that one. It just adds inherited fields on new views... Regards El 20/01/2014 04:09, Pedro Manuel Baeza pedro.ba...@gmail.com escribió: Review: Needs Information Hi, Mario, Thanks for your great efforts to bring this project to a usable state. Waiting for a

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1264950-afe into lp:ocb-addons

2014-01-20 Thread noreply
The proposal to merge lp:~camptocamp/ocb-addons/ocb-7.0-fix_1264950-afe into lp:ocb-addons has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1264950-afe/+merge/201028 --

[Openerp-community-reviewer] [Bug 1195904] Re: [trunk/7.0] [Firefox] graphs - TypeError cur is null

2014-01-20 Thread Yannick Vaucher @ Camptocamp
+1 to Stéphane comment Could you at least explain why it is passed to Incomplete and what is missing Like if you couldn't reproduced. And if the bug disappeared link commit that fixed it -- You received this bug notification because you are a member of OpenERP Community Backports Team, which

[Openerp-community-reviewer] [Merge] lp:~agilebg/ocb-addons/7.0-bug-1198250-elbati into lp:ocb-addons

2014-01-20 Thread noreply
The proposal to merge lp:~agilebg/ocb-addons/7.0-bug-1198250-elbati into lp:ocb-addons has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~agilebg/ocb-addons/7.0-bug-1198250-elbati/+merge/194395 --

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/6.1_lp1260743_print_empty_lines into lp:ocb-server/6.1

2014-01-20 Thread noreply
The proposal to merge lp:~therp-nl/ocb-server/6.1_lp1260743_print_empty_lines into lp:ocb-server/6.1 has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~therp-nl/ocb-server/6.1_lp1260743_print_empty_lines/+merge/199120 --

[Openerp-community-reviewer] [Bug 1195904] Re: [trunk/7.0] [Firefox] graphs - TypeError cur is null

2014-01-20 Thread Yannick Vaucher @ Camptocamp
By the way I tested on runbot again passing around eight times the mouse randomely over a graph in bar mode and I get this error -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/1195904

[Openerp-community-reviewer] [Bug 1195904] Re: [trunk/7.0] [Firefox] graphs - TypeError cur is null

2014-01-20 Thread Yannick Vaucher @ Camptocamp
tested on runbot OpenERP 7.0 (Build 28025) server (5208) addons (9776) web (4119) -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/1195904 Title: [trunk/7.0] [Firefox] graphs -

[Openerp-community-reviewer] [Bug 1195904] Re: [trunk/7.0] [Firefox] graphs - TypeError cur is null

2014-01-20 Thread Twinkle Christian(OpenERP)
** Changed in: openobject-addons Status: Incomplete = Fix Committed -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/1195904 Title: [trunk/7.0] [Firefox] graphs - TypeError cur

[Openerp-community-reviewer] [Bug 1195904] Re: [trunk/7.0] [Firefox] graphs - TypeError cur is null

2014-01-20 Thread Bharat Devnani (Open ERP)
Hello, Sorry for the inconvenience, it was not done intentionally. We have changed the status to Fix Committed. Thanks Regards, Devnani Bharat R. -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee.

[Openerp-community-reviewer] [Merge] lp:~michelemilidoni/server-env-tools/it_tr into lp:server-env-tools

2014-01-20 Thread noreply
The proposal to merge lp:~michelemilidoni/server-env-tools/it_tr into lp:server-env-tools has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~michelemilidoni/server-env-tools/it_tr/+merge/199557 --

[Openerp-community-reviewer] [Merge] lp:~initos.com/partner-contact-management/7.0 into lp:partner-contact-management

2014-01-20 Thread noreply
The proposal to merge lp:~initos.com/partner-contact-management/7.0 into lp:partner-contact-management has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~initos.com/partner-contact-management/7.0/+merge/195066 --

[Openerp-community-reviewer] [Bug 1195904] Re: [trunk/7.0] [Firefox] graphs - TypeError cur is null

2014-01-20 Thread Yannick Vaucher @ Camptocamp
Thanks Bharat :-) Cheers, -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/1195904 Title: [trunk/7.0] [Firefox] graphs - TypeError cur is null Status in OpenERP Community Backports

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-financial-report/6.1-analytic_entries_report_fiscalyear into lp:account-financial-report/6.1

2014-01-20 Thread Leonardo Pistone @ camptocamp
Review: Approve code review Nothing wrong Holger! I would appreciate just a little comment that says that the query is identical, to save time to people evaluating the module in the future. I'm not blocking it though, thanks for your work! --

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/city-move into lp:partner-contact-management

2014-01-20 Thread Sandy Carter (http://www.savoirfairelinux.com)
The proposal to merge lp:~savoirfairelinux-openerp/partner-contact-management/city-move into lp:partner-contact-management has been updated. Status: Needs review = Rejected For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~trobz/web-addons/web-unleashed into lp:web-addons

2014-01-20 Thread Holger Brunn (Therp)
Looks pretty good! I'm yet to try it in a serious project, but for the time being: Well done! Some nits so far: - your js tests will run twice, once from the web module, once triggered from tests/test_js.py. Is this possibly a leftover from development? - any reason to deviate from putting

[Openerp-community-reviewer] [Merge] lp:~serpentcs/web-addons/web_search_alphabetic into lp:web-addons

2014-01-20 Thread Serpent Consulting Services
Serpent Consulting Services has proposed merging lp:~serpentcs/web-addons/web_search_alphabetic into lp:web-addons. Requested reviews: Web-Addons Core Editors (webaddons-core-editors) For more details, see: https://code.launchpad.net/~serpentcs/web-addons/web_search_alphabetic/+merge/202325

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr into lp:carriers-deliveries

2014-01-20 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr into lp:carriers-deliveries has been updated. Status: Merged = Needs review For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr into lp:carriers-deliveries

2014-01-20 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_postlogistics-imp-licenses-yvr into lp:carriers-deliveries. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/lp-community-utils/target_copy_from_shared_repository into lp:lp-community-utils

2014-01-20 Thread Ronald Portier (Therp)
Review: Needs Fixing test Maybe not related, but not working for me: openeyedev@laptop01:~/var/oe_repo/checkouts/lp-community-utils/target_copy_from_shared_repository$ ./clone_mp_to_community.py --mp-url

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/ocb-addons/7.0-ocb-addons-fix-bug-1089229 into lp:ocb-addons

2014-01-20 Thread Alejandro Santana
Review: Needs Information OK, despite the pure mathematics, I set myself as 'Needs fixing', because rounding calculations make mandatory to compute subtotal as shown in the report: product_uos_qty (dp as UoM) * price_unit_uos (dp as Product Price) = subtotal (dp as Account) dp = decimal

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/ocb-addons/6.1-ocb-addons-fix-bug-1089229 into lp:ocb-addons/6.1

2014-01-20 Thread Alejandro Santana
Review: Needs Information Same as MP in v7.0 (https://code.launchpad.net/~alejandrosantana/ocb-addons/7.0-ocb-addons-fix-bug-1089229/+merge/202233): OK, despite the pure mathematics, I set myself as 'Needs fixing', because rounding calculations make mandatory to compute subtotal as shown in