[Openipmi-developer] [PATCH 3/4] ipmi: Improve error messages on failed irq enable

2013-05-16 Thread Corey Minyard
When the interrupt enable message returns an error, the messages are not entirely accurate nor helpful. So improve them. Signed-off-by: Corey Minyard cminy...@mvista.com Cc: Andy Lutomirski l...@amacapital.net --- drivers/char/ipmi/ipmi_si_intf.c | 16 ++-- 1 file changed, 10

[Openipmi-developer] [PATCH 2/4] drivers/char/ipmi: memcpy, need additional 2 bytes to avoid memory overflow

2013-05-16 Thread Corey Minyard
|| msg_len IPMI_MAX_MSG_LENGTH) for operating: memcpy(data + 2, bt-read_data + 4, msg_len - 2) Signed-off-by: Chen Gang gang.c...@asianux.com Signed-off-by: Corey Minyard cminy...@mvista.com Cc: sta...@vger.kernel.org --- drivers/char/ipmi/ipmi_bt_sm.c |4 ++-- 1 file changed, 2 insertions(+), 2

[Openipmi-developer] [PATCH 1/4] drivers: char: ipmi: Replaced kmalloc and strcpy with kstrdup

2013-05-16 Thread Corey Minyard
From: Alexandru Gheorghiu gheorghiuan...@gmail.com Replaced calls to kmalloc followed by strcpy with a sincle call to kstrdup. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu gheorghiuan...@gmail.com Signed-off-by: Corey Minyard cminy...@mvista.com --- drivers/char/ipmi

[Openipmi-developer] [PATCH 4/4] ipmi: ipmi_devintf: compat_ioctl method fails to take ipmi_mutex

2013-05-16 Thread Corey Minyard
() to take ipmi_mutex to fix this. Signed-off-by: Benjamin LaHaise b...@kvack.org Signed-off-by: Corey Minyard cminy...@mvista.com Cc: sta...@vger.kernel.org --- drivers/char/ipmi/ipmi_devintf.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/char/ipmi

[Openipmi-developer] [PATCH 0/4] ipmi: Some minor fixes

2013-05-16 Thread Corey Minyard
Some minor fixes I had queued up. The last one came in recently (patch 4) and it and patch 2 are candidates for stable-kernel. -- AlienVault Unified Security Management (USM) platform delivers complete security

Re: [Openipmi-developer] [PATCH 3/4] ipmi: Improve error messages on failed irq enable

2013-05-16 Thread Corey Minyard
On 05/16/2013 05:23 PM, Andy Lutomirski wrote: /* We got the flags from the SMI, now handle them. */ smi_info-handlers-get_result(smi_info-si_sm, msg, 4); - if (msg[2] != 0) - dev_warn(smi_info-dev, Could not enable

Re: [Openipmi-developer] Could not enable interrupts despite interrupts working

2013-05-10 Thread Corey Minyard
On 05/09/2013 04:00 PM, Andy Lutomirski wrote: IPMI in polled mode sucks enough that this warning is alarming: ipmi_si ipmi_si.0: Could not enable interrupts, failed set, using polled mode. On two of my Dell gen 7 (I think) servers, this warning prints, but IPMI uses interrupts. Can the

Re: [Openipmi-developer] Could not enable interrupts despite interrupts working

2013-05-10 Thread Corey Minyard
On 05/10/2013 01:47 PM, Andy Lutomirski wrote: On Fri, May 10, 2013 at 11:45 AM, Corey Minyard tcminy...@gmail.com wrote: On 05/10/2013 01:31 PM, Andy Lutomirski wrote: On Fri, May 10, 2013 at 5:16 AM, Corey Minyard tcminy...@gmail.com wrote: On 05/09/2013 04:00 PM, Andy Lutomirski wrote

Re: [Openipmi-developer] [PATCH] drivers: char: ipmi: Replaced kmalloc and strcpy with kstrdup

2013-03-18 Thread Corey Minyard
); return -ENOMEM; } - strcpy(entry-name, name); file = proc_create_data(name, 0, smi-proc_dir, proc_ops, data); if (!file) { Looks good to me. Acked-by: Corey Minyard cminy...@mvista.com -- Everyone

Re: [Openipmi-developer] [PATCH] ipmi: add new kernel options to prevent automatic ipmi init

2012-12-14 Thread Corey Minyard
On 12/14/2012 10:25 AM, Evans, Robert wrote: Corey, Thanks for the thoughtful reply. Below I respond in detail to these three points. 1) Why building a variant kernel with ipmi_si as a module is not feasible. 2) User mode access to IPMI on Stratus systems (e.g. ipmitool). 3)

Re: [Openipmi-developer] [PATCH] ipmi: add new kernel options to prevent automatic ipmi init

2012-12-13 Thread Corey Minyard
Well, the built-in driver works on systems that have more than one interface and more than one BMC, and multiple IPMBs (and all of the other channel types for that matter, and the driver handles all the multiplexing and nasty addressing). There is, in fact, no arbitrary limit, and IBM tested this

Re: [Openipmi-developer] python binding and PYPI

2012-12-02 Thread Corey Minyard
On 12/02/2012 08:59 PM, Lu, Lianhao wrote: Hi guys, Is there any plan to put openipmi python binding to http://pypi.python.org/pypi, so the users can easily install the OpenIPMI python module through pip? Some distributions(i.e. Ubuntu, etc.) don't provide its native package for the

Re: [Openipmi-developer] [PATCH 4/5] IPMI: Fix some uninitialized warning

2012-10-26 Thread Corey Minyard
On 10/22/2012 06:49 PM, Andrew Morton wrote: On Tue, 16 Oct 2012 15:53:39 -0500 miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com There was a spot where the compiler couldn't tell some variables would be set. So initialize them to make the warning go away. Signed-off

[Openipmi-developer] Location of newer kernel sources

2012-09-19 Thread Corey Minyard
I while ago I moved to keeping the IPMI driver updates in a git repository. Unfortunately, I didn't tell anyone. So, access to the IPMI driver for newer versions of the kernel is currently available at git//openipmi.git.sourceforge.net/gitroot/openipmi/linux-ipmi under obvious branch names

[Openipmi-developer] Code moved to git, looking at old bug items

2012-07-21 Thread Corey Minyard
I just got tired of using CVS, so I finally converted the repository over to git. It's a lot nicer to use. I've imported all the history. If I had known it would be that easy, I would have done it earlier. I've also added a kernel git repository with the kernel patches. This should make it

Re: [Openipmi-developer] [PATCH] PM / IPMI: Remove empty legacy PCI PM callbacks

2012-07-06 Thread Corey Minyard
Looks fine to me. Acked-by: Corey Minyard cminy...@mvista.com On 07/06/2012 03:02 PM, Rafael J. Wysocki wrote: From: Rafael J. Wysocki r...@sisk.pl The legacy PM callbacks provided by the IPMI PCI driver are empty routines returning 0, so they can be safely dropped. Signed-off-by: Rafael J

Re: [Openipmi-developer] [PATCH 1/1 v2 ] ipmi: Setting OS name as Linux in BMC

2012-07-04 Thread Corey Minyard
On 07/04/2012 07:17 AM, Andi Kleen wrote: Rather than just have a static entry such as 'Linux' I could probably write the version number and more(distro name etc.. ) Thoughts.. ? I still think Linux means nothing even to the management software. What should it do with that? If you provide

Re: [Openipmi-developer] [PATCH 1/1 v2 ] ipmi: Setting OS name as Linux in BMC

2012-06-29 Thread Corey Minyard
On 06/29/2012 07:30 AM, Matthew Garrett wrote: On Thu, Jun 28, 2012 at 05:01:54PM -0700, Andi Kleen wrote: Not sure that's all that useful. I can just see BMC's making the ACPI mistake of trying to work around specific issues, by checking for Linux. I'm not sure I see that happening, but I

Re: [Openipmi-developer] IPMI device file locking

2012-06-26 Thread Corey Minyard
On 06/26/2012 09:33 PM, dbashaw wrote: I have a question about using ipmi_watchdog, ipmitool, and another open source program ipmisensors together at the same time. ipmitool uses the /dev/ipmi0 char interface. So does (can) ipmi_watchdog. ipmisensors uses ipmi_settime(..) to send messages

Re: [Openipmi-developer] Multiple users sending messages via KCS interface

2012-04-06 Thread Corey Minyard
You don't mention the kernel version or anything of that nature. There was a bug fixed a while back for something that looked like this. -corey On 04/05/2012 09:15 PM, dbashaw wrote: I have two IPMI users created using ipmi_create_user(..). Each user can send messages async with respect to

[Openipmi-developer] [PATCH 2/6] ipmi: Increase KCS timeouts

2012-02-03 Thread Corey Minyard
are not shown explicitly in the flow diagrams. A five-second timeout or greater is recommended. Change the timeout to five seconds to satisfy the slow hardware. From: Matthew Garrett m...@redhat.com Signed-off-by: Matthew Garrett m...@redhat.com Signed-off-by: Corey Minyard cminy...@mvista.com --- drivers

[Openipmi-developer] [PATCH 4/6] ipmi: Fix message handling during panics

2012-02-03 Thread Corey Minyard
. Signed-off-by: Corey Minyard cminy...@mvista.com --- drivers/char/ipmi/ipmi_msghandler.c | 103 --- drivers/char/ipmi/ipmi_watchdog.c | 17 --- 2 files changed, 56 insertions(+), 64 deletions(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char

[Openipmi-developer] [PATCH 3/6] ipmi: use a tasklet for handling received messages

2012-02-03 Thread Corey Minyard
The IPMI driver would release a lock, deliver a message, then relock. This is obviously ugly, and this patch converts the message handler interface to use a tasklet to schedule work. This lets the receive handler be called from an interrupt handler with interrupts enabled. Signed-off-by: Corey

[Openipmi-developer] [PATCH 6/6] ipmi: Use locks on watchdog timeout set on reboot

2012-02-03 Thread Corey Minyard
The IPMI watchdog timer clears or extends the timer on reboot/shutdown. It was using the non-locking routine for setting the watchdog timer, but this was causing race conditions. Instead, use the locking version to avoid the races. It seems to work fine. Signed-off-by: Corey Minyard cminy

[Openipmi-developer] [PATCH 1/6] ipmi: decreases the IPMI message transaction time in interrupt mode

2012-02-03 Thread Corey Minyard
-by: Srinivas_Gowda srinivas_g_go...@dell.com Signed-off-by: Corey Minyard cminy...@mvista.com --- drivers/char/ipmi/ipmi_si_intf.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 50fcf9c..73ebbb1 100644

Re: [Openipmi-developer] [PATCH 3/6] ipmi: use a tasklet for handling received messages

2012-02-03 Thread Corey Minyard
On 02/03/2012 01:44 PM, Andrew Morton wrote: On Fri, 03 Feb 2012 09:47:56 -0600 Corey Minyardcminy...@mvista.com wrote: The IPMI driver would release a lock, deliver a message, then relock. This is obviously ugly, and this patch converts the message handler interface to use a tasklet to

Re: [Openipmi-developer] [PATCH] ipmi: Increase KCS timeouts

2011-12-15 Thread Corey Minyard
This is fine, if it is really necessary to make slow hardware work. I've pulled it in, I'll submit in a bit. -corey On 12/14/2011 03:12 PM, Matthew Garrett wrote: Ping? On Wed, Nov 30, 2011 at 02:12:27PM -0500, Matthew Garrett wrote: We currently time out and retry KCS transactions after 1

Re: [Openipmi-developer] openipmi appropriateness for raw requests

2011-10-12 Thread Corey Minyard
On 10/11/2011 04:02 PM, a...@nyi.net wrote: So I have some ipmitool raw commands i run remotely against a host's bmc, and wanted to code them via the python bindings (so i can more frequent polling and then do further processing w/o forking ipmitool over and over). However the

Re: [Openipmi-developer] [PATCH 31/62] driver/char: irq: Remove IRQF_DISABLED

2011-09-08 Thread Corey Minyard
, + IRQF_SHARED, DEVICE_NAME, info); if (rv) { Ok by me. Acked-by: Corey Minyard cminy...@mvista.com -- Doing More with Less

Re: [Openipmi-developer] OpenIPMI and RedHat 6

2011-07-29 Thread Corey Minyard
On 07/29/2011 03:50 AM, Bob Sauvage wrote: Hello Jan and Corey, First of all, thanks for the provided information. The ipmi service is started : *service ipmi status* ipmi_msghandler module loaded. ipmi_si module loaded. ipmi_devintf module loaded. /dev/ipmi0 does not exist. *Modules are

Re: [Openipmi-developer] OpenIPMI and RedHat 6

2011-07-28 Thread Corey Minyard
Well, first of all, ipmitool is not part of the openipmi package, it is a separate tool. But it's probably what you want. You probably don't have the IPMI driver loaded or your board does not have IPMI support. IIRC, RHEL 6 should automatically load the driver, so my suspicion is the latter.

Re: [Openipmi-developer] How to compiled openipmi-python module

2011-04-18 Thread Corey Minyard
It should work automatically. Do you have python-dev installed? On Apr 16, 2011 11:08 PM, 白白wong kid.xiy...@gmail.com wrote: HI~ Who can provide the way to compiled openipmi-python module ? when compiled OpenIPMI i give the --with-python=/usr/bin/python2.5

Re: [Openipmi-developer] [PATCH] ipmi: Fix IPMI errors due to timing problems

2011-03-10 Thread Corey Minyard
On 03/10/2011 01:17 PM, Matthew Garrett wrote: On Thu, Mar 10, 2011 at 01:12:50PM -0600, Corey Minyard wrote: +smi_info-last_timeout_jiffies ?iffies; Something looks mangled here? Otherwise, ACK. I have no idea how that happened, but it wasn't that way before I compiled with it. I guess

[Openipmi-developer] [PATCH] ipmi: Fix IPMI errors due to timing problems

2011-03-10 Thread Corey Minyard
From: Doe, YiCheng yicheng@hp.com This patch fixes an issue in OpenIPMI module where sometimes an ABORT command is sent after sending an IPMI request to BMC causing the IPMI request to fail. Signed-off-by: YiCheng Doe yicheng@hp.com Signed-off-by: Corey Minyard cminy...@mvista.com Acked

[Openipmi-developer] [PATCH] ipmi: Fix IPMI errors due to timing problems

2011-03-10 Thread Corey Minyard
From: Doe, YiCheng yicheng@hp.com This patch fixes an issue in OpenIPMI module where sometimes an ABORT command is sent after sending an IPMI request to BMC causing the IPMI request to fail. Signed-off-by: YiCheng Doe yicheng@hp.com Signed-off-by: Corey Minyard cminy...@mvista.com Acked

Re: [Openipmi-developer] OpenIPMI and CPU temperature

2011-02-25 Thread Corey Minyard
On 02/24/2011 09:49 AM, Sandra Escandor wrote: Hello, I'm currently researching how to use OpenIPMI to obtain sensor readings, specifically for an Intel Xeon 5500 CPU. I am wondering: Is it possible to obtain this reading through OpenIPMI, or should I use something else? One of the

[Openipmi-developer] [PATCH] char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver

2011-02-10 Thread Corey Minyard
...@oracle.com Signed-off-by: Corey Minyard cminy...@mvista.com --- drivers/char/ipmi/ipmi_si_intf.c | 12 ++-- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index b6ae6e9..7855f9f 100644 --- a/drivers/char/ipmi

Re: [Openipmi-developer] ipmi: reduce polling patch disrupts IPMI watchdog

2011-01-10 Thread Corey Minyard
This is almost certainly a bug in the BMC. The change in your patch should have no effect, this is the start of a send, and the BMC interface should be idle at that point, so doing an smi_timeout will only result in another extraneous read from the IPMI interface (and of course a slightly

Re: [Openipmi-developer] [PATCH] Add missing space in start_now parameter description

2010-12-18 Thread Corey Minyard
Looks good to me. Acked-by: Corey Minyard cminy...@mvista.com On 12/17/2010 05:38 PM, dann frazier wrote: Signed-off-by: dann frazierdann.fraz...@canonical.com --- drivers/char/ipmi/ipmi_watchdog.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char

Re: [Openipmi-developer] [PATCH 0/3_v14] IPMI/ACPI: Install the ACPI IPMI opregion

2010-12-14 Thread Corey Minyard
On 12/13/2010 11:21 PM, Len Brown wrote: Corey, Most of the code is in drivers/acpi, but that depends on the ipmi part. Shall I take all three patches in the acpi-test tree? thanks, Len Brown, Intel Open Source Technology Center I was trying to figure out what to do with these, so yes,

Re: [Openipmi-developer] [RFC PATCH 1/4] IPMI: Add one interface to get more info of low-level IPMI device

2010-11-03 Thread Corey Minyard
On 11/02/2010 12:33 AM, ykzhao wrote: On Thu, 2010-10-28 at 09:00 +0800, ykzhao wrote: On Thu, 2010-10-28 at 00:13 +0800, Corey Minyard wrote: I think you miss the point of a refcount. The refcount is to keep the data structure around even if the device has gone away, so that any

Re: [Openipmi-developer] [RFC PATCH 1/4] IPMI: Add one interface to get more info of low-level IPMI device

2010-10-14 Thread Corey Minyard
On 10/14/2010 08:07 PM, ykzhao wrote: The way you are doing it, there is no need for a refcount, since you are making a copy of the data. Is a copy or a pointer better? A pointer is generally preferred, it keeps from having to either store data on the stack or dynamically allocate it for

Re: [Openipmi-developer] [RFC PATCH 1/2_v9] IPMI: Add one interface to get more info of low-level IPMI device

2010-09-27 Thread Corey Minyard
On 09/26/2010 08:34 PM, ykzhao wrote: On Wed, 2010-09-15 at 16:06 +0800, Zhao, Yakui wrote: From: Zhao Yakuiyakui.z...@intel.com The IPMI smi_watcher will be used to catch the IPMI interface as they come or go. In order to communicate with the correct IPMI device, it should be

Re: [Openipmi-developer] [patch] ipmi: make static checkers happy about range checks

2010-09-18 Thread Corey Minyard
I'm ok with this, I don't think it will make any real difference besides the compiler converting that comparison to unsigned. I wish I had made that unsigned. -corey On 09/17/2010 02:26 PM, Dan Carpenter wrote: I'm working on a Smatch check that complains that addr-channel comes from the

Re: [Openipmi-developer] [PATCH] ipmi: Fix memleaking for add_smi when duplicating happen

2010-07-27 Thread Corey Minyard
On 07/26/2010 11:41 PM, Yinghai Lu wrote: On 07/26/2010 07:05 PM, Corey Minyard wrote: Please run this through checkpatch, as it has coding style violations. y...@linux-siqj:~/xx/xx/kernel/tip/linux-2.6 ./scripts/checkpatch.pl patches/ipmi_reg_size.patch total: 0 errors, 0

Re: [Openipmi-developer] [PATCH_v8 1/2] IPMI/ACPI: Define acpi_ipmi notifier hook functions

2010-07-27 Thread Corey Minyard
On 07/27/2010 08:09 PM, ykzhao wrote: I agree that a notifier framework seems like massive overkill for this interface. I will note that there are already interfaces for registering to receive callbacks when an IPMI device is added or removed. What's missing is a way to ask Is this an ACPI

Re: [Openipmi-developer] [PATCH] ipmi: Fix memleaking for add_smi when duplicating happen

2010-07-26 Thread Corey Minyard
Please run this through checkpatch, as it has coding style violations. Also, this patch appears to fix bugs in addition to adding the print. Can we have a separate patch for that? I'm also not clear on the reason for this. I believe all this information is already available in

Re: [Openipmi-developer] [PATCH_v8 1/2] IPMI/ACPI: Define acpi_ipmi notifier hook functions

2010-07-26 Thread Corey Minyard
On 07/26/2010 11:52 AM, Bjorn Helgaas wrote: On Monday, July 26, 2010 08:46:04 am yakui.z...@intel.com wrote: From: Zhao yakuiyakui.z...@intel.com This needs a changelog. This seems like a complicated solution to a simple problem. I don't understand why the ACPI IPMI opregion

Re: [Openipmi-developer] [PATCH v2]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used

2010-07-08 Thread Corey Minyard
On 07/07/2010 11:05 PM, Justin P. Mattock wrote: what ever came about with this? Justin P. Mattock Well, Sergey sent a patch, but I don't think it was quite in a form that can be taken. Do you want to resend per the standard rules? -corey

Re: [Openipmi-developer] Is session used for UART payload interface?

2010-07-07 Thread Corey Minyard
On 07/06/2010 11:54 PM, WANG Yong ming wrote: Hi, I am implementing a payload interface based on UART, from the spec, serial channel is session based, but I could not find the openIPMI source code for the serial channel session establishment, so the question is, 1) Is openIPMI has a UART

Re: [Openipmi-developer] [PATCH -v6 2/2] IPMI: use ACPI detection mechanism firstly to detect IPMI system interface

2010-06-09 Thread Corey Minyard
ykzhao wrote: My first thought is to put the ACPI-IPMI opregion handler into ACPI subsystem. But Bjorn suggests that it can be put into the smi code. Then I follow his suggestion. OK. I will rewrite the code and don't tie the ACPI-IPMI opregion handler to the smi code. I think it's ok to

Re: [Openipmi-developer] OpenIPMI sensor's names/sensor's Id with strange suffix 1 (tested on Sun x64 servers)

2010-05-28 Thread Corey Minyard
in the spec, and it's silly for anyone to put a 1 in this share count field. -corey Alex Deiter wrote: Hi Corey, Also i uploaded output from command: mc sdrs test(0.20) main into http://deiter.net.ru/mc_sdr.txt Thanks a lot! 2010/5/28 Corey Minyard cminy...@mvista.com: Can you do

[Openipmi-developer] [PATCH 5/8] ipmi: Reduce polling when interrupts are available

2010-05-03 Thread Corey Minyard
, and make the timeout code reset itself only if the transaction is incomplete or we have no interrupts. Signed-off-by: Matthew Garrett m...@redhat.com Signed-off-by: Corey Minyard cminy...@mvista.com --- Index: linux-2.6/drivers/char/ipmi/ipmi_si_intf.c

[Openipmi-developer] [PATCH 6/8] ipmi: Reduce polling

2010-05-03 Thread Corey Minyard
From: Matthew Garrett m...@redhat.com We can reasonably alter the poll rate depending on whether we're performing a transaction or merely waiting for an event. Signed-off-by: Matthew Garrett m...@redhat.com Signed-off-by: Corey Minyard cminy...@mvista.com --- Index: linux-2.6/drivers/char/ipmi

[Openipmi-developer] [PATCH 7/8] ipmi: Attempt to register multiple SIs of the same type

2010-05-03 Thread Corey Minyard
unless we have multiple BMCs. If these hold true then we should register all SIs of the same type. Signed-off-by: Matthew Garrett m...@redhat.com Signed-off-by: Corey Minyard cminy...@mvista.com --- Index: linux-2.6/drivers/char/ipmi/ipmi_si_intf.c

[Openipmi-developer] [PATCH 8/8] ipmi: Change timeout and event poll to one second

2010-05-03 Thread Corey Minyard
From: Corey Minyard cminy...@mvista.com The timeouts in IPMI are in the 1-5 second range in message handling, so a 1 second timeout is a reasonable thing to do. This should help with reducing power consumption on idle systems. Signed-off-by: Corey Minyard cminy...@mvista.com --- Index: linux

[Openipmi-developer] [PATCH 1/8] ipmi: Change addr_source to an enum rather than strings

2010-05-03 Thread Corey Minyard
From: Matthew Garrett m...@redhat.com Switch from a char* to an enum to identify the address source of SIs, making it easier to handle them appropriately during registration. Signed-off-by: Matthew Garrett m...@redhat.com Signed-off-by: Corey Minyard cminy...@mvista.com --- Index: linux-2.6

[Openipmi-developer] [PATCH 2/8] ipmi: Split device discovery and registration

2010-05-03 Thread Corey Minyard
From: Matthew Garrett m...@redhat.com The ipmi spec indicates that we should only make use of one si per bmc, so separate device discovery and registration to make that possible. Signed-off-by: Matthew Garrett m...@redhat.com Signed-off-by: Corey Minyard cminy...@mvista.com --- Index: linux-2.6

[Openipmi-developer] [PATCH 4/8] ipmi: Change device discovery order

2010-05-03 Thread Corey Minyard
Signed-off-by: Corey Minyard cminy...@mvista.com --- Index: linux-2.6/drivers/char/ipmi/ipmi_si_intf.c === --- linux-2.6.orig/drivers/char/ipmi/ipmi_si_intf.c +++ linux-2.6/drivers/char/ipmi/ipmi_si_intf.c @@ -3308,17 +3308,6 @@ static

[Openipmi-developer] OpenIPMI 2.0.17 released

2010-04-29 Thread Corey Minyard
It's been a while since a release, and lots of little things have gone in. Thanks to everyone who has helped with this. ChangeLog follows... 2010-04-29 Corey Minyard cminy...@mvista.com * configure.in: Move to version 2.0.17. 2010-04-28 Corey Minyard cminy...@mvista.com

Re: [Openipmi-developer] [PATCH 2/3] ipmi: Only register one si per bmc

2010-04-21 Thread Corey Minyard
Matthew Garrett wrote: Only register one si per bmc. Use any user-provided devices first, followed by the first device with an irq, followed by the first device discovered. If I understand this correctly, this would really be Only register one si per system. Unfortunately, there are

Re: [Openipmi-developer] [PATCH 2/3] ipmi: Only register one si per bmc

2010-04-21 Thread Corey Minyard
Matthew Garrett wrote: On Wed, Apr 21, 2010 at 01:09:45PM -0500, Corey Minyard wrote: If I understand this correctly, this would really be Only register one si per system. Unfortunately, there are systems that have more than one BMC each with their own interface. The spec

Re: [Openipmi-developer] [Ipmitool-devel] OpenIPMI Python tutorial, documentation, sample code?

2010-03-24 Thread Corey Minyard
/bin/python # sample # # A sample file that uses most of the python/OpenIPMI interface # # Author: MontaVista Software, Inc. # Corey Minyard miny...@mvista.com # sou...@mvista.com # # Copyright 2010 MontaVista Software Inc. # # This program is free software; you can redistribute

Re: [Openipmi-developer] [SPAM] - Re: [PATCH 0/4] ipmi: remove SPMI and update core driver with dev_printk - Email found in subject

2010-03-10 Thread Corey Minyard
the code in is a problem, then we need to figure something out. I'm for the two patch approach mentioned by Myron. -corey Andy -Original Message- From: Myron Stowe [mailto:myron.st...@hp.com] Sent: Tuesday, March 09, 2010 6:16 PM To: Corey Minyard Cc: linux-a...@vger.kernel.org

[Openipmi-developer] [PATCH 1/4] IPMI: Add parameter to limit CPU usage in kipmid

2010-03-03 Thread Corey Minyard
loosing too much ipmi throughput performance. Not setting the value, or setting the value to zero, operation is unaffected. Signed-off-by: Martin Wilck martin.wi...@ts.fujitsu.com Cc: Jean Delvare jdelv...@suse.de Signed-off-by: Corey Minyard cminy...@mvista.com --- This patch has been discussed

[Openipmi-developer] [PATCH 2/4] IPMI: Fix slave_addrs setting to actually work

2010-03-03 Thread Corey Minyard
From: Bela Lubkin blub...@vmware.com Actually use the slave_addrs module parameter if it is specified, and make things consistent about passing zero in for the slave address for the default. Signed-off-by: Bela Lubkin blub...@vmware.com Signed-off-by: Corey Minyard miny...@acm.org --- Index

[Openipmi-developer] [PATCH 3/4] IPMI: Remove ipmi_smi.h self-include

2010-03-03 Thread Corey Minyard
From: Corey Minyard miny...@acm.org There is no need for linux/ipmi_smi.h to include itself. Signed-off-by: Corey Minyard miny...@acm.org Index: linux-2.6.29/include/linux/ipmi_smi.h === --- linux-2.6.29.orig/include/linux

[Openipmi-developer] [PATCH 4/4] IPMI: Add proper offset for HP PCI interfaces

2010-03-03 Thread Corey Minyard
From: Corey Minyard cminy...@mvista.com On a PCI update, the offset for HP PCI interfaces to the IPMI controller was left off. Add the offset back in. The dead code dealing with first_reg_offset was removed in 2.6.32, so that is re-added. Signed-off-by: Corey Minyard cminy...@mvista.com Index

Re: [Openipmi-developer] FRU Decode issues with openIPMI-2.14.0

2010-01-25 Thread Corey Minyard
harish kulkarni wrote: Hello All, I am getting following error/warnings. EINF: .1.20.218.0.0.0 fru.c(fetch_complete): Unable to decode FRU information WARN: (12.0) entity.c(fru_fetched_ent_cb):Error fetching entity 12.0 FRU: 26 EINF: .1.20.221.0.0.0 fru.c(fetch_complete): Unable to

Re: [Openipmi-developer] [PATCH] IPMI: Add parameter to limit CPU usage in kipmid

2009-12-17 Thread Corey Minyard
On Thu, Dec 17, 2009 at 09:07:45PM +0100, Jean Delvare wrote: Le jeudi 17 décembre 2009 19:34, Corey Minyard a écrit : I agree, these should be inlines. I should have caught that. I can convert them and address adding comments as Andrew suggests. Jean, I cleaned up the patch some. I

Re: [Openipmi-developer] [Resend PATCH] ACPI: Add the IPMI opregion driver to enable ACPI to access BMC controller

2009-12-11 Thread Corey Minyard
Len Brown wrote: On Wed, 9 Dec 2009, Bjorn Helgaas wrote: On Tuesday 08 December 2009 06:58:45 pm yakui.z...@intel.com wrote: From: Zhao Yakui yakui.z...@intel.com Add the IPMI opregion driver so that the AML code can communicate with BMC throught IPMI message. It will

Re: [Openipmi-developer] [PATCH v1 0/5] IPMI devices from ACPI namespace

2009-12-11 Thread Corey Minyard
Len Brown wrote: Corey, Bjorn, To keep things simple, I've put the 5 patches in this series together in the acpi-test tree. Let me know if that is a bad idea. thanks, Len Brown, Intel Open Source Technology Center That sounds good to me. I have no way to test them. -corey

Re: [Openipmi-developer] [PATCH v1 3/5] ipmi: remove unused PCI probe coded

2009-12-02 Thread Corey Minyard
Bjorn Helgaas wrote: I guess you're referring to b0defcdbd2b7d? Prior to that commit, we did this: int fe_rmc = 0; ... if (pci_dev (pci_dev-subsystem_vendor == PCI_HP_VENDOR_ID)) fe_rmc = 1; ... if (! fe_rmc)

Re: [Openipmi-developer] [PATCH v1 3/5] ipmi: remove unused PCI probe coded

2009-12-02 Thread Corey Minyard
Bela Lubkin wrote: Bjorn Helgaas wrote: The original 5-patch series leaves the PCI base address alone. That's the same as the old behavior for HP devices, and we verified that it works on an HP DL380G6 by disabling SMBIOS/SMPI/PNP detection. (We also verified that, as you would expect,

Re: [Openipmi-developer] [Discuss] [PATCH] ipmi: use round_jiffies on timers to reduce timer overhead/wakeups

2009-10-22 Thread Corey Minyard
Bela Lubkin wrote: Matt Domsch wrote: Though I'm really curious that HP has a KCS+interrupt controller available. That gives me hope that the industry-wide problems which prevented Dell from doing likewise a couple years ago are now resolved. I'll have my team look into it again.

Re: [Openipmi-developer] ipmi_smb.c decode_dmi() workaround for buggy BIOS appears to be broken

2009-10-21 Thread Corey Minyard
Well, no that's not the case. This is in the not clause of that if statement, where the I2C address is not in the slave address field. This seems to just be the case of an incorrect value in the slave address field. Unfortunately, your change will break correct systems. I'm not exactly sure

Re: [Openipmi-developer] [Discuss] [PATCH] ipmi: use round_jiffies on timers to reduce timer overhead/wakeups

2009-10-21 Thread Corey Minyard
Randy Dunlap wrote: On Wed, 21 Oct 2009 11:49:59 -0700 Kok, Auke wrote: Arjan van de Ven wrote: On Wed, 21 Oct 2009 10:28:22 -0700 Randy Dunlap randy.dun...@oracle.com wrote: From: Randy Dunlap randy.dun...@oracle.com Use a round_jiffies() variant to reduce overhead of

Re: [Openipmi-developer] Subject:[RFC Patch 1/2]IPMI/ACPI: Locate the IPMI system interface in ACPI namespace

2009-09-28 Thread Corey Minyard
I've been looking for something like this for a while, but I didn't have a system that supports this, so I didn't have a way to test it. Thanks for doing this. Now to the code. In general, the code is not consistent in the way it uses blank lines between functions, if statements, etc. Can

Re: [Openipmi-developer] [PATCH] char/impi: adding __init macro/ fix of __exit macro location in ipmi_poweroff.c

2009-08-23 Thread Corey Minyard
This is correct, I'm fine with it going through the trivial tree. Thanks. Acked-by: Corey Minyard miny...@acm.org Peter Hüwe wrote: From: Peter Huewe peterhu...@gmx.de Trivial patch which adds the __init to the module_init function of drivers/char/ipmi/ipmy_poweroff.c and corrects

Re: [Openipmi-developer] panic handler and ipmi_si

2009-08-14 Thread Corey Minyard
Hicks wrote: On Thu, Aug 13, 2009 at 09:24:06PM -0500, Corey Minyard wrote: I haven't seen this, but I don't use KDB. If you remove KDB, does the problem go away? No difference. I think it's totally unrelated. Without KDB the kernel still halts inside send_panic_events function

Re: [Openipmi-developer] [SPAM] - Re: BMC returned incorrect response - Email found in subject

2009-07-27 Thread Corey Minyard
incorrect response, expected netfn d cmd 2, got netfn 5 cmd 12 -Original Message- From: Corey Minyard [mailto:miny...@acm.org] Sent: Saturday, July 25, 2009 3:57 PM To: Mathieu Alorent Cc: openipmi-developer@lists.sourceforge.net; Gemini TRAN Subject: [SPAM] - Re: [Openipmi-developer

Re: [Openipmi-developer] [PATCH] Two null-pointer fixes to ipmi_lan.c

2009-06-18 Thread Corey Minyard
Thank you, patch is applied. -corey Eric J. Bowersox wrote: Two more null-pointer fixes to ipmi_lan.c, found in 2.0.16. The first is in a debugging message in rmcpp_find_ipmi, which was using the IPMI_CONN_NAME(ipmi) macro in a scenario in which the pointer it was passing would always be

[Openipmi-developer] Driver released for 2.6 30

2009-06-17 Thread Corey Minyard
I have released the Linux IPMI driver updates for 2.6.30. Sorry it took so long, but some serial driver changes caused me some issues. However, I have everything working and tested, so it's ready at http://openipmi.sourceforge.net/ The biggest change is the max busy changes from Martin

Re: [Openipmi-developer] modprobe ipmi_si hangs under 2.6.30-rc5

2009-05-18 Thread Corey Minyard
to the number of channels in an IPMI 1.0 system, as this value is used to tell if the channel information has been initialized. Signed-off-by: Corey Minyard cminy...@mvista.com diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index aa83a08..48f4269 100644

Re: [Openipmi-developer] Improving IPMI performance under load

2009-03-24 Thread Corey Minyard
Martin Wilck wrote: Hi Corey, yesterday I posted some results about the IPMI performance under CPU load, which can be up to 25 times slower than in an idle system. I think it might be worthwhile to try to improve that behavior as well. Yes, that would be expected, as kipmid would never

Re: [Openipmi-developer] Improving IPMI performance under load

2009-03-24 Thread Corey Minyard
Martin Wilck wrote: Corey Minyard wrote: I would guess that changing the nice value is the main thing that caused the difference. The other changes probably didn't make as big a difference. That's true, but setting the nice level to 0 isn't nice without kipmid_max_busy. The two

Re: [Openipmi-developer] BMC returned incorrect response

2009-03-11 Thread Corey Minyard
Mathieu ALORENT wrote: Hi, we've got this error on all our SUN V40Z systems. I don't know what does it mean.. [kern.warning] kernel IPMI message handler: BMC returned incorrect response, expected netfn 3b cmd 3c, got netfn 3a cmd 3c Can someone give me an explanation ? It appears to

Re: [Openipmi-developer] [PATCH] ipmi: reduce stack size of msghandler

2009-03-04 Thread Corey Minyard
Frank Seidel wrote: From: Frank Seidel fr...@f-seidel.de Reduce stack memory footprint in ipmi_msghandler for send_panic_events. (From 992 bytes on i386 down to below 100) I'm not sure this is a good idea. This only occurs in a panic situation, so it may be best to not dynamically

[Openipmi-developer] [PATCH 2/5] IPMI: Test for event buffer before using

2009-03-03 Thread Corey Minyard
The IPMI driver would attempt to use the event buffer even if that didn't exist on the BMC. This patch modified the IPMI driver to check for the event buffer's existence before trying to use it. Signed-off-by: Corey Minyard miny...@acm.org --- drivers/char/ipmi/ipmi_si_intf.c | 148

[Openipmi-developer] [PATCH 3/5] IPMI: Fix statistics counting issues

2009-03-03 Thread Corey Minyard
From: Corey Minyard cminy...@mvista.com Bela Lubkin noticed that the statistics for send IPMB and LAN commands in the IPMI driver could be incremented even if an error occurred. Move the increments to the proper place to avoid this. Also add some statistics for retransmissions that failed

[Openipmi-developer] [PATCH 4/5] IPMI: Add console oops catcher

2009-03-03 Thread Corey Minyard
. The number of entries for this output is limited by msg_limit paramter, and the default value is 100. Signed-off-by: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Signed-off-by: Corey Minyard cminy...@mvista.com --- v2 - v3: Use timestamp in first recode and every 10 seconds. v1 - v2: Add msg_limit

[Openipmi-developer] [PATCH 5/5] IPMI: Add oem message handling

2009-03-03 Thread Corey Minyard
From: dann frazier da...@hp.com Enable userspace to receive messages that a BMC transmits using an OEM medium. This is used by the HP iLO2. Based on code originally written by Patrick Schoeller. Signed-off-by: dann frazier da...@hp.com Signed-off-by: Corey Minyard cminy...@mvista.com

Re: [Openipmi-developer] [RFC v3] ipmi: introduce oops_console

2008-12-20 Thread Corey Minyard
Hiroshi Shimamoto wrote: Corey Minyard wrote: This is fine. Can you write a program to reconstruct the log from the SEL? Sure, will do. BTW, I'm not sure, which package will contain this program? In the kernel doc? ipmiutil? It would probably be best to tie into OpenIPMI

Re: [Openipmi-developer] [RFC v3] ipmi: introduce oops_console

2008-12-19 Thread Corey Minyard
This is fine. Can you write a program to reconstruct the log from the SEL? -corey Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Console messages on oops or panic are very important to investigate problem. Logging oops or panic messages to SEL is useful because

Re: [Openipmi-developer] perl binding documentation

2008-12-19 Thread Corey Minyard
Sorry I haven't responded to this. Did you look in the swig/perl directory? There's a bunch of sample and test code there. Not much documentation, you can look in swig/OpenIPMI.i for the interface, though. -corey Mark Seger wrote: More digging and I found the sample script in the openipmi

Re: [Openipmi-developer] Zircon PM connected to Marvell System Controller and MPC7448

2008-12-19 Thread Corey Minyard
I don't think ipmi_si will work, that's the driver for the standard system interfaces. I'm guessing it's a Katana. If so, your board connects to the PM over the I2C bus, and it does not use the IPMI-specified interface over I2C (because that didn't exist when the board was designed). If

Re: [Openipmi-developer] New kernel patches available

2008-12-10 Thread Corey Minyard
FYI, 2.6.26 patches are available. -corey Michael Ott wrote: Hi Corey! I finally figured out the problem with the serial coded and I've uploaded the patches for 2.6.27. Enjoy! One simple (;-)) question: Is it also possible to port it to the .26 kernel or the new

Re: [Openipmi-developer] RFC: logging oops messages to SEL

2008-12-09 Thread Corey Minyard
Hiroshi Shimamoto wrote: Hi all, I'd like to add a new feature to IPMI driver. New feature, IPMI oops console, is a console driver to log oops or panic messages to IPMI SEL. We can see the messages after receiving the system board returning from end user. Getting oops or panic messages is

[Openipmi-developer] New kernel patches available

2008-11-21 Thread Corey Minyard
I finally figured out the problem with the serial coded and I've uploaded the patches for 2.6.27. Enjoy! -corey - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based

Re: [Openipmi-developer] Unable to connect?

2008-11-07 Thread Corey Minyard
Can you try the following patch? I had a report of a similar problem and this fixed it. -corey (((ipmi-hacks IPMI_CONN_HACK_20_AS_MAIN_ADDR) (tmsg[3] == 0x20)) || ((! (ipmi-hacks IPMI_CONN_HACK_20_AS_MAIN_ADDR)) - (tmsg[3] ==

<    3   4   5   6   7   8   9   10   >