On 10/14/2010 08:07 PM, ykzhao wrote:
>
>> The way you are doing it, there is no need for a refcount, since you are
>> making a copy of the data.
>>
>> Is a copy or a pointer better? A pointer is generally preferred, it
>> keeps from having to either store data on the stack or dynamically
>> allo
Well, no, you are returning a pointer to something that is in the smi
data structure. For that you would need a refcount, because that
structure can cease to exist asynchronously to your code. Instead, just
pass in the structure you want to fill in. Like:
int ipmi_get_smi_info(int if_num, st
On 11/02/2010 12:33 AM, ykzhao wrote:
> On Thu, 2010-10-28 at 09:00 +0800, ykzhao wrote:
>
>> On Thu, 2010-10-28 at 00:13 +0800, Corey Minyard wrote:
>>
>>> I think you miss the point of a refcount. The refcount is to keep the
>>> data structure aro
On 12/13/2010 11:21 PM, Len Brown wrote:
> Corey,
> Most of the code is in drivers/acpi, but that depends on the ipmi part.
> Shall I take all three patches in the acpi-test tree?
>
> thanks,
> Len Brown, Intel Open Source Technology Center
>
I was trying to figure out what to do with these, so
Looks good to me.
Acked-by: Corey Minyard
On 12/17/2010 05:38 PM, dann frazier wrote:
> Signed-off-by: dann frazier
> ---
> drivers/char/ipmi/ipmi_watchdog.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_watchdog.c
This is almost certainly a bug in the BMC. The change in your patch
should have no effect, this is the start of a send, and the BMC
interface should be idle at that point, so doing an smi_timeout will
only result in another extraneous read from the IPMI interface (and of
course a slightly long
Huewe originally reported this patch and supplied a fix, I have
a different patch based on Linus' suggestion that cleans things up a
bit more.
KernelVersion: 2.6.37
Cc:
Cc:
Cc: Peter Huewe
Cc: Randy Dunlap
Signed-off-by: Corey Minyard
---
drivers/char/ipmi/ipmi_si_intf.c | 12 ++
This has been reported by others on different hardware, so I'm beginning
to think this is a problem in the driver.
-corey
On 02/09/2011 07:48 AM, mika.lansiri...@stonesoft.com wrote:
> Hello,
>
> We noticed recently that ipmitool started randomly having problems when we
> upgraded the kernel fro
Yeah, I should have noticed this.
Acked-by: Corey Minyard
On 02/14/2011 09:03 AM, Sergey Senozhatsky wrote:
> Hello,
>
> commit d2478521afc20227658a10a8c5c2bf1a2aa615b3
> Author: Corey Minyard
> Date: Thu Feb 10 16:08:38 2011 -0600
>
> char/ipmi: fix OOPS caused by
.6.36 kernel
Date: Mon, 21 Feb 2011 08:46:13 +
From: Doe, YiCheng
To: Corey Minyard , "Mingarelli, Thomas"
Hi Corey,
The only purpose to call smi_timeout() within the sender() function is to update the
"smi_info->last_timeout_jiffies" field to the current jiffie
On 02/24/2011 09:49 AM, Sandra Escandor wrote:
Hello,
I'm currently researching how to use OpenIPMI to obtain sensor
readings, specifically for an Intel Xeon 5500 CPU. I am wondering: Is
it possible to obtain this reading through OpenIPMI, or should I use
something else?
One of the reasons
On 03/10/2011 01:17 PM, Matthew Garrett wrote:
> On Thu, Mar 10, 2011 at 01:12:50PM -0600, Corey Minyard wrote:
>
>> +smi_info->last_timeout_jiffies ?iffies;
> Something looks mangled here? Otherwise, ACK.
>
I have no idea how that happened, but it wasn't that way
From: Doe, YiCheng
This patch fixes an issue in OpenIPMI module where sometimes an ABORT command
is sent after sending an IPMI request to BMC causing the IPMI request to fail.
Signed-off-by: YiCheng Doe
Signed-off-by: Corey Minyard
Acked-by: Tom Mingarelli
Tested-by: Andy Cress
Tested-by
From: Doe, YiCheng
This patch fixes an issue in OpenIPMI module where sometimes an ABORT command
is sent after sending an IPMI request to BMC causing the IPMI request to fail.
Signed-off-by: YiCheng Doe
Signed-off-by: Corey Minyard
Acked-by: Tom Mingarelli
Tested-by: Andy Cress
Tested-by
It should work automatically. Do you have python-dev installed?
On Apr 16, 2011 11:08 PM, "白白wong" wrote:
HI~
Who can provide the way to compiled openipmi-python module ?
when compiled OpenIPMI i give the
"--with-python=/usr/bin/python2.5
--with-pythoninstall=/usr/lib/python2.5/site-pac
Well, first of all, ipmitool is not part of the openipmi package, it is
a separate tool. But it's probably what you want.
You probably don't have the IPMI driver loaded or your board does not
have IPMI support. IIRC, RHEL 6 should automatically load the driver,
so my suspicion is the latter.
On 07/29/2011 03:50 AM, Bob Sauvage wrote:
Hello Jan and Corey,
First of all, thanks for the provided information.
The ipmi service is started :
*service ipmi status*
ipmi_msghandler module loaded.
ipmi_si module loaded.
ipmi_devintf module loaded.
/dev/ipmi0 does not exist.
*Modules are loa
si_irq_handler,
> - IRQF_SHARED | IRQF_DISABLED,
> + IRQF_SHARED,
>DEVICE_NAME,
> info);
> if (rv) {
>
Ok by me.
Acked-by: Corey Minyard
--
On 10/11/2011 04:02 PM, a...@nyi.net wrote:
So I have some ipmitool raw commands i run remotely against a host's
bmc, and wanted to code them via the python bindings (so i can more
frequent polling and then do further processing w/o forking ipmitool
over and over).
However the document
It's been a long time since I uploaded a version of OpenIPMI, and there
are some little bug fixes pending. Most of the changes are due to
autotools changes, though I found a couple of little bugs today playing
with the python script I just sent out.
-corey
not much documentation help for writing
simple things.
>
> I was hoping someone had some simple sample code that took a
> username/password/ip for the bmc, and i could hard-code the hex
> queries into the code and adapt it to the rest of my needs.
The "sample2.py" program
This is fine, if it is really necessary to make slow hardware work.
I've pulled it in, I'll submit in a bit.
-corey
On 12/14/2011 03:12 PM, Matthew Garrett wrote:
> Ping?
>
> On Wed, Nov 30, 2011 at 02:12:27PM -0500, Matthew Garrett wrote:
>> We currently time out and retry KCS transactions aft
shown explicitly in the flow diagrams. A
five-second timeout or greater is recommended". Change the timeout to five
seconds to satisfy the slow hardware.
From: Matthew Garrett
Signed-off-by: Matthew Garrett
Signed-off-by: Corey Minyard
---
drivers/char/ipmi/ipmi_kcs_sm.c |4 ++--
1 files
refcounts.
Signed-off-by: Corey Minyard
---
drivers/char/ipmi/ipmi_msghandler.c | 103 ---
drivers/char/ipmi/ipmi_watchdog.c | 17 ---
2 files changed, 56 insertions(+), 64 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c
b/drivers
Now that the the IPMI driver is using a tasklet, we can simplify
the locking in the driver and get rid of the message lock.
Signed-off-by: Corey Minyard
---
drivers/char/ipmi/ipmi_si_intf.c | 54 ++---
1 files changed, 21 insertions(+), 33 deletions(-)
diff
The IPMI driver would release a lock, deliver a message, then relock.
This is obviously ugly, and this patch converts the message handler
interface to use a tasklet to schedule work. This lets the receive
handler be called from an interrupt handler with interrupts enabled.
Signed-off-by: Corey
The IPMI watchdog timer clears or extends the timer on reboot/shutdown.
It was using the non-locking routine for setting the watchdog timer, but
this was causing race conditions. Instead, use the locking version to
avoid the races. It seems to work fine.
Signed-off-by: Corey Minyard
From: Srinivas_Gowda
Call the event handler immediately after starting the next message.
This change considerably decreases the IPMI transaction time (cuts off
~9ms for a single ipmitool transaction).
From: Srinivas_Gowda
Signed-off-by: Srinivas_Gowda
Signed-off-by: Corey Minyard
On 02/03/2012 01:44 PM, Andrew Morton wrote:
> On Fri, 03 Feb 2012 09:47:56 -0600
> Corey Minyard wrote:
>
>> The IPMI driver would release a lock, deliver a message, then relock.
>> This is obviously ugly, and this patch converts the message handler
>> interface to use
You don't mention the kernel version or anything of that nature. There
was a bug fixed a while back for something that looked like this.
-corey
On 04/05/2012 09:15 PM, dbashaw wrote:
> I have two IPMI users created using ipmi_create_user(..).
> Each user can send messages async with respect to
On 06/26/2012 09:33 PM, dbashaw wrote:
> I have a question about using ipmi_watchdog, ipmitool, and another open
> source program ipmisensors together
> at the same time.
>
> ipmitool uses the /dev/ipmi0 char interface. So does (can)
> ipmi_watchdog. ipmisensors uses ipmi_settime(..) to send
> mess
Srinivas, what is your use case?
-corey
On 06/28/2012 07:01 PM, Andi Kleen wrote:
> writes:
>> +
>> +data[0] = param_select;
>> +data[1] = set_selector;
>> +data[2] = string_encode;
>> +data[3] = str_len;
>> +data[4] = 'L';
>> +data[5] = 'i';
>> +data[6] = 'n';
>>
On 06/29/2012 07:30 AM, Matthew Garrett wrote:
> On Thu, Jun 28, 2012 at 05:01:54PM -0700, Andi Kleen wrote:
>> Not sure that's all that useful. I can just see BMC's making the ACPI
>> mistake of trying to work around specific issues, by checking for
>> Linux.
I'm not sure I see that happening, bu
On 07/04/2012 07:17 AM, Andi Kleen wrote:
>> Rather than just have a static entry such as 'Linux' I could probably write
>> the version number and more(distro name etc.. )
>>
>> Thoughts.. ?
> I still think "Linux" means nothing even to the management software.
> What should it do with that?
>
> I
Looks fine to me.
Acked-by: Corey Minyard
On 07/06/2012 03:02 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> The legacy PM callbacks provided by the IPMI PCI driver are
> empty routines returning 0, so they can be safely dropped.
>
> Signed-off-by:
I just got tired of using CVS, so I finally converted the repository
over to git. It's a lot nicer to use. I've imported all the history.
If I had known it would be that easy, I would have done it earlier.
I've also added a kernel git repository with the kernel patches. This
should make it e
On 09/18/2012 12:47 PM, David Bashaw wrote:
>
> I have a 2.6.32 kernel running on two different machines.
>
> The init messages look different and I’m not sure why.
>
> Machine A:
>
> IPMI System Interface driver.
>
> ipmi_si: Adding SMBIOS-specified kcs state machine
>
> ipmi_si: Trying SMBIOS-spe
I while ago I moved to keeping the IPMI driver updates in a git
repository. Unfortunately, I didn't tell anyone.
So, access to the IPMI driver for newer versions of the kernel is
currently available at
git//openipmi.git.sourceforge.net/gitroot/openipmi/linux-ipmi under
obvious branch names (
On 10/22/2012 06:49 PM, Andrew Morton wrote:
> On Tue, 16 Oct 2012 15:53:39 -0500
> miny...@acm.org wrote:
>
>> From: Corey Minyard
>>
>> There was a spot where the compiler couldn't tell some variables
>> would be set. So initialize them to make the warni
On 12/02/2012 08:59 PM, Lu, Lianhao wrote:
> Hi guys,
>
> Is there any plan to put openipmi python binding to
> http://pypi.python.org/pypi, so the users can easily install the OpenIPMI
> python module through pip? Some distributions(i.e. Ubuntu, etc.) don't
> provide its native package for the
Well, the built-in driver works on systems that have more than one interface
and more than one BMC, and multiple IPMBs (and all of the other channel
types for that matter, and the driver handles all the multiplexing and nasty
addressing). There is, in fact, no arbitrary limit, and IBM tested
this
On 12/14/2012 10:25 AM, Evans, Robert wrote:
> Corey,
>
> Thanks for the thoughtful reply. Below I respond in detail to
> these three points.
>
> 1) Why building a variant kernel with ipmi_si as a module is not
> feasible.
>
> 2) User mode access to IPMI on Stratus systems (e.g. ipmitool).
>
>
Sorry, I missed this. What version of Linux? I believe this has been
fixed a while ago, but you may not have the fix.
-corey
On 03/01/2013 05:08 PM, David Bashaw wrote:
> I sent this some time ago. Is anyone still actively working IPMI bugs?
> I would like to make some progress on this issue.
P_KERNEL);
> if (!entry->name) {
> kfree(entry);
> return -ENOMEM;
> }
> - strcpy(entry->name, name);
>
> file = proc_create_data(name, 0, smi->proc_dir, proc_ops, data);
> if (!file) {
Looks good to me.
Acked-by: Corey Minyard
On 03/16/2013 09:16 AM, Alexandru Gheorghiu wrote:
> Replaced calls to kmalloc followed by strcpy with a sincle call to kstrdup.
> Patch found using coccinelle.
>
> Signed-off-by: Alexandru Gheorghiu
> ---
> drivers/char/ipmi/ipmi_msghandler.c |3 +--
> 1 file changed, 1 insertion(+), 2 del
Yes, this is correct, I've pulled it into my tree.
-corey
On 03/29/2013 02:18 AM, Chen Gang wrote:
>when calling memcpy, read_data and write_data need additional 2 bytes.
>
>write_data:
> for checking: "if (size > IPMI_MAX_MSG_LENGTH)"
> for operating: "memcpy(bt->write_data +
On 05/09/2013 04:00 PM, Andy Lutomirski wrote:
> IPMI in polled mode sucks enough that this warning is alarming:
>
> ipmi_si ipmi_si.0: Could not enable interrupts, failed set, using polled mode.
>
> On two of my Dell gen 7 (I think) servers, this warning prints, but
> IPMI uses interrupts. Can th
On 05/10/2013 01:31 PM, Andy Lutomirski wrote:
> On Fri, May 10, 2013 at 5:16 AM, Corey Minyard wrote:
>> On 05/09/2013 04:00 PM, Andy Lutomirski wrote:
>>> IPMI in polled mode sucks enough that this warning is alarming:
>>>
>>> ipmi_si ipmi_si.0: Could not
On 05/10/2013 01:47 PM, Andy Lutomirski wrote:
> On Fri, May 10, 2013 at 11:45 AM, Corey Minyard wrote:
>> On 05/10/2013 01:31 PM, Andy Lutomirski wrote:
>>> On Fri, May 10, 2013 at 5:16 AM, Corey Minyard
>>> wrote:
>>>> On 05/09/2013 04:00 PM, Andy Luto
Yes, you are right. I've pulled this in to my tree. Looking at this,
ipmi_mutex really should go away and be replaced bu something that
scales better, but I guess it's not that critical for IPMI.
-corey
On 05/13/2013 02:39 PM, Benjamin LaHaise wrote:
> When a 32 bit version of ipmitool is use
When the interrupt enable message returns an error, the messages are
not entirely accurate nor helpful. So improve them.
Signed-off-by: Corey Minyard
Cc: Andy Lutomirski
---
drivers/char/ipmi/ipmi_si_intf.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git
quot;if (msg_len < 3 || msg_len > IPMI_MAX_MSG_LENGTH)"
for operating: "memcpy(data + 2, bt->read_data + 4, msg_len - 2)"
Signed-off-by: Chen Gang
Signed-off-by: Corey Minyard
Cc: sta...@vger.kernel.org
---
drivers/char/ipmi/ipmi_bt_sm.c |4 ++--
1 file changed, 2 insert
From: Alexandru Gheorghiu
Replaced calls to kmalloc followed by strcpy with a sincle call to kstrdup.
Patch found using coccinelle.
Signed-off-by: Alexandru Gheorghiu
Signed-off-by: Corey Minyard
---
drivers/char/ipmi/ipmi_msghandler.c |3 +--
1 file changed, 1 insertion(+), 2 deletions
ipmi_mutex to fix this.
Signed-off-by: Benjamin LaHaise
Signed-off-by: Corey Minyard
Cc: sta...@vger.kernel.org
---
drivers/char/ipmi/ipmi_devintf.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
Some minor fixes I had queued up. The last one came in recently (patch 4)
and it and patch 2 are candidates for stable-kernel.
--
AlienVault Unified Security Management (USM) platform delivers complete
security visibili
On 05/16/2013 05:23 PM, Andy Lutomirski wrote:
>
> /* We got the flags from the SMI, now handle them. */
> smi_info->handlers->get_result(smi_info->si_sm, msg, 4);
> - if (msg[2] != 0)
> - dev_warn(smi_info->dev, "Could not enabl
On 05/31/2013 07:46 AM, Dan Carpenter wrote:
> On x86_64 there is a 4 byte hole between ->recv_type and ->addr.
Got it, in my tree now. Thanks.
>
> Signed-off-by: Dan Carpenter
> ---
> v2: fixed the changelog a little. Also added LKML because the
> openipmi is a moderated list (and the moderat
On 06/03/2013 08:21 AM, Arvind Kumar wrote:
> m trying to ./configure openipmi2.0.20
> but always getting error as "Could not find headers for the popt library"
A better subject would help keep this from getting tagged as spam.
You need to install the popt-dev package on your system. How to do t
Thanks, I've applied it.
I also increased the size of the msg map to 32 bits with the attached patch.
-corey
On 06/13/2013 03:10 AM, Nikita Yushchenko wrote:
Hi.
I was running OpenIPMI against not-properly-behaving BMC, and discovered a
problem in incoming packet sequence number checking.
At
Ok, it's in my queue. Sorry I missed this earlier.
-corey
On 07/16/2013 10:00 AM, jordan_hargr...@dell.com wrote:
> I'd submitted this about a year ago but it never made it upstream.
>
> The latest versions of the kernel drivers for ipmi can use ACPI to
> determine the type of BMC device used in
On 07/25/2013 07:06 AM, Rafael J. Wysocki wrote:
> On Thursday, July 25, 2013 03:09:35 AM Zheng, Lv wrote:
>> -stable according to the previous conversation.
>>
>>> From: Rafael J. Wysocki [mailto:r...@sisk.pl]
>>> Sent: Thursday, July 25, 2013 7:38 AM
>>>
>>> On Tuesday, July 23, 2013 04:09:15 PM
On 07/25/2013 07:16 PM, Zheng, Lv wrote:
>>
>> If I understand this correctly, the problem would be if:
>>
>> rem_time = wait_for_completion_timeout(&tx_msg->tx_complete,
>> IPMI_TIMEOUT);
>>
>> returns on a timeout, then checks msg_done and races with some
Ok, I have it in my tree. Rolf mentioned a few cleanup things, but this
is consistent with what is already there. I should clean up all the
things Rolf talked about in all the cases.
Thanks,
-corey
On 07/30/2013 04:13 PM, Thomas Bogendoerfer wrote:
> The last line of PARISC machines (C8000,
On 08/25/2013 11:47 PM, Nikita Yushchenko wrote:
> Hi
>
> Has anyone ever tried to implement firmware upgrade per HPM.1 specification
> on top of openipmi library?
>
> WBR,
> Nikita Yushchenko
>
Firmware upgrades are all custom commands, and nobody has submitted
anything on that. I do not have ac
This is good. I have applied and pushed, thank you.
-corey
On 08/27/2013 05:59 AM, Nikita Yushchenko wrote:
> Hi
>
> Here is a patch against openipmi master branch, that fixes error handling
> in auth_cap_done() routine, making it in line with other similar routines.
>
> Without this patch, in c
Ok, patch is applied.
Also, I see that this is going to be racy and needs a lock. I'll work
on that.
-corey
On 08/28/2013 02:17 AM, Nikita Yushchenko wrote:
> Hi
>
> Just found a bug in stop_timer() in unix/posix_thread_os_hnd.c
>
> Looks like the same was once fixed in unix/posix_os_hnd.c, bu
I just uploaded an rc2 version, can you try that?
Thanks,
-corey
On 08/30/2013 12:46 AM, Rishi Kaundinya Mutnuru wrote:
> Hi,
> I have downladed OpenIPMI-2.0.20-rc1 and tried using for developing a
> hardware monitoring tool.
> I am facing
> compilation issues on ubuntu 12.04 host. I am snippin
undinya Mutnuru wrote:
> Hi Corey,
> I couldn't see rc3 yet. Can you please send me the location for download.
> Also, please send me the pointer to the distribution for ubuntu 12.04.
>
> Thanks,
> Rishi
>
>
> -Original Message-
> From: Corey Minyard [mai
openipmi/files/OpenIPMI%202.0%20Library/ ?
I don't do RPMs or debs or anything like that. That means I'd have to
have a boatload of distros and do a bunch of work each release. That's
really not feasible.
-corey
> Thank you very much,
> Regards,
> Rishi
>
>
> -
this will be useful for many developers across globe.
> I am curious to know the diff and patch for this. Can you point me the diff
> or fix done.
>
> Thanks,
> Rishi
>
>
> -Original Message-
> From: Corey Minyard [mailto:tcminy...@gmail.com]
> Sent: Friday, Aug
-DPIC -o .libs/string.o
> string.c:56:34: fatal error: OpenIPMI/ipmi_string.h: No such file or directory
> compilation terminated.
> make[2]: *** [string.lo] Error 1
> make[2]: Leaving directory `/home/jab/OpenIPMI2/OpenIPMI-2.0.20-rc2/utils'
>
> -Original Message-
&g
There is sample code in the "samples" directory that shows a lot of
this. If you just want to periodically query a single sensor, openipmi
is probably overkill and ipmitool would be simpler. If you want to
continuously monitor a bunch of sensors or a large number of systems,
the openipmi is p
y
>
> Thanks,
> Rishi
>
> -----Original Message-
> From: Corey Minyard [mailto:tcminy...@gmail.com]
> Sent: Friday, September 06, 2013 8:21 PM
> To: Rishi Kaundinya Mutnuru
> Cc: openipmi-developer@lists.sourceforge.net
> Subject: Re: [Openipmi-developer] Power Supply
On 09/10/2013 04:09 PM, Rishi Kaundinya Mutnuru wrote:
> Hi Corey,
> Can you tell me how do I get the message trace.
Include ipmi_debug.h and add:
DEBUG_MSG_ENABLE();
to your code before you init.
-corey
>
> Regards,
> Rishi
>
>
> -Original Message-----
> From: C
It won't call done until, well, it's done. That may take a while, and
since it can't get the SDRs, it's going to fail and never be done. There
is another callback for connection up/down. But there's something going
on with your BMC, either something else is getting SDRs all the time, or
there's
It goes the the standard log output, as debug logs.
-corey
On 09/10/2013 06:12 PM, Rishi Kaundinya Mutnuru wrote:
> Hi Corey,
> Where does the messages go after I keep DEBUG_MSG_ENABLE in my daemon?
>
> Thanks,
> Rishi
>
> -Original Message-
> From: Core
On 09/11/2013 12:41 PM, Tony Camuso wrote:
> Corey,
>
> Is there a git tree for the ipmi driver I can fetch?
>
> Thanks,
> Tony
Yes, it's on Sourceforge, the web page for it is
https://sourceforge.net/p/openipmi/linux-ipmi/ci/master/tree/
master-ipmi-rebase is the branch I rebase to track k.org.
On 09/11/2013 01:34 PM, Tony Camuso wrote:
> On 09/11/2013 01:54 PM, Corey Minyard wrote:
>> On 09/11/2013 12:41 PM, Tony Camuso wrote:
>>> Corey,
>>>
>>> Is there a git tree for the ipmi driver I can fetch?
>>>
>>> Thanks,
>>> Ton
Sorry, I didn't respond to an earlier message you sent.
That should be mostly fine. You need a log handlers, and the output of
that may tell you what is going wrong.
-corey
On 09/15/2013 01:29 AM, Rishi Kaundinya Mutnuru wrote:
> Hi Corey,
> I am invoking the OpenIPMI routines by linking the lib
Sorry for the long delay on this. I will certainly take such patches.
If you can auto-detect and develop white/black lists, that would be even
better.
Thanks,
-corey
On 08/28/2013 12:31 AM, Nikita Yushchenko wrote:
> Hello
>
> Hardware I currently deal with has issues that force me to patch op
On 08/28/2013 09:07 AM, Nikita Yushchenko wrote:
> Hi
>
> I'm trying to handle 'invalid user' and 'invalid password' errors in
> openipmi-based application.
>
> I've found how I can detect 'invalid user'.In this case, error passed to
> connection callback is either 0x181 or 0x20d, dependi
Applied, thank you.
-corey
On 09/24/2013 11:21 PM, Nikita Yushchenko wrote:
>>> With RMCP+, there is EINVAL, originatiing from
>>>
>>> if (memcmp(data+40, integ_data, rinfo->key_len) != 0)
>>> return EINVAL;
>>>
>>> in rakp_hmac_c2().
>>>
>>> I suggest to replace this EINVAL with
Got it, thanks. I added a header to the new file.
-corey
On 10/10/2013 05:33 AM, Lashenko, George wrote:
> Dear Developers,
>
> I've encountered a problem in OpenIPMI something I see as a bug, the issue is
> that the library uses gettimeofday as its source for creating timeouts
>
> this can cau
Actually, this patch was broken. It didn't pass the test. You have to
modify the condition variables to use monotonic time, or condwait will
be broken.
I've completely rewritten this patch, but it was an important change and
needed to be done. Changes are now in git.
-corey
On 10/10/2013 05:3
Thanks, it's in the queue.
-corey
On 10/12/2013 10:59 PM, Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker
> ---
> drivers/char/ipmi/ipmi_si_intf.c | 4 +
On 11/05/2013 07:56 AM, Michael S. Tsirkin wrote:
> On Wed, May 29, 2013 at 05:07:56PM -0500, miny...@acm.org wrote:
>> I have finally gotten some time to work on this, this series of
>> patches adds an IPMI interface to qemu. The changes are roughly:
>>
>> patches 01-05 - Add the capability to ha
On 11/05/2013 10:09 AM, Andreas Färber wrote:
> Hi,
>
> Am 05.11.2013 14:56, schrieb Michael S. Tsirkin:
>> On Wed, May 29, 2013 at 05:07:56PM -0500, miny...@acm.org wrote:
>>> I have finally gotten some time to work on this, this series of
>>> patches adds an IPMI interface to qemu. The changes a
That shouldn't happen. Did you deregister the user when you removed the
module?
Actually, that doesn't seem to be it:
[] ? do_page_fault+0x3e/0xa0
[] ? page_fault+0x25/0x30
[] ? misc_register+0x4c/0x170
[] ? misc_register+0x27/0x170
[] ? sce_new_smi+0x74/0x10c [ipmi_sce_
On 11/22/2013 09:18 AM, Aleksandrs Saveljevs wrote:
> Good morning,
>
> We noticed that OpenIPMI versions 2.0.16 through 2.0.18 append "0" to
> discrete sensor names. Here is an example to illustrate that:
>
> $ ipmitool -U ... -P ... -I lan -H ... -L user sensor | grep
> Processor.Status | cut -
On 12/09/2013 03:31 AM, Michael Opdenacker wrote:
> Hi Corey,
>
> On 10/13/2013 09:45 PM, Corey Minyard wrote:
>> Thanks, it's in the queue.
>>
>> -corey
>>
>> On 10/12/2013 10:59 PM, Michael Opdenacker wrote:
>>> This patch proposes to remove
Both look good, thank you. I've queued them for the next window.
-corey
On 12/12/2013 08:36 PM, Xie XiuQi wrote:
> Hu Shiyuan report, when loading ipmi_si module while bmc is
> disconnected, we found the timeout is longer than 5 secs.
> Actually it takes about 3 mins and 20 secs (HZ=250).
>
> er
On 12/17/2013 09:38 AM, Florian Pritz wrote:
> Hi,
>
> Just set up the watchdog on an Intel S1200RP board and I keep getting
> errors in dmesg, but "ipmitool mc watchdog get" gives the following
> output (present countdown is always >590 sec as I'd expect).
>
>> Watchdog Timer Use: SMS/OS (0x44
All the patches except one are correct and applied. Thanks for the
fixes. I need to get a formal release out soon, and this was a good
addition.
The following patch is incorrect. It was caught by some automatic
printf checker, but the call here doesn't exactly match printf
semantics. So please
The library already runs on ARM Linux and is tested. The driver should
work, too, though I don't know of any current ARM platforms that support
and IPMI interface. What exactly are you trying to do?
-corey
On 01/14/2014 08:08 PM, Frank W. Miller wrote:
>
> Greetings,
>
> I'm considering por
gement controller on that processor.
-corey
>
> I'll try building it in.
>
> Thanks,
> FM
>
>
> -----Original Message-
> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard
> Sent: Tuesday, January 14, 2014 8:37 PM
> To: Fr
I didn't realize it, but the rework to modernize the autoconf file
caused the tarball and directory names to be downcased from OpenIPMI to
openipmi. I've fixed the issue and uploaded a new version of
OpenIPMI-2.0.20 that is correctly named. Sorry about that. I didn't
even notice when uploading i
e: each undeclared identifier is
> reported only once for each function it appears in
>
> Introduced by commit d02b3709ff8efebfca0612d0ac2a6e31a91c13f4 ("ipmi:
> Cleanup error return")
>
> Signed-off-by: Geert Uytterhoeven
Dang it. Yes, you are right, of course.
A
I don't really understand the error that is happening. I see that it
continues to time out, but I don't know why. If you can get in to this
situation here, it makes me worried that there is some other issue.
issuing the warm reset, even if the command is not supported, should be
harmless. Maybe
On 02/24/2014 10:53 AM, Dmitry Torokhov wrote:
> Hi Corey,
>
> On Sun, Feb 23, 2014 at 08:23:34PM -0600, miny...@acm.org wrote:
> Would not
>
> static bool si_trydefaults =
> IS_ENABLED(CONFIG_IPMI_SI_PROBE_DEFAULTS);
>
> work better here?
>
> Thanks.
>
Certainly. I will update it. Than
On 02/24/2014 10:57 AM, Dmitry Torokhov wrote:
> On Sun, Feb 23, 2014 at 08:23:35PM -0600, miny...@acm.org wrote:
>> @@ -1194,7 +1223,17 @@ int ipmi_set_gets_events(ipmi_user_t user, int val)
>> INIT_LIST_HEAD(&msgs);
>>
>> spin_lock_irqsave(&intf->events_lock, flags);
>> -user->get
1 - 100 of 1387 matches
Mail list logo
