Re: Marlin-Renderer and JavaFX

2016-11-09 Thread Tobias Bley
Do you have started any parallelization? > Am 10.11.2016 um 01:02 schrieb Felix Bembrick : > > If you want to know how to parallelise the JavaFX pipeline (or how it's > already been done with amazing results) then talk to me. > > If, of course, this email gets

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-09 Thread Tom Schindl
Hi, Might be dumb questions but Did you try that this doesn't interfere with stages who have been created with StageStyle.TRANSPARENT? What happens if i set the Scene.fill to an rgba value? Doesn't this lead to a different color than what you get today where the background stage background

[9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-09 Thread Chien Yang
Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8088179/webrev.00/ Thanks, - Chien

Re: Marlin-Renderer and JavaFX

2016-11-09 Thread Felix Bembrick
> On 10 Nov. 2016, at 10:27, Jim Graham wrote: > > On 10/20/16 5:34 AM, Kevin Rushforth wrote: >>> For now the OpenPiscesRasterizer class uses a static Renderer (single >>> instance) so it is single-threaded. >>> >>> In MarlinFX I could prepare the multi-threading

Re: Marlin-Renderer and JavaFX

2016-11-09 Thread Felix Bembrick
If you want to know how to parallelise the JavaFX pipeline (or how it's already been done with amazing results) then talk to me. If, of course, this email gets moderated... > On 10 Nov. 2016, at 10:57, Felix Bembrick wrote: > > > >> On 10 Nov. 2016, at 10:27, Jim

Re: Fwd: Re: Marlin-Renderer and JavaFX

2016-11-09 Thread Jim Graham
Hi Laurent, Great job on creating a very obvious minimal impact! That should help streamline it through the approval process. Is MarlinProperties.isEnabled still used? (Searching patch file - no, I don't think so) Kevin and I had a long back and forth over the packaging of the Reentrant

Re: Fwd: Re: Marlin-Renderer and JavaFX

2016-11-09 Thread Jim Graham
Going forward perhaps we should refer to the version of Marlin in Java2D as Marlin2D? Then Marlin is your original plug-in version that is still being worked on. Marlin2D is what you integrated into OpenJDK/Java2D. MarlinFX is what you are planning for FX. That's just for conversational

Re: Fwd: Re: Marlin-Renderer and JavaFX

2016-11-09 Thread Jim Graham
On 10/21/16 9:51 AM, Laurent Bourgès wrote: Jim, do you think possible to unify Marlin and MarlinFX for openjdk9 ? The main difference relies in different Shape/PathConsumer classes and Fx uses the AlphaConsumer + different initialization. Did you have a look at the diffs ? One of the big

Re: Fwd: Re: Marlin-Renderer and JavaFX

2016-11-09 Thread Jim Graham
On 10/20/16 5:34 AM, Kevin Rushforth wrote: For now the OpenPiscesRasterizer class uses a static Renderer (single instance) so it is single-threaded. In MarlinFX I could prepare the multi-threading support by using 1 RendererContext per thread (ThreadLocal) as I did in Marlin for java2d.

review: correct concatenation of dependencies/*/*.extra files

2016-11-09 Thread David Hill
Kevin, if you would review JBS: https://bugs.openjdk.java.net/browse/JDK-8169511 diff inline. -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: JDK-8163078 ArrayIndexOutOfBounds is thrown in Parent.updateCachedBounds

2016-11-09 Thread Stefan Fuchs
Hi Daniel, are you registering or removing the listeners on a thread other than the JavaFX Application Thread? I think the Observables are not thread save. -- regards Stefan Hi guys, We're facing an exception triggered from Parent.updateCachedBounds. I've pasted the stack trace below.

Re: ACTION - JavaFX modular build is here

2016-11-09 Thread Kevin Rushforth
Yes, it is somewhat tricky to add a new qualified export. I would expect that to be rare. For JDK 9 let's go with the public API since it will be fewer moving parts. -- Kevin Laurent Bourgès wrote: Kevin & David, It seems tricky to add a module dependency ! 2016-11-09 14:51 GMT+01:00

Re: ACTION - JavaFX modular build is here

2016-11-09 Thread Laurent Bourgès
Kevin & David, It seems tricky to add a module dependency ! 2016-11-09 14:51 GMT+01:00 Kevin Rushforth : > My recommendation would be to avoid this dependency if possible, but if > not, then Dave's suggestion is the way to go. What is it that you need from >