On Thu, 5 Dec 2019 12:16:53 GMT, Johan Vos wrote:
>> The pull request has been updated with 1 additional commit.
>
> Works as expected. I recommend removing gtk-specific flags in the launcher.
> Works as expected. I recommend removing gtk-specific flags in the launcher.
Hi Johan, The PR is upd
Issue: NPE in GlassScene.frameRendered().
Cause: scenePaintListener is set in setTKScenePaintListener(), used in
frameRendered() and
set to null in dispose().
setTKScenePaintListener() and dispose() are called on JavaFX Application Thread
and
frameRendered() is called by QuantumRenderer thread
> https://bugs.openjdk.java.net/browse/JDK-8232811
>
> This one was hard to tackle.
>
> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest
The pull request has been updated with 1 additional commit.
-
Ad
> https://bugs.openjdk.java.net/browse/JDK-8232811
>
> This one was hard to tackle.
>
> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest
The pull request has been updated with 1 additional commit.
-
Ad
Well, git blames Antem Ananiev - not sure you're around this list.
Question 1 - Why can't we use gtk_window_set_resizable () ?
Question 2 - Why do we keep separated geometry and not use gtk directly?
Thanks.
On Mon, 9 Dec 2019 21:01:40 GMT, Kevin Rushforth wrote:
>> The fix looks good to me.
>>
>> I left a few minor comments, including adding a missing comma in the API
>> docs, which will also need to be changed in the CSR. Once this is updated
>> I'll review the CSR and then you can move the CSR
Thanks for the heads-up. Let us know what you find.
-- Kevin
On 12/9/2019 1:13 PM, Dirk Lemmermann wrote:
Hi,
I just noticed that the timeline in FlexGanttFX does not get rendered correctly
anymore after updating to 14-ea+4. The borders around the date cells
disappeared.
I assume that this
Hi,
I just noticed that the timeline in FlexGanttFX does not get rendered correctly
anymore after updating to 14-ea+4. The borders around the date cells
disappeared.
I assume that this must be somehow related to the CSS fix that made it into
this version.
This is just a heads-up. If possible
On Mon, 9 Dec 2019 20:58:28 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> The fix looks good to me.
>
> I left a few minor comments, including adding a missing comma in the API
> docs, which will also need to be changed in the CSR. Once this is
On Mon, 9 Dec 2019 20:58:46 GMT, Hadzic Samir wrote:
>> Allright, this is a fix for JDK-8207957
>
> The pull request has been updated with 1 additional commit.
The fix looks good to me.
I left a few minor comments, including adding a missing comma in the API docs,
which will also need to be c
It depends. Some cleanup like this can be good if it reduces overall
maintenance going forward. In many cases, though, it would take more
effort to get it reviewed and prove that there aren't any regressions
than it is worth. In particular, I don't think there is high value in
the sort of autom
While going across the source code I have noticed some code that might be
incorrect , such as:
- WindowStage.setScene() has a call to requestFocus()
I might be missing something, but I think it does not belong there because the
scene is usually set before show(), and while it may be set after t
https://bugs.openjdk.java.net/browse/JDK-8232811
This one was hard to tackle.
./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest
-
Commits:
- 338bedbe: Fix mistake
- a02894d6: Fix JDK-8232811
- 7a23cdbd:
Thanks for the cleanup :)
Zitat von Kevin Rushforth :
I was planning to do that this morning (I was going to do it Friday
afternoon, but ran into the JBS maintenance window, and then ran out
of time). They actually had turned it on before the below bug was
integrated, but there was a con
I was planning to do that this morning (I was going to do it Friday
afternoon, but ran into the JBS maintenance window, and then ran out of
time). They actually had turned it on before the below bug was
integrated, but there was a configuration error in the Skara bot that
prevented it from work
This bug can be reproduced when the screen resolution is at 125%, 150% and 175%
for Windows, which correpsonds to `pixelScale` values of 1.25, 1.5 and 1.75,
respectively.
Issue: The rectangle inside canvas is rendered on `pixelScale` while the
borders are rendered on `Math.ceil(pixelScale)`
Fi
Zitat von Kevin Rushforth :
The plan is to put this into place tomorrow (Friday, Dec 6) and test
drive it for a week or two so that the Skara team can get feedback
on how it is working for our project (they already use it for the
Skara project).
hmm .. looks like https://github.com/op
Changeset: 71ca899f
Author:Jeanette Winzenburg
Committer: Ajit Ghaisas
Date: 2019-12-09 08:08:34 +
URL: https://git.openjdk.java.net/jfx/commit/71ca899f
8220722: ProgressBarSkin: adds strong listener to control's width property
Reviewed-by: aghaisas, arapte
!
modules/javafx
18 matches
Mail list logo
