Re: RFR: 8181775: JavaFX WebView does not calculate border-radius properly

2020-05-15 Thread Kevin Rushforth
On Thu, 14 May 2020 08:15:19 GMT, Bhawesh Choudhary wrote: > root cause of issue is prism's fillRoundedRect() API doesn't allow rendering > of rounded corner rectangle if four > corners have different radii. but same can be achieved via Path. to fix the > issue, in GraphicsContextJava.cpp whil

Re: RFR: 8208169: can not print selected pages of web page

2020-05-15 Thread Kevin Rushforth
On Fri, 15 May 2020 16:36:29 GMT, Bhawesh Choudhary wrote: > Print function of WebEngine.java ignores page range setting and prints given > number of pages starting from first page, > which is the root cause of this issue. To fix it, put check for page ranges > and if it available, use it for

RFR: 8208169: can not print selected pages of web page

2020-05-15 Thread Bhawesh Choudhary
Print function of WebEngine.java ignores page range setting and prints given number of pages starting from first page, which is the root cause of this issue. To fix it, put check for page ranges and if it available, use it for printing pages otherwise print all pages as usual. - Com

Re: RFR: 8169501: GIF animation is too fast

2020-05-15 Thread Kevin Rushforth
On Fri, 15 May 2020 07:42:40 GMT, Bhawesh Choudhary wrote: > issue is caused by the threshold value for frame duration used by javaFx > before it gets normalized. JavaFx is using > threshold value 10 while other browser (Safari, Firefox) is using 50 due to > which, value between 10 and 50 don'

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-15 Thread Jeanette Winzenburg
On Thu, 14 May 2020 19:22:54 GMT, Abhinay Agarwal wrote: > In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > c

Re: RFR: 8244824: TableView : Incorrect German translation

2020-05-15 Thread Jeanette Winzenburg
On Fri, 15 May 2020 06:49:04 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 > > Fix : As simple as it gets !!! Correct :) - Marked as reviewed by fastegal (Author). PR: https://git.openjdk.java.net/jfx/pull/220

Re: [Rev 01] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar

2020-05-15 Thread Jeanette Winzenburg
On Fri, 15 May 2020 09:19:19 GMT, Ajit Ghaisas wrote: >> Hmm .. re-reading my comment: was assuming and then formulating round a >> corner, sry. Will try again >> >> My assumption (from the method implementation before the fix) was that the >> method expects only valid indices (either -1 >> or

Re: [Rev 01] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar

2020-05-15 Thread Ajit Ghaisas
On Wed, 13 May 2020 10:42:41 GMT, Jeanette Winzenburg wrote: >> This was the place where exception was occurring. Hence, I added this check. >> When I ran against the test, I still got the exception at caller lambda. I >> added that check later. >> Wanted to remove this check - but simple code

RFR: 8169501: GIF animation is too fast

2020-05-15 Thread Bhawesh Choudhary
issue is caused by the threshold value for frame duration used by javaFx before it gets normalized. JavaFx is using threshold value 10 while other browser (Safari, Firefox) is using 50 due to which, value between 10 and 50 don't get normalized and animation runs at faster speed. To fix the issue

Re: RFR: 8244824: TableView : Incorrect German translation

2020-05-15 Thread danielpeintner
On Fri, 15 May 2020 06:49:04 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 > > Fix : As simple as it gets !!! FYI: While I agree "Inhalt" is better than "Content" the latter is not completely wrong (see https://www.duden.de/rechtschreibung/Content) --