Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-28 Thread Philip Race
Ok. you said in the first post : im using jfx 15-ea-5 on MacOS 10.15.3 Where did you get that build ? -phil On 5/28/20, 5:50 PM, Abu Abdullah wrote: On Fri, May 29, 2020 at 1:21 AM Philip Race wrote: Looks like this is not a Catalina problem. It is a regression in openjfx 14 on macOS. And

Re: RFR: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin

2020-05-28 Thread Ajit Ghaisas
On Tue, 26 May 2020 13:41:15 GMT, Jeanette Winzenburg wrote: > Both skins have similar misbehavior when switching skins > > - memory leak due to a manually added but not removed change listener > - NPE when modifying items after skin switch due to a not removed listener to > the control's

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-28 Thread Abu Abdullah
On Fri, May 29, 2020 at 1:21 AM Philip Race wrote: > > Looks like this is not a Catalina problem. It is a regression in openjfx 14 > on macOS. > And it is caused by https://bugs.openjdk.java.net/browse/JDK-8234916 I can see in the console this message: CoreText note: Client requested name

Re: Arabic letters are not displayed correctly in MacOS 10.15.3

2020-05-28 Thread Philip Race
Looks like this is not a Catalina problem. It is a regression in openjfx 14 on macOS. And it is caused by https://bugs.openjdk.java.net/browse/JDK-8234916 We have filed a new bug : https://bugs.openjdk.java.net/browse/JDK-8246104 -phil. On 5/27/20, 9:00 AM, Abu Abdullah wrote: On Wed, May

RFR: 8246099: Intermittent test failures in SandboxAppTest

2020-05-28 Thread Kevin Rushforth
This is a fix for an intermittent test failure, due to a timeout, in `SandboxAppTest` that we are starting to see on some of our test machines. The failure is happening because of a 10 second timeout in the launched application. This doesn't seem to be enough to run the test to completion in

Re: [Rev 01] RFR: 8242523: Update the animation and clip envelope classes

2020-05-28 Thread Kevin Rushforth
On Thu, 28 May 2020 16:44:33 GMT, Nir Lisker wrote: >> Mostly refactoring in preparation of the upcoming fixes. The changes might >> look like a lot, but it's mostly rearranging >> of methods. Summery of changes: >> ### Animation >> * Added `isNearZero` and `areNearEqual` methods that deal with

Re: [Rev 01] RFR: 8242523: Update the animation and clip envelope classes

2020-05-28 Thread Nir Lisker
On Thu, 28 May 2020 15:51:19 GMT, Kevin Rushforth wrote: >> Doesn't the autogenerated JavaDoc for the `getX`, `setX` and `xProperty` >> methods work by matching the method name to >> the property name regardless of they location in the class? >> `doSetCurrentRate` shouldn't ever be able to

Re: [Rev 01] RFR: 8242523: Update the animation and clip envelope classes

2020-05-28 Thread Nir Lisker
> Mostly refactoring in preparation of the upcoming fixes. The changes might > look like a lot, but it's mostly rearranging > of methods. Summery of changes: > ### Animation > * Added `isNearZero` and `areNearEqual` methods that deal with `EPSILON` > checks. > * Added `isStopped`, `isRunning`

Re: RFR: 8242523: Update the animation and clip envelope classes

2020-05-28 Thread Kevin Rushforth
On Thu, 28 May 2020 15:23:38 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line >> 402: >> >>> 401: */ >>> 402: private void doSetCurrentRate(double value) { >>> 403: if (currentRate != null || !areNearEqual(value, >>>

Re: RFR: 8242523: Update the animation and clip envelope classes

2020-05-28 Thread Kevin Rushforth
On Thu, 28 May 2020 15:16:03 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line >> 332: >> >>> 331: } >>> 332: if (isNearZero(newRate)) { >>> 333: if (isRunning()) { >> >> The

Re: RFR: 8242523: Update the animation and clip envelope classes

2020-05-28 Thread Nir Lisker
On Tue, 26 May 2020 21:53:44 GMT, Kevin Rushforth wrote: >> Mostly refactoring in preparation of the upcoming fixes. The changes might >> look like a lot, but it's mostly rearranging >> of methods. Summery of changes: >> ### Animation >> * Added `isNearZero` and `areNearEqual` methods that deal

Re: RFR: 8242523: Update the animation and clip envelope classes

2020-05-28 Thread Nir Lisker
On Tue, 26 May 2020 21:12:07 GMT, Kevin Rushforth wrote: >> Mostly refactoring in preparation of the upcoming fixes. The changes might >> look like a lot, but it's mostly rearranging >> of methods. Summery of changes: >> ### Animation >> * Added `isNearZero` and `areNearEqual` methods that deal

Re: RFR: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently

2020-05-28 Thread Kevin Rushforth
On Thu, 28 May 2020 08:45:36 GMT, Arun Joseph wrote: > Issue: Snapshot taken before webpage is rendered > > Fix: Use stateProperty and sleep to wait for the page to finish rendering I tested it on my machine and it is running reliably for me now. I have a couple suggestions below.

RFR: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently

2020-05-28 Thread Arun Joseph
Issue: Snapshot taken before webpage is rendered Fix: Use stateProperty and sleep to wait for the page to finish rendering - Commit messages: - Add sleep - 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently Changes: https://git.openjdk.java.net/jfx/pull/240/files

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-28 Thread Robert Lichtenberger
On Wed, 27 May 2020 12:11:48 GMT, Robert Lichtenberger wrote: >> you are hacking around ;) >> >> doSelect _must not_ be called somewhere "in-between" changing the text: the >> api doc clearly states that the >> caret/anchor coordinates are the _new_ coordinates, that is after all >> changes